Page MenuHomePhabricator

lint/unit failures cause confusing error message
Closed, ResolvedPublic

Description

For installs that don't use harbormaster, users get a confusing message about a build failure when they try to land diffs with lint or unit failures. Since we're theoretically just using harbormaster as a backend store, it would be nice to instead specifically prompt users that they have lint or unit failures when they try to land their diff (which we probably know because we're using harbormaster autotarget?)

Especially germane since we have a completely different system for continuous integration that runs builds.

Event Timeline

meitros assigned this task to epriestley.
meitros updated the task description. (Show Details)
meitros added a project: Restricted Project.
meitros added a subscriber: meitros.

I don't see an especially clear way forward here:

We could just let arc ignore these autotarget failures; we already prompted the user when they created the diff. However, the autotarget failures cause a failure on the Buildable, and we currently care about the state of the buildable, so this isn't trivial (the client would need to deduce that the Buildable state was a consequence of the autotarget failures alone, which doesn't feel very good).

We could make autotarget failures not fail the buildable, although this feels sort of bad/incorrect.

We could rename the "Arcanist Client Results" autoplan to "Unit and lint results implicitly generated by arc unit and arc lint when you typed arc diff".

We could ignore the failure state of the buildable and only prompt on build failures, excluding the arc autoplan. Maybe this is fine, but it probably gets into trouble later if builds are permitted to fail without impacting the buildable.

Maybe renaming "Arcanist Client Results to "arc lint + arc unit" would be clear enough? It sounds like this workflow is generally fine, users are just not making the connection between "Arcanist Client Results" and the "arc" client?

Renaming to arc lint + arc unit sounds good and clearer to me.

angie moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Sep 10 2015, 4:49 PM
angie moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Oct 14 2015, 6:39 PM