The SSH username change wasn't sufficient because there's a hard-coded piece of logic to select the username by instance name:

If pre-commit can not mutate the commit

The preview section underneath the comment area doesn't mark "editing" inlines in any special way.

Not exactly related, but:

In D21225, I made the "attach_inlines" parameter to differential.createcomment a no-op. This originated in D7019 and was a "Facebook Feature" at the time with no use case or rationale.

There was a related AccountIdentifier issue with InstancesShadowUserQuery: we loaded shadow users based on accountID, but this is no longer consistently populated after T13493.

AccountIdentifiers do not sync during setup after T13493.

bin/services sync --instance X exits with no error if X does not exist.

• Audit is missing the "attach, drop-voided, upgrade-to-draft-text" code that Differential has when submitting "isEditing" comments.
• Audit is missing the entire submit-editing workflow in general.

In Chrome (Version 64.0.3282.140 (Official Build) (64-bit)) the inline comment buttons have a hot-spot for tooltips to party

I reordered these elements in D21200. See also D20967.

Mooted by changes in T13513.

We've never seen other requests for this feature and currently have no customer requests for it, so I don't plan to implement it.

See T13513.

• When you load the page and there are multiple inlines which we're pushing into an edit state, we focus and select them in sequence (and the overall order is basically random). The focus + select behavior should be disabled for this edit pathway.

• When we force saves of inlines, we probably (?) save the last saved state, not the draft state.

• When you click a line, type text, get a draft, reload the page, and cancel the inline: we cancel into an empty state.

• When you click a line, type text, then go to the list view: the revision draft state has not re-synchronized based on an empty inline comment with only a draft, because saving a draft doesn't trigger a re-sync.

• In the preview, editing inline comments don't reflect draft states correctly.

• The preview section underneath the comment area doesn't mark "editing" inlines in any special way.
• The "view" links in the preview don't jump to editing comments correctly.
• The "delete" links in the preview don't put editing comments into the right state (delete is normally impossible for an editing comment).

I think that covers things here.

(This kind of question is best asked on Discourse.)

You can open the revision in the web UI and "Request Review". You can use arc diff --browse ... to open the web UI automatically.

See https://discourse.phabricator-community.org/t/typeerror-w-arc-diff-when-build-plan-view-policy-does-not-contain-user/3820/. The reproduction case is "policy makes the build plan invisible".

As of D21188, inlines have these remaining weird behaviors:

In the DOM, inline comments are currently structured as a "comment row", followed by zero or more related rows (which may contain the editor UI or the undo UI).

OKAY SO