Page MenuHomePhabricator
Create Task
Maniphest T13527

"mb_check_encoding()" may rase a warning if passed an object which implements "__toString()"
Closed, ResolvedPublic
Actions

Description

See:

If mb_check_encoding() is passed an object which is not a string, but implements __toString(), it raises a warning in certain versions of PHP:

Screen Shot 2020-04-30 at 7.11.05 AM.png (1×1 px, 147 KB)

We can avoid this by using phutil_string_cast() before passing the parameter.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

epriestley triaged this task as Low priority.Apr 30 2020, 2:11 PM
epriestley created this task.
Herald added a subscriber: amckinley. · View Herald TranscriptApr 30 2020, 2:11 PM
epriestley added a revision: Restricted Differential Revision.Apr 30 2020, 2:14 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Apr 30 2020, 2:19 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
Phabricator · Built by Phacility