Page MenuHomePhabricator
Feed Advanced Search

Jan 13 2020

epriestley merged task T13470: Unable to upload (crashes) large files (eg. 20mb) via file application upload section: https://secure.phabricator.com/file/upload/ into T13256: Update storage engines in Files to a modern multi-service configuration.
Jan 13 2020, 7:26 PM
epriestley merged T13470: Unable to upload (crashes) large files (eg. 20mb) via file application upload section: https://secure.phabricator.com/file/upload/ into T13256: Update storage engines in Files to a modern multi-service configuration.
Jan 13 2020, 7:26 PM · Files
epriestley added a comment to T11162: Unable to Edit Projects as Administrator, Showing Restricted.

If you believe you've found a bug in Phabricator, please report it by creating a new thread on Discourse.

Jan 13 2020, 6:23 PM · Projects, Bug Report (Needs Information)
epriestley triaged T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4 as Wishlist priority.
Jan 13 2020, 4:49 PM · Search

Jan 9 2020

brablc awarded T5427: Force a line break in a table cell a Like token.
Jan 9 2020, 4:18 PM · Remarkup

Dec 19 2019

epriestley triaged T13471: Guard call to "get_magic_quotes_gpc()" during startup as Wishlist priority.
Dec 19 2019, 6:52 PM · Infrastructure
epriestley added a comment to T13269: Improve initial implementations of Workboard triggers and groups.

See also PHI1594, which wants:

Dec 19 2019, 5:18 PM · Workboards (v3)
epriestley added a comment to T13468: Last block of blocked Jupyter notebook diffs is not displayed in side-by-side view.

See also PHI1579.

Dec 19 2019, 5:11 PM · Differential

Dec 13 2019

epriestley edited the content of Changelog.
Dec 13 2019, 6:44 PM
epriestley created an object: 2019 Week 50 (Mid December).
Dec 13 2019, 6:43 PM

Nov 30 2019

epriestley added a revision to T13362: Push the "Config" application UI out to full-width: Unknown Object (Differential Revision).
Nov 30 2019, 8:03 PM · Design, Config
epriestley updated the task description for T13362: Push the "Config" application UI out to full-width.
Nov 30 2019, 7:55 PM · Design, Config
epriestley updated the task description for T13362: Push the "Config" application UI out to full-width.
Nov 30 2019, 6:38 PM · Design, Config
epriestley added a revision to T13362: Push the "Config" application UI out to full-width: Unknown Object (Differential Revision).
Nov 30 2019, 6:37 PM · Design, Config

Nov 26 2019

epriestley added a revision to T13362: Push the "Config" application UI out to full-width: Unknown Object (Differential Revision).
Nov 26 2019, 11:31 PM · Design, Config
epriestley added a revision to T13362: Push the "Config" application UI out to full-width: Unknown Object (Differential Revision).
Nov 26 2019, 11:01 PM · Design, Config
epriestley triaged T13467: Expand the "ddata003" volume as Low priority.
Nov 26 2019, 6:00 PM · Phacility
CodeMouse92 awarded T10779: Cannot manage base project milestones if base project has subprojects a Party Time token.
Nov 26 2019, 3:17 AM · Restricted Project, Projects, Bug Report
epriestley closed T10779: Cannot manage base project milestones if base project has subprojects as Resolved.

I believe T13462 resolved this.

Nov 26 2019, 1:52 AM · Restricted Project, Projects, Bug Report
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

there is no way to bin/host query against the set of instances using a particular repository shard service

Nov 26 2019, 12:14 AM · Phacility, Ops
epriestley added a revision to T13466: AWS instance termination may fail/hang indefinitely: Unknown Object (Differential Revision).
Nov 26 2019, 12:09 AM · Phacility, Ops

Nov 25 2019

epriestley added a revision to T13466: AWS instance termination may fail/hang indefinitely: Unknown Object (Differential Revision).
Nov 25 2019, 11:57 PM · Phacility, Ops
epriestley added a comment to T11860: Bot email addresses can't be edited.

In D20927, I implemented a policy rule like this:

Nov 25 2019, 11:08 PM · Setup, People
epriestley added a revision to T11860: Bot email addresses can't be edited: Unknown Object (Differential Revision).
Nov 25 2019, 11:06 PM · Setup, People
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: Unknown Object (Differential Revision).
Nov 25 2019, 11:06 PM · Diffusion
epriestley added a revision to T13466: AWS instance termination may fail/hang indefinitely: Unknown Object (Differential Revision).
Nov 25 2019, 10:46 PM · Phacility, Ops
epriestley added a revision to T13362: Push the "Config" application UI out to full-width: Unknown Object (Differential Revision).
Nov 25 2019, 10:37 PM · Design, Config
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

Update Almanac definitions for all instances not on the paired db023 shard.

Nov 25 2019, 5:01 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

PHI1566 is resolved narrowly. These cleanup steps still need to happen.

Nov 25 2019, 4:42 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

(Updating addresses with bin/host query leaves the service address cache dirty (the "mutable structure cache" via PhabricatorRepository->getAlmanacServiceRefs()) so it should be followed with bin/cache purge --caches general.)

Nov 25 2019, 4:29 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

I'll flesh this out more later, but the move away from db123 = repo123 shard pairing, plus bin/host query using mysql makes it difficult to directly query instances using a particular repository service.

Nov 25 2019, 4:15 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

Minor issue that should be looked at during service sync arising from improved validation elsewhere:

Nov 25 2019, 4:06 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

I'm deploying the new host now. We just crossed a release so I'm going to manually restore it to 72f82abe07 once it comes up (see also T13359). Then, I'll resynchronize instance services for active instances.

Nov 25 2019, 3:57 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

Instance termination completed after about 20 minutes and all the volumes detached. Since the original instance can be recycled, I'm going to reattach and restart it, and throw away the replacement host.

Nov 25 2019, 3:51 PM · Phacility, Ops
epriestley added a project to T13466: AWS instance termination may fail/hang indefinitely: Phacility.
Nov 25 2019, 3:48 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

Normal volume detachment is just spinning, which isn't exactly surprising. I'm going to give it a few minutes and then force detachment.

Nov 25 2019, 3:47 PM · Phacility, Ops
epriestley added a comment to T13466: AWS instance termination may fail/hang indefinitely.

To deal with this narrowly, I'm going to:

Nov 25 2019, 3:44 PM · Phacility, Ops
epriestley triaged T13466: AWS instance termination may fail/hang indefinitely as Low priority.
Nov 25 2019, 3:42 PM · Phacility, Ops
epriestley updated the task description for T13362: Push the "Config" application UI out to full-width.
Nov 25 2019, 3:24 PM · Design, Config
epriestley updated the task description for T13362: Push the "Config" application UI out to full-width.
Nov 25 2019, 3:22 PM · Design, Config
epriestley added a comment to T13362: Push the "Config" application UI out to full-width.

...

Nov 25 2019, 3:17 PM · Design, Config
epriestley edited the content of Changelog.
Nov 25 2019, 3:13 PM
epriestley created an object: 2019 Week 47 (Very Late November).
Nov 25 2019, 3:11 PM

Nov 22 2019

epriestley closed T13465: Stop sending Conduit exceptions to the error log as Resolved by committing Restricted Diffusion Commit.
Nov 22 2019, 8:03 PM · Conduit
epriestley added a revision to T13465: Stop sending Conduit exceptions to the error log: Unknown Object (Differential Revision).
Nov 22 2019, 7:54 PM · Conduit
epriestley triaged T13465: Stop sending Conduit exceptions to the error log as Low priority.
Nov 22 2019, 7:52 PM · Conduit

Nov 21 2019

epriestley closed T13464: Fix "display" index issue when editing Paths in Owners as Resolved by committing Restricted Diffusion Commit.
Nov 21 2019, 7:29 PM · Owners
epriestley added a revision to T13464: Fix "display" index issue when editing Paths in Owners: Unknown Object (Differential Revision).
Nov 21 2019, 7:27 PM · Owners
epriestley triaged T13464: Fix "display" index issue when editing Paths in Owners as Low priority.
Nov 21 2019, 7:18 PM · Owners
epriestley removed a parent task for T3794: Rebuild Diffusion/Audit on top of CustomField infrastructure: T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234".
Nov 21 2019, 4:06 PM · Restricted Project, Diffusion, Custom Fields
epriestley removed a subtask for T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234": T3794: Rebuild Diffusion/Audit on top of CustomField infrastructure.
Nov 21 2019, 4:06 PM · Maniphest
epriestley removed a subtask for T10034: Plan the future of Maniphest task relationships: T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships.
Nov 21 2019, 4:06 PM · Maniphest
epriestley removed a parent task for T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships: T10034: Plan the future of Maniphest task relationships.
Nov 21 2019, 4:06 PM · Customer Impact, Maniphest, Differential
epriestley merged T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234" into T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".
Nov 21 2019, 4:05 PM · Maniphest, Differential, Diffusion
epriestley merged task T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234" into T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".
Nov 21 2019, 4:05 PM · Maniphest
epriestley added a comment to T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234".

T13463 is approximately the same as this, but now ripe; I'm going to merge this there.

Nov 21 2019, 4:04 PM · Maniphest
epriestley added a parent task for T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234": T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".
Nov 21 2019, 4:03 PM · Maniphest
epriestley added a subtask for T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx": T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234".
Nov 21 2019, 4:03 PM · Maniphest, Differential, Diffusion
epriestley added a subtask for T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships: T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".
Nov 21 2019, 4:03 PM · Customer Impact, Maniphest, Differential
epriestley added a parent task for T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx": T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships.
Nov 21 2019, 4:03 PM · Maniphest, Differential, Diffusion
epriestley updated the task description for T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".
Nov 21 2019, 4:02 PM · Maniphest, Differential, Diffusion
epriestley triaged T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx" as Low priority.
Nov 21 2019, 4:02 PM · Maniphest, Differential, Diffusion
epriestley closed T5598: Make "T123" in commit title work like "Ref T123" or "Fixes T123" in the body or test plan or a comment as Wontfix.

I don't currently plan to pursue this.

Nov 21 2019, 3:56 PM · Differential, Maniphest

Nov 20 2019

epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

In the general case:

Nov 20 2019, 7:00 AM · Customer Impact, Diffusion (v3)

Nov 19 2019

epriestley closed T12164: Put an indirection layer between author/committer strings and user accounts as Resolved.

I think this doesn't have anything actionable left, see T13444 for some followups. This feature probably isn't 100% perfect quite yet, but I think remaining work is just cleanup.

Nov 19 2019, 8:37 PM · Customer Impact, Diffusion (v3)
epriestley claimed T13444: Provide a standalone script entry point for resolving a repository identity.
Nov 19 2019, 8:36 PM · Diffusion
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: Unknown Object (Differential Revision).
Nov 19 2019, 8:34 PM · Diffusion
epriestley closed T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration, a subtask of T13444: Provide a standalone script entry point for resolving a repository identity, as Resolved.
Nov 19 2019, 6:19 PM · Diffusion
epriestley closed T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration as Resolved by committing Restricted Diffusion Commit.
Nov 19 2019, 6:19 PM · Diffusion
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: Unknown Object (Differential Revision).
Nov 19 2019, 6:10 PM · Diffusion
epriestley added a revision to T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration: Unknown Object (Differential Revision).
Nov 19 2019, 6:10 PM · Diffusion
epriestley edited the content of Changelog.
Nov 19 2019, 5:30 PM
epriestley created an object: 2019 Week 46 (Late November).
Nov 19 2019, 5:29 PM
epriestley closed T13462: Correct some policy/membership issues in milestone creation as Resolved.
Nov 19 2019, 7:13 AM · Projects, Policy
epriestley added a comment to T13462: Correct some policy/membership issues in milestone creation.

We materialize some members into the milestone? This causes no real problems, but we shouldn't materialize members into milestones.

Nov 19 2019, 6:53 AM · Projects, Policy
epriestley added a revision to T13462: Correct some policy/membership issues in milestone creation: Restricted Differential Revision.
Nov 19 2019, 6:52 AM · Projects, Policy
epriestley added a comment to T13462: Correct some policy/membership issues in milestone creation.

We predict the wrong set of members for the milestone when testing policies: we predict "no members", but should predict "exactly the same as the members of the parent project"?

Nov 19 2019, 6:42 AM · Projects, Policy
epriestley added a revision to T13462: Correct some policy/membership issues in milestone creation: Unknown Object (Differential Revision).
Nov 19 2019, 6:29 AM · Projects, Policy
epriestley added a comment to T13462: Correct some policy/membership issues in milestone creation.

We check the wrong edit policy when testing if you can create a milestone: we check the default application policy, but should check the parent project policy?

Nov 19 2019, 6:13 AM · Projects, Policy
epriestley triaged T13462: Correct some policy/membership issues in milestone creation as Normal priority.
Nov 19 2019, 6:09 AM · Projects, Policy
epriestley closed T13461: Remove policy tag coloration in object header UI as Resolved by committing Restricted Diffusion Commit.
Nov 19 2019, 6:05 AM · Policy
epriestley updated the task description for T13461: Remove policy tag coloration in object header UI.
Nov 19 2019, 6:04 AM · Policy
epriestley added a revision to T13461: Remove policy tag coloration in object header UI: Unknown Object (Differential Revision).
Nov 19 2019, 6:00 AM · Policy
epriestley closed T13460: Restore "Owner can view/edit task" policy hint in Task policy explanation dialogs as Resolved by committing Restricted Diffusion Commit.
Nov 19 2019, 5:54 AM · Policy, Maniphest
epriestley triaged T13461: Remove policy tag coloration in object header UI as Low priority.
Nov 19 2019, 5:49 AM · Policy
epriestley added a revision to T13460: Restore "Owner can view/edit task" policy hint in Task policy explanation dialogs: Unknown Object (Differential Revision).
Nov 19 2019, 5:41 AM · Policy, Maniphest
epriestley triaged T13460: Restore "Owner can view/edit task" policy hint in Task policy explanation dialogs as Low priority.
Nov 19 2019, 5:38 AM · Policy, Maniphest
epriestley closed T13459: Allow "arc upgrade" to upgrade the "experimental" branch as Resolved by committing Restricted Diffusion Commit.
Nov 19 2019, 4:53 AM · Arcanist
epriestley added a revision to T13459: Allow "arc upgrade" to upgrade the "experimental" branch: Unknown Object (Differential Revision).
Nov 19 2019, 4:52 AM · Arcanist
epriestley triaged T13459: Allow "arc upgrade" to upgrade the "experimental" branch as Low priority.
Nov 19 2019, 4:47 AM · Arcanist
epriestley closed T13458: When "arc land" calls "arc close-revision" but declines to act because the revision is not "Accepted", emit a message as Resolved by committing Restricted Diffusion Commit.
Nov 19 2019, 4:31 AM · Arcanist
epriestley added a revision to T13458: When "arc land" calls "arc close-revision" but declines to act because the revision is not "Accepted", emit a message: Unknown Object (Differential Revision).
Nov 19 2019, 4:30 AM · Arcanist
epriestley updated the task description for T13458: When "arc land" calls "arc close-revision" but declines to act because the revision is not "Accepted", emit a message.
Nov 19 2019, 4:15 AM · Arcanist
epriestley claimed T13458: When "arc land" calls "arc close-revision" but declines to act because the revision is not "Accepted", emit a message.
Nov 19 2019, 4:14 AM · Arcanist
epriestley triaged T13458: When "arc land" calls "arc close-revision" but declines to act because the revision is not "Accepted", emit a message as Low priority.
Nov 19 2019, 4:14 AM · Arcanist

Nov 14 2019

epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: Unknown Object (Differential Revision).
Nov 14 2019, 7:49 PM · Diffusion
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: Restricted Differential Revision.
Nov 14 2019, 7:31 PM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Uhhhh, absolutely none of this works because PhabricatorUserEmail does not have a PHID.

Nov 14 2019, 7:20 PM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Another likely bug is:

Nov 14 2019, 7:05 PM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Currently, the flow here is that changes queue a daemon task.

Nov 14 2019, 6:42 PM · Diffusion