Page MenuHomePhabricator
Feed Advanced Search

Sep 13 2019

epriestley added a comment to T13410: Update Phriction UI structural behaviors.

At the lowest levels:

Sep 13 2019, 3:24 AM · Phriction
epriestley added a comment to T13410: Update Phriction UI structural behaviors.

This needs a lot more work, but here's very roughly where I'm trying to go with this:

Sep 13 2019, 2:57 AM · Phriction
epriestley added a revision to T13413: Chrome 77 rendering engine freezes when elements are nested with particular word-wrap / white-space CSS behavior: Unknown Object (Differential Revision).
Sep 13 2019, 1:59 AM · Google Chrome

Sep 12 2019

epriestley triaged T13416: Transaction logs may overheat explosively as Low priority.
Sep 12 2019, 11:22 PM · Feed
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: Unknown Object (Differential Revision).
Sep 12 2019, 11:21 PM · Policy
epriestley closed T13415: Allow the "Change Subtype" comment action to be disabled on a per-subtype basis as Resolved by committing Restricted Diffusion Commit.
Sep 12 2019, 11:17 PM · EditEngine
epriestley added a revision to T13415: Allow the "Change Subtype" comment action to be disabled on a per-subtype basis: Unknown Object (Differential Revision).
Sep 12 2019, 11:12 PM · EditEngine
epriestley triaged T13415: Allow the "Change Subtype" comment action to be disabled on a per-subtype basis as Low priority.
Sep 12 2019, 10:39 PM · EditEngine
epriestley closed T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules as Resolved.

D20808 fixes the two original cases (Harbormaster and Legalpad). There are probably more fields or actions which could be configured to be sometimes-unavailable, but these are probably the major ones.

Sep 12 2019, 7:59 PM · Applications, Herald
epriestley added a revision to T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules: Unknown Object (Differential Revision).
Sep 12 2019, 7:57 PM · Applications, Herald
epriestley triaged T13414: Raise the effective corpus size limit in "PhutilProseDifferenceEngine" by using "diff" for coarse passes as Low priority.
Sep 12 2019, 7:30 PM · Infrastructure
epriestley added a comment to T13232: Mac OS X Mojave, SIP, Code Signing, and Apache.

For LDAP, brew install openldap + --with-ldap=/usr/local/opt/openldap/.

Sep 12 2019, 5:25 PM · Infrastructure
epriestley closed T13411: Improve "Custom Policy" behavior in policy dialogs as Resolved by committing Restricted Diffusion Commit.
Sep 12 2019, 4:49 PM · Policy
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: Unknown Object (Differential Revision).
Sep 12 2019, 4:30 PM · Policy
epriestley closed T6802: "Custom policy" for editing/viewing does not link to details as Resolved.

Here's the fate of the various issues discussed here:

Sep 12 2019, 4:04 PM · Design, Policy
epriestley closed T6802: "Custom policy" for editing/viewing does not link to details, a subtask of T13411: Improve "Custom Policy" behavior in policy dialogs, as Resolved.
Sep 12 2019, 4:03 PM · Policy
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: Unknown Object (Differential Revision).
Sep 12 2019, 3:57 PM · Policy
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: Unknown Object (Differential Revision).
Sep 12 2019, 3:39 PM · Policy
epriestley added a parent task for T6802: "Custom policy" for editing/viewing does not link to details: T13411: Improve "Custom Policy" behavior in policy dialogs.
Sep 12 2019, 3:13 PM · Design, Policy
epriestley added a subtask for T13411: Improve "Custom Policy" behavior in policy dialogs: T6802: "Custom policy" for editing/viewing does not link to details.
Sep 12 2019, 3:13 PM · Policy
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: Unknown Object (Differential Revision).
Sep 12 2019, 2:46 PM · Policy
epriestley added a comment to T13411: Improve "Custom Policy" behavior in policy dialogs.

This should be reworked some day (perhaps partly here) into some more cohesive API, perhaps newLink().

Sep 12 2019, 2:15 PM · Policy
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: Unknown Object (Differential Revision).
Sep 12 2019, 2:08 PM · Policy
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: Unknown Object (Differential Revision).
Sep 12 2019, 2:06 PM · Policy
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: Unknown Object (Differential Revision).
Sep 12 2019, 2:03 PM · Policy
epriestley added a comment to T13411: Improve "Custom Policy" behavior in policy dialogs.

One other thing is that PhabricatorApplicationPolicyChangeTransaction->renderApplicationPolicy() has unconventional behaviors which are not very helpful and not consistent with normal CAN_EDIT / CAN_VIEW transactions. This is somewhat perplexing because ModularTransactions has renderPolicy() already, which has better behavior. I think it didn't exist yet when Applications modularized in D17757, and when it was introduced in D19829 I just overlooked the opportunity to update it.

Sep 12 2019, 4:47 AM · Policy
epriestley added a comment to T13411: Improve "Custom Policy" behavior in policy dialogs.

In Applications → (Pick Something), if an application policy is set to "Custom Policy", the policy is not linked.

Sep 12 2019, 4:39 AM · Policy
epriestley added a revision to T13410: Update Phriction UI structural behaviors: Unknown Object (Differential Revision).
Sep 12 2019, 4:04 AM · Phriction

Sep 11 2019

epriestley added a comment to T13413: Chrome 77 rendering engine freezes when elements are nested with particular word-wrap / white-space CSS behavior.

I upstreamed this to Chrome here: https://bugs.chromium.org/p/chromium/issues/detail?id=1003002

Sep 11 2019, 6:00 PM · Google Chrome
epriestley triaged T13413: Chrome 77 rendering engine freezes when elements are nested with particular word-wrap / white-space CSS behavior as Normal priority.
Sep 11 2019, 5:53 PM · Google Chrome

Sep 10 2019

epriestley updated the task description for T13410: Update Phriction UI structural behaviors.
Sep 10 2019, 10:05 PM · Phriction
20after4 awarded T13377: Write about "how to solve problems with program behavior" a Mountain of Wealth token.
Sep 10 2019, 1:46 PM · Guides

Sep 9 2019

epriestley closed T8808: Policy menu should show actual project icon next to project as Resolved by committing Restricted Diffusion Commit.
Sep 9 2019, 8:38 PM · Policy
epriestley added a revision to T8808: Policy menu should show actual project icon next to project: Unknown Object (Differential Revision).
Sep 9 2019, 8:35 PM · Policy
epriestley closed T9136: '(Disabled)' rules show up multi times under 'Another Herald Rule' as Resolved by committing Restricted Diffusion Commit.
Sep 9 2019, 8:29 PM · Restricted Project, Herald
epriestley added a revision to T9136: '(Disabled)' rules show up multi times under 'Another Herald Rule': Unknown Object (Differential Revision).
Sep 9 2019, 8:25 PM · Restricted Project, Herald
epriestley closed T8952: Hide "Herald added subscribers..." stories from feed completely as Resolved by committing Restricted Diffusion Commit.
Sep 9 2019, 8:17 PM · Feed, Herald
epriestley closed T13409: Support a "Remove Flag" action in Herald as Resolved by committing Restricted Diffusion Commit.
Sep 9 2019, 8:16 PM · Herald
epriestley added a comment to T8952: Hide "Herald added subscribers..." stories from feed completely.

0.00000000001 is very funny and we would be losing a truly great joke at such a young age

Sep 9 2019, 8:15 PM · Feed, Herald
epriestley added a revision to T8952: Hide "Herald added subscribers..." stories from feed completely: Unknown Object (Differential Revision).
Sep 9 2019, 8:14 PM · Feed, Herald
epriestley added a revision to T13409: Support a "Remove Flag" action in Herald: Unknown Object (Differential Revision).
Sep 9 2019, 8:02 PM · Herald
epriestley closed T13408: Examine conditions, not just actions, when indexing Herald rules for links to other objects as Resolved by committing Restricted Diffusion Commit.
Sep 9 2019, 7:50 PM · Herald
epriestley closed T13412: Searching for the install URI with no trailing slash fatals as Resolved by committing Restricted Diffusion Commit.
Sep 9 2019, 7:45 PM · Search
epriestley added a revision to T13408: Examine conditions, not just actions, when indexing Herald rules for links to other objects: Restricted Differential Revision.
Sep 9 2019, 7:44 PM · Herald
epriestley added a revision to T13412: Searching for the install URI with no trailing slash fatals: Unknown Object (Differential Revision).
Sep 9 2019, 7:30 PM · Search
epriestley closed T13405: Support customization of the default global search scope as Resolved by committing Restricted Diffusion Commit.
Sep 9 2019, 7:21 PM · User Preferences
epriestley added a revision to T13405: Support customization of the default global search scope: Unknown Object (Differential Revision).
Sep 9 2019, 7:16 PM · User Preferences
epriestley added a revision to T13405: Support customization of the default global search scope: Unknown Object (Differential Revision).
Sep 9 2019, 7:11 PM · User Preferences
epriestley triaged T13412: Searching for the install URI with no trailing slash fatals as Low priority.
Sep 9 2019, 5:10 PM · Search
epriestley moved T6802: "Custom policy" for editing/viewing does not link to details from Backlog to Next on the Policy board.
Sep 9 2019, 5:07 PM · Design, Policy
epriestley moved T8808: Policy menu should show actual project icon next to project from Backlog to Next on the Policy board.
Sep 9 2019, 5:07 PM · Policy
epriestley moved T13411: Improve "Custom Policy" behavior in policy dialogs from Backlog to Next on the Policy board.
Sep 9 2019, 5:06 PM · Policy
epriestley triaged T13411: Improve "Custom Policy" behavior in policy dialogs as Low priority.
Sep 9 2019, 5:06 PM · Policy
epriestley added a comment to T13410: Update Phriction UI structural behaviors.

Left Nav

Sep 9 2019, 4:56 PM · Phriction
epriestley updated the task description for T13410: Update Phriction UI structural behaviors.
Sep 9 2019, 4:07 PM · Phriction
epriestley updated the task description for T13410: Update Phriction UI structural behaviors.
Sep 9 2019, 4:02 PM · Phriction
epriestley updated the task description for T13410: Update Phriction UI structural behaviors.
Sep 9 2019, 4:01 PM · Phriction
epriestley removed a subtask for T8552: Increase user control over document hierarchy in Phriction: T13011: Let community to fund features and bug fixes for increased priority and earlier delivery.
Sep 9 2019, 3:58 PM · Phriction, Restricted Project
epriestley removed a parent task for T13011: Let community to fund features and bug fixes for increased priority and earlier delivery: T8552: Increase user control over document hierarchy in Phriction.
Sep 9 2019, 3:58 PM · Feature Request, Fund
epriestley added a parent task for T8552: Increase user control over document hierarchy in Phriction: T13410: Update Phriction UI structural behaviors.
Sep 9 2019, 3:58 PM · Phriction, Restricted Project
epriestley added a parent task for T4280: Embed anchor in remark up text and later link to it. : T13410: Update Phriction UI structural behaviors.
Sep 9 2019, 3:58 PM · Remarkup
epriestley added subtasks for T13410: Update Phriction UI structural behaviors: T4280: Embed anchor in remark up text and later link to it. , T8552: Increase user control over document hierarchy in Phriction.
Sep 9 2019, 3:58 PM · Phriction
epriestley triaged T13410: Update Phriction UI structural behaviors as Normal priority.
Sep 9 2019, 3:57 PM · Phriction
epriestley added a comment to T13405: Support customization of the default global search scope.

There may also be no Application in contexts where we want to render a global search menu, notably the 404 page:

Sep 9 2019, 3:37 PM · User Preferences
epriestley triaged T13409: Support a "Remove Flag" action in Herald as Low priority.
Sep 9 2019, 2:35 PM · Herald
epriestley triaged T13408: Examine conditions, not just actions, when indexing Herald rules for links to other objects as Low priority.
Sep 9 2019, 2:33 PM · Herald
epriestley edited the content of Changelog.
Sep 9 2019, 12:04 AM
epriestley created an object: 2019 Week 36 (Early September).
Sep 9 2019, 12:02 AM

Sep 8 2019

epriestley triaged T13407: If an S3 request returns with HTTP 404, error handling behavior is poor as Wishlist priority.
Sep 8 2019, 8:22 PM · Files
epriestley added a revision to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY: Unknown Object (Differential Revision).
Sep 8 2019, 8:02 PM · Database, Infrastructure
epriestley added a revision to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY: Unknown Object (Differential Revision).
Sep 8 2019, 7:59 PM · Database, Infrastructure
epriestley closed T13406: When a user with no authentication providers configured tries to log out, warn them as Resolved by committing Restricted Diffusion Commit.
Sep 8 2019, 7:27 PM · Setup
epriestley added a comment to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY.

Vaguely adjacent:

Sep 8 2019, 7:27 PM · Database, Infrastructure
epriestley added a revision to T13406: When a user with no authentication providers configured tries to log out, warn them: Restricted Differential Revision.
Sep 8 2019, 4:48 PM · Setup
epriestley triaged T13406: When a user with no authentication providers configured tries to log out, warn them as Wishlist priority.
Sep 8 2019, 4:27 PM · Setup
epriestley updated the task description for T12910: Allow SES to be used for inbound mail.
Sep 8 2019, 2:58 PM · Mail

Sep 6 2019

epriestley reopened T13405: Support customization of the default global search scope as "Open".

I think I missed one case here: the global preference will currently show custom personal queries for the viewing user, but selecting these queries won't work (at least, not completely) for other users. Instead, the control should offer only hard-coded options and global queries.

Sep 6 2019, 5:54 PM · User Preferences
epriestley closed T13405: Support customization of the default global search scope as Resolved by committing Restricted Diffusion Commit.
Sep 6 2019, 3:39 PM · User Preferences
epriestley added a revision to T13405: Support customization of the default global search scope: Unknown Object (Differential Revision).
Sep 6 2019, 3:25 PM · User Preferences
epriestley triaged T13405: Support customization of the default global search scope as Low priority.
Sep 6 2019, 3:21 PM · User Preferences

Sep 5 2019

epriestley added a comment to T13394: Evaluate Okta OAuth.

But did you check your spam folder? 😄

Sep 5 2019, 11:10 PM · Auth
epriestley added a comment to T13394: Evaluate Okta OAuth.

I attempted to register for a developer account and am receiving neither an email verification email nor a password reset email. 🤷

Sep 5 2019, 9:44 PM · Auth
epriestley closed T10321: Running "arc land" without a branch checked out sort of works but fails when trying to delete the branch as Resolved by committing Restricted Diffusion Commit.
Sep 5 2019, 12:31 PM · Bug Report
epriestley added a revision to T10321: Running "arc land" without a branch checked out sort of works but fails when trying to delete the branch: Unknown Object (Differential Revision).
Sep 5 2019, 12:25 PM · Bug Report
epriestley added a comment to T10321: Running "arc land" without a branch checked out sort of works but fails when trying to delete the branch.

See also https://discourse.phabricator-community.org/t/arc-land-fails-with-detached-head/3078/.

Sep 5 2019, 12:19 PM · Bug Report
epriestley closed T13392: Current implementations of "X-Forwarded-For" may take the wrong element as Resolved by committing Restricted Diffusion Commit.
Sep 5 2019, 11:30 AM · Infrastructure
epriestley added a revision to T13392: Current implementations of "X-Forwarded-For" may take the wrong element: Unknown Object (Differential Revision).
Sep 5 2019, 11:26 AM · Infrastructure
epriestley added a comment to T13392: Current implementations of "X-Forwarded-For" may take the wrong element.

Our behavior appears to be correct when the load balancer is an AWS ELB.

Sep 5 2019, 9:57 AM · Infrastructure

Sep 4 2019

epriestley added a revision to T13336: "bin/storage dump" option "--for-replica" might not interact properly with "--no-indexes" and PERSISTENCE_CACHE: Unknown Object (Differential Revision).
Sep 4 2019, 5:08 PM · Infrastructure
Krinkle awarded T13279: Build Charting for Facts a Orange Medal token.
Sep 4 2019, 4:04 PM · Plans, Facts
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: Unknown Object (Differential Revision).
Sep 4 2019, 2:11 PM · Phortune, Phacility

Sep 3 2019

epriestley added a comment to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY.

There are only 23 occurrences of the string "GROUP BY" in the codebase, and, from inspection, many obviously do not conflict with ONLY_FULL_GROUP_BY.

Sep 3 2019, 11:54 PM · Database, Infrastructure
epriestley added a revision to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY: Restricted Differential Revision.
Sep 3 2019, 11:43 PM · Database, Infrastructure
epriestley triaged T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY as Wishlist priority.
Sep 3 2019, 11:23 PM · Database, Infrastructure
epriestley closed T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues as Resolved.
Sep 3 2019, 7:54 PM · Database, Config
epriestley added a comment to T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover.

Also remaining is to extend this behavior to the HTTP pathway (and to Mercurial/SVN, eventually).

Sep 3 2019, 7:35 PM · Clusters, Diffusion
epriestley added a revision to T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues: Unknown Object (Differential Revision).
Sep 3 2019, 7:26 PM · Database, Config
epriestley added a revision to T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues: Restricted Differential Revision.
Sep 3 2019, 7:23 PM · Database, Config
epriestley added a revision to T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues: Unknown Object (Differential Revision).
Sep 3 2019, 7:19 PM · Database, Config
epriestley triaged T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues as Low priority.
Sep 3 2019, 7:05 PM · Database, Config