Page MenuHomePhabricator
Create Task
Maniphest T13405

Support customization of the default global search scope
Closed, ResolvedPublic
Actions

Description

See PHI29. The default behavior of the global search in the menu bar is not currently configurable, but it's backed by a standard setting and can be made configurable (since approximately T4103).

Revisions and Commits

rP Phabricator
D20793rPf87ec6a5dff9 (stable) Don't offer personal saved queries in global "Search Scope" settings…
D20792rP984e253d41e7 (stable) Fix global search scope fatal on 404 page (or other pages with no…
D20793rP278092974f2f Don't offer personal saved queries in global "Search Scope" settings dropdown
D20792rP63c7302af130 Fix global search scope fatal on 404 page (or other pages with no Application)
D20787rP7e2bec92807d Add a global setting for controlling the default main menu search scope

Related Objects

Event Timeline

epriestley triaged this task as Low priority.Sep 6 2019, 3:20 PM
epriestley created this task.
Herald added a subscriber: amckinley. · View Herald TranscriptSep 6 2019, 3:20 PM
epriestley added a revision: D20787: Add a global setting for controlling the default main menu search scope.Sep 6 2019, 3:24 PM
epriestley closed this task as Resolved by committing rP7e2bec92807d: Add a global setting for controlling the default main menu search scope.Sep 6 2019, 3:39 PM
epriestley added a commit: rP7e2bec92807d: Add a global setting for controlling the default main menu search scope.
epriestley reopened this task as Open.Sep 6 2019, 5:54 PM

I think I missed one case here: the global preference will currently show custom personal queries for the viewing user, but selecting these queries won't work (at least, not completely) for other users. Instead, the control should offer only hard-coded options and global queries.

epriestley added a comment.Sep 9 2019, 3:37 PM

There may also be no Application in contexts where we want to render a global search menu, notably the 404 page:

Argument 2 passed to PhabricatorMainMenuSearchView::getGlobalSearchScopeItems() must be an instance of PhabricatorApplication, null given, called in /Users/epriestley/dev/core/lib/phabricator/src/view/page/menu/PhabricatorMainMenuSearchView.php on line 194

epriestley added a revision: D20792: Fix global search scope fatal on 404 page (or other pages with no Application).Sep 9 2019, 7:11 PM
epriestley added a revision: D20793: Don't offer personal saved queries in global "Search Scope" settings dropdown.Sep 9 2019, 7:16 PM
epriestley added a commit: rP63c7302af130: Fix global search scope fatal on 404 page (or other pages with no Application).Sep 9 2019, 7:18 PM
epriestley closed this task as Resolved by committing rP278092974f2f: Don't offer personal saved queries in global "Search Scope" settings dropdown.Sep 9 2019, 7:21 PM
epriestley added a commit: rP278092974f2f: Don't offer personal saved queries in global "Search Scope" settings dropdown.
epriestley added a commit: rP984e253d41e7: (stable) Fix global search scope fatal on 404 page (or other pages with no….Sep 10 2019, 2:11 PM
epriestley added a commit: rPf87ec6a5dff9: (stable) Don't offer personal saved queries in global "Search Scope" settings….Sep 13 2019, 7:34 PM
Phabricator · Built by Phacility