- D20793 / rPf87ec6a5dff9: (stable) Don't offer personal saved queries in global "Search Scope" settings…
D20792 / rP984e253d41e7: (stable) Fix global search scope fatal on 404 page (or other pages with no…
D20793 / rP278092974f2f: Don't offer personal saved queries in global "Search Scope" settings dropdown
D20792 / rP63c7302af130: Fix global search scope fatal on 404 page (or other pages with no Application)
D20787 / rP7e2bec92807d: Add a global setting for controlling the default main menu search scope
I think I missed one case here: the global preference will currently show custom personal queries for the viewing user, but selecting these queries won't work (at least, not completely) for other users. Instead, the control should offer only hard-coded options and global queries.
There may also be no Application in contexts where we want to render a global search menu, notably the 404 page:
Argument 2 passed to PhabricatorMainMenuSearchView::getGlobalSearchScopeItems() must be an instance of PhabricatorApplication, null given, called in /Users/epriestley/dev/core/lib/phabricator/src/view/page/menu/PhabricatorMainMenuSearchView.php on line 194