Page MenuHomePhabricator

Examine conditions, not just actions, when indexing Herald rules for links to other objects
Closed, ResolvedPublic

Description

See PHI1147.

Currently, Herald indexes other objects that appear in actions, but not conditions. So this gets indexed and shows up on the package page:

[ Add blocking reviewers ][ Package 123 ]

...but this does not:

[ Affected packages include ][ Package 123 ]

There is no technical reason not to index conditions -- this behavior was just implemented for builds first, which never appear in conditions.

Revisions and Commits

Restricted Differential Revision

Event Timeline

epriestley created this task.
epriestley added a revision: Restricted Differential Revision.Sep 9 2019, 7:44 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Sep 9 2019, 7:50 PM
epriestley added a commit: Restricted Diffusion Commit.