Page MenuHomePhabricator
Feed Advanced Search

Dec 1 2016

epriestley added a comment to T11937: GCloud SQL does not support configuring sql_mode.

As far as I can tell, Amazon RDS allows configuration of sql_mode. Here's their announcement of support (from May 2016):

Dec 1 2016, 9:46 PM · Infrastructure, Setup, Feature Request
epriestley added a revision to T11922: Upgrading: Changes to Fulltext Indexing (InnoDB Fulltext): Unknown Object (Differential Revision).
Dec 1 2016, 7:32 PM · FreeBSD, Restricted Project, Installing & Upgrading
epriestley added a comment to T11934: Make email commands ("/subscribe") work in all contexts, including Conpherence ("/me").

See also T7787 for plans to support existing !cc stuff from arc on the CLI.

Dec 1 2016, 7:31 PM · Conpherence (v4), Feature Request
epriestley added a comment to T11934: Make email commands ("/subscribe") work in all contexts, including Conpherence ("/me").

(This doesn't really follow the rules as a feature request because it's just 35 copies of "other systems implement it so you should too", but I think it's something we would probably implement anyway sooner or later so I'm fine with keeping it open.)

Dec 1 2016, 7:30 PM · Conpherence (v4), Feature Request
epriestley closed T11933: Let `PhutilTypeLexer` support PHP style qualified names as Resolved.

Presuming this was resolved by D16967, let me know if there was more to be done.

Dec 1 2016, 7:20 PM · libphutil, Feature Request
epriestley added a comment to Q526: Does ELB/ALB need extra configuration to proxy git ssh?.

Try putting MaxStartups 1024 in your /etc/ssh/sshd_config (or similar).

Dec 1 2016, 2:14 AM
joshuaspence added a project to T11933: Let `PhutilTypeLexer` support PHP style qualified names: libphutil.
Dec 1 2016, 1:36 AM · libphutil, Feature Request
20after4 awarded Blog Post: Write, Review, Merge, Publish: Phabricator Review Workflow a Orange Medal token.
Dec 1 2016, 1:29 AM
carwyn awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Dec 1 2016, 12:40 AM · Workboards (v3), Restricted Project

Nov 30 2016

ocrete awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Nov 30 2016, 8:34 PM · Workboards (v3), Restricted Project
epriestley updated subscribers of T11922: Upgrading: Changes to Fulltext Indexing (InnoDB Fulltext).

@csilvers, not sure if you got directed here from IRC. See also T11932. At HEAD, we'll now issue more explicit guidance about the required index rebuild.

Nov 30 2016, 7:24 PM · FreeBSD, Restricted Project, Installing & Upgrading
epriestley triaged T11932: Manual Activity: Rebuild Search Index as Normal priority.
Nov 30 2016, 7:13 PM · Search, Guides
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

Hmm, I'm guessing this wasn't clear from the workflow either, then?

Nov 30 2016, 6:48 PM · Restricted Project, Calendar
epriestley added a revision to T11922: Upgrading: Changes to Fulltext Indexing (InnoDB Fulltext): Unknown Object (Differential Revision).
Nov 30 2016, 6:47 PM · FreeBSD, Restricted Project, Installing & Upgrading
epriestley created U33 Manual Activity: Rebuild Search Index.
Nov 30 2016, 6:18 PM
epriestley created T11932: Manual Activity: Rebuild Search Index.
Nov 30 2016, 6:18 PM · Search, Guides
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

Why did you allow everyone everyone edit the event?

Nov 30 2016, 5:15 PM · Restricted Project, Calendar
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

Everyone can see from which url a calendar event came.

Nov 30 2016, 4:33 PM · Restricted Project, Calendar
epriestley closed T11931: Conduit API of Projects return their parents projects info as Invalid.

Please read Contributing Feature Requests carefully before filing a feature request.

Nov 30 2016, 4:31 PM · Feature Request

Nov 29 2016

epriestley edited the content of Phacility Cluster Devices.
Nov 29 2016, 9:55 PM
joshuaspence added a comment to T11930: Users don't realise that they must link their account.

That didn't seem to be the case. It might have been because we only enforced Google authentication around one year ago, before that users could use a password for authentication. I can check later today, but perhaps the users that ended up with duplicate accounts never setup Google Auth.

Nov 29 2016, 9:42 PM · NUX, Auth
epriestley added a comment to T11930: Users don't realise that they must link their account.

If the only way to register is Google, it should be impossible to create more than one account per Google account.

Nov 29 2016, 9:37 PM · NUX, Auth
epriestley added a comment to T11930: Users don't realise that they must link their account.

Why is registration disabled?

Nov 29 2016, 9:36 PM · NUX, Auth
joshuaspence added a project to T11930: Users don't realise that they must link their account: NUX.
Nov 29 2016, 9:35 PM · NUX, Auth
joshuaspence added a comment to T11930: Users don't realise that they must link their account.

To provide some additional context, we originally allowed users to register their own accounts, but we eventually disabled this because we ended up with around 30 duplicate accounts (users with more than one account). I think that this happened because users had listed an alias address in their Phabricator settings, but Google was using a canonical email address to authenticate, which didn't map to any existing user accounts (we have a lot of users that have aliases set up. For example, abraham@mycompany.com would be an alias for the canonical alincoln@mycompany.com address).

Nov 29 2016, 9:35 PM · NUX, Auth
joshuaspence created T11930: Users don't realise that they must link their account.
Nov 29 2016, 9:32 PM · NUX, Auth
epriestley added a comment to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.

This one is fine, I'm still going to fiddle with "in" too.

Nov 29 2016, 8:36 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley closed T11929: Merge in duplicates doesn't contain latest tasks as Resolved by committing Restricted Diffusion Commit.
Nov 29 2016, 8:15 PM · Bug Report, Maniphest
epriestley added a revision to T11929: Merge in duplicates doesn't contain latest tasks: Unknown Object (Differential Revision).
Nov 29 2016, 6:40 PM · Bug Report, Maniphest
epriestley closed T11921: Set mail sender name as "<User> via <Configurable name>". as Invalid.

We haven't received more information about this in a few days, so I'm going to close it. Feel free to file a new request in the future, we just prefer not to keep requests open if they're outside of our control to move forward with.

Nov 29 2016, 1:36 PM · Feature Request
epriestley closed T11925: Set niceity levels of background processes: git diff sometimes appears to thrash disk I/O and CPU from background worker as Invalid.

We haven't ever experienced this, nor have we seen reports of users other than you experiencing it. This ("basically prevent the server from doing any other work") doesn't sound like a description of how properly configured servers are generally expected to work. My expectation of modern systems is that they have sophisticated schedulers which are largely fair in allocating resources and produce generally reasonable behavior, and this is consistent with my experience.

Nov 29 2016, 1:22 PM · Feature Request
epriestley closed T11926: Implement a Work Can Wait as Invalid.

If this feature is valuable for you, I think you should implement it in your mail client rather than pursue implementation in every piece of software you use for work. A client-side solution could give you complete coverage with one implementation, and would be more powerful because it could perform additional filtering (e.g., allow important emails through even during off times, or deliver messages but not play an audio alert during off times, or ironically block family communication during work hours instead).

Nov 29 2016, 1:05 PM · Feature Request
epriestley closed T11927: HTML no escaped in Diffusion as Invalid.
  • Please report security issues via HackerOne.
  • This isn't a valid bug report: it is missing required information. See Contributing Bug Reports.
  • I can't reproduce this. Here's an HTML file which is properly escaped:
Nov 29 2016, 12:37 PM · Bug Report
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

Feel free to file a new task when you encounter actual problems with real text and we can look at adjusting the limit, adding an additional block-level difference phase, rewriting PhutilEditDistanceMatrix in C (see T2312), or other approaches. We can make a better decision based on concrete examples of where the current solution is falling short than by guessing where issues might arise.

Nov 29 2016, 12:09 PM · Prioritized, Transactions
cguenther awarded T7930: Let Calendar provide date services to other applications a Love token.
Nov 29 2016, 1:10 AM · Calendar
cguenther awarded T10604: Allow application code to stream request data a Like token.
Nov 29 2016, 1:07 AM · Diffusion (v3), Restricted Project
joshuaspence added a project to T11509: Provide a way to quickly see if all comments on a diff have been marked as "done": Differential.
Nov 29 2016, 12:32 AM · Inline Comments, Differential, Restricted Project, Feature Request
joshuaspence renamed T11495: Drydock doesn't delete working copies from DryDock doesn't delete working copies to Drydock doesn't delete working copies.
Nov 29 2016, 12:30 AM · Bug Report (Needs Information), Drydock

Nov 28 2016

chad awarded T11922: Upgrading: Changes to Fulltext Indexing (InnoDB Fulltext) a Party Time token.
Nov 28 2016, 11:55 PM · FreeBSD, Restricted Project, Installing & Upgrading
epriestley updated the task description for T11922: Upgrading: Changes to Fulltext Indexing (InnoDB Fulltext).
Nov 28 2016, 11:25 PM · FreeBSD, Restricted Project, Installing & Upgrading
joshuaspence added a project to T11900: Create bot reviewers that do code analysis and post findings as inline comments.: Differential.
Nov 28 2016, 7:21 PM · Differential, Feature Request
epriestley closed T11909: Recurring Events: "Edit all Future Events" edits past instances as well as Resolved by committing Restricted Diffusion Commit.
Nov 28 2016, 6:48 PM · Wikimedia, Calendar, Bug Report
epriestley added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

Here's the revised dialog after D16956:

Nov 28 2016, 5:50 PM · Wikimedia, Calendar, Bug Report
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 28 2016, 5:50 PM · Restricted Project, Calendar
epriestley added a revision to T11909: Recurring Events: "Edit all Future Events" edits past instances as well: Unknown Object (Differential Revision).
Nov 28 2016, 5:50 PM · Wikimedia, Calendar, Bug Report
epriestley added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

I don't think that edit is always invalid: offhand, one reason you might want to make such an edit is so that you can add a tag to all events in a series, allowing you to query them so they can be exported to another calendar. Another case I could imagine is wanting to correct a mistake in the description of an event when you know nothing will be lost by editing future events (e.g., because you are the only user who can edit the event).

Nov 28 2016, 5:49 PM · Wikimedia, Calendar, Bug Report
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 28 2016, 5:20 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 28 2016, 4:53 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 28 2016, 4:28 PM · Restricted Project, Calendar
epriestley added a comment to M10: Workphlow.

No.

Nov 28 2016, 3:11 PM
epriestley added a comment to T3612: Lightbox v2.

(To answer your question more directly: yeah, no way to do pht() with variables in Javascript. We can build that without TOO much trouble, but I'd like to wait for a really good use case first.)

Nov 28 2016, 2:44 PM · Lightbox, Restricted Project, Files, Pholio
epriestley closed T11924: Non-numeric maniphest.points values as Wontfix.

I do not plan to pursue any variation on points which can not be summed in a linear way. You can find some discussion under "Quantitative" in T4427#157820.

Nov 28 2016, 2:40 PM · Maniphest, Feature Request
tiagolarafranca awarded T5447: How do I write my own Phabricator applications? a Yellow Medal token.
Nov 28 2016, 2:13 AM · Guides, Applications
epriestley added a comment to T3612: Lightbox v2.

I'd say just get rid of it, or render "X / Y" without pht()?

Nov 28 2016, 1:14 AM · Lightbox, Restricted Project, Files, Pholio

Nov 26 2016

epriestley added a comment to T11816: Calendar: Feedback and Suggestions.
  • Availability cache build on All-Day events may be off, I didn't pick up a dot for E1222.
Nov 26 2016, 5:11 PM · Restricted Project, Calendar
epriestley created E1222: Pup Duty.
Nov 26 2016, 5:10 PM
epriestley added a comment to Q523: How to display Related Objects panel?.

The panel was updated in D16806, on Nov 6. Upgrade Phabricator to see these changes.

Nov 26 2016, 1:09 PM · Maniphest

Nov 25 2016

epriestley created T11922: Upgrading: Changes to Fulltext Indexing (InnoDB Fulltext).
Nov 25 2016, 11:31 PM · FreeBSD, Restricted Project, Installing & Upgrading
epriestley edited the content of Changelog.
Nov 25 2016, 11:08 PM
epriestley created 2016 Week 48 (Very Late November).
Nov 25 2016, 11:07 PM
epriestley closed T10642: Default search boolean logic is mildly inconvenient and not configurable in Amazon RDS as Resolved by committing Restricted Diffusion Commit.
Nov 25 2016, 10:46 PM · Search, Bug Report
epriestley added a revision to T6740: Put some kind of stemmer on the MySQL search index: Unknown Object (Differential Revision).
Nov 25 2016, 10:44 PM · Search
epriestley added a revision to T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud): Unknown Object (Differential Revision).
Nov 25 2016, 9:57 PM
epriestley added a revision to T6740: Put some kind of stemmer on the MySQL search index: Unknown Object (Differential Revision).
Nov 25 2016, 9:36 PM · Search
epriestley added a revision to T6740: Put some kind of stemmer on the MySQL search index: Unknown Object (Differential Revision).
Nov 25 2016, 9:28 PM · Search
epriestley added a revision to T6740: Put some kind of stemmer on the MySQL search index: Unknown Object (Differential Revision).
Nov 25 2016, 8:35 PM · Search
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

Couple of other things:

Nov 25 2016, 7:07 PM · Restricted Project, Calendar
epriestley added a comment to T11921: Set mail sender name as "<User> via <Configurable name>"..

Likewise if this only might cause confusion, but has not actually caused confusion yet, it's a hypothetical problem (see Hypotheticals). We don't accept requests to address hypothetical problems because they often never actually occur.

Nov 25 2016, 6:41 PM · Feature Request
epriestley added a comment to T11921: Set mail sender name as "<User> via <Configurable name>"..

This request doesn't describe a root problem (see Describing Root Problems), but we can only accept feature requests which completely describe root problems. See Contributing Feature Requests for more.

Nov 25 2016, 1:34 PM · Feature Request
epriestley closed T11920: test as Invalid.
Nov 25 2016, 12:00 PM
epriestley closed T11919: Without phabricator.base-uri defined,ssh permission denied as Invalid.

That setup is not supported, and we already raise a setup warning making it clear that major features will not work until the base URI is configured.

Nov 25 2016, 2:51 AM · Bug Report
epriestley added a comment to T11919: Without phabricator.base-uri defined,ssh permission denied.

Why did you choose to ignore the warning, considering that it says "major features will not work properly" until you configure it?

Nov 25 2016, 2:29 AM · Bug Report
epriestley added a comment to T11919: Without phabricator.base-uri defined,ssh permission denied.

When phabriator.base-uri is not configured, you should receive this setup warning:

Nov 25 2016, 2:18 AM · Bug Report

Nov 24 2016

MarcDufresne awarded I2 Donate to Phacility a Mountain of Wealth token.
Nov 24 2016, 8:27 PM · Phacility
epriestley added a comment to T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud).

@20after4, just a heads up:

Nov 24 2016, 6:14 PM
epriestley added a revision to T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud): Unknown Object (Differential Revision).
Nov 24 2016, 6:03 PM
epriestley added a revision to T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud): Unknown Object (Differential Revision).
Nov 24 2016, 5:08 PM
epriestley added a revision to T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud): Unknown Object (Differential Revision).
Nov 24 2016, 4:43 PM
epriestley added a revision to T10642: Default search boolean logic is mildly inconvenient and not configurable in Amazon RDS: Unknown Object (Differential Revision).
Nov 24 2016, 4:23 PM · Search, Bug Report
epriestley added a revision to T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud): Restricted Differential Revision.
Nov 24 2016, 4:23 PM
epriestley added a revision to T10642: Default search boolean logic is mildly inconvenient and not configurable in Amazon RDS: Unknown Object (Differential Revision).
Nov 24 2016, 3:32 PM · Search, Bug Report
epriestley added a revision to T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud): Unknown Object (Differential Revision).
Nov 24 2016, 3:32 PM
epriestley added a comment to T11909: Recurring Events: "Edit all Future Events" edits past instances as well.

As far as I understand, E66 acts as a prototyp (or template), providing defaults for when the individual instances are "materialized" later, when they are edited. Is that correct?

Nov 24 2016, 3:12 PM · Wikimedia, Calendar, Bug Report
epriestley closed T11918: How can I get tasks in one milestone of one object? as Invalid.
Nov 24 2016, 1:23 PM · Maniphest, Feature Request
epriestley created E1220: Thanksgiving.
Nov 24 2016, 12:35 AM
epriestley created E1219: Squirrel Patrol.
Nov 24 2016, 12:33 AM

Nov 23 2016

epriestley added a comment to T11894: Calendar "away icons" do not automatically appear.

E1218 seems to have worked properly after the patch, at least.

Nov 23 2016, 11:47 PM · Calendar, Bug Report
epriestley created E1218: Event Starting More Than 15 Minutes From Now.
Nov 23 2016, 11:23 PM
epriestley closed T11894: Calendar "away icons" do not automatically appear as Resolved by committing Restricted Diffusion Commit.
Nov 23 2016, 11:22 PM · Calendar, Bug Report
epriestley added a comment to T11894: Calendar "away icons" do not automatically appear.

I'm pretty sure D16937 fixes this, thanks for the report! Let us know if you're still seeing issues after that.

Nov 23 2016, 11:16 PM · Calendar, Bug Report
epriestley added a revision to T11894: Calendar "away icons" do not automatically appear: Unknown Object (Differential Revision).
Nov 23 2016, 11:10 PM · Calendar, Bug Report
epriestley added a comment to T11917: Global default settings only apply to logged in users.

I think this should be fixed in HEAD now, but you may want to wait a few days to update (e.g., until stable promotes on Friday) since a few bugs related to T11044 have been cropping up since it landed a couple days ago.

Nov 23 2016, 10:27 PM · Haskell.org, Bug Report
epriestley closed T11917: Global default settings only apply to logged in users as Resolved by committing Restricted Diffusion Commit.
Nov 23 2016, 10:26 PM · Haskell.org, Bug Report
epriestley added a revision to T11917: Global default settings only apply to logged in users: Unknown Object (Differential Revision).
Nov 23 2016, 10:06 PM · Haskell.org, Bug Report
epriestley added a comment to T11894: Calendar "away icons" do not automatically appear.

Yeah, looks like that reproduced it. Here are the caches:

Nov 23 2016, 9:06 PM · Calendar, Bug Report
epriestley added a comment to T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`.

After D16933, the behavior of arc browse <branch> on the experimental branch is:

Nov 23 2016, 8:07 PM · Arcanist, Prioritized, Restricted Project, Feature Request
epriestley added a revision to T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`: Unknown Object (Differential Revision).
Nov 23 2016, 7:50 PM · Arcanist, Prioritized, Restricted Project, Feature Request
epriestley added a comment to E1217: Test-event.

Sorry, can't make it this time! I'll catch you guys next time for sure.

Nov 23 2016, 7:27 PM · Calendar
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
Nov 23 2016, 7:09 PM · Prioritized, Localization
epriestley added a comment to T5267: Localize Phabricator.

Sure, not a problem.

Nov 23 2016, 7:03 PM · Prioritized, Localization