Page MenuHomePhabricator
Create Task
Maniphest T11933

Let `PhutilTypeLexer` support PHP style qualified names
Closed, ResolvedPublic
Actions

Description

PhutilTypeLexer is used by PhutilTypeSpec to perform type checks. Currently it doesn't support qualified class/interface name, in which case it throws an exception. But since qualified name is very common in PHP, I think it's reasonable to add this support.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

wjiang created this task.Dec 1 2016, 1:02 AM
wjiang added a subscriber: joshuaspence.
wjiang added a revision: Restricted Differential Revision.Dec 1 2016, 1:06 AM
joshuaspence added a project: libphutil.Dec 1 2016, 1:36 AM
epriestley added a commit: Restricted Diffusion Commit.Dec 1 2016, 1:50 AM
epriestley closed this task as Resolved.Dec 1 2016, 7:20 PM
epriestley claimed this task.
epriestley added a subscriber: epriestley.

Presuming this was resolved by D16967, let me know if there was more to be done.

Phabricator · Built by Phacility