Page MenuHomePhabricator
Feed Advanced Search

Sep 26 2016

epriestley added a comment to T8135: drag & drop on a workboard sorted by priority behavior is surprising.

I mean, it's probably not worse-worse, and but it feels like trading one kind of confusion for possibly-moderately-less-confusion more than putting a reasonable stopgap behavior in place until we can fix it properly.

Sep 26 2016, 1:25 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley added a comment to T8135: drag & drop on a workboard sorted by priority behavior is surprising.

Oh. To me, that's sort of worse? You end up with "Sort by priority" and your tasks aren't actually sorted by priority if you've moved them between columns, and jump around if you reload, and other users won't see the same ordering if they're trying to follow along in a presentation or whatever.

Sep 26 2016, 1:23 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley added a comment to T8135: drag & drop on a workboard sorted by priority behavior is surprising.

Sorry, I think I'm still not understanding. When the column is grouped by priority, I still expect the auto-reprioritize behavior to work more or less as it does today: if you drag a task into the "High" group, it will change to "High" priority. I don't think we can avoid that without greater confusion.

Sep 26 2016, 1:20 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley added a comment to T8135: drag & drop on a workboard sorted by priority behavior is surprising.

@chad Oh, maybe I'm misunderstanding. What are you proposing, specifically?

Sep 26 2016, 1:11 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley added a comment to T8135: drag & drop on a workboard sorted by priority behavior is surprising.

I think of T10333 and what remains here as mostly the same task -- I don't plan to make sorting and grouping separate (offhand, I can't come up with much of a good reason to group + sort, and if we did support that it would recreate a small version of this problem within groups).

Sep 26 2016, 1:08 PM · Restricted Project, Workboards (v3), Restricted Project
joshuaspence closed T11699: `arc patch` is timing out as Invalid.

Sorry, apparently after running arc upgrade it no longer times out (although it does take a long time).

Sep 26 2016, 4:07 AM · Conduit, Differential
joshuaspence added a comment to T11699: `arc patch` is timing out.
In T11699#195930, @chad wrote:

The error log says July

Sep 26 2016, 2:29 AM · Conduit, Differential
joshuaspence added a comment to T11699: `arc patch` is timing out.

Server

  • rP38b10f05a224d29c723c033dec0820f977aa8026
  • rARC483e985d08d279816708a9e755de8e5c3586d3ba
  • rPHU1a0371a2247a256d1e6e44d4f348adc2750a9788
Sep 26 2016, 2:27 AM · Conduit, Differential
joshuaspence added a comment to T11699: `arc patch` is timing out.

Here are some query traces from XHProf:

Sep 26 2016, 1:24 AM · Conduit, Differential
joshuaspence added a comment to T11699: `arc patch` is timing out.
> time echo '{"revisionIDs": [46496]}' | arc call-conduit  differential.querydiffs >/dev/null
Sep 26 2016, 12:13 AM · Conduit, Differential
joshuaspence created T11699: `arc patch` is timing out.
Sep 26 2016, 12:13 AM · Conduit, Differential

Sep 24 2016

epriestley edited the content of 2016 Week 39 (Late September).
Sep 24 2016, 1:14 PM
epriestley closed T11695: Observer URI fails to clone as Resolved.

iiam

Sep 24 2016, 1:11 PM · Bug Report
epriestley added a comment to T11695: Observer URI fails to clone.

How can I reproduce this locally? See Providing Reproduction Steps for help on providing reproduction steps.

Sep 24 2016, 12:35 PM · Bug Report
epriestley edited the content of Changelog.
Sep 24 2016, 12:55 AM
epriestley created 2016 Week 39 (Late September).
Sep 24 2016, 12:54 AM
epriestley added a comment to T11692: Open differential submission and public view.

To accept this report, we need reproduction instructions we can follow to reproduce the issue locally. See Providing Reproduction Steps for details.

Sep 24 2016, 12:43 AM · Differential, Bug Report (Needs Information)

Sep 23 2016

epriestley added a revision to T11672: Evaluate persistent connections from HTTP contexts: Unknown Object (Differential Revision).
Sep 23 2016, 7:40 PM · Restricted Project, Performance, Clusters, Database
epriestley reopened T11672: Evaluate persistent connections from HTTP contexts as "Open".
Sep 23 2016, 7:37 PM · Restricted Project, Performance, Clusters, Database
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 23 2016, 6:56 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T11691: arc diff with untracked directory complains about every single file in that directory.

I think this is entirely reasonable.

Sep 23 2016, 5:56 PM · FreeBSD, Restricted Project, Arcanist, Bug Report
epriestley triaged T11691: arc diff with untracked directory complains about every single file in that directory as Normal priority.
Sep 23 2016, 5:51 PM · FreeBSD, Restricted Project, Arcanist, Bug Report
epriestley added a comment to T4190: Rebuild remarkup image proxying.

To actually add a remarkup rule, the basics are simple:

Sep 23 2016, 1:28 PM · Contributor Onboarding, Remarkup

Sep 22 2016

epriestley closed T11679: Phragment has invalid (non-UTF8) title glyph as Resolved by committing Restricted Diffusion Commit.
Sep 22 2016, 10:13 PM · Contributor Onboarding, Phragment, Bug Report
epriestley reopened T9896: make images from comments visible in email as "Open".

I think this didn't actually get handled in T10262, but should be doable now.

Sep 22 2016, 10:12 PM · Restricted Project, Remarkup, Mail
epriestley renamed T11670: Automate more of the migration process for moving instances across shards in the Phacility cluster from Move instances across shards in the Phacility cluster to Automate more of the migration process for moving instances across shards in the Phacility cluster.
Sep 22 2016, 10:09 PM · Ops, Phacility
epriestley moved T11670: Automate more of the migration process for moving instances across shards in the Phacility cluster from Backlog to Do Eventually on the Phacility board.
Sep 22 2016, 10:09 PM · Ops, Phacility
epriestley claimed T11679: Phragment has invalid (non-UTF8) title glyph.
Sep 22 2016, 10:08 PM · Contributor Onboarding, Phragment, Bug Report
epriestley added a revision to T11679: Phragment has invalid (non-UTF8) title glyph: Unknown Object (Differential Revision).
Sep 22 2016, 10:08 PM · Contributor Onboarding, Phragment, Bug Report
epriestley added a comment to T11679: Phragment has invalid (non-UTF8) title glyph.

Unicode has a page of heiroglyphs but they don't seem to be supported yet on OSX.

Sep 22 2016, 10:04 PM · Contributor Onboarding, Phragment, Bug Report
epriestley added a comment to T11623: Make Conpherence send text with bare return key, like a chatroom.

This is probably 5 minutes of work, I am just incredibly unreliable.

Sep 22 2016, 10:01 PM · Conpherence (v4)
epriestley closed T11682: Numbered lists are overzealous as Wontfix.

Actually, I don't think we can really style the numbers of a numbered list independently of the rest of the list. They aren't directly addressable with CSS and the approaches I've found for doing it rely on using counter(...), which I think is unreasonably complex for this use case:

Sep 22 2016, 9:57 PM · Bug Report
epriestley closed T11685: Phurl "Shorten a URL" 404s as Resolved by committing Restricted Diffusion Commit.
Sep 22 2016, 9:45 PM · Phurl, Bug Report
epriestley added a revision to T11685: Phurl "Shorten a URL" 404s: Unknown Object (Differential Revision).
Sep 22 2016, 9:41 PM · Phurl, Bug Report
epriestley closed T11683: Attempt to connect to phabricator@p:127.0.0.1 failed with error #1040: Too many connections. as Resolved by committing Restricted Diffusion Commit.
Sep 22 2016, 8:09 PM · Bug Report
epriestley added a revision to T11683: Attempt to connect to phabricator@p:127.0.0.1 failed with error #1040: Too many connections.: Unknown Object (Differential Revision).
Sep 22 2016, 7:39 PM · Bug Report
epriestley added a comment to T11686: Differentials for new files.

I can't reproduce this. Here's a diff with a new file:

Sep 22 2016, 7:22 PM · Feature Request
epriestley added a project to T11685: Phurl "Shorten a URL" 404s: Phurl.
Sep 22 2016, 5:12 PM · Phurl, Bug Report
epriestley added a comment to T11685: Phurl "Shorten a URL" 404s.

Ah! Thanks, we'll get this fixed.

Sep 22 2016, 5:12 PM · Phurl, Bug Report
epriestley reopened T11685: Phurl "Shorten a URL" 404s as "Open".
Sep 22 2016, 5:12 PM · Phurl, Bug Report
epriestley closed T11685: Phurl "Shorten a URL" 404s as Invalid.

See Contributing Bug Reports if this is intended to be a bug report.

Sep 22 2016, 5:11 PM · Phurl, Bug Report
dzahn awarded T11675: "Text" type custom field in Maniphest not displayed in Maniphest Advanced Search form a Love token.
Sep 22 2016, 2:45 PM · Custom Fields, Maniphest, Bug Report
epriestley added a comment to T11683: Attempt to connect to phabricator@p:127.0.0.1 failed with error #1040: Too many connections..

Does raising max_connections in /etc/my.cnf (or similar) and restarting MySQL resolve this?

Sep 22 2016, 1:28 PM · Bug Report
epriestley added a comment to T11682: Numbered lists are overzealous.

GitHub also does this:

Sep 22 2016, 12:11 PM · Bug Report
epriestley added a comment to T11683: Attempt to connect to phabricator@p:127.0.0.1 failed with error #1040: Too many connections..

We made one change recently (T11672) but that should cause us to use fewer connections.

Sep 22 2016, 12:00 PM · Bug Report
epriestley closed T11680: Why not use indentation for TASK GRAPH? as Invalid.

Please see Contributing Feature Requests for help filing feature requests. Thanks!

Sep 22 2016, 3:10 AM · Feature Request
epriestley added a comment to T11675: "Text" type custom field in Maniphest not displayed in Maniphest Advanced Search form.

This should now just work without any changes at HEAD of master. Let us know if you're still seeing issues after updating.

Sep 22 2016, 1:24 AM · Custom Fields, Maniphest, Bug Report
epriestley added a comment to T11676: For task with many dependencies, cannot scroll horizontally in Task Graph for certain widths (overflow is clipped).

I think this should work better at HEAD of master now -- let us know if you're still seeing issues after updating. Thanks for the report!

Sep 22 2016, 1:23 AM · Maniphest, Bug Report
epriestley closed T11676: For task with many dependencies, cannot scroll horizontally in Task Graph for certain widths (overflow is clipped) as Resolved by committing Restricted Diffusion Commit.
Sep 22 2016, 1:22 AM · Maniphest, Bug Report

Sep 21 2016

epriestley closed T11677: Queue tasks from importing repositories at a lower priority level as Resolved by committing Restricted Diffusion Commit.
Sep 21 2016, 11:41 PM · Diffusion, Daemons
epriestley closed T11675: "Text" type custom field in Maniphest not displayed in Maniphest Advanced Search form as Resolved by committing Restricted Diffusion Commit.
Sep 21 2016, 11:39 PM · Custom Fields, Maniphest, Bug Report
epriestley added a revision to T11677: Queue tasks from importing repositories at a lower priority level: Unknown Object (Differential Revision).
Sep 21 2016, 10:38 PM · Diffusion, Daemons
epriestley claimed T11675: "Text" type custom field in Maniphest not displayed in Maniphest Advanced Search form.
Sep 21 2016, 10:07 PM · Custom Fields, Maniphest, Bug Report
epriestley claimed T11676: For task with many dependencies, cannot scroll horizontally in Task Graph for certain widths (overflow is clipped).
Sep 21 2016, 10:06 PM · Maniphest, Bug Report
epriestley closed T11678: Inline images from emails sent from Outlook are not correctly attached to Maniphest Tasks as Resolved.

Presuming resolved by D16584. Thanks!

Sep 21 2016, 10:06 PM · Bug Report
epriestley closed T11672: Evaluate persistent connections from HTTP contexts as Resolved.
Sep 21 2016, 9:47 PM · Restricted Project, Performance, Clusters, Database
epriestley added a comment to T11672: Evaluate persistent connections from HTTP contexts.

I've banged on this a reasonable amount locally without issues and the originating instance reports that this seems to have calmed things down in production with these patches, so it seems like this pretty much just worked.

Sep 21 2016, 9:47 PM · Restricted Project, Performance, Clusters, Database
epriestley added a revision to T11676: For task with many dependencies, cannot scroll horizontally in Task Graph for certain widths (overflow is clipped): Unknown Object (Differential Revision).
Sep 21 2016, 9:45 PM · Maniphest, Bug Report
epriestley added a revision to T11675: "Text" type custom field in Maniphest not displayed in Maniphest Advanced Search form: Unknown Object (Differential Revision).
Sep 21 2016, 9:35 PM · Custom Fields, Maniphest, Bug Report
epriestley added a comment to T11675: "Text" type custom field in Maniphest not displayed in Maniphest Advanced Search form.

There's a bunch of other Herald stuff we already do for this field so I'm just undoing the change from D14766, at least until someone complains that this field type isn't using the search logic they expect.

Sep 21 2016, 9:34 PM · Custom Fields, Maniphest, Bug Report
epriestley added a comment to T11678: Inline images from emails sent from Outlook are not correctly attached to Maniphest Tasks.

Yeah, go ahead and submit a patch. Thanks!

Sep 21 2016, 9:28 PM · Bug Report
epriestley added a comment to T7916: Can't paste images from clipboard in Firefox / Safari.

I can't reproduce this in Chrome (OS X, Version 53.0.2785.116 (64-bit)) so it may be a behavioral change in Chrome.

Sep 21 2016, 7:57 PM · Restricted Project, Firefox, Safari, PHUI
epriestley triaged T11679: Phragment has invalid (non-UTF8) title glyph as Wishlist priority.
Sep 21 2016, 5:57 PM · Contributor Onboarding, Phragment, Bug Report
epriestley renamed T11679: Phragment has invalid (non-UTF8) title glyph from Phragment on secure.phabricator.com crashes to Phragment has invalid (non-UTF8) title glyph.
Sep 21 2016, 5:57 PM · Contributor Onboarding, Phragment, Bug Report
epriestley moved T11679: Phragment has invalid (non-UTF8) title glyph from Backlog to Ready on the Contributor Onboarding board.
Sep 21 2016, 5:56 PM · Contributor Onboarding, Phragment, Bug Report
epriestley added a project to T11679: Phragment has invalid (non-UTF8) title glyph: Contributor Onboarding.

To fix:

Sep 21 2016, 5:56 PM · Contributor Onboarding, Phragment, Bug Report
epriestley updated subscribers of T11679: Phragment has invalid (non-UTF8) title glyph.

We don't normally accept bug reports on prototype applications (see Prototype) but this is a one-line fix.

Sep 21 2016, 5:48 PM · Contributor Onboarding, Phragment, Bug Report
epriestley moved T11667: Default global syntax.filemap sets default filetypes to JavaScript for JSON configurations from Backlog to Ready on the Contributor Onboarding board.
Sep 21 2016, 5:01 PM · Contributor Onboarding, Bug Report
epriestley added a project to T11667: Default global syntax.filemap sets default filetypes to JavaScript for JSON configurations: Contributor Onboarding.

To fix this:

Sep 21 2016, 5:01 PM · Contributor Onboarding, Bug Report
epriestley closed T11668: Herald editing view show unknown error as Invalid.

This isn't a bug in Phabricator, then. Please review Contributing Bug Reports and Support Resources carefully for details on what we provide support with.

Sep 21 2016, 3:40 PM · Bug Report (Needs Information)
epriestley added a comment to T4190: Rebuild remarkup image proxying.

On the cache:

Sep 21 2016, 3:38 PM · Contributor Onboarding, Remarkup
epriestley created T11677: Queue tasks from importing repositories at a lower priority level.
Sep 21 2016, 2:54 PM · Diffusion, Daemons
epriestley added a comment to T11676: For task with many dependencies, cannot scroll horizontally in Task Graph for certain widths (overflow is clipped).

I think this is the CSS that tries to cut off the titles interacting weirdly with other table CSS.

Sep 21 2016, 2:37 PM · Maniphest, Bug Report
epriestley added a comment to T11675: "Text" type custom field in Maniphest not displayed in Maniphest Advanced Search form.

I believed this was semi-intentional, although the downstream report suggests it worked at one point, so maybe I just made a mistake.

Sep 21 2016, 2:23 PM · Custom Fields, Maniphest, Bug Report
epriestley added a comment to T4190: Rebuild remarkup image proxying.

In this case, use the AphrontWriteGuard::beginScopedUnguardedWrites() method to surround the block -- you can grep for usage, but it will look like this:

Sep 21 2016, 1:15 PM · Contributor Onboarding, Remarkup

Sep 20 2016

epriestley awarded T9900: Figlet does not properly render apostrophes with some characters a Cup of Joe token.
Sep 20 2016, 5:22 PM · Contributor Onboarding, Remarkup
epriestley closed T11665: repo002.phacility.net is heavily loaded as Resolved.

All queues have emptied, and repo002 is back in a healthy range again:

Sep 20 2016, 4:39 PM · Ops, Phacility
epriestley edited the content of Phacility Cluster Devices.
Sep 20 2016, 4:36 PM
epriestley edited the content of Phacility Cluster Devices.
Sep 20 2016, 4:36 PM
epriestley added a revision to T11672: Evaluate persistent connections from HTTP contexts: Unknown Object (Differential Revision).
Sep 20 2016, 2:34 PM · Restricted Project, Performance, Clusters, Database
epriestley added a revision to T11672: Evaluate persistent connections from HTTP contexts: Unknown Object (Differential Revision).
Sep 20 2016, 2:29 PM · Restricted Project, Performance, Clusters, Database
epriestley created T11672: Evaluate persistent connections from HTTP contexts.
Sep 20 2016, 1:54 PM · Restricted Project, Performance, Clusters, Database
epriestley merged task T11671: Passing an incorrectly formatted revision ID to `arc patch` results in an exception into T8937: Unclear exception when patching non-existant revision.
Sep 20 2016, 1:33 PM · Arcanist, Bug Report
epriestley merged T11671: Passing an incorrectly formatted revision ID to `arc patch` results in an exception into T8937: Unclear exception when patching non-existant revision.
Sep 20 2016, 1:33 PM · Arcanist
epriestley added a comment to T11665: repo002.phacility.net is heavily loaded.

rP9329e6a12d9f improved the rate at which the Herald queue is draining by approximately 10x.

Sep 20 2016, 1:10 PM · Ops, Phacility
epriestley added a comment to T11665: repo002.phacility.net is heavily loaded.

I've moved the largest instance from repo002 to a new empty shard, which has put both shards into fairly reasonable range. Queues still aren't draining as quickly as I'd like/expect.

Sep 20 2016, 1:02 PM · Ops, Phacility
epriestley added a comment to T11670: Automate more of the migration process for moving instances across shards in the Phacility cluster.

I moved the largest instance from shard 002 to shard 006. This took about 35 minutes, most of which was backup/transfer time. I hit a couple of minor issues, but things appear to have worked properly overall.

Sep 20 2016, 12:47 PM · Ops, Phacility
epriestley added a comment to T11670: Automate more of the migration process for moving instances across shards in the Phacility cluster.

I migrated a test instance, which appears to have worked properly. I'm going to run though things again, then move a large instance off repo002.

Sep 20 2016, 11:52 AM · Ops, Phacility
chad awarded T11670: Automate more of the migration process for moving instances across shards in the Phacility cluster a 100 token.
Sep 20 2016, 11:50 AM · Ops, Phacility
epriestley added a comment to T11670: Automate more of the migration process for moving instances across shards in the Phacility cluster.
  • Suspend the instance: Admin → Instance → Manage Instance → Suspend Instance
  • Stop the daemons:
Sep 20 2016, 11:50 AM · Ops, Phacility
epriestley added a comment to T11670: Automate more of the migration process for moving instances across shards in the Phacility cluster.

I've provisioned and deployed a new shard, but not yet opened it for allocations. I'm going to launch and then migrate a test instance next.

Sep 20 2016, 11:06 AM · Ops, Phacility
epriestley created T11670: Automate more of the migration process for moving instances across shards in the Phacility cluster.
Sep 20 2016, 10:24 AM · Ops, Phacility
epriestley added a comment to T11665: repo002.phacility.net is heavily loaded.

I let the queues drain for a bit overnight. One of the large queues is down from ~16K items to ~12K items in the last 8 hours, but I don't want to just let this sit for 24 hours to "resolve" it. I'm going to look at moving instances across shards instead, which is a capability we need to automate eventually anyway.

Sep 20 2016, 10:06 AM · Ops, Phacility
epriestley added a comment to T11668: Herald editing view show unknown error .

Is this reproducible using fields available in the upstream? How can I reproduce this issue against a clean, vanilla, up-to-date copy of Phabricator with no custom code?

Sep 20 2016, 9:50 AM · Bug Report (Needs Information)
epriestley added a comment to T11668: Herald editing view show unknown error .

Where is "Platform--MUST-->" coming from? That isn't a field we provide in the upstream.

Sep 20 2016, 9:39 AM · Bug Report (Needs Information)
stevex awarded T10038: Plan the mid-term pathway for unit-test/linter bindings a Party Time token.
Sep 20 2016, 8:13 AM · Lint, Arcanist
epriestley added a comment to T11665: repo002.phacility.net is heavily loaded.

Looking at improving the raw performance of bin/repository update, one fixable issue is that we run git for-each-ref three times:

Sep 20 2016, 3:16 AM · Ops, Phacility
epriestley added a comment to T11665: repo002.phacility.net is heavily loaded.

I also identified an instance with a bad HTTP hook which had managed to queue up 8,000 tasks in the queue. These already have scaling backoffs and likely didn't contribute a meaningful amount of load, but we could perhaps find a more graceful approach to handling bad webhook URIs during T11330.

Sep 20 2016, 3:05 AM · Ops, Phacility
epriestley added a comment to T11665: repo002.phacility.net is heavily loaded.

I disabled the keys of the user running 30 clones/minute and notified the instance administrator. This appeared to create some headroom; I reverted the daemon pool size limits to the default and we're draining the queues at a somewhat more reasonable pace now.

Sep 20 2016, 3:03 AM · Ops, Phacility
epriestley added a comment to T11665: repo002.phacility.net is heavily loaded.

@swisspol, that's what this refers to ("From T11666"):

Sep 20 2016, 2:22 AM · Ops, Phacility