Page MenuHomePhabricator
Feed Advanced Search

May 27 2015

epriestley added a comment to T8332: Allow arcanist output to be sent to a file.

Is there a practical use case motivating this? The cases I can come up with are:

May 27 2015, 11:22 PM · Arcanist
epriestley edited P1794 arc lint.
May 27 2015, 11:05 PM
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

We could really push two refs: phabricator/diff/12345 and phabricator/base/12345. To phabricator/base/12345, we push the first parent of the last thing that pops out of git log HEAD --not --remotes -- (that is, the first ancestor of the diff which is also present in any remote)?

May 27 2015, 10:59 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
joshuaspence created T8332: Allow arcanist output to be sent to a file.
May 27 2015, 10:57 PM · Arcanist
joshuaspence created T8331: phlog can be improved.
May 27 2015, 10:53 PM · Infrastructure
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

From D13041, it looks like the first time git does a push to a totally separate staging area it pushes a lot of extra data, probably because none of the heads in the remote are ancestors of the head being pushed, so it can't detect that their ancestries are 99.9% identical.

May 27 2015, 10:51 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
joshuaspence edited P1793 (An Untitled Masterwork).
May 27 2015, 10:32 PM
btrahan awarded T8330: Detect/repair invalid "enum" config a Like token.
May 27 2015, 10:31 PM · Contributor Onboarding, Setup
joshuaspence edited P1793 (An Untitled Masterwork).
May 27 2015, 10:28 PM
epriestley updated subscribers of T8330: Detect/repair invalid "enum" config.
May 27 2015, 10:11 PM · Contributor Onboarding, Setup
epriestley created T8330: Detect/repair invalid "enum" config.
May 27 2015, 10:11 PM · Contributor Onboarding, Setup
joshuaspence closed T6214: New revisions aren't always assigned an Arcanist Project automatically as Wontfix.

See T7604.

May 27 2015, 9:54 PM · Arcanist
epriestley added a comment to T8200: Upload File explanation dialog displays behind fullscreen editor.

make the fullscreen mode z-index some smaller value

May 27 2015, 9:49 PM · Restricted Project, Remarkup, Files
joshuaspence updated subscribers of T784: Allow Differential changesets to be marked with various attributes.
May 27 2015, 9:48 PM · Restricted Project, Restricted Project, Restricted Project, Differential, Arcanist
joshuaspence merged task T6275: Differential should hide files in with exclude syntax same as .arclint into T784: Allow Differential changesets to be marked with various attributes.
May 27 2015, 9:48 PM · Differential
joshuaspence claimed T6310: Parameters description is not Remarkuped.
May 27 2015, 9:42 PM · Remarkup, Diviner
joshuaspence updated the task description for T8327: Argument 1 passed to DifferentialChangesetHTMLRenderer::renderImageStage() must be an instance of PhabricatorFile.
May 27 2015, 8:54 PM · Differential
joshuaspence created T8327: Argument 1 passed to DifferentialChangesetHTMLRenderer::renderImageStage() must be an instance of PhabricatorFile.
May 27 2015, 8:54 PM · Differential
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

I configured this for our repos; only hiccup so far is that there's no way to disable "Commit Hook" Herald rules right now so the first pushes (which pushed the entire repo history) took a little while. Normal "arc diff" staging pushes only take about a second.

May 27 2015, 7:04 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley edited P1791 Instance Config.
May 27 2015, 6:40 PM
epriestley added a comment to T8326: Scripts may try to access PhabricatorStartup, but can not.

A clean-ish but very non-general fix would be to load PhabricatorStartup explicitly before using it in code which might be hit on a non-web pathway. It looks like PhabricatorAccessControlTestCase.php already does this.

May 27 2015, 5:47 PM · Infrastructure
epriestley created T8326: Scripts may try to access PhabricatorStartup, but can not.
May 27 2015, 5:44 PM · Infrastructure
epriestley closed T7127: Saving new path list when deletes occur is erroneous at best as Resolved by committing Restricted Diffusion Commit.
May 27 2015, 5:30 PM · Owners
epriestley closed T7127: Saving new path list when deletes occur is erroneous at best, a subtask of T8320: Bring Owners out of the dark ages, as Resolved.
May 27 2015, 5:30 PM · Prioritized, Owners
epriestley closed T8073: Unable to add Repositories to Owner groups (Packages) after creation as Resolved by committing Restricted Diffusion Commit.
May 27 2015, 5:30 PM · Owners
epriestley closed T8073: Unable to add Repositories to Owner groups (Packages) after creation, a subtask of T8320: Bring Owners out of the dark ages, as Resolved.
May 27 2015, 5:30 PM · Prioritized, Owners
epriestley closed Restricted Maniphest Task, a subtask of T8320: Bring Owners out of the dark ages, as Resolved.
May 27 2015, 5:30 PM · Prioritized, Owners
epriestley closed T8317: Can't add a new path to an owner's package as Resolved by committing Restricted Diffusion Commit.
May 27 2015, 5:30 PM · Owners
epriestley closed T8317: Can't add a new path to an owner's package, a subtask of T8320: Bring Owners out of the dark ages, as Resolved.
May 27 2015, 5:30 PM · Prioritized, Owners
epriestley closed T8259: `arc diff` doesn't use chunked uploads as Resolved by committing Restricted Diffusion Commit.
May 27 2015, 5:26 PM · Arcanist
epriestley added a revision to T8259: `arc diff` doesn't use chunked uploads: Unknown Object (Differential Revision).
May 27 2015, 5:18 PM · Arcanist
joshuaspence claimed T6482: arc patch does not pull in dependencies.
May 27 2015, 1:03 PM · Restricted Project, Arcanist
joshuaspence claimed T6653: Script and regex linter could use some examples.
May 27 2015, 12:23 PM · Lint, Documentation, Arcanist
joshuaspence added a comment to T6766: `arc diff` should do an early check for total diff size and provide appropriate hints for the user.

T8259 should partially fix this.

May 27 2015, 11:01 AM · Arcanist
joshuaspence closed T6154: XHPAST fails to recognise some syntax errors as Resolved.

This was sorta fixed by D12922.

May 27 2015, 9:28 AM · XHPAST
CodeMouse92 awarded T8022: Implement a meeting autoscheduler a Like token.
May 27 2015, 5:54 AM · Calendar
joshuaspence closed T8321: Re-enable reentrant code as Wontfix.
May 27 2015, 2:43 AM · Arcanist
joshuaspence added a comment to T8322: Pasting task ID into ObjectBrowser doesn't work on Mobile.

Ah OK, so it seems to only affect my mobile device (Chrome on Nexus 5).

May 27 2015, 2:42 AM · Mobile, Maniphest
epriestley added a revision to T7127: Saving new path list when deletes occur is erroneous at best: Unknown Object (Differential Revision).
May 27 2015, 1:29 AM · Owners
epriestley added a revision to T8317: Can't add a new path to an owner's package: Unknown Object (Differential Revision).
May 27 2015, 1:29 AM · Owners
epriestley added a revision to T8073: Unable to add Repositories to Owner groups (Packages) after creation: Unknown Object (Differential Revision).
May 27 2015, 1:29 AM · Owners
epriestley added a revision to T8320: Bring Owners out of the dark ages: Unknown Object (Differential Revision).
May 27 2015, 1:29 AM · Prioritized, Owners
epriestley created T8323: Saving draft inlines on left hand side of files not present in newer diff in diff-of-diffs fails.
May 27 2015, 12:29 AM · Inline Comments, Differential

May 26 2015

joshuaspence added a comment to T8321: Re-enable reentrant code.

I guess that's reasonable.

May 26 2015, 11:48 PM · Arcanist
epriestley added a comment to T8321: Re-enable reentrant code.

Maybe put "../arcanist/bin" as the first component of your PATH? That should work from arcanist/ or libphutil/.

May 26 2015, 11:47 PM · Arcanist
joshuaspence added a comment to T8321: Re-enable reentrant code.

That would mean always running ./bin/arc (from rARC) or ../arcanist/bin/arc (from rPHU), which I thought would be manageable but it turns out to be annoying.

May 26 2015, 11:45 PM · Arcanist
epriestley added a revision to T8320: Bring Owners out of the dark ages: Unknown Object (Differential Revision).
May 26 2015, 11:22 PM · Prioritized, Owners
epriestley added a comment to T8321: Re-enable reentrant code.

Can you just... not run different copies of arc in other different copies of arc? Crazy workaround, I know.

May 26 2015, 11:07 PM · Arcanist
joshuaspence claimed T6806: Raise severity of "phd.user" warning eventually.
May 26 2015, 10:06 PM · Daemons
joshuaspence claimed T6867: Add linter and unit test engine for Go(lang).
May 26 2015, 10:03 PM · Lint
joshuaspence claimed T6884: Logging when a task has been marked as a blocker.
May 26 2015, 10:02 PM · Transactions, Maniphest
joshuaspence created T8322: Pasting task ID into ObjectBrowser doesn't work on Mobile.
May 26 2015, 10:02 PM · Mobile, Maniphest
joshuaspence closed T6897: Diffusion commit email notification does not specify branch as Resolved.
May 26 2015, 10:00 PM · Diffusion
joshuaspence added a revision to T6897: Diffusion commit email notification does not specify branch: Unknown Object (Differential Revision).
May 26 2015, 9:59 PM · Diffusion
joshuaspence claimed T8321: Re-enable reentrant code.
May 26 2015, 9:25 PM · Arcanist
joshuaspence created T8321: Re-enable reentrant code.
May 26 2015, 9:25 PM · Arcanist
epriestley added a comment to T8320: Bring Owners out of the dark ages.

So, anyone have any clue what we use "primary owner" for?

May 26 2015, 9:01 PM · Prioritized, Owners
epriestley added a revision to T8320: Bring Owners out of the dark ages: Unknown Object (Differential Revision).
May 26 2015, 8:57 PM · Prioritized, Owners
epriestley added a comment to T8320: Bring Owners out of the dark ages.

Installs which relied on "Arcanist Project" Herald rules don't necessarily have a perfect way forward; "Owners"-based rules are one of the alternatives I suggest in the upgrading guide in the description of that task.

May 26 2015, 8:38 PM · Prioritized, Owners
joshuaspence added a comment to T8320: Bring Owners out of the dark ages.

What does this have to do with T7604?

May 26 2015, 8:37 PM · Prioritized, Owners
epriestley added a revision to T8320: Bring Owners out of the dark ages: Unknown Object (Differential Revision).
May 26 2015, 8:33 PM · Prioritized, Owners
epriestley updated the task description for T4830: Applications with Public permissions requiring users to login.
May 26 2015, 7:49 PM · Policy, People, Facts
epriestley removed a project from T4830: Applications with Public permissions requiring users to login: Owners.
May 26 2015, 7:49 PM · Policy, People, Facts
epriestley added a comment to T4830: Applications with Public permissions requiring users to login.

D13024 fixes this for Owners.

May 26 2015, 7:49 PM · People, Policy, Facts
epriestley added a revision to T8320: Bring Owners out of the dark ages: Unknown Object (Differential Revision).
May 26 2015, 7:49 PM · Prioritized, Owners
epriestley added a subtask for T8320: Bring Owners out of the dark ages: T5263: Owners does not interact well with Subversion repositories using "Import Only" to import a subset of the repository.
May 26 2015, 7:11 PM · Prioritized, Owners
epriestley added a parent task for T5263: Owners does not interact well with Subversion repositories using "Import Only" to import a subset of the repository: T8320: Bring Owners out of the dark ages.
May 26 2015, 7:11 PM · Owners
chad awarded T8320: Bring Owners out of the dark ages a Manufacturing Defect? token.
May 26 2015, 7:11 PM · Prioritized, Owners
epriestley moved T4830: Applications with Public permissions requiring users to login from Future to Dark Ages on the Owners board.
May 26 2015, 7:11 PM · People, Policy, Facts
epriestley moved T5263: Owners does not interact well with Subversion repositories using "Import Only" to import a subset of the repository from Future to Dark Ages on the Owners board.
May 26 2015, 7:11 PM · Owners
epriestley added a parent task for T7127: Saving new path list when deletes occur is erroneous at best: T8320: Bring Owners out of the dark ages.
May 26 2015, 7:11 PM · Owners
epriestley added a subtask for T8320: Bring Owners out of the dark ages: T7127: Saving new path list when deletes occur is erroneous at best.
May 26 2015, 7:11 PM · Prioritized, Owners
epriestley moved T7127: Saving new path list when deletes occur is erroneous at best from Backlog to Dark Ages on the Owners board.
May 26 2015, 7:11 PM · Owners
epriestley moved T8073: Unable to add Repositories to Owner groups (Packages) after creation from Backlog to Dark Ages on the Owners board.
May 26 2015, 7:11 PM · Owners
epriestley moved T8317: Can't add a new path to an owner's package from Backlog to Dark Ages on the Owners board.
May 26 2015, 7:11 PM · Owners
epriestley moved T8320: Bring Owners out of the dark ages from Backlog to Dark Ages on the Owners board.
May 26 2015, 7:10 PM · Prioritized, Owners
epriestley added a subtask for T8320: Bring Owners out of the dark ages: T8073: Unable to add Repositories to Owner groups (Packages) after creation.
May 26 2015, 7:10 PM · Prioritized, Owners
epriestley added a parent task for T8073: Unable to add Repositories to Owner groups (Packages) after creation: T8320: Bring Owners out of the dark ages.
May 26 2015, 7:10 PM · Owners
epriestley added a subtask for T8320: Bring Owners out of the dark ages: Unknown Object (Maniphest Task).
May 26 2015, 7:10 PM · Prioritized, Owners
epriestley added a subtask for T8320: Bring Owners out of the dark ages: T8317: Can't add a new path to an owner's package.
May 26 2015, 7:10 PM · Prioritized, Owners
epriestley added a parent task for T8317: Can't add a new path to an owner's package: T8320: Bring Owners out of the dark ages.
May 26 2015, 7:10 PM · Owners
epriestley created T8320: Bring Owners out of the dark ages.
May 26 2015, 7:10 PM · Prioritized, Owners
epriestley added a comment to T8317: Can't add a new path to an owner's package.

I can't immediately reproduce this, but Owners is in generally bad shape. I think I can justify spending at least some time unearthing it because of vaguely related work in T7604, though, so let's see how far I get.

May 26 2015, 7:09 PM · Owners
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

Yep, that's right. My plan for the upstream to move forward in the short term (until we build virtual refs) is:

May 26 2015, 6:46 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley closed T8318: Diffusion closes tasks when commit message has a line ending in "fixes" followed by a line beginning with a Txxx task reference as Wontfix.

In the general case, this is working as intended. Specifically, it's intentional that we accept linebreaks in the middle of a "Fixes X, Y" statement, because linebreaks aren't always added explicitly by users.

May 26 2015, 5:53 PM · Diffusion
epriestley added a revision to T8238: Formally support side-band change handoff in external repositories: Unknown Object (Differential Revision).
May 26 2015, 5:42 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a revision to T8238: Formally support side-band change handoff in external repositories: Unknown Object (Differential Revision).
May 26 2015, 5:39 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

It looks like we can push to some secret place:

May 26 2015, 5:31 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

I have this working, but pushing to tags in the same repo is pretty leaky. The docs say this of git fetch:

May 26 2015, 5:19 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a revision to T8259: `arc diff` doesn't use chunked uploads: Unknown Object (Differential Revision).
May 26 2015, 3:57 PM · Arcanist
epriestley added a revision to T8259: `arc diff` doesn't use chunked uploads: Unknown Object (Differential Revision).
May 26 2015, 3:18 PM · Arcanist
epriestley added a comment to T7484: Lock is not locked by this process.

spooky!

May 26 2015, 1:52 PM · Restricted Project, Daemons
epriestley lowered the priority of T5375: Tokenizers fail in Firefox on Android from Unbreak Now! to Wishlist.
May 26 2015, 1:36 PM · Firefox, Android
gerriet awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
May 26 2015, 1:29 PM · Workboards (v3), Restricted Project
epriestley closed T8312: Example for postponed linters as Wontfix.

See T8089 / T8097. We are moving away from the "postponed linters" mechanism, specifically.

May 26 2015, 1:15 PM · Support
epriestley closed T8314: arc diff causes exception if no reviewers are specified as Resolved by committing Restricted Diffusion Commit.
May 26 2015, 1:07 PM · Arcanist
epriestley closed T8156: Linter failures don't provide relevant stacktraces as Resolved by committing Restricted Diffusion Commit.
May 26 2015, 1:06 PM · Arcanist, Lint
joshuaspence claimed T7449: Support ANSI escaped color sequences in Paste.
May 26 2015, 12:56 PM · Paste
joshuaspence added a project to T8311: Allow Diviner to import documentation: Diviner.
May 26 2015, 7:33 AM · Diviner
joshuaspence created T8311: Allow Diviner to import documentation.
May 26 2015, 3:13 AM · Diviner