See PHI364. An install encountered a held lock issue in a cluster which resolved itself immediately when I appeared onsite.

is there a chance that this problem will get fixed?
The change D17989 is already from May 2017 without any reviewer...

Having looked at the code some more, I see when the HeraldPreCommitRefAdapter runs, there is no parsed commit object yet, so there's no way to invoke harbormaster (what would the container PHID be?). This kind of makes sense.

It would be nice if exemptions could be granted for all members of a given Phabricator group, rather than only on a user basis.
Use case: having a group of employees of a given organization, who don't need to sign a DCO-like document, because their employment contracts take care of it; while at the same time requiring DCO signing by external contributors.

Some of this got fixed, some ended up in T13081.

With that stuff, we're down from 473 to 227 on T9950. That's still awful, but not quite as ridiculous.

See T13069 for mail stamp plans.

This was largely tackled above.

I'm having some difficulty merging (5) and (6), or either of them into (2). My local test also has a lot of nonsense going on that a real install shouldn't. I'm going to land what I've got so far and see how much progress we've made here.

Queries are down to 139 for me locally.

Queries are now down from 151 to 145 for me locally.

Next problem:

For my local test task (T369), the initial page query load was 199 queries. After D19222 we're down slightly to 151 queries.

Some of this is:

This was resolved by the introduction of PhabricatorExtendedPolicyInterface. Older cases with missing policy proxies occasionally crop up, but I believe most of them are resolved at HEAD of master. These errors always fail closed (deny access which should be acceptable), never fail open (allow impermissible access) so there's no urgency to hunting them down.

See followup in T13105.

See followup in T13105.

(I'll follow up in T13102 if there's more to be done here, it's possible that some installs are missing this for reasons other than "Ubuntu + apt get install php5-mysql").

It appears that MYSQLI_ASYNC depends mostly on mysqlnd ("MySQL Native Driver"). This has been the default since PHP 5.3 was released in 200 BC, but Ubuntu, at least, unbundles it and you can still install php5-mysql (non-native driver). Compounding this, we currently recommend installs install php5-mysql (bad), rather than php5-msyqlnd (good).

Yeah, that was the commit that reminded me how I wanted this. Unfortunately, it looks like the database still stores literal repositoryPHIDs, so the schema would need to change if it were to handle functions (which is why I bumped the ticket instead of taking a stab at implementing it myself first). I figured I'd add my voice to the ticket for now and continue toiling along with complex Herald rules for now.

After D19191 it would be relatively easy to support projects and wildcard functions (like "Any Repository") but there's currently no interest in this from customers.

I don't suppose there's been any interest in adding wildcards/function matchers to Owners in the last couple of years?

While testing D19215 I ran into this behavior in Asana:

I wasn't able to reproduce the black background issue, exactly, but here's what I changed:

Thanks, I wasn't able to puzzle out the reproduction instructions on the original report since they didn't mention actually making any policy changes.

(This still needs documentation and validation for the configuration option before it's done, but I don't have any short-term plans to pursue those.)

To customize this:

Safari, Chrome, and Firefox all seem fine with PNG icons so I think we don't need to deal with actual .ico icons.

I'm rolling this forward into T13103 but don't actually plan to implement Harbormaster build icons at this time since there are no outstanding requests from customers.