Page MenuHomePhabricator
Feed Advanced Search

Jan 5 2017

epriestley added a revision to T12068: Inbound Emails View Mail Body shows the wrong command: Unknown Object (Differential Revision).
Jan 5 2017, 3:40 PM · Bug Report
chad added a comment to T12068: Inbound Emails View Mail Body shows the wrong command.

Funny, never knew we put that text in that drop down.

Jan 5 2017, 3:39 PM · Bug Report
epriestley claimed T12068: Inbound Emails View Mail Body shows the wrong command.
Jan 5 2017, 3:38 PM · Bug Report
pouyana added a comment to T12068: Inbound Emails View Mail Body shows the wrong command.

Sorry, Step By Step Guide:

Jan 5 2017, 3:37 PM · Bug Report
epriestley added a comment to T11989: Wage an endless war against HP Printer Fax Support.

That one is somewhat interesting because the user created a safe-looking object, then edited the objectionable content into it. I had hoped we might see a few years of uneasy peace before things escalated so far.

Jan 5 2017, 3:33 PM · Abuse
chad added a comment to T12068: Inbound Emails View Mail Body shows the wrong command.

Please read Contributing Bug Reports carefully, specifically we require a complete, easy to follow and under.stand, set of steps to reproduce the problem.

Jan 5 2017, 3:30 PM · Bug Report
chad added a comment to T12067: Inbound Email Reply-to not set correctly.

Please read Contributing Bug Reports carefully, specifically we require a complete, easy to follow and under.stand, set of steps to reproduce the problem. I also don't understand what you're saying the bug in Phabricator is.

Jan 5 2017, 3:30 PM · Bug Report
pouyana added a comment to T12067: Inbound Email Reply-to not set correctly.

So, just some insight, I use postfix as mail server and for catch all mail (@domain) I used the canonical approach. This results the error above. Using virtual as described here will solve this problem.

Jan 5 2017, 2:33 PM · Bug Report
pouyana created T12068: Inbound Emails View Mail Body shows the wrong command.
Jan 5 2017, 2:02 PM · Bug Report
pouyana renamed T12067: Inbound Email Reply-to not set correctly from Inbound Email ReplayTo not set correctly to Inbound Email Replay-to not set correctly.
Jan 5 2017, 1:52 PM · Bug Report
pouyana created T12067: Inbound Email Reply-to not set correctly.
Jan 5 2017, 1:52 PM · Bug Report
urzds added a comment to T9021: Put User accounts in Spaces so some users can not see one another.

@PicoCreator:

  1. Paste the patch into a $FILE
  2. cd $PHABRICATOR_SRC
  3. patch -p1 < $FILE
Jan 5 2017, 11:03 AM · Spaces
johnny-bit added a comment to T11989: Wage an endless war against HP Printer Fax Support.

Endless war continues with E1323 😉

Jan 5 2017, 10:58 AM · Abuse
aubort added a watcher for Security: aubort.
Jan 5 2017, 8:42 AM
chad added a comment to T12064: Tooltip for "Preview" in comment box overflows horizontally.

On my laptop it triggers either to the right of the preview icon or to the bottom, on my desktop, it does top, and gets jittery.

Jan 5 2017, 3:23 AM · Bug Report
epriestley added a comment to T12064: Tooltip for "Preview" in comment box overflows horizontally.

I think this really is the same as T10687, but the jittery bad degenerate behavior is only when a scrollbar gets added, so probably laptop + mouse works to repro but not laptop + touchpad?

Jan 5 2017, 3:21 AM · Bug Report
epriestley awarded T12065: Can't close actions in Maniphest a Evil Spooky Haunted Tree token.
Jan 5 2017, 3:18 AM · Bug Report
epriestley added a comment to T12065: Can't close actions in Maniphest.

Thanks for the excellent bug report with high-quality reproduction steps. Your clear, thorough reproduction steps made fixing this issue extremely easy!

Jan 5 2017, 3:17 AM · Bug Report
epriestley closed T12065: Can't close actions in Maniphest as Resolved by committing Restricted Diffusion Commit.
Jan 5 2017, 3:17 AM · Bug Report
epriestley added a revision to T12065: Can't close actions in Maniphest: Unknown Object (Differential Revision).
Jan 5 2017, 3:15 AM · Bug Report
chad added a comment to T12065: Can't close actions in Maniphest.

Cry in vain this step is optional.

Jan 5 2017, 3:11 AM · Bug Report
epriestley claimed T12065: Can't close actions in Maniphest.
Jan 5 2017, 3:11 AM · Bug Report
chad created T12065: Can't close actions in Maniphest.
Jan 5 2017, 3:10 AM · Bug Report
epriestley closed T12061: When problems occur in phd inside sudo error messages are neither printed nor logged as Invalid.

Specifically, this was already improved by D15726 in April 2016.

Jan 5 2017, 3:09 AM · Feature Request
chad updated the task description for T12064: Tooltip for "Preview" in comment box overflows horizontally.
Jan 5 2017, 3:00 AM · Bug Report
chad added a comment to T12061: When problems occur in phd inside sudo error messages are neither printed nor logged.

This doesn't appear to be a valid Feature Request or Bug Report. See Support Resources for how to get support using Phabricator.

Jan 5 2017, 2:11 AM · Feature Request
chad updated the task description for T12064: Tooltip for "Preview" in comment box overflows horizontally.
Jan 5 2017, 2:10 AM · Bug Report
chad updated the task description for T12064: Tooltip for "Preview" in comment box overflows horizontally.
Jan 5 2017, 2:09 AM · Bug Report
chad reopened T12064: Tooltip for "Preview" in comment box overflows horizontally as "Open".

Actually, this is a haunt mode bug, I'll update the description with a full set of reproducible steps.

Jan 5 2017, 2:07 AM · Bug Report
chad merged task T12064: Tooltip for "Preview" in comment box overflows horizontally into T10687: jx-tooltip does whatever it feels like.
Jan 5 2017, 2:01 AM · Bug Report
chad merged T12064: Tooltip for "Preview" in comment box overflows horizontally into T10687: jx-tooltip does whatever it feels like.
Jan 5 2017, 2:01 AM · PHUI, Bug Report
diagramatics created T12064: Tooltip for "Preview" in comment box overflows horizontally.
Jan 5 2017, 1:08 AM · Bug Report

Jan 4 2017

epriestley closed T10136: Show warning in Revision when build failed as Resolved by committing Restricted Diffusion Commit.
Jan 4 2017, 11:12 PM · Restricted Project, Differential, Feature Request
chad merged T12063: Would like herald rules that add required reviewers be more of a guarantee into T731: Allow revisions to have alternate acceptance conditions.
Jan 4 2017, 10:44 PM · Restricted Project, Restricted Project, Differential
chad merged task T12063: Would like herald rules that add required reviewers be more of a guarantee into T731: Allow revisions to have alternate acceptance conditions.
Jan 4 2017, 10:43 PM · Feature Request
chris.siden created T12063: Would like herald rules that add required reviewers be more of a guarantee.
Jan 4 2017, 10:15 PM · Feature Request
epriestley added a revision to T10136: Show warning in Revision when build failed: Unknown Object (Differential Revision).
Jan 4 2017, 10:07 PM · Restricted Project, Differential, Feature Request
epriestley added a comment to T8650: DifferentialTransactionEditor may race HarbormasterBuildWorker.

The revision editor and diff editor should no longer be racing to edit the diff. The two revision editors may be racing now, but that race is significantly easier to resolve if it crops up.

Jan 4 2017, 9:57 PM · Restricted Project, Harbormaster (v3), Differential
epriestley added a comment to T9276: Display when builds happen with status somewhere handy, like the differential timeline.

This should work again now. The behavior probably needs refinement -- I don't remember exactly where we left it and I think there was some disagreement about who should or shouldn't receive build failure notifications before D10911 accidentally disabled this, but I think T9892 and other Harbormaster tasks discuss most of that.

Jan 4 2017, 9:56 PM · Restricted Project, Harbormaster (v3), Differential
epriestley closed T9276: Display when builds happen with status somewhere handy, like the differential timeline as Resolved by committing Restricted Diffusion Commit.
Jan 4 2017, 9:46 PM · Restricted Project, Harbormaster (v3), Differential
epriestley closed T8650: DifferentialTransactionEditor may race HarbormasterBuildWorker as Resolved by committing Restricted Diffusion Commit.
Jan 4 2017, 9:46 PM · Restricted Project, Harbormaster (v3), Differential
epriestley closed T8650: DifferentialTransactionEditor may race HarbormasterBuildWorker, a subtask of T8657: Harbormaster v1 Errata, as Resolved.
Jan 4 2017, 9:46 PM · Harbormaster
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Chrome upstream has patched this, now:

Jan 4 2017, 9:31 PM · Bug Report
epriestley added a revision to T9276: Display when builds happen with status somewhere handy, like the differential timeline: Unknown Object (Differential Revision).
Jan 4 2017, 9:24 PM · Restricted Project, Harbormaster (v3), Differential
epriestley added a revision to T8650: DifferentialTransactionEditor may race HarbormasterBuildWorker: Unknown Object (Differential Revision).
Jan 4 2017, 9:24 PM · Restricted Project, Harbormaster (v3), Differential
epriestley added a comment to T10939: Support for OWNERS files.

From elsewhere:

Jan 4 2017, 8:40 PM · Prioritized, Restricted Project, Owners
neilfitz added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

They said it's a definite improvement. Nice!

Jan 4 2017, 7:34 PM · Accessibility, Design, Feature Request, Restricted Project
neilfitz added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

Thanks for the quick response! I'll send that last image over to our user, and see if it's an improvement for them as well.

Jan 4 2017, 7:25 PM · Accessibility, Design, Feature Request, Restricted Project
chad added a revision to T12060: Colorblind accessibility for red/green highlighting in e-mails: Unknown Object (Differential Revision).
Jan 4 2017, 7:22 PM · Accessibility, Design, Feature Request, Restricted Project
epriestley added a comment to T5867: Move Quick Create to MenuItemEngine.

I'm not actually sure which will end up being easier, I think they have like 95% of the same problems. Quick Create probably is a bit easier, though.

Jan 4 2017, 7:07 PM · Design
chad added a project to T12060: Colorblind accessibility for red/green highlighting in e-mails: Accessibility.
Jan 4 2017, 7:06 PM · Accessibility, Design, Feature Request, Restricted Project
chad added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

I really want a small remarkup block sometimes.

Jan 4 2017, 7:05 PM · Accessibility, Design, Feature Request, Restricted Project
epriestley added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

Haha, maybe it's like when Blizzard uses a simulator to build a colorblind mode they screw it up, therefor the simulator must not work?

Jan 4 2017, 7:03 PM · Accessibility, Design, Feature Request, Restricted Project
chad added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

He said simulators don't work well... but I'm like (how would you know................)

Jan 4 2017, 7:02 PM · Accessibility, Design, Feature Request, Restricted Project
epriestley added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

Ah, cool. I'm 100% onboard with it if an actual affected user has confirmed that the change is good, I'm just really uneasy about accessibility changes that don't actually involve the affected users.

Jan 4 2017, 7:02 PM · Accessibility, Design, Feature Request, Restricted Project
chad added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

pasted_file (812×924 px, 112 KB)

Jan 4 2017, 7:01 PM · Accessibility, Design, Feature Request, Restricted Project
chad added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

I'm working with a color blind designer in another chat channel, they're looking over my work. We don't think it's needed.

Jan 4 2017, 7:00 PM · Accessibility, Design, Feature Request, Restricted Project
epriestley added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

Do you specifically not want to add a red-green colorblind mode to the existing "Accessibility" settings?

Jan 4 2017, 6:59 PM · Accessibility, Design, Feature Request, Restricted Project
chad added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

I think I'd learn, if that's the way I always saw red/green.

Jan 4 2017, 6:56 PM · Accessibility, Design, Feature Request, Restricted Project
epriestley added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

If a change only had one of those colors (e.g., just one added section, or just one removed section) I think I'd have no clue if it was removed-red or added-red.

Jan 4 2017, 6:55 PM · Accessibility, Design, Feature Request, Restricted Project
chad added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

Screen Shot 2017-01-04 at 10.51.40 AM.png (782×838 px, 79 KB)

Jan 4 2017, 6:52 PM · Accessibility, Design, Feature Request, Restricted Project
chad added a comment to T5867: Move Quick Create to MenuItemEngine.

I'm for whichever is easiest, since the other will fall in line quickly after.

Jan 4 2017, 6:40 PM · Design
chad added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

I think I can get by just tweaking the red/green current diff colors.

Jan 4 2017, 6:34 PM · Accessibility, Design, Feature Request, Restricted Project
epriestley added a comment to T5867: Move Quick Create to MenuItemEngine.

You were thinking about doing this one first, then Home later, right?

Jan 4 2017, 6:19 PM · Design
chad updated the task description for T12060: Colorblind accessibility for red/green highlighting in e-mails.
Jan 4 2017, 6:17 PM · Accessibility, Design, Feature Request, Restricted Project
epriestley added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

That's easy to add, but I'd worry it will result in much worse readability for all users for diffs with a lot of small corrections. If there are just 1-2 big edits the extra "+" and "-" probably aren't a big deal, but choppier edits will get a lot of extra annotation.

Jan 4 2017, 6:09 PM · Accessibility, Design, Feature Request, Restricted Project
yelirekim updated subscribers of T9515: Build a "quorum" mechanism and associated UI.
Jan 4 2017, 6:04 PM · Restricted Project, Notifications, Phacility, Auth
epriestley added a comment to T9515: Build a "quorum" mechanism and associated UI.

100% accurate mockup of this feature

Jan 4 2017, 6:04 PM · Restricted Project, Notifications, Phacility, Auth
yelirekim added a comment to T9515: Build a "quorum" mechanism and associated UI.

hqdefault.jpg (360×480 px, 16 KB)

Jan 4 2017, 6:04 PM · Restricted Project, Notifications, Phacility, Auth
chad added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

Yeah I'm wondering if a quick patch for this is just add + and - to the prose diffs.

Jan 4 2017, 6:02 PM · Accessibility, Design, Feature Request, Restricted Project
epriestley added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

I'm hesitant about using math to solve this because I think Blizzard did that in Overwatch (apparently? or something?) and ended up with modes that were worse for colorblind users than users with normal vision:

Jan 4 2017, 6:00 PM · Accessibility, Design, Feature Request, Restricted Project
chad added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

I wonder we could solve this with math since most colors are stored as hex (we'd have to move diff colors to hex, but that's not a huge deal).

Jan 4 2017, 5:33 PM · Accessibility, Design, Feature Request, Restricted Project
chad added a comment to T5867: Move Quick Create to MenuItemEngine.

@epriestley I feel like we had this conversation on how to implement this somewhere... (on a diff)? Not sure where these extend from, just move it into Personal/Global settings?

Jan 4 2017, 5:21 PM · Design
chad raised the priority of T5867: Move Quick Create to MenuItemEngine from Wishlist to High.
Jan 4 2017, 5:20 PM · Design
epriestley added a comment to T12061: When problems occur in phd inside sudo error messages are neither printed nor logged.

What version of Phabricator are you running? See Providing Version Information for help.

Jan 4 2017, 5:18 PM · Feature Request
chad renamed T5867: Move Quick Create to MenuItemEngine from Add Flags/Phurl dropdown to global header? to Move Quick Create to MenuItemEngine.
Jan 4 2017, 5:16 PM · Design
epriestley closed T12062: Survive import of artificially manufactured Git commits with no timestamps as Resolved by committing Restricted Diffusion Commit.
Jan 4 2017, 5:07 PM · Diffusion
chad changed the visibility for T3127: Sometimes color highlighting doesn't work on differential.
Jan 4 2017, 5:01 PM · Differential
epriestley added a revision to T12062: Survive import of artificially manufactured Git commits with no timestamps: Unknown Object (Differential Revision).
Jan 4 2017, 3:45 PM · Diffusion
epriestley closed T11978: Storage Tools Not Actually Upgrading Database as Resolved.

Cool, glad things are back in working order. Thanks for following up.

Jan 4 2017, 3:37 PM · Bug Report (Needs Information)
mbishopim3 added a comment to T11978: Storage Tools Not Actually Upgrading Database.

This can be closed as invalid (or resolved I guess). Looks like we performed an install and some upgrades at an awkward time when some storage upgrade changes were occurring. We've run several stable branch updates on the install since and it's been fine.

Jan 4 2017, 3:34 PM · Bug Report (Needs Information)
chad edited projects for T12060: Colorblind accessibility for red/green highlighting in e-mails, added: Feature Request, Design; removed Feature Request (Needs Information).
Jan 4 2017, 3:20 PM · Accessibility, Design, Feature Request, Restricted Project
chad added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

Slack has some nice color blind themes, which I use as my normal theme.

Jan 4 2017, 3:19 PM · Accessibility, Design, Feature Request, Restricted Project
epriestley added a comment to T12062: Survive import of artificially manufactured Git commits with no timestamps.

I believe this reproduces by following the steps in T11537#192019, but deleting all timestamp information completely.

Jan 4 2017, 3:15 PM · Diffusion
epriestley created T12062: Survive import of artificially manufactured Git commits with no timestamps.
Jan 4 2017, 3:00 PM · Diffusion
tolbrino updated the answer details for Q125: How to debug `sudo command failed. Starting daemon as current user.`? (Answer 211).
Jan 4 2017, 2:56 PM
epriestley closed T12058: url rewriting 302 redirects do not respect custom port as Resolved by committing Restricted Diffusion Commit.
Jan 4 2017, 2:55 PM · Bug Report
epriestley closed T12056: Searching for symbol / filename "PhabricatorProfilePanel" does not list commit when this symbol / file was removed as Wontfix.

This is working as intended.

Jan 4 2017, 2:54 PM · Bug Report
peerst created T12061: When problems occur in phd inside sudo error messages are neither printed nor logged.
Jan 4 2017, 2:01 PM · Feature Request
peerst added a comment to Q125: How to debug `sudo command failed. Starting daemon as current user.`? (Answer 211).

Thanks for the extended tip

Jan 4 2017, 12:58 PM
urzds added a comment to T12056: Searching for symbol / filename "PhabricatorProfilePanel" does not list commit when this symbol / file was removed.

I just tried it on GitHub an see that you're right. I guess this finally shifts this task into the feature request area, for which I would like to present the root cause: What I actually tried to achieve, when searching for for "PhabricatorProfilePanel", was to figure out in which commit this symbol got removed from Phabricator, so as to know how to change my extension's code (T10308#205605) to make it work with current Phabricator.

Jan 4 2017, 11:36 AM · Bug Report
epriestley added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

What color scheme would the user prefer?

Jan 4 2017, 8:38 AM · Accessibility, Design, Feature Request, Restricted Project
gregprice added a project to T12060: Colorblind accessibility for red/green highlighting in e-mails: Restricted Project.
Jan 4 2017, 5:14 AM · Accessibility, Design, Feature Request, Restricted Project
neilfitz updated the task description for T12060: Colorblind accessibility for red/green highlighting in e-mails.
Jan 4 2017, 2:32 AM · Accessibility, Design, Feature Request, Restricted Project
neilfitz added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

Okay, after some tests, looks like the user has deuteranopia. Consistent with what you have there.

Jan 4 2017, 2:32 AM · Accessibility, Design, Feature Request, Restricted Project
chad added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

http://www.color-blindness.com/deuteranopia-red-green-color-blindness/

Jan 4 2017, 2:18 AM · Accessibility, Design, Feature Request, Restricted Project
chad added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

Of the four, this is the only type that's difficult:

Jan 4 2017, 2:18 AM · Accessibility, Design, Feature Request, Restricted Project
neilfitz added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

Uh, I'll see if they can take an online test to narrow it down further.

Jan 4 2017, 2:17 AM · Accessibility, Design, Feature Request, Restricted Project
neilfitz added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

They don't know what type they have more specifically than red-green, unfortunately.

Jan 4 2017, 2:15 AM · Accessibility, Design, Feature Request, Restricted Project
chad added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

There are 4 types of red-green color blindness, and they all work differently.

Jan 4 2017, 2:09 AM · Accessibility, Design, Feature Request, Restricted Project