Page MenuHomePhabricator
Feed Advanced Search

Sep 24 2019

epriestley added a revision to T13420: Update "Change Username" to make it more friendly for non-administrators: Unknown Object (Differential Revision).
Sep 24 2019, 5:41 PM · People, Auth
epriestley added a revision to T13420: Update "Change Username" to make it more friendly for non-administrators: Unknown Object (Differential Revision).
Sep 24 2019, 5:36 PM · People, Auth
epriestley added a revision to T4280: Embed anchor in remark up text and later link to it. : Unknown Object (Differential Revision).
Sep 24 2019, 5:26 PM · Remarkup
epriestley added a revision to T13410: Update Phriction UI structural behaviors: Unknown Object (Differential Revision).
Sep 24 2019, 5:26 PM · Phriction
epriestley closed T13418: "arc liberate" incorrectly includes subdirectories of "src/extensions/" in library map as Resolved by committing Restricted Diffusion Commit.
Sep 24 2019, 5:02 PM · libphutil
epriestley added a revision to T13418: "arc liberate" incorrectly includes subdirectories of "src/extensions/" in library map: Unknown Object (Differential Revision).
Sep 24 2019, 4:40 PM · libphutil
epriestley added a comment to T13418: "arc liberate" incorrectly includes subdirectories of "src/extensions/" in library map.

Oh, no, that's unrelated:

Sep 24 2019, 4:37 PM · libphutil
epriestley added a comment to T13418: "arc liberate" incorrectly includes subdirectories of "src/extensions/" in library map.

Looking at this in slightly more detail, I think the immediate issue is just that .gitignore specifies /src/extensions/*, not /src/extensions/**.

Sep 24 2019, 4:36 PM · libphutil
jmeador added a comment to T13418: "arc liberate" incorrectly includes subdirectories of "src/extensions/" in library map.

I actually tried to use the extensions directory to hide Composer's vendored files and ran into this same issue.

Sep 24 2019, 4:33 PM · libphutil
epriestley added a project to T13423: Conduit log paging is broken, fails with `Call to undefined method PhabricatorConduitLogQuery::withIDs` error: Conduit.
Sep 24 2019, 3:37 PM · Conduit
epriestley closed T13423: Conduit log paging is broken, fails with `Call to undefined method PhabricatorConduitLogQuery::withIDs` error as Resolved by committing Restricted Diffusion Commit.
Sep 24 2019, 3:36 PM · Conduit
epriestley triaged T13423: Conduit log paging is broken, fails with `Call to undefined method PhabricatorConduitLogQuery::withIDs` error as Normal priority.
Sep 24 2019, 3:36 PM · Conduit
epriestley added a revision to T13423: Conduit log paging is broken, fails with `Call to undefined method PhabricatorConduitLogQuery::withIDs` error: Unknown Object (Differential Revision).
Sep 24 2019, 3:34 PM · Conduit

Sep 23 2019

epriestley edited the content of Changelog.
Sep 23 2019, 9:09 PM
epriestley created an object: 2019 Week 38 (Late September).
Sep 23 2019, 9:08 PM
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
Sep 23 2019, 7:43 PM · Plans, Facts
epriestley added a comment to T13424: Support builds with TeamCity in Harbormaster.

(This has been made to exist, at least roughly; see PHI1448.)

Sep 23 2019, 4:34 PM · Harbormaster
epriestley closed T12011: Support builds with Travis CI, a subtask of T9456: Evaluate upstream support for third-party build systems, as Wontfix.
Sep 23 2019, 4:33 PM · Restricted Project, Harbormaster
epriestley closed T12011: Support builds with Travis CI as Wontfix.

TravisCI sold to Idera and is no longer "cool".

Sep 23 2019, 4:33 PM · Harbormaster, Feature Request
epriestley closed T9456: Evaluate upstream support for third-party build systems as Resolved.

I generally don't plan to upstream any more support for third-party build tools, since I don't think a future where Phabricator is free glue for a bunch of paid systems is desirable. The pathways forward here are either:

Sep 23 2019, 4:29 PM · Restricted Project, Harbormaster
epriestley closed T9456: Evaluate upstream support for third-party build systems, a subtask of T7869: Support CircleCI webhooks for Test results (so that one can run unit tests asynchronously), as Resolved.
Sep 23 2019, 4:28 PM · Phacility
epriestley added a subtask for T9456: Evaluate upstream support for third-party build systems: T13424: Support builds with TeamCity in Harbormaster.
Sep 23 2019, 3:42 PM · Restricted Project, Harbormaster
epriestley added a parent task for T13424: Support builds with TeamCity in Harbormaster: T9456: Evaluate upstream support for third-party build systems.
Sep 23 2019, 3:41 PM · Harbormaster
epriestley triaged T13424: Support builds with TeamCity in Harbormaster as Low priority.
Sep 23 2019, 3:41 PM · Harbormaster
artms renamed T13423: Conduit log paging is broken, fails with `Call to undefined method PhabricatorConduitLogQuery::withIDs` error from Conduit log paging is broken to Conduit log paging is broken, fails with `Call to undefined method PhabricatorConduitLogQuery::withIDs` error.
Sep 23 2019, 12:26 PM · Conduit
artms created T13423: Conduit log paging is broken, fails with `Call to undefined method PhabricatorConduitLogQuery::withIDs` error.
Sep 23 2019, 12:26 PM · Conduit

Sep 20 2019

epriestley added a comment to T13279: Build Charting for Facts.

get rid of all obsolete / policy-violating stuff so no part of the Facts application is broken;

Sep 20 2019, 7:07 PM · Plans, Facts
epriestley triaged T13422: Remarkup previews with embedded video have flickery behavior as Wishlist priority.
Sep 20 2019, 3:46 PM · Remarkup

Sep 19 2019

epriestley added a comment to T13421: Implement OpenGraph metadata in Phame for Twitter cards.

og:title should probably be the post title.

Sep 19 2019, 9:28 PM · Phame
epriestley triaged T13421: Implement OpenGraph metadata in Phame for Twitter cards as Normal priority.
Sep 19 2019, 9:27 PM · Phame
epriestley updated the task description for T9515: Build a "quorum" mechanism and associated UI.
Sep 19 2019, 8:02 PM · Restricted Project, Notifications, Phacility, Auth
epriestley triaged T13420: Update "Change Username" to make it more friendly for non-administrators as Normal priority.
Sep 19 2019, 7:59 PM · People, Auth
epriestley added a comment to T13018: Support Discourse's specific dialect of OpenGraph metadata tags to enrich Discourse "OneBox" previews.

Looks like Twitter's dialect of og tags is slightly special, but nothing too crazy:

Sep 19 2019, 7:50 PM

Sep 18 2019

Krinkle added a comment to T13018: Support Discourse's specific dialect of OpenGraph metadata tags to enrich Discourse "OneBox" previews.

This would also be great for Phame, so that sharing a link to a Phame post results in a title card when shared on Twitter.

Sep 18 2019, 11:20 PM
Krinkle awarded T13018: Support Discourse's specific dialect of OpenGraph metadata tags to enrich Discourse "OneBox" previews a Orange Medal token.
Sep 18 2019, 11:20 PM
epriestley added a revision to T13410: Update Phriction UI structural behaviors: Unknown Object (Differential Revision).
Sep 18 2019, 10:23 PM · Phriction
epriestley added a revision to T13410: Update Phriction UI structural behaviors: Unknown Object (Differential Revision).
Sep 18 2019, 10:02 PM · Phriction
epriestley added a comment to T13279: Build Charting for Facts.

I believe charts in the UI now make physical sense. They aren't very fancy/polished yet, but everything I see on this install looks cohesive (no more overlapping negative areas, weird gaps, general nonsense, etc):

Sep 18 2019, 5:55 PM · Plans, Facts
epriestley updated the task description for T9515: Build a "quorum" mechanism and associated UI.
Sep 18 2019, 5:18 PM · Restricted Project, Notifications, Phacility, Auth
epriestley triaged T13419: Fully modularize object relationships, to support custom relationships like "Subtask/Parent Task" as Low priority.
Sep 18 2019, 5:12 PM · Infrastructure

Sep 17 2019

epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
Sep 17 2019, 8:25 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
Sep 17 2019, 7:30 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
Sep 17 2019, 4:26 PM · Plans, Facts

Sep 16 2019

epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
Sep 16 2019, 10:34 PM · Plans, Facts
epriestley added a comment to T13279: Build Charting for Facts.

The "compose(...)" function won't select input values correctly if the first function in the chain isn't a data function. For example, if we compose:

Sep 16 2019, 9:32 PM · Plans, Facts
epriestley triaged T13418: "arc liberate" incorrectly includes subdirectories of "src/extensions/" in library map as Wishlist priority.
Sep 16 2019, 6:44 PM · libphutil
epriestley added a comment to T13279: Build Charting for Facts.

D20814 combines nearby points so we don't have tons of overlapping tiny circles. For now, the grouping is just based on X-axis distance:

Sep 16 2019, 5:44 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
Sep 16 2019, 5:41 PM · Plans, Facts

Sep 15 2019

reed edited the content of 2019 Week 36 (Early September).
Sep 15 2019, 11:49 AM

Sep 13 2019

epriestley edited the content of Changelog.
Sep 13 2019, 7:37 PM
epriestley created an object: 2019 Week 37 (Mid September).
Sep 13 2019, 7:36 PM
epriestley triaged T13417: "bin/storage upgrade" should test for replication problems before applying migrations as Low priority.
Sep 13 2019, 7:31 PM · Database
epriestley added a comment to T13279: Build Charting for Facts.

In stacked area charts, when we stack areas, we accumulate some error by stacking integer points on top of interpolated points.

Sep 13 2019, 5:12 PM · Plans, Facts
epriestley added a comment to T13279: Build Charting for Facts.

if prototypes are disabled, some stuff is broken, particularly "View Chart".

Sep 13 2019, 4:45 PM · Plans, Facts
epriestley added a comment to T13410: Update Phriction UI structural behaviors.

At the lowest levels:

Sep 13 2019, 3:24 AM · Phriction
epriestley added a comment to T13410: Update Phriction UI structural behaviors.

This needs a lot more work, but here's very roughly where I'm trying to go with this:

Sep 13 2019, 2:57 AM · Phriction
epriestley added a revision to T13413: Chrome 77 rendering engine freezes when elements are nested with particular word-wrap / white-space CSS behavior: Restricted Differential Revision.
Sep 13 2019, 1:59 AM · Google Chrome

Sep 12 2019

epriestley triaged T13416: Transaction logs may overheat explosively as Low priority.
Sep 12 2019, 11:22 PM · Feed
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: Unknown Object (Differential Revision).
Sep 12 2019, 11:21 PM · Policy
epriestley closed T13415: Allow the "Change Subtype" comment action to be disabled on a per-subtype basis as Resolved by committing Restricted Diffusion Commit.
Sep 12 2019, 11:17 PM · EditEngine
epriestley added a revision to T13415: Allow the "Change Subtype" comment action to be disabled on a per-subtype basis: Unknown Object (Differential Revision).
Sep 12 2019, 11:12 PM · EditEngine
epriestley triaged T13415: Allow the "Change Subtype" comment action to be disabled on a per-subtype basis as Low priority.
Sep 12 2019, 10:39 PM · EditEngine
epriestley closed T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules as Resolved.

D20808 fixes the two original cases (Harbormaster and Legalpad). There are probably more fields or actions which could be configured to be sometimes-unavailable, but these are probably the major ones.

Sep 12 2019, 7:59 PM · Applications, Herald
epriestley added a revision to T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules: Unknown Object (Differential Revision).
Sep 12 2019, 7:57 PM · Applications, Herald
epriestley triaged T13414: Raise the effective corpus size limit in "PhutilProseDifferenceEngine" by using "diff" for coarse passes as Low priority.
Sep 12 2019, 7:30 PM · Infrastructure
epriestley added a comment to T13232: Mac OS X Mojave, SIP, Code Signing, and Apache.

For LDAP, brew install openldap + --with-ldap=/usr/local/opt/openldap/.

Sep 12 2019, 5:25 PM · Infrastructure
epriestley closed T13411: Improve "Custom Policy" behavior in policy dialogs as Resolved by committing Restricted Diffusion Commit.
Sep 12 2019, 4:49 PM · Policy
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: Unknown Object (Differential Revision).
Sep 12 2019, 4:30 PM · Policy
epriestley closed T6802: "Custom policy" for editing/viewing does not link to details as Resolved.

Here's the fate of the various issues discussed here:

Sep 12 2019, 4:04 PM · Design, Policy
epriestley closed T6802: "Custom policy" for editing/viewing does not link to details, a subtask of T13411: Improve "Custom Policy" behavior in policy dialogs, as Resolved.
Sep 12 2019, 4:03 PM · Policy
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: Unknown Object (Differential Revision).
Sep 12 2019, 3:57 PM · Policy
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: Unknown Object (Differential Revision).
Sep 12 2019, 3:39 PM · Policy
epriestley added a parent task for T6802: "Custom policy" for editing/viewing does not link to details: T13411: Improve "Custom Policy" behavior in policy dialogs.
Sep 12 2019, 3:13 PM · Design, Policy
epriestley added a subtask for T13411: Improve "Custom Policy" behavior in policy dialogs: T6802: "Custom policy" for editing/viewing does not link to details.
Sep 12 2019, 3:13 PM · Policy
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: Unknown Object (Differential Revision).
Sep 12 2019, 2:46 PM · Policy
epriestley added a comment to T13411: Improve "Custom Policy" behavior in policy dialogs.

This should be reworked some day (perhaps partly here) into some more cohesive API, perhaps newLink().

Sep 12 2019, 2:15 PM · Policy
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: Unknown Object (Differential Revision).
Sep 12 2019, 2:08 PM · Policy
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: Unknown Object (Differential Revision).
Sep 12 2019, 2:06 PM · Policy
epriestley added a revision to T13411: Improve "Custom Policy" behavior in policy dialogs: Unknown Object (Differential Revision).
Sep 12 2019, 2:03 PM · Policy
epriestley added a comment to T13411: Improve "Custom Policy" behavior in policy dialogs.

One other thing is that PhabricatorApplicationPolicyChangeTransaction->renderApplicationPolicy() has unconventional behaviors which are not very helpful and not consistent with normal CAN_EDIT / CAN_VIEW transactions. This is somewhat perplexing because ModularTransactions has renderPolicy() already, which has better behavior. I think it didn't exist yet when Applications modularized in D17757, and when it was introduced in D19829 I just overlooked the opportunity to update it.

Sep 12 2019, 4:47 AM · Policy
epriestley added a comment to T13411: Improve "Custom Policy" behavior in policy dialogs.

In Applications → (Pick Something), if an application policy is set to "Custom Policy", the policy is not linked.

Sep 12 2019, 4:39 AM · Policy
epriestley added a revision to T13410: Update Phriction UI structural behaviors: Unknown Object (Differential Revision).
Sep 12 2019, 4:04 AM · Phriction

Sep 11 2019

epriestley added a comment to T13413: Chrome 77 rendering engine freezes when elements are nested with particular word-wrap / white-space CSS behavior.

I upstreamed this to Chrome here: https://bugs.chromium.org/p/chromium/issues/detail?id=1003002

Sep 11 2019, 6:00 PM · Google Chrome
epriestley triaged T13413: Chrome 77 rendering engine freezes when elements are nested with particular word-wrap / white-space CSS behavior as Normal priority.
Sep 11 2019, 5:53 PM · Google Chrome
mormegil added a comment to T13299: Herald only triggers for commits once, during the initial publish phase.

I understand this was supposed to be mentioned here: Herald ignores commits that are ancestors of permanent refs if they were previously pushed to some other non-permanent ref.

Sep 11 2019, 9:10 AM · Diffusion, Herald

Sep 10 2019

epriestley updated the task description for T13410: Update Phriction UI structural behaviors.
Sep 10 2019, 10:05 PM · Phriction
20after4 awarded T13377: Write about "how to solve problems with program behavior" a Mountain of Wealth token.
Sep 10 2019, 1:46 PM · Guides

Sep 9 2019

epriestley closed T8808: Policy menu should show actual project icon next to project as Resolved by committing Restricted Diffusion Commit.
Sep 9 2019, 8:38 PM · Policy
epriestley added a revision to T8808: Policy menu should show actual project icon next to project: Unknown Object (Differential Revision).
Sep 9 2019, 8:35 PM · Policy
epriestley closed T9136: '(Disabled)' rules show up multi times under 'Another Herald Rule' as Resolved by committing Restricted Diffusion Commit.
Sep 9 2019, 8:29 PM · Restricted Project, Herald
epriestley added a revision to T9136: '(Disabled)' rules show up multi times under 'Another Herald Rule': Unknown Object (Differential Revision).
Sep 9 2019, 8:25 PM · Restricted Project, Herald
epriestley closed T8952: Hide "Herald added subscribers..." stories from feed completely as Resolved by committing Restricted Diffusion Commit.
Sep 9 2019, 8:17 PM · Feed, Herald
epriestley closed T13409: Support a "Remove Flag" action in Herald as Resolved by committing Restricted Diffusion Commit.
Sep 9 2019, 8:16 PM · Herald
epriestley added a comment to T8952: Hide "Herald added subscribers..." stories from feed completely.

0.00000000001 is very funny and we would be losing a truly great joke at such a young age

Sep 9 2019, 8:15 PM · Feed, Herald
epriestley added a revision to T8952: Hide "Herald added subscribers..." stories from feed completely: Restricted Differential Revision.
Sep 9 2019, 8:14 PM · Feed, Herald
epriestley added a revision to T13409: Support a "Remove Flag" action in Herald: Unknown Object (Differential Revision).
Sep 9 2019, 8:02 PM · Herald
epriestley closed T13408: Examine conditions, not just actions, when indexing Herald rules for links to other objects as Resolved by committing Restricted Diffusion Commit.
Sep 9 2019, 7:50 PM · Herald
epriestley closed T13412: Searching for the install URI with no trailing slash fatals as Resolved by committing Restricted Diffusion Commit.
Sep 9 2019, 7:45 PM · Search
epriestley added a revision to T13408: Examine conditions, not just actions, when indexing Herald rules for links to other objects: Restricted Differential Revision.
Sep 9 2019, 7:44 PM · Herald
epriestley added a revision to T13412: Searching for the install URI with no trailing slash fatals: Unknown Object (Differential Revision).
Sep 9 2019, 7:30 PM · Search