Page MenuHomePhabricator
Feed Advanced Search

Sep 9 2019

epriestley closed T13405: Support customization of the default global search scope as Resolved by committing Restricted Diffusion Commit.
Sep 9 2019, 7:21 PM · User Preferences
epriestley added a revision to T13405: Support customization of the default global search scope: Unknown Object (Differential Revision).
Sep 9 2019, 7:16 PM · User Preferences
epriestley added a revision to T13405: Support customization of the default global search scope: Unknown Object (Differential Revision).
Sep 9 2019, 7:11 PM · User Preferences
epriestley triaged T13412: Searching for the install URI with no trailing slash fatals as Low priority.
Sep 9 2019, 5:10 PM · Search
epriestley moved T6802: "Custom policy" for editing/viewing does not link to details from Backlog to Next on the Policy board.
Sep 9 2019, 5:07 PM · Design, Policy
epriestley moved T8808: Policy menu should show actual project icon next to project from Backlog to Next on the Policy board.
Sep 9 2019, 5:07 PM · Policy
epriestley moved T13411: Improve "Custom Policy" behavior in policy dialogs from Backlog to Next on the Policy board.
Sep 9 2019, 5:06 PM · Policy
epriestley triaged T13411: Improve "Custom Policy" behavior in policy dialogs as Low priority.
Sep 9 2019, 5:06 PM · Policy
epriestley added a comment to T13410: Update Phriction UI structural behaviors.

Left Nav

Sep 9 2019, 4:56 PM · Phriction
epriestley updated the task description for T13410: Update Phriction UI structural behaviors.
Sep 9 2019, 4:07 PM · Phriction
epriestley updated the task description for T13410: Update Phriction UI structural behaviors.
Sep 9 2019, 4:02 PM · Phriction
epriestley updated the task description for T13410: Update Phriction UI structural behaviors.
Sep 9 2019, 4:01 PM · Phriction
epriestley removed a subtask for T8552: Increase user control over document hierarchy in Phriction: T13011: Let community to fund features and bug fixes for increased priority and earlier delivery.
Sep 9 2019, 3:58 PM · Phriction, Restricted Project
epriestley removed a parent task for T13011: Let community to fund features and bug fixes for increased priority and earlier delivery: T8552: Increase user control over document hierarchy in Phriction.
Sep 9 2019, 3:58 PM · Feature Request, Fund
epriestley added a parent task for T8552: Increase user control over document hierarchy in Phriction: T13410: Update Phriction UI structural behaviors.
Sep 9 2019, 3:58 PM · Phriction, Restricted Project
epriestley added a parent task for T4280: Embed anchor in remark up text and later link to it. : T13410: Update Phriction UI structural behaviors.
Sep 9 2019, 3:58 PM · Remarkup
epriestley added subtasks for T13410: Update Phriction UI structural behaviors: T4280: Embed anchor in remark up text and later link to it. , T8552: Increase user control over document hierarchy in Phriction.
Sep 9 2019, 3:58 PM · Phriction
epriestley triaged T13410: Update Phriction UI structural behaviors as Normal priority.
Sep 9 2019, 3:57 PM · Phriction
epriestley added a comment to T13405: Support customization of the default global search scope.

There may also be no Application in contexts where we want to render a global search menu, notably the 404 page:

Sep 9 2019, 3:37 PM · User Preferences
epriestley triaged T13409: Support a "Remove Flag" action in Herald as Low priority.
Sep 9 2019, 2:35 PM · Herald
epriestley triaged T13408: Examine conditions, not just actions, when indexing Herald rules for links to other objects as Low priority.
Sep 9 2019, 2:33 PM · Herald
epriestley edited the content of Changelog.
Sep 9 2019, 12:04 AM
epriestley created an object: 2019 Week 36 (Early September).
Sep 9 2019, 12:02 AM

Sep 8 2019

epriestley triaged T13407: If an S3 request returns with HTTP 404, error handling behavior is poor as Wishlist priority.
Sep 8 2019, 8:22 PM · Files
epriestley added a revision to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY: Unknown Object (Differential Revision).
Sep 8 2019, 8:02 PM · Database, Infrastructure
epriestley added a revision to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY: Unknown Object (Differential Revision).
Sep 8 2019, 7:59 PM · Database, Infrastructure
epriestley closed T13406: When a user with no authentication providers configured tries to log out, warn them as Resolved by committing Restricted Diffusion Commit.
Sep 8 2019, 7:27 PM · Setup
epriestley added a comment to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY.

Vaguely adjacent:

Sep 8 2019, 7:27 PM · Database, Infrastructure
leoluk awarded T3967: Build a 2-up preview mode into the fullscreen Remarkup editor a Like token.
Sep 8 2019, 5:22 PM · Remarkup
epriestley added a revision to T13406: When a user with no authentication providers configured tries to log out, warn them: Unknown Object (Differential Revision).
Sep 8 2019, 4:48 PM · Setup
epriestley triaged T13406: When a user with no authentication providers configured tries to log out, warn them as Wishlist priority.
Sep 8 2019, 4:27 PM · Setup
epriestley updated the task description for T12910: Allow SES to be used for inbound mail.
Sep 8 2019, 2:58 PM · Mail

Sep 7 2019

swisspol added a comment to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY.

Now that we are on RDS I can confirm that MySQL also has ONLY_FULL_GROUP_BY enabled by default.

Sep 7 2019, 1:55 AM · Database, Infrastructure

Sep 6 2019

epriestley reopened T13405: Support customization of the default global search scope as "Open".

I think I missed one case here: the global preference will currently show custom personal queries for the viewing user, but selecting these queries won't work (at least, not completely) for other users. Instead, the control should offer only hard-coded options and global queries.

Sep 6 2019, 5:54 PM · User Preferences
epriestley closed T13405: Support customization of the default global search scope as Resolved by committing Restricted Diffusion Commit.
Sep 6 2019, 3:39 PM · User Preferences
epriestley added a revision to T13405: Support customization of the default global search scope: Unknown Object (Differential Revision).
Sep 6 2019, 3:25 PM · User Preferences
epriestley triaged T13405: Support customization of the default global search scope as Low priority.
Sep 6 2019, 3:21 PM · User Preferences

Sep 5 2019

epriestley added a comment to T13394: Evaluate Okta OAuth.

But did you check your spam folder? 😄

Sep 5 2019, 11:10 PM · Auth
swisspol added a comment to T13394: Evaluate Okta OAuth.

But did you check your spam folder? 😄

Sep 5 2019, 10:54 PM · Auth
epriestley added a comment to T13394: Evaluate Okta OAuth.

I attempted to register for a developer account and am receiving neither an email verification email nor a password reset email. 🤷

Sep 5 2019, 9:44 PM · Auth
epriestley closed T10321: Running "arc land" without a branch checked out sort of works but fails when trying to delete the branch as Resolved by committing Restricted Diffusion Commit.
Sep 5 2019, 12:31 PM · Bug Report
epriestley added a revision to T10321: Running "arc land" without a branch checked out sort of works but fails when trying to delete the branch: Unknown Object (Differential Revision).
Sep 5 2019, 12:25 PM · Bug Report
epriestley added a comment to T10321: Running "arc land" without a branch checked out sort of works but fails when trying to delete the branch.

See also https://discourse.phabricator-community.org/t/arc-land-fails-with-detached-head/3078/.

Sep 5 2019, 12:19 PM · Bug Report
epriestley closed T13392: Current implementations of "X-Forwarded-For" may take the wrong element as Resolved by committing Restricted Diffusion Commit.
Sep 5 2019, 11:30 AM · Infrastructure
epriestley added a revision to T13392: Current implementations of "X-Forwarded-For" may take the wrong element: Unknown Object (Differential Revision).
Sep 5 2019, 11:26 AM · Infrastructure
epriestley added a comment to T13392: Current implementations of "X-Forwarded-For" may take the wrong element.

Our behavior appears to be correct when the load balancer is an AWS ELB.

Sep 5 2019, 9:57 AM · Infrastructure

Sep 4 2019

epriestley added a revision to T13336: "bin/storage dump" option "--for-replica" might not interact properly with "--no-indexes" and PERSISTENCE_CACHE: Unknown Object (Differential Revision).
Sep 4 2019, 5:08 PM · Infrastructure
Krinkle awarded T13279: Build Charting for Facts a Orange Medal token.
Sep 4 2019, 4:04 PM · Plans, Facts
epriestley added a revision to T13366: Update Phortune to work better with "enterprise" billing/accounts departments: Unknown Object (Differential Revision).
Sep 4 2019, 2:11 PM · Phortune, Phacility
swisspol added a comment to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY.

That actually using MySQL official Docker image.

Sep 4 2019, 3:12 AM · Database, Infrastructure

Sep 3 2019

epriestley added a comment to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY.

There are only 23 occurrences of the string "GROUP BY" in the codebase, and, from inspection, many obviously do not conflict with ONLY_FULL_GROUP_BY.

Sep 3 2019, 11:54 PM · Database, Infrastructure
epriestley added a revision to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY: Unknown Object (Differential Revision).
Sep 3 2019, 11:43 PM · Database, Infrastructure
epriestley triaged T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY as Wishlist priority.
Sep 3 2019, 11:23 PM · Database, Infrastructure
epriestley closed T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues as Resolved.
Sep 3 2019, 7:54 PM · Database, Config
epriestley added a comment to T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover.

Also remaining is to extend this behavior to the HTTP pathway (and to Mercurial/SVN, eventually).

Sep 3 2019, 7:35 PM · Clusters, Diffusion
epriestley added a revision to T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues: Unknown Object (Differential Revision).
Sep 3 2019, 7:26 PM · Database, Config
epriestley added a revision to T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues: Unknown Object (Differential Revision).
Sep 3 2019, 7:23 PM · Database, Config
epriestley added a revision to T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues: Unknown Object (Differential Revision).
Sep 3 2019, 7:19 PM · Database, Config
epriestley triaged T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues as Low priority.
Sep 3 2019, 7:05 PM · Database, Config
epriestley added a revision to T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover: Unknown Object (Differential Revision).
Sep 3 2019, 6:37 PM · Clusters, Diffusion
epriestley added a comment to T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover.
  • if we have already retried 3 times, do not retry;
Sep 3 2019, 6:07 PM · Clusters, Diffusion
epriestley added a revision to T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover: Unknown Object (Differential Revision).
Sep 3 2019, 5:41 PM · Clusters, Diffusion
epriestley added a revision to T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover: Unknown Object (Differential Revision).
Sep 3 2019, 4:50 PM · Clusters, Diffusion
epriestley added a comment to T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover.

we'll reduce silly client-visible behavior where you request /tourtle.git instead of /turtle.git and the server seems confused...

Sep 3 2019, 4:32 PM · Clusters, Diffusion
epriestley added a revision to T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover: Unknown Object (Differential Revision).
Sep 3 2019, 3:58 PM · Clusters, Diffusion

Sep 2 2019

epriestley created T13402: Owner audit flag got flipped in update?.
Sep 2 2019, 3:06 PM · Audit
epriestley added a comment to T13339: Update "diffusion.searchquery" to handle multiple path arguments and various weird cases.

See also https://discourse.phabricator-community.org/t/diffusion-search-how-to-do-case-insensitive-search/2854/.

Sep 2 2019, 3:04 PM · Diffusion, Conduit
epriestley closed T13393: Improve repository shard migration pathway in the shared cluster as Resolved.

The migration in PHI1403 seems to have gone through cleanly. This workflow can continue to improve, but it's in relatively good shape now.

Sep 2 2019, 3:02 PM · Phacility, Infrastructure
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Sep 2 2019, 2:20 PM · libphutil
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Sep 2 2019, 1:43 PM · libphutil
epriestley lowered the priority of T13396: Support downloads of 2GB+ files with HTTPSFuture from Normal to Wishlist.
Sep 2 2019, 1:11 PM · Infrastructure, libphutil
epriestley added a comment to T13397: "bin/host upload" and the Uploader wrapper should retry chunks on HTTP/504, and perhaps other status codes.

A generally cleaner version of this would also fix the parallelization TODO (just above the patch in the previous comment). This probably needs FutureIterator to be better at managing in-flight changes to the working set.

Sep 2 2019, 1:11 PM · Infrastructure, Arcanist
epriestley closed T13401: Phacility 2019 Week 35 Deployment Log as Resolved.

Everything here appears to have made it to production cleanly.

Sep 2 2019, 1:07 PM · Phacility
epriestley updated the task description for T13401: Phacility 2019 Week 35 Deployment Log.
Sep 2 2019, 1:05 PM · Phacility
epriestley updated the task description for T13367: Phortune "enterprise" update errata.
Sep 2 2019, 1:04 PM · Phortune, Phacility
epriestley added a revision to T13401: Phacility 2019 Week 35 Deployment Log: Unknown Object (Differential Revision).
Sep 2 2019, 1:04 PM · Phacility
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
Sep 2 2019, 12:57 PM · Phacility, Infrastructure

Sep 1 2019

epriestley added a comment to T13400: Evaluate performance impact of performing MySQL dump/restore in parallel.

Anecdata: locally, using 2 subprocesses went twice as fast (~85s -> ~42s). 4 subprocesses chopped another ~20% of the time off (~42s > ~35s). It stopped getting faster at 4. However, the largest table took 24s, so even if this was completely parallelizable we wouldn't expect it to drop lower than that.

Sep 1 2019, 11:19 PM · Infrastructure, Database
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
Sep 1 2019, 8:12 PM · Phacility, Infrastructure
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
Sep 1 2019, 8:08 PM · Phacility, Infrastructure
epriestley added a comment to T13393: Improve repository shard migration pathway in the shared cluster.

Anecdotally from the last time around, gzipping the tarball didn't really do much. Possibly, this might more broadly imply that we'd be better off not compressing repository backups.

Sep 1 2019, 7:26 PM · Phacility, Infrastructure
epriestley added a comment to T13393: Improve repository shard migration pathway in the shared cluster.

I believe I've moved "core/" from "instances.queryinstances" and sequenced all the followup changes properly, now, and that the only remaining piece is glue.

Sep 1 2019, 5:48 PM · Phacility, Infrastructure
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
Sep 1 2019, 5:31 PM · Phacility, Infrastructure
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
Sep 1 2019, 5:29 PM · Phacility, Infrastructure
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
Sep 1 2019, 5:19 PM · Phacility, Infrastructure
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
Sep 1 2019, 5:12 PM · Phacility, Infrastructure
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
Sep 1 2019, 5:09 PM · Phacility, Infrastructure
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
Sep 1 2019, 4:51 PM · Phacility, Infrastructure
epriestley added a comment to T13399: Remove "instances.queryinstances" Conduit API method.

SyncWorkflow also depends on creatorPHID to synchronize the initial administrator account.

Sep 1 2019, 4:48 PM · Phacility
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Restricted Differential Revision.
Sep 1 2019, 4:44 PM · Phacility, Infrastructure
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
Sep 1 2019, 4:41 PM · Phacility, Infrastructure
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
Sep 1 2019, 12:35 AM · Phacility, Infrastructure
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
Sep 1 2019, 12:20 AM · Phacility, Infrastructure
epriestley added a revision to T13393: Improve repository shard migration pathway in the shared cluster: Unknown Object (Differential Revision).
Sep 1 2019, 12:19 AM · Phacility, Infrastructure

Aug 31 2019

epriestley added a comment to T13401: Phacility 2019 Week 35 Deployment Log.

The primary Week 34 / Week 35 deployment has completed without apparent issues. I'm going to deploy some followup changes for T13393 later, but it looks like we're out of the woods on the bulk of outbound changes.

Aug 31 2019, 5:15 PM · Phacility
epriestley updated the task description for T13401: Phacility 2019 Week 35 Deployment Log.
Aug 31 2019, 4:42 PM · Phacility
epriestley added a comment to T13401: Phacility 2019 Week 35 Deployment Log.

Clicking "Pay Now" from landing page fatals in "PhortuneCartCheckoutController.php:104"; "Call to undefined method PhortuneCartCheckoutController::buildCartContentTable()"
Pacts have a bad URI for billing accounts on the "Billing" tab.
Instances also have a bad URI for billing accounts on the "Billing " tab. Maybe the handle is using the wrong URI?
The sync worker is failing on new instance launch for lack of credentials.

Aug 31 2019, 4:38 PM · Phacility
epriestley added a comment to T13401: Phacility 2019 Week 35 Deployment Log.

The sync worker is failing on new instance launch for lack of credentials.

Aug 31 2019, 4:30 PM · Phacility
epriestley updated the task description for T13401: Phacility 2019 Week 35 Deployment Log.
Aug 31 2019, 4:26 PM · Phacility
epriestley triaged T13401: Phacility 2019 Week 35 Deployment Log as Normal priority.
Aug 31 2019, 4:10 PM · Phacility