Page MenuHomePhabricator
Feed Advanced Search

Dec 28 2018

epriestley created 2018 Week 51 (End of Year).
Dec 28 2018, 8:44 PM
quark.zju added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

I'm not an Windows expert. But to my knowledge there are a couple of things missing here:

Dec 28 2018, 8:14 PM · Arcanist, Windows
adamchainz added a comment to T13227: Figure out if Google Auth needs to be updated before Google+ shutdown on March 7, 2019.

Yes the exact text from the announcement about the intermittent failures states:

Dec 28 2018, 6:42 PM · Auth
kristo.mario added a comment to T13227: Figure out if Google Auth needs to be updated before Google+ shutdown on March 7, 2019.

I received email from google announcing the deprecation few days ago. In the announcement they stated that they'll introduce intermittent failures on responses from the G+ API as soon as 01/2019.

Dec 28 2018, 5:55 PM · Auth

Dec 24 2018

renatomassaro awarded T13115: Handle mail bounces inside Phabricator a Like token.
Dec 24 2018, 8:07 AM · Mail

Dec 23 2018

epriestley added a comment to T8787: Add support for U2F MFA once browser implementations improve and compatible hardware is more widely available.

The original request focused on OTP, not U2F, but I think the amount of configuration required by OTP and the lack (?) of a pathway on mobile make it a better candidate for third-party integration than first-party integration. If we were supporting OTP in the upstream I'd want to run a first-party verification service so we aren't dependent on Yubikey's service, but the whole thing seems very messy and very bound to the Yubikey stack. It also looks (?) like Yubikey OTP and Yubikey U2F aren't linked to the same key (I think?) so you can't use U2F on one device and then fall back to OTP on mobile, even if you want to type in 44 characters? You have to enroll OTP and U2F separately.

Dec 23 2018, 1:06 AM · Haskell.org, Auth
epriestley added a comment to T8787: Add support for U2F MFA once browser implementations improve and compatible hardware is more widely available.

This browser doesn’t support the FIDO U2F standard yet.

Dec 23 2018, 12:00 AM · Haskell.org, Auth

Dec 22 2018

epriestley added a comment to T13222: 2018 Week 48-51 Bonus Content.

The bit-strength change above should still happen.

Dec 22 2018, 10:41 PM · Plans
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: Unknown Object (Differential Revision).
Dec 22 2018, 10:17 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a comment to T13215: Secure/Admin have many accounts with commercial links in profile blurbs.

$table = new PhabricatorUser();
$cache_path = 'progress.json';

Dec 22 2018, 10:15 PM · People, Phacility, Abuse
epriestley added a comment to T13215: Secure/Admin have many accounts with commercial links in profile blurbs.

I just deleted the users above and am backing away from D19933, at least for now, since it doesn't feel like an especially great fit for either secure or admin.

Dec 22 2018, 6:35 PM · People, Phacility, Abuse
epriestley added a comment to T13215: Secure/Admin have many accounts with commercial links in profile blurbs.

On admin, basically every user with a blurb is abusive. I've just disabled the field as a coarse reaction.

Dec 22 2018, 6:28 PM · People, Phacility, Abuse
epriestley updated subscribers of T13215: Secure/Admin have many accounts with commercial links in profile blurbs.

I'm planning to banish these users from secure. This is mostly: polish (?) SEO bots; printer fax spam; and "security researchers":

Dec 22 2018, 5:49 PM · People, Phacility, Abuse
epriestley added a revision to T13215: Secure/Admin have many accounts with commercial links in profile blurbs: Unknown Object (Differential Revision).
Dec 22 2018, 5:09 PM · People, Phacility, Abuse
epriestley triaged T13227: Figure out if Google Auth needs to be updated before Google+ shutdown on March 7, 2019 as Normal priority.
Dec 22 2018, 2:36 PM · Auth
epriestley closed T13228: Cycle AWS Hosts (January 2019) as Wontfix.

There's some ephemeral data on this host and my house doesn't currently burn down if the associated services are unavailable, so I'm just going to let AWS restart it when the time comes.

Dec 22 2018, 2:35 PM
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Restricted Differential Revision.
Dec 22 2018, 12:54 PM · Plans

Dec 21 2018

avivey added a comment to T13227: Figure out if Google Auth needs to be updated before Google+ shutdown on March 7, 2019.

Since the google-api is also disabled by default in Google Cloud env, I had to make changes to some other oauth provider at https://gitlab.com/SirEdvin/sanic-oauth/commit/fae23f6b35517dd9e8bec328dbb4dc883e033d78.
There, the g+ api was only used to get the user's email, iirc, and an alternative exists in https://www.googleapis.com/userinfo/v2/me.

Dec 21 2018, 1:51 AM · Auth

Dec 20 2018

epriestley added a comment to T13222: 2018 Week 48-51 Bonus Content.
  • We still need to key the Image table in Pholio (see D19914) although the right key looks like just <mockPHID>.
  • instances/ should get some cleanup for the changes to transactions.
Dec 20 2018, 10:53 PM · Plans
epriestley claimed T13228: Cycle AWS Hosts (January 2019).

Oh, this is on my personal AWS account. Oops!

Dec 20 2018, 10:50 PM
epriestley created T13228: Cycle AWS Hosts (January 2019).
Dec 20 2018, 10:48 PM
epriestley created T13227: Figure out if Google Auth needs to be updated before Google+ shutdown on March 7, 2019.
Dec 20 2018, 10:47 PM · Auth
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: Unknown Object (Differential Revision).
Dec 20 2018, 9:53 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: Unknown Object (Differential Revision).
Dec 20 2018, 9:33 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: Unknown Object (Differential Revision).
Dec 20 2018, 8:18 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley updated the task description for T13178: Plans: Support Pact Competitive Update.
Dec 20 2018, 7:57 PM · Plans, Support, Phacility
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: Unknown Object (Differential Revision).
Dec 20 2018, 7:56 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: Unknown Object (Differential Revision).
Dec 20 2018, 7:56 PM · Mail
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: Unknown Object (Differential Revision).
Dec 20 2018, 7:48 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley triaged T11351: Move Pholio to EditEngine and modern APIs as Wishlist priority.
Dec 20 2018, 7:48 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: Unknown Object (Differential Revision).
Dec 20 2018, 6:43 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: Unknown Object (Differential Revision).
Dec 20 2018, 6:24 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: Unknown Object (Differential Revision).
Dec 20 2018, 6:12 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
amckinley edited the content of Developer Setup.
Dec 20 2018, 12:15 AM

Dec 19 2018

epriestley added a revision to T13179: sshd with "ForceUser" does not compile on High Sierra: Unknown Object (Differential Revision).
Dec 19 2018, 8:48 PM · Setup, Phacility
amckinley created P2112 (An Untitled Masterwork).
Dec 19 2018, 8:24 PM
epriestley added a member for Community: jmc.
Dec 19 2018, 7:28 PM
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: Unknown Object (Differential Revision).
Dec 19 2018, 7:21 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a comment to T13179: sshd with "ForceUser" does not compile on High Sierra.

I'll get this actually landed, but here's the patch I'm using for ForceUser until I get there:

Dec 19 2018, 7:15 PM · Setup, Phacility
amckinley added a comment to T13179: sshd with "ForceUser" does not compile on High Sierra.

I was also able to get OpenSSH 7.9p1 to build cleanly on OS X Mojave 10.14.2. For posterity:

Dec 19 2018, 7:06 PM · Setup, Phacility
epriestley added a comment to T4200: Building OS packages and install scripts.

(Please use Discourse for this sort of discussion.)

Dec 19 2018, 3:50 PM · Guides, Setup
yaneurabeya added a comment to T4200: Building OS packages and install scripts.

It's been several year's since this task has been opened up, and it's not clear what the current progress on this. Is there a way that versioning please be added to GitHub, per the recommendations on https://github.com/Homebrew/homebrew-php/pull/3864 ? I'm not able to install arcanist currently using homebrew because there isn't a stable tagged version newer than one from 2012.

Dec 19 2018, 11:13 AM · Guides, Setup
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: Unknown Object (Differential Revision).
Dec 19 2018, 12:09 AM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request

Dec 18 2018

epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: Unknown Object (Differential Revision).
Dec 18 2018, 11:41 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley updated subscribers of T11351: Move Pholio to EditEngine and modern APIs.

@amckinley, for general context on where I'm headed here:

Dec 18 2018, 11:34 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: Unknown Object (Differential Revision).
Dec 18 2018, 11:28 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: Unknown Object (Differential Revision).
Dec 18 2018, 11:17 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 18 2018, 10:34 PM · Plans
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 18 2018, 10:19 PM · Plans
amckinley added a revision to T12538: Search field in header doesn't show both tags and (disabled, bot, or mailing list) users with same name: Unknown Object (Differential Revision).
Dec 18 2018, 8:08 PM · Customer Impact, Typeahead, Bug Report
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 18 2018, 8:04 PM · Plans
epriestley added a revision to T13226: Consider login/session alerts, and other security alerts (for example, around MFA): Unknown Object (Differential Revision).
Dec 18 2018, 7:58 PM · Auth, Security
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 18 2018, 7:58 PM · Plans
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 18 2018, 7:38 PM · Plans
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 18 2018, 7:17 PM · Plans
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 18 2018, 4:23 PM · Plans
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 18 2018, 4:12 PM · Plans
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 18 2018, 4:04 PM · Plans
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 18 2018, 3:19 PM · Plans
epriestley awarded T13222: 2018 Week 48-51 Bonus Content a The World Burns token.
Dec 18 2018, 3:17 PM · Plans
epriestley added a comment to T13222: 2018 Week 48-51 Bonus Content.

Notes for myself:

Dec 18 2018, 3:06 PM · Plans
epriestley triaged T13226: Consider login/session alerts, and other security alerts (for example, around MFA) as Low priority.
Dec 18 2018, 2:20 PM · Auth, Security
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 18 2018, 2:01 PM · Plans

Dec 17 2018

epriestley closed T9770: It is possible to use the same 2FA token more than once as Wontfix.

After the stack of changes under D19897 land:

Dec 17 2018, 10:22 PM · Security, Auth
epriestley closed T13186: Upgrading: Legacy "Can Edit <Field>" policies in Maniphest; requireCapabilities() in TransactionEditor as Resolved.

This appears to be stable and working properly. D19897 removes a straggling guardrail.

Dec 17 2018, 8:46 PM · Security, Policy, ApplicationEditor, Guides, Installing & Upgrading
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 17 2018, 8:37 PM · Plans
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 17 2018, 7:24 PM · Plans
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 17 2018, 7:12 PM · Plans
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 17 2018, 6:10 PM · Plans
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 17 2018, 5:19 PM · Plans
epriestley renamed T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing] from User documentation on "secure" is occasionally unpublishing to Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].
Dec 17 2018, 3:45 PM · Diviner
epriestley renamed T13222: 2018 Week 48-51 Bonus Content from 2018 Week 48-50 Bonus Content to 2018 Week 48-51 Bonus Content.
Dec 17 2018, 2:51 PM · Plans
epriestley added a member for Community: • cfloyd.
Dec 17 2018, 2:08 PM

Dec 16 2018

20after4 added a watcher for Plans: 20after4.
Dec 16 2018, 6:03 PM

Dec 15 2018

epriestley edited the content of Changelog.
Dec 15 2018, 7:20 AM
epriestley created 2018 Week 50 (Mid December).
Dec 15 2018, 7:19 AM

Dec 14 2018

epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 14 2018, 3:57 PM · Plans
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 14 2018, 2:16 PM · Plans
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 14 2018, 1:32 PM · Plans

Dec 13 2018

epriestley added a revision to T9770: It is possible to use the same 2FA token more than once: Unknown Object (Differential Revision).
Dec 13 2018, 11:44 PM · Security, Auth
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 13 2018, 11:44 PM · Plans
epriestley added a comment to T13219: When returning a writable connection as a "r" connection, label it so it can be reused as a "w" connection.

Yeah, that's T10769.

Dec 13 2018, 11:41 PM · Clusters, Infrastructure
joshuaspence added a comment to T13219: When returning a writable connection as a "r" connection, label it so it can be reused as a "w" connection.

I am seeing a similar issue on our install:

[2018-12-13 12:20:12] EXCEPTION: (PhabricatorClusterImproperWriteException) Unable to establish a write-mode connection (to application database "phabricator_repository") because Phabricator is in read-only mode. Whatever you are trying to do does not function correctly in read-only mode. at [<phabricator>/src/infrastructure/storage/lisk/PhabricatorLiskDAO.php:119] arcanist(head=stable, ref.master=d9a4293ae734, ref.stable=45a8d22c74a6), phabricator(head=stable, ref.master=2951694c2737, ref.stable=237a2a190984), phlab(head=master, ref.master=564c60d09ff4), phutil(head=stable, ref.master=dd136d1c3712, ref.stable=414a4c6abb1b)
  #0 PhabricatorLiskDAO::raiseImproperWrite(string) called at [<phabricator>/src/infrastructure/storage/lisk/PhabricatorLiskDAO.php:60]
  #1 PhabricatorLiskDAO::establishLiveConnection(string) called at [<phabricator>/src/infrastructre/storage/lisk/LiskDAO.php:1011]
  #2 LiskDAO::establishConnection(string) called at [<phabricator>/src/applications/repository/stora... (619 more bytes) ... at [<phutil>/src/future/exec/ExecFuture.php:380]
[13-Dec-2018 12:20:12 Etc/UTC] arcanist(head=stable, ref.master=d9a4293ae734, ref.stable=45a8d22c74a6), phabricator(head=stable, ref.master=2951694c2737, ref.stable=237a2a190984), phlab(head=master, ref.master=564c60d09ff4), phutil(head=stable, ref.master=dd136d1c3712, ref.stable=414a4c6abb1b)
[13-Dec-2018 12:20:12 Etc/UTC]   #0 <#3> ExecFuture::resolvex() called at [<phabricator>/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:446]
[13-Dec-2018 12:20:12 Etc/UTC]   #1 phlog(PhutilProxyException) called at [<phabricator>/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:453]
[13-Dec-2018 12:20:12 Etc/UTC]   #2 PhabricatorRepositoryPullLocalDaemon::resolveUpdateFuture(PhabricatorRepository, ExecFuture, integer) called at [<phabricator>/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:222]
[13-Dec-2018 12:20:12 Etc/UTC]   #3 PhabricatorRepositoryPullLocalDaemon::run() called at [<phutil>/src/daemon/PhutilDaemon.php:219]
[13-Dec-2018 12:20:12 Etc/UTC]   #4 PhutilDaemon::execute() called at [<phutil>/scripts/daemon/exec/exec_daemon.php:131]
Dec 13 2018, 11:40 PM · Clusters, Infrastructure
joshuaspence added a comment to T13219: When returning a writable connection as a "r" connection, label it so it can be reused as a "w" connection.

I am seeing a similar issue on our install:

Dec 13 2018, 11:38 PM · Clusters, Infrastructure
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 13 2018, 8:41 PM · Plans
epriestley added a revision to T12509: Plan the path forward from HMAC-SHA1: Unknown Object (Differential Revision).
Dec 13 2018, 8:19 PM · Infrastructure, Security
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 13 2018, 8:19 PM · Plans
epriestley added a revision to T13225: Complete session digest migration from SHA1 to SHA256: Unknown Object (Differential Revision).
Dec 13 2018, 7:31 PM · Installing & Upgrading, Infrastructure, Security
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 13 2018, 7:31 PM · Plans
epriestley added a comment to T13222: 2018 Week 48-51 Bonus Content.

One piece of minor mess here -- when you bin/auth recover yourself into a MFA'd account, you can get two MFA prompts: one to upgrade the session, then one to allow you to perform a password reset. Probably, the contextless password reset should only require MFA if you actually submit the form, and should do one-shot MFA, and ideally should carry the challenge tokens from the login and belong to the same workflow, although that's probably impractical.

Dec 13 2018, 7:21 PM · Plans
epriestley added a revision to T13217: Upgrading: Hardening of qsprintf(): Unknown Object (Differential Revision).
Dec 13 2018, 7:01 PM · Installing & Upgrading, Infrastructure, Security, Guides
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 13 2018, 7:01 PM · Plans
epriestley triaged T13225: Complete session digest migration from SHA1 to SHA256 as Low priority.
Dec 13 2018, 6:42 PM · Installing & Upgrading, Infrastructure, Security
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 13 2018, 6:34 PM · Plans
epriestley added a comment to T13222: 2018 Week 48-51 Bonus Content.

Bind Challenges to Sessions

Dec 13 2018, 6:03 PM · Plans
epriestley added a comment to T12521: "(Exception) Expected nonempty 'cmds' specification!" when trying to clone or pull mercurial repository.

If you want me to look at something, file a report on Discourse with reproduction steps that I can follow to reproduce the issue. I don't need any other discussion or context. I do need working reproduction steps.

Dec 13 2018, 5:46 PM · Bug Report (Needs Information)
epriestley added a comment to T12521: "(Exception) Expected nonempty 'cmds' specification!" when trying to clone or pull mercurial repository.

No.

Dec 13 2018, 5:43 PM · Bug Report (Needs Information)
arrowd added a comment to T12521: "(Exception) Expected nonempty 'cmds' specification!" when trying to clone or pull mercurial repository.

@epriestley I have seen you working on Mercurial stuff. Can you take a look at my findings above?

Dec 13 2018, 4:38 PM · Bug Report (Needs Information)
epriestley added a comment to T2549: Support linking multiple external accounts from the same provider with one Phabricator account.

Sorry, yeah, I meant T6703.

Dec 13 2018, 12:48 PM · Restricted Project, Restricted Project, LDAP, Auth, OAuthServer
urzds added a comment to T2549: Support linking multiple external accounts from the same provider with one Phabricator account.

I believe that instead of T7667 you meant to write T6703.

Dec 13 2018, 11:20 AM · Restricted Project, Restricted Project, LDAP, Auth, OAuthServer