Page MenuHomePhabricator
Feed Advanced Search

Jul 3 2016

Danny_B added a comment to T11265: Milestone series navigation doesn't work.

Ah, then it will be some of our local enhancements... Sorry for bothering then.

Jul 3 2016, 9:08 PM · Projects, Bug Report
chad added a comment to T11244: Identify additional tokens to add to Phabricator.

next batch is ready, should land tonight:

Jul 3 2016, 9:03 PM · Celerity, Tokens
epriestley added a comment to T11264: Add access key for global search field.

In the future, we might reasonably want to put tabindex="1" on the first input on form pages, like the "Edit Task" page, so that you could press tab once to quickly begin editing. If we put tabindex="1" on global search, the cost of making this change in the future will be much higher.

Jul 3 2016, 8:57 PM · Accessibility, Feature Request
epriestley added a comment to T11265: Milestone series navigation doesn't work.

Phabricator has no such sidebar item. Where are you seeing this?

Jul 3 2016, 8:54 PM · Projects, Bug Report
Danny_B added a comment to T11264: Add access key for global search field.

Good point, thanks for research. I was looking in some notes from research done several years ago, thus obviously no longer accurate.

Jul 3 2016, 8:53 PM · Accessibility, Feature Request
Danny_B created T11265: Milestone series navigation doesn't work.
Jul 3 2016, 8:32 PM · Projects, Bug Report
epriestley added a comment to T11264: Add access key for global search field.

Can you substantiate "f" being "typically used"? Here's what I see in use in the wild from a quick survey of popular sites and software:

Jul 3 2016, 7:54 PM · Accessibility, Feature Request
Danny_B added a comment to T11264: Add access key for global search field.

Those are all about preferences and JavaScript handling...

Jul 3 2016, 7:08 PM · Accessibility, Feature Request
epriestley added a comment to T11264: Add access key for global search field.

This feature has a tiny impact and a huge support cost.

Jul 3 2016, 7:00 PM · Accessibility, Feature Request
chad added a comment to T11263: DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts.

I can look in more detail when I'm back home. Kids have a picnic today.

Jul 3 2016, 5:07 PM · Bug Report (Needs Information)
Danny_B added a comment to T11263: DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts.

That's what I plan. Just tested it on WXPx86 and FF 47.0.1 32bit and it works there.

Jul 3 2016, 4:28 PM · Bug Report (Needs Information)
chad added a comment to T11263: DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts.

The next step on this report would be for you to try to reproduce on a different environment.

Jul 3 2016, 4:26 PM · Bug Report (Needs Information)
Danny_B added a comment to T11263: DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts.

And FF? And 32 or 64 bit?

Jul 3 2016, 4:21 PM · Bug Report (Needs Information)
chad added a comment to T11263: DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts.

Tested 8 and 10. I don't have Win7.

Jul 3 2016, 4:20 PM · Bug Report (Needs Information)
Danny_B added a comment to T11263: DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts.

@chad Which version of Win & FF you use?

Jul 3 2016, 4:11 PM · Bug Report (Needs Information)
Danny_B added a comment to T11264: Add access key for global search field.

I don't see anything relevant there actually, could you please elaborate?

Jul 3 2016, 4:10 PM · Accessibility, Feature Request
chad added a comment to T11263: DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts.

I can't reproduce on Windows, Chrome, FF, IE with en layouts.

Jul 3 2016, 3:58 PM · Bug Report (Needs Information)
epriestley closed T11264: Add access key for global search field as Wontfix.

See discussion in D15984.

Jul 3 2016, 2:44 PM · Accessibility, Feature Request
Danny_B created T11264: Add access key for global search field.
Jul 3 2016, 2:36 PM · Accessibility, Feature Request
Danny_B added a comment to T11263: DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts.

Tested in both en and cs layouts.

Jul 3 2016, 2:33 PM · Bug Report (Needs Information)
epriestley added a comment to T11263: DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts.

/ was removed, see D15976 and the changelog:

Jul 3 2016, 2:15 PM · Bug Report (Needs Information)
Danny_B created T11263: DarkConsole "`" keypress does not fire immediately on some systems or keyboard layouts.
Jul 3 2016, 2:08 PM · Bug Report (Needs Information)
• offluri added a comment to T8936: Unable to identify the reftype of 'refs/remotes/origin/master'. Rejecting push..

Same problem :
Versions :
phabricator bc3ac3158448dfe966d05787fa9272f08ddc7faa (Fri, Jul 1)
arcanist 4d4d16f25985f133501f20fdddd183e525f00341 (Wed, Jun 29)
phutil dde2f74f2793f0216f0d76618ed335a9c802cfec (Fri, Jul 1)

Jul 3 2016, 12:42 PM · Diffusion
nickhutchinson added a comment to T11105: ExecFuture performs blocking reads on Windows, causing deadlocks with `arc lint`.

This is solved with D11688, but it needs to be turned on globally (at the moment it's a per call option, which was added so that internally our custom unit test runner wouldn't deadlock).

Jul 3 2016, 12:06 PM · Windows, Arcanist, Lint, Bug Report
nickhutchinson added a watcher for Windows: nickhutchinson.
Jul 3 2016, 12:03 PM
epriestley added a comment to T10855: Allow external systems to edit the content of dashboard panels so they can publish information.

We probably need to do almost all of this work before adding new panel types anyway, since building a new panel type on top of CustomFields would make moving everything from CustomFields to EditEngine harder.

Jul 3 2016, 9:11 AM · Dashboards, Restricted Project, Conduit, Feature Request
epriestley added a comment to T9360: Unbeta Phame.
In T9360#183602, @chad wrote:

Is [HTTPS] simple? Not sure where to start? Nothing is jumping out at me here.

Jul 3 2016, 9:06 AM · Phame
epriestley edited subtasks for T9897: Unbeta Feedback on Phame, added: T6299: Remarkup links to objects in Phame break if a CNAME is set; removed: T4936: Phame is not accessible on a custom domain without `policy.allow-public`.
Jul 3 2016, 9:00 AM · Phame
epriestley removed a parent task for T4936: Phame is not accessible on a custom domain without `policy.allow-public`: T9897: Unbeta Feedback on Phame.
Jul 3 2016, 9:00 AM · Phame
epriestley added a parent task for T6299: Remarkup links to objects in Phame break if a CNAME is set: T9897: Unbeta Feedback on Phame.
Jul 3 2016, 9:00 AM · Haskell.org, Remarkup, Phame
epriestley removed a subtask for T9897: Unbeta Feedback on Phame: T6299: Remarkup links to objects in Phame break if a CNAME is set.
Jul 3 2016, 9:00 AM · Phame
epriestley removed a parent task for T6299: Remarkup links to objects in Phame break if a CNAME is set: T9897: Unbeta Feedback on Phame.
Jul 3 2016, 9:00 AM · Haskell.org, Remarkup, Phame
Danny_B added a comment to T11254: Provide a way for quick revert of all activities of the most recent task editor..

Suggestion from one chat I had:

I mean even having just a "Revert" button for each change would be easier
Even if you had 50 to click, it's better than manually undoing :)

Jul 3 2016, 8:53 AM · Abuse, Maniphest, Wikimedia, Feature Request
epriestley merged T11262: On slow connections, it's possible to submit the Create Task form on workboards multiple times into T11145: Dialog submit buttons don't disable on click.
Jul 3 2016, 8:37 AM · Restricted Project, PHUI, Bug Report
epriestley merged task T11262: On slow connections, it's possible to submit the Create Task form on workboards multiple times into T11145: Dialog submit buttons don't disable on click.
Jul 3 2016, 8:37 AM · Maniphest, Bug Report
eadler added a comment to T10855: Allow external systems to edit the content of dashboard panels so they can publish information.

FWIW we'd be perfectly fine with the following:

  • allow editing phriction documents via Conduit
  • create a panel which shows the contents of a specific phriction page
Jul 3 2016, 5:51 AM · Dashboards, Restricted Project, Conduit, Feature Request
eadler added a project to T11254: Provide a way for quick revert of all activities of the most recent task editor.: Abuse.
Jul 3 2016, 5:49 AM · Abuse, Maniphest, Wikimedia, Feature Request
hach-que added projects to T11262: On slow connections, it's possible to submit the Create Task form on workboards multiple times: Bug Report, Maniphest.
Jul 3 2016, 5:20 AM · Maniphest, Bug Report
hach-que created T11262: On slow connections, it's possible to submit the Create Task form on workboards multiple times.
Jul 3 2016, 5:20 AM · Maniphest, Bug Report

Jul 2 2016

chad added a comment to T9360: Unbeta Phame.

Oh, and we select the correct protocol for custom domains now, but don't enforce it when serving content. That is, these both work, and we always link to "https", but "http" should redirect you directly to "https" instead of serving content:

Jul 2 2016, 8:13 PM · Phame
chad renamed T11261: Simplify Dashboard Panel Layouts from Simply Dashboard Panel Layouts to Simplify Dashboard Panel Layouts.
Jul 2 2016, 7:47 PM · Dashboards
epriestley added a comment to T10855: Allow external systems to edit the content of dashboard panels so they can publish information.

The actual panel transactions that we need to update for this aren't too bad. The board transactions are a little more involved, but we can skip them.

Jul 2 2016, 7:36 PM · Dashboards, Restricted Project, Conduit, Feature Request
epriestley moved T5267: Localize Phabricator from Backlog to The Queue on the Prioritized board.
Jul 2 2016, 7:24 PM · Prioritized, Localization
epriestley moved T10855: Allow external systems to edit the content of dashboard panels so they can publish information from Preflight to The Queue on the Prioritized board.
Jul 2 2016, 7:24 PM · Dashboards, Restricted Project, Conduit, Feature Request
epriestley removed a project from T11051: "Explain Why" isn't properly explaining why revisions were closed: Prioritized.

This could still be improved, but the immediate confusion we encountered appears fixed.

Jul 2 2016, 7:18 PM · Restricted Project, Differential, Bug Report
epriestley removed a project from T7916: Can't paste images from clipboard in Firefox / Safari: Prioritized.
Jul 2 2016, 7:17 PM · Restricted Project, Firefox, Safari, PHUI
epriestley moved T3875: Allow arc to perform cascading rebases, maybe during or after `arc land` from Backlog to Rugged Terrain on the Prioritized board.
Jul 2 2016, 7:15 PM · Prioritized, Restricted Project, Arcanist
epriestley moved T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI from Backlog to The Queue on the Prioritized board.
Jul 2 2016, 7:12 PM · Prioritized, Restricted Project, Arcanist, Bug Report
epriestley added a comment to T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI.

We can fix the highly-tractable web UI part, at least.

Jul 2 2016, 7:12 PM · Prioritized, Restricted Project, Arcanist, Bug Report
epriestley renamed T11085: Prevent users from generating an ambiguous commit message by editing revisions with the web UI from arcanist incorrectly parses fields inside fields to Prevent users from generating an ambiguous commit message by editing revisions with the web UI.
Jul 2 2016, 7:12 PM · Prioritized, Restricted Project, Arcanist, Bug Report
epriestley moved T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks from The Queue to Paused on the Prioritized board.
Jul 2 2016, 7:11 PM · Prioritized, Wikimedia, Remarkup
epriestley removed a project from T9789: Make it easier to write custom transaction types: Prioritized.

(Just bookkeeping; there's no external priority on this.)

Jul 2 2016, 7:10 PM · Modernization, Transactions
epriestley moved T11114: Move Differential to EditEngine from Backlog to Rugged Terrain on the Prioritized board.
Jul 2 2016, 7:09 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley moved T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential from Preflight to Rugged Terrain on the Prioritized board.
Jul 2 2016, 7:09 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley moved T8909: Provide ability to hide all inline or done comments from Backlog to Rugged Terrain on the Prioritized board.

I'm moving this to "Rugged Terrain", as the best available pathway forward leaves us with dramatically higher implementation cost than the reasonable value of the feature. We can pursue this after tasks with better aligned costs and value are addressed.

Jul 2 2016, 7:09 PM · Inline Comments, Prioritized, Restricted Project, Restricted Project, Differential, FreeBSD
epriestley removed a project from T4631: Allow Differential to raise warnings on the server side via Conduit: Prioritized.

Mooted from a prioritization standpoint by D16139.

Jul 2 2016, 7:01 PM · Restricted Project, Differential, Arcanist
epriestley moved T11159: Cluster detection of "replication OK" is unreasonably optimistic from Backlog to The Queue on the Prioritized board.
Jul 2 2016, 7:00 PM · Prioritized, Clusters
chad merged task T11261: Simplify Dashboard Panel Layouts into T11132: New Phabricator NUX.
Jul 2 2016, 6:36 PM · Dashboards
chad merged T11261: Simplify Dashboard Panel Layouts into T11132: New Phabricator NUX.
Jul 2 2016, 6:36 PM · Design, Phacility, NUX
chad added a comment to T11261: Simplify Dashboard Panel Layouts.

but yeah, a spacer could help too

Jul 2 2016, 6:35 PM · Dashboards
epriestley added a comment to T11261: Simplify Dashboard Panel Layouts.

That sounds good to me, should give us more clarity around the dashboard stuff.

Jul 2 2016, 6:35 PM · Dashboards
chad added a comment to T11261: Simplify Dashboard Panel Layouts.

Maybe I should just design out my dock idea, the dock then goes with Dashboards (admins can set the apps, etc).

Jul 2 2016, 6:34 PM · Dashboards
epriestley added a comment to T11261: Simplify Dashboard Panel Layouts.

When you're editing a homepage dashboard, just having a spacer bar there for the applications menu might help make it more clear that 66/33 is better in a lot of cases than 50/50 -- currently, you can't see what stuff will really look like until you're already done and installed.

Jul 2 2016, 6:33 PM · Dashboards
chad added a comment to T11261: Simplify Dashboard Panel Layouts.

I think some sort of logged out / open source public template would head off like the majority of these. I think I had a plan in another thread.

Jul 2 2016, 6:33 PM · Dashboards
epriestley added a comment to T11261: Simplify Dashboard Panel Layouts.

wow pretty sure I even picked numbers that add up to 100%

Jul 2 2016, 6:32 PM · Dashboards
epriestley added a comment to T11261: Simplify Dashboard Panel Layouts.

I definitely think we should skip the 3-column versions for now, I don't think we've seen any kind of need for them in practice. We could look at it again after Facts since I think some of these weirder things could make more sense on standalone dashboards, the app just isn't powerful enough yet for that to be paritcularly useful.

Jul 2 2016, 6:32 PM · Dashboards
chad added a comment to T11261: Simplify Dashboard Panel Layouts.

this guy is clueless: T5531#66370

Jul 2 2016, 6:28 PM · Dashboards
chad added a comment to T11261: Simplify Dashboard Panel Layouts.

T6444#81725

Jul 2 2016, 6:28 PM · Dashboards
chad added a comment to T11261: Simplify Dashboard Panel Layouts.

The other solution is just to make it so these are more hidden / advanced options. That the defaults we provide are good enough that users just modify those templates instead of making one from scratch.

Jul 2 2016, 6:24 PM · Dashboards
epriestley added a comment to T11261: Simplify Dashboard Panel Layouts.

Do you think 50/50 and 33/66 are always bad even for standalone (not-on-homepage) dashboards? e.g., if we had a "Phacility Metrics" dashboard in the future after Facts, a 50/50 of a "Users" column and "Revenue" column or whatever could never be a useful way to present the information?

Jul 2 2016, 6:22 PM · Dashboards
chad added a comment to T11261: Simplify Dashboard Panel Layouts.

My rough thinking for new homepage is roughly consisting of three things:

Jul 2 2016, 6:19 PM · Dashboards
epriestley added a comment to T11261: Simplify Dashboard Panel Layouts.

Haha, that's probably T10612.

Jul 2 2016, 6:16 PM · Dashboards
chad added a comment to T11261: Simplify Dashboard Panel Layouts.

Babel seems to have the same panel in both columns, too.

Jul 2 2016, 6:14 PM · Dashboards
chad added a comment to T11261: Simplify Dashboard Panel Layouts.

The problem with 50/50 layouts is they don't guide the user anywhere as to what is important. It basically says, everything is important and conversely, is difficult to follow the page since panels just appear everywhere.

Jul 2 2016, 6:06 PM · Dashboards
chad added a revision to T11261: Simplify Dashboard Panel Layouts: Unknown Object (Differential Revision).
Jul 2 2016, 6:05 PM · Dashboards
epriestley added a comment to T11261: Simplify Dashboard Panel Layouts.

Why do you think installs (offhand: Babel, WMF) are picking 1/2 + 1/2 if they're strictly worse than 2/3 + 1/3?

Jul 2 2016, 6:05 PM · Dashboards
chad created T11261: Simplify Dashboard Panel Layouts.
Jul 2 2016, 6:00 PM · Dashboards
epriestley triaged T11260: Deactivate "Adjust timezone" when user setting is UTC as Wishlist priority.

You're the only user we're currently aware of who wants to use the software like this, so I don't plan to address this use case at this time.

Jul 2 2016, 5:03 PM · User Preferences
jayvdb added a comment to T11260: Deactivate "Adjust timezone" when user setting is UTC.

But when I am looking at my calendar app, I want to see local times, for whatever timezone I am in.

What would you like Phabricator to do when you look at events in its Calendar application?

Jul 2 2016, 5:00 PM · User Preferences
epriestley added a comment to T11260: Deactivate "Adjust timezone" when user setting is UTC.

But when I am looking at my calendar app, I want to see local times, for whatever timezone I am in.

Jul 2 2016, 4:50 PM · User Preferences
jayvdb created T11260: Deactivate "Adjust timezone" when user setting is UTC.
Jul 2 2016, 4:46 PM · User Preferences
featherless added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

Got it. Thank you! I just started the reindexing operations recommended in this release so I may leave things be 'til that finishes.

Jul 2 2016, 4:41 PM · Bug Report
epriestley added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

they won't not exist

Jul 2 2016, 4:41 PM · Bug Report
epriestley added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

"Ignored" in the sense of: no publishing, no herald rules, no audit triggers. Not, like, "they won't not exist".

Jul 2 2016, 4:41 PM · Bug Report
epriestley added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

Only that any legitimate commits pushed until things catch up will also be ignored. The repository will automatically leave the mode once everything finishes.

Jul 2 2016, 4:40 PM · Bug Report
featherless added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

Ok; will let it do its thing then.

Jul 2 2016, 4:39 PM · Bug Report
epriestley added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

There was a relatively recent change to make Phabricator discover commits which are only reachable from tags and refs. As it discovers these commits, it will treat them like new commits and publish feed stories about them. This is a one-time event, but a few installs have a lot of tag-reachable commits for whatever reason. You can find a bit more discussion in T11188, and details about the change in T9028 and T6878.

Jul 2 2016, 4:35 PM · Bug Report
epriestley added a comment to T7916: Can't paste images from clipboard in Firefox / Safari.

This doesn't appear to even to be possible in Firefox. Here's a simple example:

Jul 2 2016, 4:31 PM · Restricted Project, Firefox, Safari, PHUI
featherless added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

Ah, I found the problem in our upgrade script. We run our upgrade in the following order:

Jul 2 2016, 4:30 PM · Bug Report
featherless added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

Thanks for quick response; hadn't seen this before so couldn't tell how serious the errors were.

Jul 2 2016, 4:29 PM · Bug Report
epriestley closed T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27 as Resolved.

Oh, or Apache.

Jul 2 2016, 4:27 PM · Bug Report
featherless added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

Just rebooted apache once more and things are looking better.

Jul 2 2016, 4:26 PM · Bug Report
epriestley added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

Also likely fixed by restarting PHP-FPM, that method is defined here:

Jul 2 2016, 4:26 PM · Bug Report
epriestley added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

Did you restart everything after upgrading? See Restarting Phabricator.

Jul 2 2016, 4:25 PM · Bug Report
featherless added a comment to T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.

Getting the following when I visit differential/:

Jul 2 2016, 4:25 PM · Bug Report
featherless created T11259: UNRECOVERABLE FATAL ERROR after upgrading to 2016 Week 27.
Jul 2 2016, 4:23 PM · Bug Report
epriestley added a comment to T7916: Can't paste images from clipboard in Firefox / Safari.

From the Firefox bug and this linked one:

Jul 2 2016, 3:44 PM · Restricted Project, Firefox, Safari, PHUI
epriestley closed T9028: Phabricator handles commits which are published and later deleted poorly as Resolved.

This appears to be stable, and is now accounted for.

Jul 2 2016, 3:24 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley closed T11098: Feedback and Errata for Global Settings as Resolved.

This seem quiet and is now accounted for.

Jul 2 2016, 3:22 PM · Prioritized, Restricted Project, User Preferences
epriestley closed T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them as Resolved.

This appears functional and is now accounted for.

Jul 2 2016, 3:18 PM · Prioritized, Restricted Project, User Preferences