Page MenuHomePhabricator
Feed Advanced Search

Jul 2 2016

epriestley closed T10431: Allow arc alias to read aliases from system configuration file as Resolved.

Haven't seen issues; now accounted for.

Jul 2 2016, 3:15 PM · Prioritized, Restricted Project, Arcanist, Feature Request
epriestley closed T10785: Allow custom third-party auth providers to implement autologin as Resolved.

The upstream part of this is working in production, and this is now accounted for.

Jul 2 2016, 3:13 PM · Prioritized, Auth, Restricted Project, Feature Request
epriestley closed T10227: Provide an extension point for HTTP behaviors (proxies, SSL trust) as Resolved.

We haven't seen issues with this and it's now accounted for (I believe it's also in production).

Jul 2 2016, 3:10 PM · Prioritized, Restricted Project, Feature Request
epriestley removed a project from T7441: Support OAuth providers in the cluster: Prioritized.

A substantial number of users have linked Google accounts in production and we haven't heard about any issues, so I think that aspect of things is in good shape.

Jul 2 2016, 3:04 PM · Auth, Phacility
epriestley closed T11140: Support at-rest encryption in Files as Resolved.

This is accounted for and we haven't run into any issues upstream with it in production after using it for about two weeks, but let us know if anyone runs into issues deploying it.

Jul 2 2016, 3:02 PM · Prioritized, Files
epriestley added a comment to T11257: HTML in Diffusion not escaped in certain circumstances.

For reference, @Danny_B filed a copy of this on HackerOne here so I could award a bounty for it:

Jul 2 2016, 2:50 PM · Security, Wikimedia, Diffusion, Bug Report
epriestley added a comment to T11257: HTML in Diffusion not escaped in certain circumstances.

Also worth noting is that Content Security Policy (T4340) would have prevented this. CSP is obviously worth implementing, but I believe the last attack it would have prevented was D4534 in January 2013, so it's hard to prioritize if it only defuses one attack every 3-4 years.

Jul 2 2016, 2:49 PM · Security, Wikimedia, Diffusion, Bug Report
epriestley added a comment to T11256: Plan how to split apart instance permissions.

Instances currently have two capabilities:

Jul 2 2016, 2:33 PM · Phacility
epriestley added a revision to T11256: Plan how to split apart instance permissions: Unknown Object (Differential Revision).
Jul 2 2016, 2:13 PM · Phacility
Danny_B updated subscribers of T11257: HTML in Diffusion not escaped in certain circumstances.
Jul 2 2016, 1:25 PM · Security, Wikimedia, Diffusion, Bug Report
epriestley added a comment to T11257: HTML in Diffusion not escaped in certain circumstances.

The Phacility cluster has been patched.

Jul 2 2016, 1:12 PM · Security, Wikimedia, Diffusion, Bug Report
epriestley edited the content of 2016 Week 27 (Very Early July).
Jul 2 2016, 12:30 PM
epriestley added a comment to T11257: HTML in Diffusion not escaped in certain circumstances.

In the future, please report security issues via HackerOne:

Jul 2 2016, 12:27 PM · Security, Wikimedia, Diffusion, Bug Report
epriestley claimed T11257: HTML in Diffusion not escaped in certain circumstances.
Jul 2 2016, 12:27 PM · Security, Wikimedia, Diffusion, Bug Report
epriestley closed T11257: HTML in Diffusion not escaped in certain circumstances as Resolved by committing Restricted Diffusion Commit.
Jul 2 2016, 12:18 PM · Security, Wikimedia, Diffusion, Bug Report
epriestley closed T11258: Push to Remote repository instead of Mirror - How to sync 2 remotes using Phabricator Diffusion as Wontfix.

This is impossible.

Jul 2 2016, 11:59 AM · Diffusion, Feature Request
johnny-bit added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

Current task graph is great for visual representation... but can we get somewhere very simple list of blocks/blocked by?

Jul 2 2016, 8:34 AM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
• niveshsaharan created T11258: Push to Remote repository instead of Mirror - How to sync 2 remotes using Phabricator Diffusion.
Jul 2 2016, 7:47 AM · Diffusion, Feature Request
Danny_B created T11257: HTML in Diffusion not escaped in certain circumstances.
Jul 2 2016, 7:28 AM · Security, Wikimedia, Diffusion, Bug Report
chad added a revision to T9360: Unbeta Phame: Unknown Object (Differential Revision).
Jul 2 2016, 4:34 AM · Phame
chad edited the content of 2016 Week 27 (Very Early July).
Jul 2 2016, 1:02 AM
chad edited the content of 2016 Week 27 (Very Early July).
Jul 2 2016, 1:02 AM

Jul 1 2016

epriestley edited the content of Changelog.
Jul 1 2016, 11:41 PM
epriestley created 2016 Week 27 (Very Early July).
Jul 1 2016, 11:41 PM
epriestley added a comment to T9741: Default Edit Policy for Differential.

See also T10215.

Jul 1 2016, 10:58 PM · Differential
epriestley added a comment to T9741: Default Edit Policy for Differential.

https://secure.phabricator.com/book/phabcontrib/article/feature_requests/#hypotheticals

Jul 1 2016, 10:57 PM · Differential
appsforartists added a comment to T9741: Default Edit Policy for Differential.

We just edited this ticket's information to test if we could indeed edit someone else's diff (don't worry - we changed it back).

Jul 1 2016, 10:52 PM · Differential
appsforartists updated the task description for T9741: Default Edit Policy for Differential.
Jul 1 2016, 10:46 PM · Differential
appsforartists updated the task description for T9741: Default Edit Policy for Differential.
Jul 1 2016, 10:44 PM · Differential
epriestley added a comment to T11237: Mobile action menus are "undefined".

Truly our most useful project.

Jul 1 2016, 10:22 PM · Chad's House, Mobile, Safari, Bug Report
chad added a project to T11237: Mobile action menus are "undefined": Chad's House.

Wait for it...

Jul 1 2016, 10:21 PM · Chad's House, Mobile, Safari, Bug Report
chad added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

T2637 cycles down to itself again

Jul 1 2016, 10:18 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
chad changed the visibility for T2637: Unbeta Pholio.
Jul 1 2016, 10:17 PM · Pholio
epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

A few tasks (like T2637) are still drawing crazily enormous trees. I think our tasks are especially highly-connected and 97% of what I've looked at seems reasonable, so this might not be much of an issue for other installs, but I think we definitely need some kind of behavior where we hide the more distant parts of the tree once it gets too big.

Jul 1 2016, 10:15 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a comment to T10855: Allow external systems to edit the content of dashboard panels so they can publish information.

parrot

Jul 1 2016, 10:07 PM · Dashboards, Restricted Project, Conduit, Feature Request
epriestley created T11256: Plan how to split apart instance permissions.
Jul 1 2016, 10:03 PM · Phacility
chad added a comment to T11255: make it possible to turn any image in a review (any file) into a mock.

Merging this over and re-opening.

Jul 1 2016, 10:02 PM · Restricted Project, Pholio, Feature Request
chad updated subscribers of T3612: Lightbox v2.
Jul 1 2016, 10:01 PM · Lightbox, Restricted Project, Files, Pholio
chad reopened T3612: Lightbox v2 as "Open".
Jul 1 2016, 10:01 PM · Lightbox, Restricted Project, Files, Pholio
chad reopened T3612: Lightbox v2, a subtask of T2637: Unbeta Pholio, as Open.
Jul 1 2016, 10:01 PM · Pholio
chad merged task T11255: make it possible to turn any image in a review (any file) into a mock into T3612: Lightbox v2.
Jul 1 2016, 10:00 PM · Restricted Project, Pholio, Feature Request
chad merged T11255: make it possible to turn any image in a review (any file) into a mock into T3612: Lightbox v2.
Jul 1 2016, 10:00 PM · Lightbox, Restricted Project, Files, Pholio
chad added a comment to T10855: Allow external systems to edit the content of dashboard panels so they can publish information.

No, no I can't. I can't make a Phriction Panel.

Jul 1 2016, 9:59 PM · Dashboards, Restricted Project, Conduit, Feature Request
chad added a comment to T10855: Allow external systems to edit the content of dashboard panels so they can publish information.

I might be able make a Phriction Panel

Jul 1 2016, 9:53 PM · Dashboards, Restricted Project, Conduit, Feature Request
chad changed the visibility for T3612: Lightbox v2.
Jul 1 2016, 9:48 PM · Lightbox, Restricted Project, Files, Pholio
chad changed the visibility for M44: Inline Image Commenting.
Jul 1 2016, 9:47 PM
epriestley added a comment to T11255: make it possible to turn any image in a review (any file) into a mock.

Some earlier discussion in T3612.

Jul 1 2016, 9:39 PM · Restricted Project, Pholio, Feature Request
eadler added a comment to T11250: New Herald rule: "Differential revision accepted by".

The downside of this was that it caused a flood of notifications to go to the supervisors

Could you do something like this?

  • Create two projects, "Supervisors (Blocking)" and "Supervisors (Ready for Approval)".
  • Supervisors are in both projects.
  • Herald adds "Supervisors (Blocking)" as a blocking reviewer.
  • Interns add "Supervisors (Ready for Approval)" as a reviewer once they're ready to complete the flow.
  • If supervisors only want mail once things are ready, they can disable earlier mail in Supervisors (Blocking) → Members → Disable Mail.
Jul 1 2016, 9:38 PM · Feature Request
epriestley added a project to T7916: Can't paste images from clipboard in Firefox / Safari: Prioritized.
Jul 1 2016, 9:35 PM · Restricted Project, Firefox, Safari, PHUI
eadler added a project to T11255: make it possible to turn any image in a review (any file) into a mock: Restricted Project.
Jul 1 2016, 9:33 PM · Restricted Project, Pholio, Feature Request
eadler created T11255: make it possible to turn any image in a review (any file) into a mock.
Jul 1 2016, 9:33 PM · Restricted Project, Pholio, Feature Request
eadler added a project to T7916: Can't paste images from clipboard in Firefox / Safari: Restricted Project.
Jul 1 2016, 9:28 PM · Restricted Project, Firefox, Safari, PHUI
avivey added a comment to T11251: Diff dependency should cause shared lines to be hidden.

Assuming your local tree looks like this:

[master] - last commit from master, has "old"
abc4321 - Add Hello
25ag344 - Add World
Jul 1 2016, 9:02 PM · Feature Request
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Jul 1 2016, 8:32 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
avivey added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

I guess that after some exposure, it would be clear; If we're prioritizing experienced users over new ones, it's fine the way it is.

Jul 1 2016, 8:26 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
chad added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

It's clear enough to me that higher -> more parental. It might be nice to make T123 not a link and bold, like elsewhere, for easy copy-pasta.

Jul 1 2016, 8:24 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
avivey added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

Not a good idea, but an idea:

pasted_file (216×324 px, 20 KB)

Jul 1 2016, 8:22 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
d.maznekov awarded T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies a Mountain of Wealth token.
Jul 1 2016, 8:22 PM · Maniphest
johnny-bit added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

After looking through real-life applications, this now seems obvious and in @avivey example A is Parent of B. At first glance - there's relation. But yeah, arrows would help, only thing problematic is agreeing on arrow notation.

Jul 1 2016, 8:22 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley claimed T4788: Allow "Edit Dependencies" both ways (blocking and depending).
Jul 1 2016, 8:12 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

@avivey Do you have any ideas on how to make that more clear? I'm imagining it will probably be obvious on real data when you know what the tasks are and you'll get used to it pretty quickly, but maybe not.

Jul 1 2016, 8:12 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley closed T8152: Allow Batch Edit of Blocking Task Field as Resolved.

This is now available as "Edit Parent Tasks".

Jul 1 2016, 8:08 PM · Maniphest
epriestley closed T8152: Allow Batch Edit of Blocking Task Field, a subtask of T10005: Implement an ApplicationEditor-based Bulk Editor, as Resolved.
Jul 1 2016, 8:08 PM · ApplicationEditor
epriestley closed T8152: Allow Batch Edit of Blocking Task Field, a subtask of T10034: Plan the future of Maniphest task relationships, as Resolved.
Jul 1 2016, 8:08 PM · Maniphest
epriestley closed T5450: Add support for adding / removing dependent tasks when batch editing tasks as Wontfix.

We haven't seen more requests for this in nearly two years, and the use case isn't really clear to me since you've always been able to edit many dependencies at once from a task. After recent work in T4788, you can edit them in both directions, too.

Jul 1 2016, 8:08 PM · Maniphest
epriestley closed T5450: Add support for adding / removing dependent tasks when batch editing tasks, a subtask of T10034: Plan the future of Maniphest task relationships, as Wontfix.
Jul 1 2016, 8:07 PM · Maniphest
epriestley closed T5450: Add support for adding / removing dependent tasks when batch editing tasks, a subtask of T10005: Implement an ApplicationEditor-based Bulk Editor, as Wontfix.
Jul 1 2016, 8:07 PM · ApplicationEditor
chad awarded T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies a Mountain of Wealth token.
Jul 1 2016, 8:06 PM · Maniphest
epriestley closed T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies as Resolved.

We now render dependency graphs, as on this task:

Jul 1 2016, 8:01 PM · Maniphest
epriestley closed T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies, a subtask of T10034: Plan the future of Maniphest task relationships, as Resolved.
Jul 1 2016, 8:01 PM · Maniphest
epriestley closed T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies, a subtask of T10387: Create UI for visual (drag and drop) rearranging of task hierarchy, as Resolved.
Jul 1 2016, 8:01 PM · Feature Request
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Jul 1 2016, 7:55 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a comment to T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails.

From elsewhere, it would also be nice if this tokenizer highlighted instance members of instances associated with the billing account. There isn't a straightforward way to determine which "joe" or whatever is correct right now that works better than "ask Joe what his account name is".

Jul 1 2016, 7:42 PM · Phortune, Phacility
bjshively added a comment to T11252: Provide better control over mixing denial of access to users in the default space.

Got it. Was able to get the desired result using the Conduit API web UI and the calls you mentioned.

Jul 1 2016, 7:29 PM · Feature Request
chad added a comment to T11253: Make it possible to paste images.

oh man, I even filed it.

Jul 1 2016, 7:28 PM · Restricted Project, Remarkup, Pholio, Feature Request
epriestley merged task T11253: Make it possible to paste images into T7916: Can't paste images from clipboard in Firefox / Safari.
Jul 1 2016, 7:19 PM · Restricted Project, Remarkup, Pholio, Feature Request
epriestley merged T11253: Make it possible to paste images into T7916: Can't paste images from clipboard in Firefox / Safari.
Jul 1 2016, 7:19 PM · Restricted Project, Firefox, Safari, PHUI
epriestley added a parent task for T11254: Provide a way for quick revert of all activities of the most recent task editor.: T10215: Provide tools to combat and recover from abuse.
Jul 1 2016, 7:18 PM · Abuse, Maniphest, Wikimedia, Feature Request
epriestley added a subtask for T10215: Provide tools to combat and recover from abuse: T11254: Provide a way for quick revert of all activities of the most recent task editor..
Jul 1 2016, 7:18 PM · Abuse
Danny_B updated subscribers of T11254: Provide a way for quick revert of all activities of the most recent task editor..
Jul 1 2016, 7:15 PM · Abuse, Maniphest, Wikimedia, Feature Request
Danny_B created T11254: Provide a way for quick revert of all activities of the most recent task editor..
Jul 1 2016, 7:15 PM · Abuse, Maniphest, Wikimedia, Feature Request
epriestley added a comment to T11252: Provide better control over mixing denial of access to users in the default space.

You can use project.edit to add members, roughly:

Jul 1 2016, 7:14 PM · Feature Request
chad added a comment to T11253: Make it possible to paste images.

Any particular system this doesn't work on?

Jul 1 2016, 7:11 PM · Restricted Project, Remarkup, Pholio, Feature Request
bjshively added a comment to T11252: Provide better control over mixing denial of access to users in the default space.

Quick follow-up.. Any thoughts on the most efficient way to do a bulk add-to-group since the only obvious way to add users is via the autocomplete box from the members page for a project?

Jul 1 2016, 7:10 PM · Feature Request
chad added a comment to T11253: Make it possible to paste images.

News to me that we don't support it.

Jul 1 2016, 7:08 PM · Restricted Project, Remarkup, Pholio, Feature Request
epriestley closed T11252: Provide better control over mixing denial of access to users in the default space as Resolved.

Cool -- I'd expect that to work in most situations. Let us know if you run into anything else weird.

Jul 1 2016, 7:04 PM · Feature Request
eadler added a project to T11253: Make it possible to paste images: Restricted Project.
Jul 1 2016, 7:04 PM · Restricted Project, Remarkup, Pholio, Feature Request
eadler created T11253: Make it possible to paste images.
Jul 1 2016, 7:04 PM · Restricted Project, Remarkup, Pholio, Feature Request
bjshively added a comment to T11252: Provide better control over mixing denial of access to users in the default space.

Well, now I just feel dumb. Haha. Yes, I think that would probably work, and I feel silly for not thinking of it since it has how I have been managing other privileges (i.e. Queue Managers, User Managers, etc.) Thanks!

Jul 1 2016, 7:03 PM · Feature Request
avivey added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

in first glance, I'm not sure if A depends on B or the other way around:

Jul 1 2016, 7:01 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
Krinkle added a project to T11117: Links to hidden comments in the same task don't work: Wikimedia.

Affecting Wikimedia as well.

Jul 1 2016, 7:00 PM · Wikimedia, PHUI, Bug Report
eadler added a project to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Restricted Project.
Jul 1 2016, 6:59 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a comment to T11252: Provide better control over mixing denial of access to users in the default space.

I might not have read things carefully enough, but can you just add all the FTEs to "#yesrepo" and then use a positive policy to control access to Diffusion?

Jul 1 2016, 6:58 PM · Feature Request
bjshively updated the task description for T11252: Provide better control over mixing denial of access to users in the default space.
Jul 1 2016, 6:58 PM · Feature Request
bjshively created T11252: Provide better control over mixing denial of access to users in the default space.
Jul 1 2016, 6:54 PM · Feature Request
johnny-bit added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

Now it looks pretty and actually first glance tells something :)

Jul 1 2016, 6:53 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

Seems kinda good now? Could maybe use some style/layout tweaks on the table (I'd like resolved tasks to be more obvious, for example), but that graph seems like it's actually pretty good/useful to me at first glance. Need to poke around more.

Jul 1 2016, 6:51 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
chad added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

wut

Jul 1 2016, 6:42 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Jul 1 2016, 6:41 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
johnny-bit added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

Woooo pretty pictures graph! Can't say I can deduct any task relationship from graph, but nevertheless, it's very pretty!

Jul 1 2016, 6:37 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia