Page MenuHomePhabricator
Feed Advanced Search

Sep 22 2016

jcox updated the diff for D16581: Endpoint+controller for a remarkup image proxy.

Got the DB backed cache working

Sep 22 2016, 6:23 PM
jcox updated the diff for D16581: Endpoint+controller for a remarkup image proxy.

Added a cache storage table so we can clean up the cache.
Don't quite have this working yet.

Sep 22 2016, 3:58 PM

Sep 21 2016

michaeljs1990 awarded D16448: Added a warning prompt if the user tries to use an API cert instead of a CLI cert a Like token.
Sep 21 2016, 6:15 PM
jcox updated the diff for D16581: Endpoint+controller for a remarkup image proxy.

Use $request->getStr

Sep 21 2016, 4:17 PM
jcox updated D16581: Endpoint+controller for a remarkup image proxy.
Sep 21 2016, 3:14 PM
jcox updated the diff for D16581: Endpoint+controller for a remarkup image proxy.

Cache the image view URI so we don't fetch the same image twice

Sep 21 2016, 3:13 PM
jcox retitled D16581: Endpoint+controller for a remarkup image proxy from to Endpoint+controller for a remarkup image proxy.
Sep 21 2016, 2:02 PM
jcox added a revision to T4190: Rebuild remarkup image proxying: D16581: Endpoint+controller for a remarkup image proxy.
Sep 21 2016, 2:02 PM · Contributor Onboarding, Remarkup
jcox added a comment to T4190: Rebuild remarkup image proxying.

I've got the endpoint and controller set up, but I get the following error when I call PhabricatorFile::newFromFileDownload:

Sep 21 2016, 1:12 PM · Contributor Onboarding, Remarkup

Sep 20 2016

jcox awarded T9900: Figlet does not properly render apostrophes with some characters a Baby Tequila token.
Sep 20 2016, 5:28 PM · Contributor Onboarding, Remarkup
epriestley awarded T9900: Figlet does not properly render apostrophes with some characters a Cup of Joe token.
Sep 20 2016, 5:22 PM · Contributor Onboarding, Remarkup
jcox added a comment to T9900: Figlet does not properly render apostrophes with some characters.

Alright I've been able to narrow this down a little bit more. There's some error with how external/pear-figlet/Text/Figlet.php is smushing characters. Specifically lines 339-362 as well as the _rep($r) function. The equivalent function in the C code is here. I haven't been able to find an obvious discrepancy, but I suspect there's a subtle difference in how one of the regex functions is handling things or an error in one of the regexes themselves. This error also occurs with backticks and double-quotes:

Sep 20 2016, 5:08 PM · Contributor Onboarding, Remarkup
jcox committed rP0817eb14a94b: Update Phurl to use EditEngine (authored by jcox).
Update Phurl to use EditEngine
Sep 20 2016, 1:39 PM
jcox closed T10673: Convert Phurl to use EditEngine as Resolved by committing rP0817eb14a94b: Update Phurl to use EditEngine.
Sep 20 2016, 1:39 PM · Contributor Onboarding, Restricted Project, Phurl
jcox closed D16573: Update Phurl to use EditEngine by committing rP0817eb14a94b: Update Phurl to use EditEngine.
Sep 20 2016, 1:39 PM

Sep 19 2016

yelirekim awarded D16573: Update Phurl to use EditEngine a Piece of Eight token.
Sep 19 2016, 8:42 PM
jcox created T11661: Change PhabricatorPhurlURLViewController to use EditEngine for commenting.
Sep 19 2016, 8:15 PM · Contributor Onboarding, Modernization
jcox added inline comments to D16573: Update Phurl to use EditEngine.
Sep 19 2016, 8:13 PM
jcox updated the diff for D16573: Update Phurl to use EditEngine.

Updated based on CR comment

Sep 19 2016, 8:11 PM
jcox retitled D16573: Update Phurl to use EditEngine from to Update Phurl to use EditEngine.
Sep 19 2016, 6:11 PM
jcox added a revision to T10673: Convert Phurl to use EditEngine: D16573: Update Phurl to use EditEngine.
Sep 19 2016, 6:11 PM · Contributor Onboarding, Restricted Project, Phurl
jcox committed rPadf9d5ffdd61: Removed willProcessRequest from DifferentialRevisionLandController (authored by jcox).
Removed willProcessRequest from DifferentialRevisionLandController
Sep 19 2016, 5:49 PM
jcox closed D16572: Removed willProcessRequest from DifferentialRevisionLandController by committing rPadf9d5ffdd61: Removed willProcessRequest from DifferentialRevisionLandController.
Sep 19 2016, 5:49 PM
jcox updated the diff for D16572: Removed willProcessRequest from DifferentialRevisionLandController.

Rebase

Sep 19 2016, 5:47 PM
jcox committed rP799ecdc27886: Update RedirectController for handleRequest (authored by jcox).
Update RedirectController for handleRequest
Sep 19 2016, 5:26 PM
jcox closed D16571: Update RedirectController for handleRequest by committing rP799ecdc27886: Update RedirectController for handleRequest.
Sep 19 2016, 5:26 PM
jcox added a comment to D16572: Removed willProcessRequest from DifferentialRevisionLandController.

ah gotcha. Should I land this anyway or just leave it be?

Sep 19 2016, 5:23 PM
jcox committed rP2e4b5b45a20b: Update DarkConsole for handleRequest (authored by jcox).
Update DarkConsole for handleRequest
Sep 19 2016, 5:20 PM
jcox closed D16570: Update DarkConsole for handleRequest by committing rP2e4b5b45a20b: Update DarkConsole for handleRequest.
Sep 19 2016, 5:20 PM
jcox updated the diff for D16570: Update DarkConsole for handleRequest.

Rebase

Sep 19 2016, 5:18 PM
jcox committed rPdda06c6bdc74: Added a 'name' field to the results for harbormaster.build.search endpoint (authored by jcox).
Added a 'name' field to the results for harbormaster.build.search endpoint
Sep 19 2016, 5:18 PM
jcox closed T11642: Add "name" field to `harbormaster.build.search` results as Resolved by committing rPdda06c6bdc74: Added a 'name' field to the results for harbormaster.build.search endpoint.
Sep 19 2016, 5:17 PM · Restricted Project, Conduit, Harbormaster
jcox closed D16569: Added a 'name' field to the results for harbormaster.build.search endpoint by committing rPdda06c6bdc74: Added a 'name' field to the results for harbormaster.build.search endpoint.
Sep 19 2016, 5:17 PM
jcox updated the test plan for D16572: Removed willProcessRequest from DifferentialRevisionLandController.
Sep 19 2016, 1:50 PM
jcox added a revision to T8628: Modernize AphrontControllers to implement handleRequest: D16572: Removed willProcessRequest from DifferentialRevisionLandController.
Sep 19 2016, 1:19 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
jcox retitled D16572: Removed willProcessRequest from DifferentialRevisionLandController from to Removed willProcessRequest from DifferentialRevisionLandController.
Sep 19 2016, 1:19 PM
jcox added a revision to T8628: Modernize AphrontControllers to implement handleRequest: D16571: Update RedirectController for handleRequest.
Sep 19 2016, 12:42 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
jcox retitled D16571: Update RedirectController for handleRequest from to Update RedirectController for handleRequest.
Sep 19 2016, 12:42 PM
jcox added a revision to T8628: Modernize AphrontControllers to implement handleRequest: D16570: Update DarkConsole for handleRequest.
Sep 19 2016, 12:38 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
jcox retitled D16570: Update DarkConsole for handleRequest from to Update DarkConsole for handleRequest.
Sep 19 2016, 12:38 PM
jcox retitled D16569: Added a 'name' field to the results for harbormaster.build.search endpoint from to Added a 'name' field to the results for harbormaster.build.search endpoint.
Sep 19 2016, 12:04 PM
jcox added a revision to T11642: Add "name" field to `harbormaster.build.search` results: D16569: Added a 'name' field to the results for harbormaster.build.search endpoint.
Sep 19 2016, 12:04 PM · Restricted Project, Conduit, Harbormaster

Sep 15 2016

jcox created T11642: Add "name" field to `harbormaster.build.search` results.
Sep 15 2016, 5:24 PM · Restricted Project, Conduit, Harbormaster

Sep 13 2016

jcox committed rP2588b4fac0c1: Added initial class for displaying invisible chars (authored by jcox).
Added initial class for displaying invisible chars
Sep 13 2016, 3:28 PM
jcox closed T11586: Display errors/nonprintable characters more clearly when warning users about invalid data inputs as Resolved by committing rP2588b4fac0c1: Added initial class for displaying invisible chars.
Sep 13 2016, 3:28 PM · Contributor Onboarding
jcox closed D16541: Added initial class for displaying invisible chars by committing rP2588b4fac0c1: Added initial class for displaying invisible chars.
Sep 13 2016, 3:28 PM
jcox created T11632: Display invisible characters on erroneous user input.
Sep 13 2016, 3:24 PM · Restricted Project, Contributor Onboarding
jcox added a comment to D16541: Added initial class for displaying invisible chars.

I'm going to land this and create a separate ticket to fix up the other places it can be used.

Sep 13 2016, 3:16 PM
jcox updated the diff for D16541: Added initial class for displaying invisible chars.

Added invisible character formatting to auth controller and phurl aliases

Sep 13 2016, 11:39 AM

Sep 12 2016

jcox added inline comments to D16541: Added initial class for displaying invisible chars.
Sep 12 2016, 6:05 PM
jcox added a comment to D16541: Added initial class for displaying invisible chars.

I'm also not sure where to actually start using this. I haven't been able to find any obvious error messages that echo back user input. I could land this independently, but presumably it should be used if it's actually going to fix the issue that was reported.

Sep 12 2016, 6:04 PM
jcox updated the diff for D16541: Added initial class for displaying invisible chars.

Added some really basic CSS for invis chars

Sep 12 2016, 6:03 PM
epriestley awarded D16541: Added initial class for displaying invisible chars a 100 token.
Sep 12 2016, 5:35 PM
jcox updated the diff for D16541: Added initial class for displaying invisible chars.

Shared some code between the 2 modes, simplified unit tests
Remove anon function because old PHP

Sep 12 2016, 5:34 PM
jcox updated the test plan for D16541: Added initial class for displaying invisible chars.
Sep 12 2016, 4:10 PM
jcox updated the diff for D16541: Added initial class for displaying invisible chars.

Added unit tests, pared down the named list, and added plaintext option

Sep 12 2016, 4:09 PM
jcox planned changes to D16541: Added initial class for displaying invisible chars.
Sep 12 2016, 1:17 PM
jcox added inline comments to D16541: Added initial class for displaying invisible chars.
Sep 12 2016, 1:16 PM
jcox updated D16541: Added initial class for displaying invisible chars.
Sep 12 2016, 1:04 PM
jcox retitled D16541: Added initial class for displaying invisible chars from to Added initial class for displaying invisible chars.
Sep 12 2016, 1:04 PM
jcox added a revision to T11586: Display errors/nonprintable characters more clearly when warning users about invalid data inputs: D16541: Added initial class for displaying invisible chars.
Sep 12 2016, 1:04 PM · Contributor Onboarding

Sep 8 2016

jcox committed rPf712ae718ccc: Added `-` to the whitelist for CSS rules (authored by jcox).
Added `-` to the whitelist for CSS rules
Sep 8 2016, 8:29 PM
jcox closed D16519: Added `-` to the whitelist for CSS rules by committing rPf712ae718ccc: Added `-` to the whitelist for CSS rules.
Sep 8 2016, 8:29 PM
jcox closed T11567: Allow dashes in monospace font preferences as Resolved by committing rPf712ae718ccc: Added `-` to the whitelist for CSS rules.
Sep 8 2016, 8:29 PM · Contributor Onboarding, User Preferences
jcox updated the test plan for D16519: Added `-` to the whitelist for CSS rules.
Sep 8 2016, 8:25 PM
jcox retitled D16519: Added `-` to the whitelist for CSS rules from to Added `-` to the whitelist for CSS rules.
Sep 8 2016, 8:25 PM
jcox added a revision to T11567: Allow dashes in monospace font preferences: D16519: Added `-` to the whitelist for CSS rules.
Sep 8 2016, 8:25 PM · Contributor Onboarding, User Preferences
jcox committed rP0030bda17ea3: Check if app is installed for user before displying (authored by jcox).
Check if app is installed for user before displying
Sep 8 2016, 7:08 PM
jcox closed D16518: Check if app is installed for user before displying by committing rP0030bda17ea3: Check if app is installed for user before displying.
Sep 8 2016, 7:08 PM
jcox closed T11595: PhabricatorApplicationDatasource returns applications which have been uninstalled (e.g., in "Pin Application") as Resolved by committing rP0030bda17ea3: Check if app is installed for user before displying.
Sep 8 2016, 7:08 PM · Contributor Onboarding, Bug Report
jcox updated the diff for D16518: Check if app is installed for user before displying.

Update formatting

Sep 8 2016, 6:50 PM
jcox updated D16518: Check if app is installed for user before displying.
Sep 8 2016, 6:24 PM
jcox added a revision to T11595: PhabricatorApplicationDatasource returns applications which have been uninstalled (e.g., in "Pin Application"): D16518: Check if app is installed for user before displying.
Sep 8 2016, 6:24 PM · Contributor Onboarding, Bug Report
jcox retitled D16518: Check if app is installed for user before displying from to Check if app is installed for user before displying.
Sep 8 2016, 6:23 PM

Aug 30 2016

jcox committed rP7ce585393685: Start actually showing the phurl urls to users (authored by jcox).
Start actually showing the phurl urls to users
Aug 30 2016, 6:51 PM
jcox closed T10679: When phurl.short-uri is configured, use it in the UI as Resolved by committing rP7ce585393685: Start actually showing the phurl urls to users.
Aug 30 2016, 6:51 PM · Contributor Onboarding, Restricted Project, Phurl
jcox closed D16473: Start actually showing the phurl urls to users by committing rP7ce585393685: Start actually showing the phurl urls to users.
Aug 30 2016, 6:51 PM
jcox updated the diff for D16473: Start actually showing the phurl urls to users.

PASTE CHANGES, RETURN FROM WHENCE YOU CAME!

Aug 30 2016, 6:46 PM
jcox added a comment to D16473: Start actually showing the phurl urls to users.

uh oh I crossed streams with my diffs. One sec.

Aug 30 2016, 6:42 PM
jcox updated the diff for D16473: Start actually showing the phurl urls to users.

Make short URL construction more robust with regard to trailing slashes in base URLs

Aug 30 2016, 6:41 PM
jcox committed rPf5537fdff69f: Fix the feed line items for autodetect paste languages (authored by jcox).
Fix the feed line items for autodetect paste languages
Aug 30 2016, 6:28 PM
jcox closed D16474: Fix the feed line items for autodetect paste languages by committing rPf5537fdff69f: Fix the feed line items for autodetect paste languages.
Aug 30 2016, 6:28 PM
jcox closed T11555: Paste highlighting caches don't take name into account, but should as Resolved by committing rPf5537fdff69f: Fix the feed line items for autodetect paste languages.
Aug 30 2016, 6:28 PM · Paste, Contributor Onboarding
epriestley awarded D16474: Fix the feed line items for autodetect paste languages a Dat Boi token.
Aug 30 2016, 6:27 PM
jcox updated the diff for D16474: Fix the feed line items for autodetect paste languages.

Rename weirdly named function

Aug 30 2016, 6:25 PM
jcox created T11563: Provide a way to get all diffs associated with tasks from the API.
Aug 30 2016, 6:12 PM · Restricted Project, Conduit
jcox retitled D16474: Fix the feed line items for autodetect paste languages from to Fix the feed line items for autodetect paste languages.
Aug 30 2016, 6:02 PM
jcox added a revision to T11555: Paste highlighting caches don't take name into account, but should: D16474: Fix the feed line items for autodetect paste languages.
Aug 30 2016, 6:02 PM · Paste, Contributor Onboarding
jcox added a comment to T11555: Paste highlighting caches don't take name into account, but should.

Found some shorter repro steps:

Aug 30 2016, 5:00 PM · Paste, Contributor Onboarding
jcox added a comment to T10679: When phurl.short-uri is configured, use it in the UI.

Ahh okay. I understand now. That did indeed happen automatically.

Aug 30 2016, 4:44 PM · Contributor Onboarding, Restricted Project, Phurl
jcox added a revision to T10679: When phurl.short-uri is configured, use it in the UI: D16473: Start actually showing the phurl urls to users.
Aug 30 2016, 4:42 PM · Contributor Onboarding, Restricted Project, Phurl
jcox updated D16473: Start actually showing the phurl urls to users.
Aug 30 2016, 4:42 PM
jcox retitled D16473: Start actually showing the phurl urls to users from to Start actually showing the phurl urls to users.
Aug 30 2016, 4:41 PM
jcox added a comment to T10679: When phurl.short-uri is configured, use it in the UI.

Also the ((alias)) syntax should use the most-preferred URI, although I think that will happen automatically.

Aug 30 2016, 4:37 PM · Contributor Onboarding, Restricted Project, Phurl
jcox added a comment to T10679: When phurl.short-uri is configured, use it in the UI.

Also, are prototype applications enabled (phabricator.show-prototypes)? If not, Phurl won't actually be installed.

Aug 30 2016, 2:55 PM · Contributor Onboarding, Restricted Project, Phurl
jcox added a comment to T10679: When phurl.short-uri is configured, use it in the UI.

Oh I left out the fact that I had already configured phurl.short-uri but still get the "Site Not Found" message.

Aug 30 2016, 2:52 PM · Contributor Onboarding, Restricted Project, Phurl
jcox added a comment to T10679: When phurl.short-uri is configured, use it in the UI.

Just want to sanity check this before I continue. I set the ServerAlias and started getting this page when visiting short.url.com:

Aug 30 2016, 2:48 PM · Contributor Onboarding, Restricted Project, Phurl
jcox committed rPf2f896c761a2: Removed all instances of getIconURI (authored by jcox).
Removed all instances of getIconURI
Aug 30 2016, 2:11 PM
jcox closed D16470: Removed all instances of getIconURI by committing rPf2f896c761a2: Removed all instances of getIconURI.
Aug 30 2016, 2:11 PM
jcox closed T11541: Remove getIconURI() from PhabricatorApplication as Resolved by committing rPf2f896c761a2: Removed all instances of getIconURI.
Aug 30 2016, 2:11 PM · Contributor Onboarding, Infrastructure, Design