HomePhabricator

Added `-` to the whitelist for CSS rules

Description

Added - to the whitelist for CSS rules

Summary: Fixes T11567. This way people can use things like sans-serif and -webkit-small-control for their "monospaced" font

Test Plan:
I added the hyphen to the regex then was able to set my Monospaced Font to be anything with a hyphen in it.

I also tried to break it pretty extensively, but couldn't find anything that would let me write malicious CSS or JS.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: epriestley, yelirekim

Maniphest Tasks: T11567

Differential Revision: https://secure.phabricator.com/D16519

Details

Provenance
jcoxAuthored on Sep 8 2016, 3:29 AM
jcoxPushed on Sep 8 2016, 8:29 PM
Reviewer
Blessed Reviewers
Differential Revision
D16519: Added `-` to the whitelist for CSS rules
Parents
rP0030bda17ea3: Check if app is installed for user before displying
Branches
Unknown
Tags
Unknown
Tasks
T11567: Allow dashes in monospace font preferences
Build Status
Buildable 13640
Build 17580: Run Core Tests