Page MenuHomePhabricator

Removed willProcessRequest from DifferentialRevisionLandController
ClosedPublic

Authored by jcox on Sep 19 2016, 1:19 PM.

Details

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jcox updated this revision to Diff 39884.Sep 19 2016, 1:19 PM
jcox retitled this revision from to Removed willProcessRequest from DifferentialRevisionLandController.
jcox updated this object.
jcox edited the test plan for this revision. (Show Details)
jcox edited the test plan for this revision. (Show Details)Sep 19 2016, 1:50 PM
jcox edited edge metadata.
epriestley accepted this revision.Sep 19 2016, 5:08 PM
epriestley added a reviewer: epriestley.

This code isn't actually reachable ("Land Revision" in the web UI uses DifferentialRevisionOperationController, not this one) but it's being retained purely for backward compatibility until "Land Revision" has a better story on auth-to-GitHub stuff which this older thing technically sort-of supports.

This revision is now accepted and ready to land.Sep 19 2016, 5:08 PM
jcox added a comment.Sep 19 2016, 5:23 PM

ah gotcha. Should I land this anyway or just leave it be?

Just land it, if this somehow breaks things (unlikely) this code was slated for removal anyway.

jcox updated this revision to Diff 39889.Sep 19 2016, 5:47 PM
jcox edited edge metadata.

Rebase

This revision was automatically updated to reflect the committed changes.