Page MenuHomePhabricator
Feed Advanced Search

Dec 10 2018

epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: D19858: Share more inline "Done" code between Differential and Diffusion.
Dec 10 2018, 6:40 PM · Plans
epriestley committed rPbf6c534b567a: Give "Track Only" repository detail proper getters/setters (authored by epriestley).
Give "Track Only" repository detail proper getters/setters
Dec 10 2018, 6:22 PM
epriestley closed D19857: Give "Track Only" repository detail proper getters/setters.
Dec 10 2018, 6:22 PM
epriestley committed rPc3206476a303: Give "Autoclose Only" repository detail proper getters/setters (authored by epriestley).
Give "Autoclose Only" repository detail proper getters/setters
Dec 10 2018, 6:22 PM
epriestley closed D19856: Give "Autoclose Only" repository detail proper getters/setters.
Dec 10 2018, 6:22 PM
epriestley updated the task description for T13222: 2018 Week 48-51 Bonus Content.
Dec 10 2018, 4:09 PM · Plans
epriestley added a comment to T13222: 2018 Week 48-51 Bonus Content.

See D19829 for a followup change: getDetail()/setDetail() should be more-private APIs than they are today, and callers elsewhere (like transaction logic) should use methods like getEncoding(), not getDetail('encoding').

Dec 10 2018, 4:09 PM · Plans
epriestley requested review of D19857: Give "Track Only" repository detail proper getters/setters.
Dec 10 2018, 4:08 PM
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: D19857: Give "Track Only" repository detail proper getters/setters.
Dec 10 2018, 4:06 PM · Plans
epriestley requested review of D19856: Give "Autoclose Only" repository detail proper getters/setters.
Dec 10 2018, 3:52 PM
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: D19856: Give "Autoclose Only" repository detail proper getters/setters.
Dec 10 2018, 3:51 PM · Plans
epriestley updated the task description for T13222: 2018 Week 48-51 Bonus Content.
Dec 10 2018, 2:20 PM · Plans
epriestley updated the task description for T13222: 2018 Week 48-51 Bonus Content.
Dec 10 2018, 2:20 PM · Plans
epriestley renamed T13222: 2018 Week 48-51 Bonus Content from 2018 Week 48-49 Bonus Content to 2018 Week 48-50 Bonus Content.
Dec 10 2018, 2:20 PM · Plans
epriestley edited the content of Changelog.
Dec 10 2018, 12:55 AM
epriestley committed rPHU414a4c6abb1b: (stable) Promote 2018 Week 49 (authored by epriestley).
(stable) Promote 2018 Week 49
Dec 10 2018, 12:54 AM
epriestley committed rP237a2a190984: (stable) Promote 2018 Week 49 (authored by epriestley).
(stable) Promote 2018 Week 49
Dec 10 2018, 12:54 AM
epriestley created 2018 Week 49 (Early December).
Dec 10 2018, 12:54 AM
epriestley committed rP1a6a0181a898: Allow "bin/repository thaw --demote" to demote an entire service, not just a… (authored by epriestley).
Allow "bin/repository thaw --demote" to demote an entire service, not just a…
Dec 10 2018, 12:46 AM
epriestley closed D19850: Allow "bin/repository thaw --demote" to demote an entire service, not just a single device.
Dec 10 2018, 12:46 AM
epriestley committed rPbba418600591: Allow "bin/repository thaw" to accept "--all-repositories" instead of a list of… (authored by epriestley).
Allow "bin/repository thaw" to accept "--all-repositories" instead of a list of…
Dec 10 2018, 12:42 AM
epriestley closed D19849: Allow "bin/repository thaw" to accept "--all-repositories" instead of a list of repositories.
Dec 10 2018, 12:42 AM
epriestley committed rP1e4bdc39a11b: Add an "availaiblity" attachment for user.search (authored by epriestley).
Add an "availaiblity" attachment for user.search
Dec 10 2018, 12:41 AM
epriestley closed D19851: Add an "availaiblity" attachment for user.search.
Dec 10 2018, 12:41 AM
epriestley committed rP1029081b2805: Correct two straggling "%Q" + "implode(...)" callsites in Revision updates (authored by epriestley).
Correct two straggling "%Q" + "implode(...)" callsites in Revision updates
Dec 10 2018, 12:40 AM
epriestley closed D19846: Correct two straggling "%Q" + "implode(...)" callsites in Revision updates.
Dec 10 2018, 12:40 AM
epriestley committed rPb88a87c43a28: Address a transaction issue with some audit actions not applying correctly (authored by epriestley).
Address a transaction issue with some audit actions not applying correctly
Dec 10 2018, 12:39 AM
epriestley closed D19845: Address a transaction issue with some audit actions not applying correctly.
Dec 10 2018, 12:39 AM
epriestley committed rPf0eefdd0b58b: Replace the informal "array" subtype map with a more formal "SubtypeMap" object (authored by epriestley).
Replace the informal "array" subtype map with a more formal "SubtypeMap" object
Dec 10 2018, 12:37 AM
epriestley closed D19852: Replace the informal "array" subtype map with a more formal "SubtypeMap" object.
Dec 10 2018, 12:37 AM

Dec 7 2018

epriestley added a comment to T13224: Pygments Bash lexer has explosive complexity on unterminated strings with many backslashes.

Ah, thanks! Yeah, that looks like the same thing. I think the bug title isn't quite correct (runtime is dramatically worse than O(input), but not infinite) and the analysis is slightly misleading (escaping the $ doesn't matter, I think) but the patch looks like it will get the job done (although, offhand, I'm unsure about the ($|(?=")|(?=\$) groups).

Dec 7 2018, 4:31 PM · Infrastructure
epriestley updated the diff for D19855: Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you click" sort of UI.
  • Remove some great but ultimately unnecessary debugging code.
Dec 7 2018, 2:23 PM
epriestley added inline comments to D19855: Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you click" sort of UI.
Dec 7 2018, 2:21 PM
epriestley updated the summary of D19855: Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you click" sort of UI.
Dec 7 2018, 2:18 PM
epriestley updated the summary of D19855: Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you click" sort of UI.
Dec 7 2018, 2:17 PM
epriestley requested review of D19855: Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you click" sort of UI.
Dec 7 2018, 2:17 PM
epriestley added a revision to T12588: create subtask side menu to allow creation of subtasks of different types to the parent task: D19855: Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you click" sort of UI.
Dec 7 2018, 2:15 PM · Feature Request
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: D19855: Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you click" sort of UI.
Dec 7 2018, 2:15 PM · Plans

Dec 6 2018

epriestley created E1691: Path of Exile: Betrayal.
Dec 6 2018, 10:20 PM
epriestley requested review of D19854: Allow "maniphest.subtypes" to configure which options are presented by "Create Subtask".
Dec 6 2018, 7:56 PM
epriestley added a revision to T12588: create subtask side menu to allow creation of subtasks of different types to the parent task: D19854: Allow "maniphest.subtypes" to configure which options are presented by "Create Subtask".
Dec 6 2018, 7:55 PM · Feature Request
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: D19854: Allow "maniphest.subtypes" to configure which options are presented by "Create Subtask".
Dec 6 2018, 7:55 PM · Plans
epriestley requested review of D19853: Allow the "Create Subtask" workflow to prompt for a subtype selection, and prepare for customizable options.
Dec 6 2018, 7:11 PM
epriestley added a revision to T12588: create subtask side menu to allow creation of subtasks of different types to the parent task: D19853: Allow the "Create Subtask" workflow to prompt for a subtype selection, and prepare for customizable options.
Dec 6 2018, 7:09 PM · Feature Request
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: D19853: Allow the "Create Subtask" workflow to prompt for a subtype selection, and prepare for customizable options.
Dec 6 2018, 7:09 PM · Plans
epriestley added a revision to T12588: create subtask side menu to allow creation of subtasks of different types to the parent task: D19852: Replace the informal "array" subtype map with a more formal "SubtypeMap" object.
Dec 6 2018, 6:59 PM · Feature Request
epriestley updated the summary of D19852: Replace the informal "array" subtype map with a more formal "SubtypeMap" object.
Dec 6 2018, 6:59 PM
epriestley requested review of D19852: Replace the informal "array" subtype map with a more formal "SubtypeMap" object.
Dec 6 2018, 4:17 PM
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: D19852: Replace the informal "array" subtype map with a more formal "SubtypeMap" object.
Dec 6 2018, 4:15 PM · Plans
epriestley committed rP5d54f26daca8: Support reading and querying Almanac service PHIDs via "diffusion.repository. (authored by epriestley).
Support reading and querying Almanac service PHIDs via "diffusion.repository.
Dec 6 2018, 3:46 PM
epriestley closed D19848: Support reading and querying Almanac service PHIDs via "diffusion.repository.search".
Dec 6 2018, 3:46 PM
epriestley committed rPHU1e590fd9e58e: Prevent Pygments from flying off the rails too aggressively (authored by epriestley).
Prevent Pygments from flying off the rails too aggressively
Dec 6 2018, 3:46 PM
epriestley closed D19847: Prevent Pygments from flying off the rails too aggressively.
Dec 6 2018, 3:46 PM

Dec 5 2018

epriestley updated the task description for T13222: 2018 Week 48-51 Bonus Content.
Dec 5 2018, 9:32 PM · Plans
epriestley updated the diff for D19851: Add an "availaiblity" attachment for user.search.
  • Return an explicit "available", not null, for available users.
Dec 5 2018, 8:51 PM
epriestley requested review of D19851: Add an "availaiblity" attachment for user.search.
Dec 5 2018, 8:49 PM
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: D19851: Add an "availaiblity" attachment for user.search.
Dec 5 2018, 8:48 PM · Plans
epriestley updated the task description for T13222: 2018 Week 48-51 Bonus Content.
Dec 5 2018, 8:36 PM · Plans
epriestley updated the diff for D19850: Allow "bin/repository thaw --demote" to demote an entire service, not just a single device.
  • Mention these flags in the documentation.
Dec 5 2018, 8:31 PM
epriestley requested review of D19850: Allow "bin/repository thaw --demote" to demote an entire service, not just a single device.
Dec 5 2018, 8:26 PM
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: D19850: Allow "bin/repository thaw --demote" to demote an entire service, not just a single device.
Dec 5 2018, 8:24 PM · Plans
epriestley requested review of D19849: Allow "bin/repository thaw" to accept "--all-repositories" instead of a list of repositories.
Dec 5 2018, 8:00 PM
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: D19849: Allow "bin/repository thaw" to accept "--all-repositories" instead of a list of repositories.
Dec 5 2018, 7:58 PM · Plans
epriestley requested review of D19848: Support reading and querying Almanac service PHIDs via "diffusion.repository.search".
Dec 5 2018, 7:38 PM
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: D19848: Support reading and querying Almanac service PHIDs via "diffusion.repository.search".
Dec 5 2018, 7:37 PM · Plans
epriestley committed rP70bf63bc3adc: Fix a transaction editor "continue;" inside "switch()" for PHP 7.3 (authored by epriestley).
Fix a transaction editor "continue;" inside "switch()" for PHP 7.3
Dec 5 2018, 7:26 PM
epriestley closed D19844: Fix a transaction editor "continue;" inside "switch()" for PHP 7.3.
Dec 5 2018, 7:26 PM
epriestley requested review of D19847: Prevent Pygments from flying off the rails too aggressively.
Dec 5 2018, 7:15 PM
epriestley added a revision to T13224: Pygments Bash lexer has explosive complexity on unterminated strings with many backslashes: D19847: Prevent Pygments from flying off the rails too aggressively.
Dec 5 2018, 7:15 PM · Infrastructure
epriestley requested review of D19846: Correct two straggling "%Q" + "implode(...)" callsites in Revision updates.
Dec 5 2018, 2:16 PM
epriestley added a comment to D19845: Address a transaction issue with some audit actions not applying correctly.

I noted the immediate change which exposed this on D19842, for spelunking purposes.

Dec 5 2018, 2:03 PM
epriestley added inline comments to D19842: Allow "Change Subtype" to be selected from the comment action stack.
Dec 5 2018, 2:01 PM
epriestley requested review of D19845: Address a transaction issue with some audit actions not applying correctly.
Dec 5 2018, 1:59 PM

Dec 4 2018

epriestley requested review of D19844: Fix a transaction editor "continue;" inside "switch()" for PHP 7.3.
Dec 4 2018, 1:55 PM
epriestley added a comment to T784: Allow Differential changesets to be marked with various attributes.

Mostly, there's just relatively little interest from paying customers right now. PHI64, PHI675, PHI723 and PHI985 are all somewhat interested, but they're generally low-priority / "nice-to-have" sorts of requests, or this is a tangential or supplemental approach that might help with some other problem the request focuses on. Since there's limited customer interest, this isn't a very high priority right now.

Dec 4 2018, 1:48 PM · Restricted Project, Restricted Project, Restricted Project, Differential, Arcanist

Dec 3 2018

epriestley edited the content of Changelog.
Dec 3 2018, 6:57 PM
epriestley committed rP8ef2f4086ee3: (stable) Promote 2018 Week 48 (authored by epriestley).
(stable) Promote 2018 Week 48
Dec 3 2018, 6:56 PM
epriestley committed rPHU2a2d4fce881e: (stable) Promote 2018 Week 48 (authored by epriestley).
(stable) Promote 2018 Week 48
Dec 3 2018, 6:56 PM
epriestley created 2018 Week 48 (Very Early December).
Dec 3 2018, 6:55 PM
epriestley updated the task description for T13083: Plans: Portals and Facts.
Dec 3 2018, 6:11 PM · Plans, Facts, Dashboards
epriestley updated the task description for T13222: 2018 Week 48-51 Bonus Content.
Dec 3 2018, 6:07 PM · Plans
epriestley renamed T13222: 2018 Week 48-51 Bonus Content from 2018 Week 48 Bonus Content to 2018 Week 48-49 Bonus Content.
Dec 3 2018, 5:48 PM · Plans
epriestley added a comment to rP1d0b99e1f834: Allow applications to require a High Security token without doing a session….

not a good choice in authentication flows, but just fine when we are talking about these use-cases – and I doubt you would ever allow it to be implement as such

Dec 3 2018, 5:17 PM
epriestley added a comment to rP1d0b99e1f834: Allow applications to require a High Security token without doing a session….

(If you missed it, see also some discussion in D19843.)

Dec 3 2018, 4:23 PM

Nov 30 2018

epriestley triaged T13224: Pygments Bash lexer has explosive complexity on unterminated strings with many backslashes as Low priority.
Nov 30 2018, 6:53 PM · Infrastructure

Nov 29 2018

epriestley updated the task description for T13222: 2018 Week 48-51 Bonus Content.
Nov 29 2018, 6:41 PM · Plans
epriestley added a comment to T4863: Allow Workboard Cards to be customized for display.

This isn't an actionable task. It covers too much ground, describes too many features, and most of it lacks compelling use cases.

Nov 29 2018, 4:46 PM · Projects, Wikimedia, Workboards
epriestley closed T13221: Consider more careful cleanup of very old Repository transactions? as Wontfix.

I don't expect we'll need to do anything here, mostly just wanted to be able to dig up a list of these if something does come up.

Nov 29 2018, 4:11 PM · Diffusion

Nov 28 2018

epriestley committed rP9bfe558587aa: Add a "touched paths" limit to repositories, limiting the maximum number of… (authored by epriestley).
Add a "touched paths" limit to repositories, limiting the maximum number of…
Nov 28 2018, 10:37 PM
epriestley closed D19839: Add a "touched paths" limit to repositories, limiting the maximum number of paths any commit may touch.
Nov 28 2018, 10:37 PM
epriestley committed rPc86c5749bafb: Make the repository "Filesize Limit" and "Clone/Fetch Timeout" configurable in… (authored by epriestley).
Make the repository "Filesize Limit" and "Clone/Fetch Timeout" configurable in…
Nov 28 2018, 10:34 PM
epriestley closed D19831: Make the repository "Filesize Limit" and "Clone/Fetch Timeout" configurable in the UI.
Nov 28 2018, 10:34 PM
epriestley committed rPc6fc05ee0941: Pull Git filesize logic into a separate LowLevel query and use more Iterators (authored by epriestley).
Pull Git filesize logic into a separate LowLevel query and use more Iterators
Nov 28 2018, 10:33 PM
epriestley closed D19830: Pull Git filesize logic into a separate LowLevel query and use more Iterators.
Nov 28 2018, 10:33 PM
epriestley committed rPfd12b37d16f6: Modularize Repository transactions (authored by epriestley).
Modularize Repository transactions
Nov 28 2018, 10:29 PM
epriestley closed D19829: Modularize Repository transactions.
Nov 28 2018, 10:29 PM
epriestley updated the task description for T13222: 2018 Week 48-51 Bonus Content.
Nov 28 2018, 10:04 PM · Plans
epriestley updated the diff for D19829: Modularize Repository transactions.
  • Better spelling/consistency.
  • I agree on the getDetail() inlines, but think getX/setX is probably the better way to make them consistent and that should probably be a separate change and get proper testing. I'll note and revisit this.
Nov 28 2018, 10:03 PM
epriestley committed rPc25d2a399d68: Separate the repository management UI into sections (authored by epriestley).
Separate the repository management UI into sections
Nov 28 2018, 9:53 PM
epriestley closed D19827: Separate the repository management UI into sections.
Nov 28 2018, 9:53 PM