Page MenuHomePhabricator
Differential D19856

Give "Autoclose Only" repository detail proper getters/setters
ClosedPublic
Actions

Authored by epriestley on Dec 10 2018, 3:50 PM.
Tags
None
Referenced Files
F15520960: D19856.diff
Sun, Apr 20, 9:43 AM
F15510235: D19856.id47417.diff
Wed, Apr 16, 7:21 PM
F15507232: D19856.diff
Tue, Apr 15, 5:43 PM
F15430196: D19856.id.diff
Mar 24 2025, 6:26 AM
F15429210: D19856.diff
Mar 24 2025, 1:11 AM
F15382703: D19856.id47417.diff
Mar 14 2025, 1:59 PM
F15308940: D19856.id47419.diff
Mar 6 2025, 6:46 AM
F15308938: D19856.id47417.diff
Mar 6 2025, 6:46 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13222: 2018 Week 48-51 Bonus Content
Commits
rPc3206476a303: Give "Autoclose Only" repository detail proper getters/setters
Summary

Ref T13222. See D19829. We're inconsistent about using getDetail()/setDetail() to do some ad-hoc reads. Put this stuff in proper accessor methods.

Also a couple of text fixes from D19850.

Test Plan

Set, edited, and removed autoclose branches from a repository. Got sensible persistence and rendering behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 47419

View Options

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementThawWorkflow.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/xaction/PhabricatorRepositoryAutocloseOnlyTransaction.php

Loading...
Phabricator · Built by Phacility