Page MenuHomePhabricator
Differential D19856

Give "Autoclose Only" repository detail proper getters/setters
ClosedPublic
Actions

Authored by epriestley on Dec 10 2018, 3:50 PM.
Tags
None
Referenced Files
F18651705: D19856.id47417.diff
Sun, Sep 21, 5:06 AM
F18645556: D19856.diff
Fri, Sep 19, 8:04 AM
F18586497: D19856.diff
Thu, Sep 11, 6:49 PM
F18586486: D19856.diff
Thu, Sep 11, 6:47 PM
F18586460: D19856.diff
Thu, Sep 11, 6:41 PM
F18586431: D19856.diff
Thu, Sep 11, 6:35 PM
F18545807: D19856.id47419.diff
Mon, Sep 8, 3:15 AM
F18545806: D19856.id47417.diff
Mon, Sep 8, 3:15 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13222: 2018 Week 48-51 Bonus Content
Commits
rPc3206476a303: Give "Autoclose Only" repository detail proper getters/setters
Summary

Ref T13222. See D19829. We're inconsistent about using getDetail()/setDetail() to do some ad-hoc reads. Put this stuff in proper accessor methods.

Also a couple of text fixes from D19850.

Test Plan

Set, edited, and removed autoclose branches from a repository. Got sensible persistence and rendering behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 47419

View Options

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementThawWorkflow.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/xaction/PhabricatorRepositoryAutocloseOnlyTransaction.php

Loading...
Phabricator · Built by Phacility