Page MenuHomePhabricator
Differential D19856

Give "Autoclose Only" repository detail proper getters/setters
ClosedPublic
Actions

Authored by epriestley on Dec 10 2018, 3:50 PM.
Tags
None
Referenced Files
F19002064: D19856.id.diff
Nov 21 2025, 4:45 AM
F18872159: D19856.diff
Nov 5 2025, 2:35 AM
F18855292: D19856.id47417.diff
Nov 1 2025, 4:47 AM
F18817245: D19856.diff
Oct 21 2025, 1:48 PM
F18770212: D19856.diff
Oct 8 2025, 11:22 AM
F18651705: D19856.id47417.diff
Sep 21 2025, 5:06 AM
F18645556: D19856.diff
Sep 19 2025, 8:04 AM
F18586497: D19856.diff
Sep 11 2025, 6:49 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13222: 2018 Week 48-51 Bonus Content
Commits
rPc3206476a303: Give "Autoclose Only" repository detail proper getters/setters
Summary

Ref T13222. See D19829. We're inconsistent about using getDetail()/setDetail() to do some ad-hoc reads. Put this stuff in proper accessor methods.

Also a couple of text fixes from D19850.

Test Plan

Set, edited, and removed autoclose branches from a repository. Got sensible persistence and rendering behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 47419

View Options

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementThawWorkflow.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/xaction/PhabricatorRepositoryAutocloseOnlyTransaction.php

Loading...
Phabricator · Built by Phacility