Page MenuHomePhabricator

Pull Git filesize logic into a separate LowLevel query and use more Iterators
ClosedPublic

Authored by epriestley on Thu, Nov 22, 12:22 AM.

Details

Summary

Depends on D19829. Ref T13216. See PHI908. The current implementation is kind of a lot to live in CommitHookEngine and will likely fail if git diff-tree produces more than 2GB of output.

Pull it out and make it slightly more robust against enormous commits. It's probably limited by this, now:

implode("\n", $every_path)

We could replace that with some PhutilReverseRopeSource primitive or something but since we don't have one of those and it seems unlikely that we'll hit this case in practice, I left it here for now with just the easy stuff converted to be stream-oriented.

Test Plan

Used this script to test the query against various commits, got good results:

<?php

require_once 'scripts/init/init-script.php';

$viewer = PhabricatorUser::getOmnipotentUser();

$repository = id(new PhabricatorRepositoryQuery())
  ->setViewer($viewer)
  ->withCallsigns(array('P'))
  ->executeOne();

var_dump(
  id(new DiffusionLowLevelFilesizeQuery())
    ->setRepository($repository)
    ->withIdentifier($argv[1])
    ->execute());

Used this to find large commits in history and pull filesizes (worked great, although our largest commit only touches a couple thousand paths):

for hash in `git log --format=%H`; do echo -n $hash; echo -n ' '; git diff-tree -r --no-commit-id $hash | wc -l | awk '{print $1}'; done | awk '{print $2 " " $1}' | sort -n

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Nov 22, 12:22 AM
epriestley requested review of this revision.Thu, Nov 22, 12:24 AM
amckinley accepted this revision.Mon, Nov 26, 5:35 PM
This revision is now accepted and ready to land.Mon, Nov 26, 5:35 PM
This revision was automatically updated to reflect the committed changes.