Page MenuHomePhabricator

Replace the informal "array" subtype map with a more formal "SubtypeMap" object
ClosedPublic

Authored by epriestley on Dec 6 2018, 4:15 PM.
Tags
None
Referenced Files
F15538339: D19852.id47406.diff
Thu, Apr 24, 6:41 PM
F15506236: D19852.id47406.diff
Tue, Apr 15, 9:40 AM
F15495572: D19852.id.diff
Sun, Apr 13, 5:03 AM
F15492695: D19852.diff
Sat, Apr 12, 5:18 PM
F15478233: D19852.id.diff
Apr 7 2025, 9:22 PM
F15451777: D19852.diff
Mar 28 2025, 11:44 PM
F15443281: D19852.diff
Mar 27 2025, 3:29 AM
F15397140: D19852.diff
Mar 16 2025, 6:24 PM
Subscribers
None

Details

Summary

Ref T13222. Ref T12588. See PHI683. To make "Create Subtask..." fancier, we need slightly more logic around subtype maps. Upgrade the plain old array into a proper object so it can have relevant methods, notably "get a list of valid child subtypes for some parent subtype".

Test Plan

Created and edited tasks, changed task subtypes. Grepped for affected symbols (newEditEngineSubtypeMap, newSubtypeMap).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable