Page MenuHomePhabricator

Replace the informal "array" subtype map with a more formal "SubtypeMap" object
ClosedPublic

Authored by epriestley on Dec 6 2018, 4:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 1, 4:57 AM
Unknown Object (File)
Tue, Jun 7, 5:14 PM
Unknown Object (File)
May 29 2022, 4:02 PM
Unknown Object (File)
May 27 2022, 7:03 PM
Unknown Object (File)
May 27 2022, 10:42 AM
Unknown Object (File)
May 25 2022, 12:26 PM
Unknown Object (File)
May 25 2022, 5:01 AM
Unknown Object (File)
May 24 2022, 9:46 AM
Subscribers
None

Details

Summary

Ref T13222. Ref T12588. See PHI683. To make "Create Subtask..." fancier, we need slightly more logic around subtype maps. Upgrade the plain old array into a proper object so it can have relevant methods, notably "get a list of valid child subtypes for some parent subtype".

Test Plan

Created and edited tasks, changed task subtypes. Grepped for affected symbols (newEditEngineSubtypeMap, newSubtypeMap).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable