Page MenuHomePhabricator

Replace the informal "array" subtype map with a more formal "SubtypeMap" object
ClosedPublic

Authored by epriestley on Dec 6 2018, 4:15 PM.
Tags
None
Referenced Files
F17867067: D19852.id.diff
Mon, Jul 28, 5:19 AM
F17838782: D19852.diff
Sat, Jul 26, 7:06 PM
Unknown Object (File)
Jun 19 2025, 11:08 PM
Unknown Object (File)
Jun 19 2025, 11:07 PM
Unknown Object (File)
Jun 19 2025, 11:07 PM
Unknown Object (File)
Jun 19 2025, 11:07 PM
Unknown Object (File)
Jun 17 2025, 11:24 AM
Unknown Object (File)
Jun 2 2025, 2:12 PM
Subscribers
None

Details

Summary

Ref T13222. Ref T12588. See PHI683. To make "Create Subtask..." fancier, we need slightly more logic around subtype maps. Upgrade the plain old array into a proper object so it can have relevant methods, notably "get a list of valid child subtypes for some parent subtype".

Test Plan

Created and edited tasks, changed task subtypes. Grepped for affected symbols (newEditEngineSubtypeMap, newSubtypeMap).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable