Differential D19852

Replace the informal "array" subtype map with a more formal "SubtypeMap" object
ClosedPublic
Actions

Authored by epriestley on Dec 6 2018, 4:15 PM.

Details

Reviewers

Maniphest Tasks

T12588: create subtask side menu to allow creation of subtasks of different types to the parent task
T13222: 2018 Week 48-51 Bonus Content

Commits

rPf0eefdd0b58b: Replace the informal "array" subtype map with a more formal "SubtypeMap" object

Summary

Ref T13222. Ref T12588. See PHI683. To make "Create Subtask..." fancier, we need slightly more logic around subtype maps. Upgrade the plain old array into a proper object so it can have relevant methods, notably "get a list of valid child subtypes for some parent subtype".

Test Plan

Created and edited tasks, changed task subtypes. Grepped for affected symbols (newEditEngineSubtypeMap, newSubtypeMap).

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Dec 6 2018, 4:15 PM

Harbormaster completed remote builds in B21257: Diff 47406.Dec 6 2018, 4:17 PM

epriestley requested review of this revision.Dec 6 2018, 4:17 PM

epriestley edited the summary of this revision. (Show Details)Dec 6 2018, 6:59 PM

epriestley added a task: T12588: create subtask side menu to allow creation of subtasks of different types to the parent task.

amckinley accepted this revision.Dec 8 2018, 12:02 AM

This revision is now accepted and ready to land.Dec 8 2018, 12:02 AM

Closed by commit rPf0eefdd0b58b: Replace the informal "array" subtype map with a more formal "SubtypeMap" object (authored by epriestley). · Explain WhyDec 10 2018, 12:37 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/__phutil_library_map__.php (2 lines)
M		src/applications/maniphest/query/ManiphestTaskSearchEngine.php (2 lines)
M		src/applications/maniphest/storage/ManiphestTask.php (2 lines)
M		src/applications/maniphest/storage/ManiphestTransaction.php (5 lines)
M		src/applications/maniphest/typeahead/ManiphestTaskSubtypeDatasource.php (2 lines)
M		src/applications/maniphest/view/ManiphestTaskListView.php (3 lines)
M		src/applications/transactions/controller/PhabricatorEditEngineConfigurationSubtypeController.php (3 lines)
M		src/applications/transactions/editengine/PhabricatorEditEngineSubtype.php (2 lines)
A	M	src/applications/transactions/editengine/PhabricatorEditEngineSubtypeMap.php (42 lines)
M		src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php (2 lines)
M		src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditor.php (2 lines)
M		src/applications/transactions/engineextension/PhabricatorSubtypeEditEngineExtension.php (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	47406	5d54f26		Dec 6 2018, 4:15 PM	★	★
Diff 2	47411	5d54f26	rPf0eefdd0b58b8f2a859637d3f1faeae50c60af09	Dec 10 2018, 12:37 AM	★	★

Diff 47411

View Options

src/__phutil_library_map__.php

View Options

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

View Options

src/applications/maniphest/storage/ManiphestTask.php

View Options

src/applications/maniphest/storage/ManiphestTransaction.php

View Options

src/applications/maniphest/typeahead/ManiphestTaskSubtypeDatasource.php

View Options

src/applications/maniphest/view/ManiphestTaskListView.php

View Options

src/applications/transactions/controller/PhabricatorEditEngineConfigurationSubtypeController.php

View Options

src/applications/transactions/editengine/PhabricatorEditEngineSubtype.php

View Options

src/applications/transactions/editengine/PhabricatorEditEngineSubtypeMap.php

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

View Options

src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditor.php

View Options

src/applications/transactions/engineextension/PhabricatorSubtypeEditEngineExtension.php

Replace the informal "array" subtype map with a more formal "SubtypeMap" objectClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47411

src/__phutil_library_map__.php

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

src/applications/maniphest/storage/ManiphestTask.php

src/applications/maniphest/storage/ManiphestTransaction.php

src/applications/maniphest/typeahead/ManiphestTaskSubtypeDatasource.php

src/applications/maniphest/view/ManiphestTaskListView.php

src/applications/transactions/controller/PhabricatorEditEngineConfigurationSubtypeController.php

src/applications/transactions/editengine/PhabricatorEditEngineSubtype.php

src/applications/transactions/editengine/PhabricatorEditEngineSubtypeMap.php

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditor.php

src/applications/transactions/engineextension/PhabricatorSubtypeEditEngineExtension.php

Replace the informal "array" subtype map with a more formal "SubtypeMap" object
ClosedPublic
Actions

Revision Contents
Changeset List