Page MenuHomePhabricator

Replace the informal "array" subtype map with a more formal "SubtypeMap" object
ClosedPublic

Authored by epriestley on Thu, Dec 6, 4:15 PM.

Details

Summary

Ref T13222. Ref T12588. See PHI683. To make "Create Subtask..." fancier, we need slightly more logic around subtype maps. Upgrade the plain old array into a proper object so it can have relevant methods, notably "get a list of valid child subtypes for some parent subtype".

Test Plan

Created and edited tasks, changed task subtypes. Grepped for affected symbols (newEditEngineSubtypeMap, newSubtypeMap).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Dec 6, 4:15 PM
epriestley requested review of this revision.Thu, Dec 6, 4:17 PM
amckinley accepted this revision.Sat, Dec 8, 12:02 AM
This revision is now accepted and ready to land.Sat, Dec 8, 12:02 AM
This revision was automatically updated to reflect the committed changes.