Page MenuHomePhabricator

Correct two straggling "%Q" + "implode(...)" callsites in Revision updates
ClosedPublic

Authored by epriestley on Dec 5 2018, 2:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 10, 11:50 AM
Unknown Object (File)
Jan 10 2024, 10:16 AM
Unknown Object (File)
Dec 30 2023, 2:14 AM
Unknown Object (File)
Dec 22 2023, 9:55 PM
Unknown Object (File)
Dec 20 2023, 11:28 PM
Unknown Object (File)
Dec 19 2023, 12:44 PM
Unknown Object (File)
Dec 19 2023, 12:12 PM
Unknown Object (File)
Dec 17 2023, 2:05 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/error-seems-to-be-related-with-da40f8074-and-php-7-3/2102/12. When creating or updating revisions, we do some manual query construction to update the affected path table.

Update these queries to modern qsprintf().

Test Plan

Created and updated revisions affecting paths, no more logs in the webserver log.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable