Page MenuHomePhabricator

Correct two straggling "%Q" + "implode(...)" callsites in Revision updates
ClosedPublic

Authored by epriestley on Dec 5 2018, 2:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 20, 4:28 AM
Unknown Object (File)
May 20 2025, 10:03 AM
Unknown Object (File)
May 10 2025, 12:37 PM
Unknown Object (File)
Apr 24 2025, 4:21 PM
Unknown Object (File)
Apr 20 2025, 3:44 AM
Unknown Object (File)
Apr 16 2025, 9:08 PM
Unknown Object (File)
Apr 15 2025, 4:08 AM
Unknown Object (File)
Apr 11 2025, 3:10 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/error-seems-to-be-related-with-da40f8074-and-php-7-3/2102/12. When creating or updating revisions, we do some manual query construction to update the affected path table.

Update these queries to modern qsprintf().

Test Plan

Created and updated revisions affecting paths, no more logs in the webserver log.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable