Page MenuHomePhabricator
Differential D19846

Correct two straggling "%Q" + "implode(...)" callsites in Revision updates
ClosedPublic
Actions

Authored by epriestley on Dec 5 2018, 2:14 PM.

Details

Reviewers
amckinley
Commits
rP1029081b2805: Correct two straggling "%Q" + "implode(...)" callsites in Revision updates
Summary

See https://discourse.phabricator-community.org/t/error-seems-to-be-related-with-da40f8074-and-php-7-3/2102/12. When creating or updating revisions, we do some manual query construction to update the affected path table.

Update these queries to modern qsprintf().

Test Plan

Created and updated revisions affecting paths, no more logs in the webserver log.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Dec 5 2018, 2:14 PM
epriestley requested review of this revision.Dec 5 2018, 2:16 PM
amckinley accepted this revision.Dec 7 2018, 10:25 PM
This revision is now accepted and ready to land.Dec 7 2018, 10:25 PM
Closed by commit rP1029081b2805: Correct two straggling "%Q" + "implode(...)" callsites in Revision updates (authored by epriestley). · Explain WhyDec 10 2018, 12:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 47413

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
Phabricator · Built by Phacility