Page MenuHomePhabricator

Correct two straggling "%Q" + "implode(...)" callsites in Revision updates
ClosedPublic

Authored by epriestley on Dec 5 2018, 2:14 PM.
Tags
None
Referenced Files
F19152694: D19846.diff
Dec 11 2025, 4:27 AM
F19037917: D19846.id47413.diff
Nov 26 2025, 1:56 AM
F18828138: D19846.id47395.diff
Oct 24 2025, 2:33 PM
F18509968: D19846.id.diff
Sep 5 2025, 3:42 AM
F18503551: D19846.diff
Sep 4 2025, 11:11 PM
F18105284: D19846.id47395.diff
Aug 10 2025, 5:25 PM
F18102987: D19846.id47413.diff
Aug 10 2025, 12:48 AM
F18102245: D19846.id.diff
Aug 9 2025, 7:28 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/error-seems-to-be-related-with-da40f8074-and-php-7-3/2102/12. When creating or updating revisions, we do some manual query construction to update the affected path table.

Update these queries to modern qsprintf().

Test Plan

Created and updated revisions affecting paths, no more logs in the webserver log.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable