Page MenuHomePhabricator

Correct two straggling "%Q" + "implode(...)" callsites in Revision updates
ClosedPublic

Authored by epriestley on Dec 5 2018, 2:14 PM.
Tags
None
Referenced Files
F15465315: D19846.id47413.diff
Wed, Apr 2, 5:07 PM
F15445052: D19846.id47413.diff
Thu, Mar 27, 12:22 PM
F15399414: D19846.id.diff
Mon, Mar 17, 4:25 AM
Unknown Object (File)
Mar 3 2025, 3:49 AM
Unknown Object (File)
Feb 2 2025, 10:39 AM
Unknown Object (File)
Jan 30 2025, 3:00 PM
Unknown Object (File)
Jan 17 2025, 3:19 PM
Unknown Object (File)
Jan 2 2025, 1:42 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/error-seems-to-be-related-with-da40f8074-and-php-7-3/2102/12. When creating or updating revisions, we do some manual query construction to update the affected path table.

Update these queries to modern qsprintf().

Test Plan

Created and updated revisions affecting paths, no more logs in the webserver log.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable