- Maniphest Tasks
- T13216: 2018 Week 45-47 Bonus Content
- rPc86c5749bafb: Make the repository "Filesize Limit" and "Clone/Fetch Timeout" configurable in…
- Configured a filesize limit and pushed, hit it. Made the limit larger and pushed, change went through.
I guess it's your own damn fault if you set filesize limit to "🐐" or something, but I'm kind of surprised there's no PhabricatorNautralNumberEditField or similar.
This is so we can eventually enable a default value for this?
If it's too late to change this, no big deal, but limit.copyTime or similar might be more clear.
Just making sure you meant to use getCopyTimeLimit() instead of getEffectiveCopyTimeLimit() here. I guess this version makes more sense because if we changed the default in the code, suddenly old transactions would render differently.
And this handles the validation I was worried about above.
"Unable to parse filesize limit, specify a positive number of bytes."
This also affects the timeout on the initial import, right? Worth documenting as "If you're having trouble importing a particularly large repository, try increasing this value above the default (900 seconds)."?