Page MenuHomePhabricator

Allow "bin/repository thaw --demote" to demote an entire service, not just a single device
ClosedPublic

Authored by epriestley on Wed, Dec 5, 8:24 PM.

Details

Summary

Ref T13222. See PHI992. If you lose an entire cluster, you may want to aggressively demote it out of existence. You currently need to xargs your way through this. Allow --demote <service>, which demotes all devices in a service.

Test Plan

Demoted with --demote <device> and --demote <service>. Hit the --promote service error.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Dec 5, 8:24 PM
epriestley requested review of this revision.Wed, Dec 5, 8:26 PM
epriestley updated this revision to Diff 47401.Wed, Dec 5, 8:31 PM
  • Mention these flags in the documentation.
amckinley accepted this revision.Fri, Dec 7, 11:32 PM
amckinley added inline comments.
src/applications/repository/management/PhabricatorRepositoryManagementThawWorkflow.php
18

device|service?

21

"unsynchronized changes"?

This revision is now accepted and ready to land.Fri, Dec 7, 11:32 PM
This revision was automatically updated to reflect the committed changes.