Differential D19850

Allow "bin/repository thaw --demote" to demote an entire service, not just a single device
ClosedPublic
Actions

Authored by epriestley on Dec 5 2018, 8:24 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13222: 2018 Week 48-51 Bonus Content

Commits

rP1a6a0181a898: Allow "bin/repository thaw --demote" to demote an entire service, not just a…

Summary

Ref T13222. See PHI992. If you lose an entire cluster, you may want to aggressively demote it out of existence. You currently need to xargs your way through this. Allow --demote <service>, which demotes all devices in a service.

Test Plan

Demoted with --demote <device> and --demote <service>. Hit the --promote service error.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Dec 5 2018, 8:24 PM

Harbormaster completed remote builds in B21251: Diff 47400.Dec 5 2018, 8:26 PM

epriestley requested review of this revision.Dec 5 2018, 8:26 PM

Mention these flags in the documentation.

Harbormaster completed remote builds in B21252: Diff 47401.Dec 5 2018, 8:33 PM

amckinley accepted this revision.Dec 7 2018, 11:32 PM

amckinley added inline comments.

src/applications/repository/management/PhabricatorRepositoryManagementThawWorkflow.php
18	`device\|service`?
21	"unsynchronized changes"?

This revision is now accepted and ready to land.Dec 7 2018, 11:32 PM

Closed by commit rP1a6a0181a898: Allow "bin/repository thaw --demote" to demote an entire service, not just a… (authored by epriestley). · Explain WhyDec 10 2018, 12:46 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D19856: Give "Autoclose Only" repository detail proper getters/setters.Dec 10 2018, 3:50 PM

epriestley mentioned this in rPc3206476a303: Give "Autoclose Only" repository detail proper getters/setters.Dec 10 2018, 6:22 PM

Revision Contents
Changeset List

			Path	Packages
M			src/applications/repository/management/PhabricatorRepositoryManagementThawWorkflow.php (261 lines)
M			src/docs/user/cluster/cluster_repositories.diviner (12 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	47400	87253ea		Dec 5 2018, 8:24 PM	★	★
Diff 2	47401	87253ea	- Mention these flags in the documentation.	Dec 5 2018, 8:31 PM	★	★
Diff 3	47416	bba4186	rP1a6a0181a8985371fe1470cbea24463885850668	Dec 10 2018, 12:46 AM	★	★

Diff 47416

View Options

src/applications/repository/management/PhabricatorRepositoryManagementThawWorkflow.php