Page MenuHomePhabricator
Feed Advanced Search

Oct 31 2015

tycho.tatitscheff added a comment to rP4626fb4ef00f: Update "should not run as root" message.

By the way, can bin/aphlictuse the same if user <> phd.user then try to sudo to phd.user and run else run mecanism than bin/phd

Oct 31 2015, 2:12 PM
tycho.tatitscheff added a comment to T9677: Difficulty debugging sudo permissions.

Does GIT_CURL_VERBOSE=1 git clone http://phabricator.local/diffusion/TEST/test.gitdoesn't give you useful informations ?

Oct 31 2015, 9:11 AM · Diffusion

Oct 30 2015

tycho.tatitscheff added a comment to D14369: Allow any {icon} to spin.

I think we need a theyseemerolling macro for the occasion

Oct 30 2015, 10:28 PM
tycho.tatitscheff added a comment to T9675: behavior-fancy-datepicker may freeze chrome and firefox when `week start on` set to monday.

I guess some absolute value somewhere maybe while(abs(start--)) instead

Oct 30 2015, 9:13 PM · Javelin
tycho.tatitscheff created T9675: behavior-fancy-datepicker may freeze chrome and firefox when `week start on` set to monday.
Oct 30 2015, 8:24 PM · Javelin
tycho.tatitscheff accepted rP096117aacded: Allow any {icon} to spin.

I trust my eyes but how !

Oct 30 2015, 7:45 PM
tycho.tatitscheff raised a concern with rP096117aacded: Allow any {icon} to spin.

It doesn't seems to works with color AND spin

{icon heart spin color=red}

{icon heart color=red spin}

Oct 30 2015, 7:44 PM
tycho.tatitscheff added a comment to T9670: Conflicting field mappings for phabricator index when upgrading to Elasticsearch 2.0.

I tested and i does not fix !

Oct 30 2015, 5:16 PM · Elasticsearch
tycho.tatitscheff accepted D14368: Fix an issue with incorrect authorization handling in Working Copy build steps.
Oct 30 2015, 3:56 PM
tycho.tatitscheff added inline comments to D14368: Fix an issue with incorrect authorization handling in Working Copy build steps.
Oct 30 2015, 3:56 PM
tycho.tatitscheff added a reviewer for D14368: Fix an issue with incorrect authorization handling in Working Copy build steps: tycho.tatitscheff.

Does this also add the buildable repository asdefault repository cloned ?

Oct 30 2015, 3:50 PM
tycho.tatitscheff updated the answer details for Q179: How do you configure an Almanac based Drydock resource (Answer 212).
Oct 30 2015, 10:00 AM
tycho.tatitscheff reopened T9671: Harbormaster builds and Drydock leases are stuck as "Open".

Reopened since the main concern was more the installation of T9669 and theire is still pending question.

Oct 30 2015, 9:48 AM · Harbormaster, Drydock
tycho.tatitscheff added a comment to T9671: Harbormaster builds and Drydock leases are stuck.

@marceldegraaf : i did the first part (almanac + drydock almanac based host blueprint) of how to configure drydock here : Q179: How do you configure an Almanac based Drydock resource but not found time to get the second part (drydock working copy blueprint + harbormaster + herald). Say me if you wanna details the last part in a ponder question or shall I do it later when i have time.

Oct 30 2015, 9:47 AM · Harbormaster, Drydock
tycho.tatitscheff updated the task description for T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository.
Oct 30 2015, 9:39 AM · Harbormaster, Drydock
tycho.tatitscheff updated the task description for T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository.
Oct 30 2015, 9:34 AM · Harbormaster, Drydock
tycho.tatitscheff updated subscribers of T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository.
Oct 30 2015, 9:32 AM · Harbormaster, Drydock
tycho.tatitscheff merged task T9671: Harbormaster builds and Drydock leases are stuck into T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository.
Oct 30 2015, 9:32 AM · Harbormaster, Drydock
tycho.tatitscheff merged task T9673: Argument 1 passed to DrydockLease::setAllowedBlueprintPHIDs() must be of the type array, null given into T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository.
Oct 30 2015, 9:32 AM
tycho.tatitscheff updated the task description for T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository.
Oct 30 2015, 9:32 AM · Harbormaster, Drydock
tycho.tatitscheff added a project to T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository: Harbormaster.
Oct 30 2015, 9:21 AM · Harbormaster, Drydock
tycho.tatitscheff renamed T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository from Dont crash when testing harbormaster steps on repository commit to Harbormaster working copy build step shouldn't crash when user don't set any also clone repository.
Oct 30 2015, 9:20 AM · Harbormaster, Drydock
tycho.tatitscheff added a comment to T9673: Argument 1 passed to DrydockLease::setAllowedBlueprintPHIDs() must be of the type array, null given.

it is exactly T9669 : should i merge this one into mine ?

Oct 30 2015, 9:16 AM
tycho.tatitscheff added a comment to T9671: Harbormaster builds and Drydock leases are stuck.

Basically you need to extra set the repo to be cloned. The UI is kinda misleading and the exception is not handled correctly when allow_phid is null

Oct 30 2015, 12:05 AM · Harbormaster, Drydock
tycho.tatitscheff added a comment to T9671: Harbormaster builds and Drydock leases are stuck.

marceldegraf see T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository

Oct 30 2015, 12:01 AM · Harbormaster, Drydock

Oct 29 2015

tycho.tatitscheff updated the task description for T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository.
Oct 29 2015, 5:48 PM · Harbormaster, Drydock
tycho.tatitscheff updated the task description for T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository.
Oct 29 2015, 5:45 PM · Harbormaster, Drydock
tycho.tatitscheff awarded T9657: Upgrading: arc land flow has been rewritten in git a Evil Spooky Haunted Tree token.
Oct 29 2015, 5:42 PM · Installing & Upgrading, Arcanist
tycho.tatitscheff added a comment to T9670: Conflicting field mappings for phabricator index when upgrading to Elasticsearch 2.0.

Uhm I tested the same last month when 2.0 was still beta then conclude that phabricator only supported 1.x.
I will follow the resolution of this.

Oct 29 2015, 3:04 PM · Elasticsearch
tycho.tatitscheff added a comment to T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository.

Doing

diff --git a/src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php b/src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php
index 3c4d18f..9e20b6c 100644
--- a/src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php
+++ b/src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php
@@ -43,7 +43,9 @@ final class HarbormasterLeaseWorkingCopyBuildStepImplementation
Oct 29 2015, 2:49 PM · Harbormaster, Drydock
tycho.tatitscheff added a comment to T9662: Add initiatorPHID build variable to hint at who/what caused the build.

This would be awesome !

Oct 29 2015, 2:11 PM · Harbormaster
tycho.tatitscheff awarded T9662: Add initiatorPHID build variable to hint at who/what caused the build a Pterodactyl token.
Oct 29 2015, 2:11 PM · Harbormaster
tycho.tatitscheff added a comment to T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository.

If you agree can I submit a fix :

  • same as rP43569d4e278c365a1feb9497acfa4ce336a8262c for first part
  • if needed (maybe first part solve all later on by adding buildable.repository if no repository are selected) a modification of UI that say that clone instead of also clone and make it required.
Oct 29 2015, 2:08 PM · Harbormaster, Drydock
tycho.tatitscheff added a comment to T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository.

Basically I see two problems:

  • the fact that null isn't a normal argument and should be and empty array : it thus for me seems very similar with T9631: Don't crash when users fail to specify additional working copies and should be easy to fix
  • the fact that it is not working while all seem's to be set correctly (that is the reason I posted all this (let me know if you need more). It seem's to be a reall problem too but it is probably just me being dumb !
Oct 29 2015, 2:04 PM · Harbormaster, Drydock
tycho.tatitscheff created T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository.
Oct 29 2015, 12:40 PM · Harbormaster, Drydock

Oct 28 2015

tycho.tatitscheff created T9653: Show a link to approval queue in unapproved user profile.
Oct 28 2015, 9:08 AM · NUX
tycho.tatitscheff awarded T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies a Love token.
Oct 28 2015, 8:39 AM · Maniphest
tycho.tatitscheff awarded D14356: Make "arc land" great again a Love token.
Oct 28 2015, 8:32 AM

Oct 27 2015

tycho.tatitscheff renamed T9643: XHPast Parse error when extracting i18n from XHPast Parse error on XHPASTTree.php:55 to XHPast Parse error when etracting i18n.
Oct 27 2015, 1:43 PM · XHPAST
tycho.tatitscheff created T9643: XHPast Parse error when extracting i18n.
Oct 27 2015, 1:42 PM · XHPAST
tycho.tatitscheff awarded T9639: Unable to push to hosted Mercurial repository over SSH with new upstream bookmark position a Yellow Medal token.
Oct 27 2015, 9:38 AM · Diffusion, Mercurial
tycho.tatitscheff added a comment to T9638: Partner Did Not Generate Pay Statement for 19th through 26th Payment Page https://toolshed.uberinternal.com/t2/partners/229f5edd-a6ff-4ade-802f-f0744469dd8b/payments.
IMPORTANT: This is not a demo or test install. Please don't make a mess. You can launch a demo install on Phacility if you want to click around and try things out.
Oct 27 2015, 2:19 AM
tycho.tatitscheff added a comment to T9638: Partner Did Not Generate Pay Statement for 19th through 26th Payment Page https://toolshed.uberinternal.com/t2/partners/229f5edd-a6ff-4ade-802f-f0744469dd8b/payments.

Or it is just flood.
sadpanda

Oct 27 2015, 2:13 AM
tycho.tatitscheff added a comment to T9638: Partner Did Not Generate Pay Statement for 19th through 26th Payment Page https://toolshed.uberinternal.com/t2/partners/229f5edd-a6ff-4ade-802f-f0744469dd8b/payments.

I guess you post this on the wrong instance !!

Oct 27 2015, 2:13 AM

Oct 26 2015

tycho.tatitscheff awarded T8951: Allow Diffusion repositories to disable "push" Herald Rules to improve support for importing large repositories by pushing them a Love token.
Oct 26 2015, 1:52 PM · Restricted Project, Diffusion, Herald
tycho.tatitscheff closed Q179: How do you configure an Almanac based Drydock resource as resolved.
Oct 26 2015, 1:26 PM · Drydock
tycho.tatitscheff updated the answer details for Q179: How do you configure an Almanac based Drydock resource (Answer 212).
Oct 26 2015, 1:25 PM
tycho.tatitscheff added a comment to Q179: How do you configure an Almanac based Drydock resource (Answer 223).

I did this since I thought (very dumb estimation) that working copy would need access to phabricator back (to clone ect).
I discovered later it wasn't the case and created a bot user with an other keypair and then forget to edit this.

Oct 26 2015, 1:22 PM
tycho.tatitscheff updated the answer details for Q179: How do you configure an Almanac based Drydock resource (Answer 212).
Oct 26 2015, 1:12 PM
tycho.tatitscheff updated the answer details for Q179: How do you configure an Almanac based Drydock resource (Answer 212).
Oct 26 2015, 1:10 PM
tycho.tatitscheff added a comment to Q179: How do you configure an Almanac based Drydock resource (Answer 223).

I will edit my answer.
Thank you Sir !

Oct 26 2015, 1:09 PM
tycho.tatitscheff awarded T7045: Allow linters to be skipped a Love token.
Oct 26 2015, 12:56 PM · Differential, Lint
yelirekim awarded Q179: How do you configure an Almanac based Drydock resource a Mountain of Wealth token.
Oct 26 2015, 10:35 AM · Drydock

Oct 25 2015

tycho.tatitscheff edited P1868 Drydock exception.
Oct 25 2015, 11:53 PM · Drydock
tycho.tatitscheff added a comment to T9631: Don't crash when users fail to specify additional working copies.

Oct 25 2015, 10:57 PM
tycho.tatitscheff added a comment to T9492: Make WorkingCopy resources more powerful and flexible.

@epriestley : is making /var/drydock non hard written or just documented part of this ??

Oct 25 2015, 10:40 PM · Restricted Project, Drydock

Oct 23 2015

tycho.tatitscheff awarded T9378: Build Projects v3 a Love token.
Oct 23 2015, 4:13 PM · Projects (v3), Prioritized

Oct 22 2015

tycho.tatitscheff awarded M1450: Projects v3 a Love token.
Oct 22 2015, 7:22 PM · Projects

Oct 20 2015

tycho.tatitscheff committed rGITTEST0554499f172b: More pasta (authored by tycho.tatitscheff).
More pasta
Oct 20 2015, 4:02 PM
tycho.tatitscheff closed D14312: More pasta by committing rGITTEST0554499f172b: More pasta.
Oct 20 2015, 4:02 PM
tycho.tatitscheff retitled D14312: More pasta from to More pasta.
Oct 20 2015, 4:02 PM
tycho.tatitscheff added a comment to T9595: Changing phd.user seems poorly documented and overall a bad sysadmin experience.

sadpanda

Oct 20 2015, 1:43 PM · Documentation, Installing & Upgrading, Setup

Oct 19 2015

tycho.tatitscheff added a comment to D14297: Switching to pygmentize -V.

@cspeckmim thank you from the multiple advices. I will correct this soon(TM).

Oct 19 2015, 2:57 PM
tycho.tatitscheff added a comment to T9598: "Send message" is not greyed out for logged-out users.

I would be please to help and do it right (this time).

Oct 19 2015, 8:39 AM · People
tycho.tatitscheff created T9598: "Send message" is not greyed out for logged-out users.
Oct 19 2015, 8:38 AM · People
tycho.tatitscheff added a comment to D14299: Desactivate subtask when logged out..

I did :

  • write the diff
  • commit it
  • patched my remote non-production phab, tested it
  • create the revision, get linting issue, canceling the rev, refactor it and indent it properly (this introduces the error), amend it to existing, send skiping unit (since my laptop mysql was not working since update and since i was on travel, it wasn't easy to reinstall it)
  • since i was on travel, I thought you won't send it as it is (I should have had the WIP on title) since unit was skipped
  • when i reconnected, cathed my error, audit it , contact you on irc, created a diff but vlada was faster
Oct 19 2015, 8:18 AM

Oct 18 2015

tycho.tatitscheff accepted D14300: Fix fatal in Maniphest.

Yes my bad ! I was going to submit the same fix.
Y made a typo when amending changes to correct the indent on linting.

Oct 18 2015, 9:04 PM
tycho.tatitscheff updated subscribers of rP0e8ed0c61684: Desactivate subtask when logged out..

@epriestley : I just see I made a typo I typo this when reindenting !

Oct 18 2015, 6:45 PM
tycho.tatitscheff added a comment to T9593: Counterexample header is incorrectly colored in email.

@epriestley :correct me if Im wrong, the way of fixing this is searching in the file that describe code block ?
Then i look for code in $this->getEngine()->isHTMLMailMode() blocks and try to get it right ? Seems easy for color, a little bit less for the gap.

Oct 18 2015, 3:33 PM · Remarkup, Mail
tycho.tatitscheff updated subscribers of T9524: Show aggregate subdirectory coverage in Diffusion browse views.

Yeah. If we did the bar UI, I think the length of the bar is just "U + C" (divided by the longest bar shown on the page, I guess? Or like log-base-something of that so the absolute length of the bar always has about the same meaning?) with something like "C / (U + C)" percent of it colored in.

Or it could just say "2% of 23,000 Coverable Lines" but I suspect that would be harder to parse at a glance than a bar if you have a bunch of subdirectories.

Oct 18 2015, 3:07 PM · Diffusion, Restricted Project
tycho.tatitscheff updated the task description for T9595: Changing phd.user seems poorly documented and overall a bad sysadmin experience.
Oct 18 2015, 3:00 PM · Documentation, Installing & Upgrading, Setup
tycho.tatitscheff updated the task description for T9595: Changing phd.user seems poorly documented and overall a bad sysadmin experience.
Oct 18 2015, 3:00 PM · Documentation, Installing & Upgrading, Setup
revi awarded T9595: Changing phd.user seems poorly documented and overall a bad sysadmin experience a Like token.
Oct 18 2015, 2:55 PM · Documentation, Installing & Upgrading, Setup
tycho.tatitscheff created T9595: Changing phd.user seems poorly documented and overall a bad sysadmin experience.
Oct 18 2015, 1:03 PM · Documentation, Installing & Upgrading, Setup
tycho.tatitscheff added a revision to T9592: "Create subtask" is not greyed out for logged-out users: D14299: Desactivate subtask when logged out..
Oct 18 2015, 9:35 AM · Maniphest
tycho.tatitscheff retitled D14299: Desactivate subtask when logged out. from to Desactivate subtask when logged out..
Oct 18 2015, 9:35 AM
tycho.tatitscheff added a comment to T9592: "Create subtask" is not greyed out for logged-out users.

Ok so I hava done what you advices me and im gonna submited this.
However to make it more clear, won't it be better to just add a new can_create policy.
I guess it should be able to say that admin are only willing "Moderator" members to create a new task but then the others users may comment it (I guess, you are probably gonna want that once Nuance is out).

Oct 18 2015, 9:14 AM · Maniphest
tycho.tatitscheff renamed T9594: Demo task for solving mail bad remarkup from Demo task for solving to Demo task for solving mail bad remarkup.
Oct 18 2015, 2:31 AM
tycho.tatitscheff added a comment to T9594: Demo task for solving mail bad remarkup.
ManiphestTaskDetailController.php
$view->addAction(
      id(new PhabricatorActionView())
        ->setName(pht('Create Subtask'))
        ->setHref($this->getApplicationURI("/task/create/?parent={$id}"))
        ->setIcon('fa-level-down'));
Oct 18 2015, 2:30 AM
tycho.tatitscheff closed T9594: Demo task for solving mail bad remarkup as Wontfix.
Oct 18 2015, 2:28 AM
tycho.tatitscheff created T9594: Demo task for solving mail bad remarkup.
Oct 18 2015, 2:27 AM
tycho.tatitscheff claimed T9592: "Create subtask" is not greyed out for logged-out users.
Oct 18 2015, 2:12 AM · Maniphest

Oct 17 2015

tycho.tatitscheff added a comment to T4213: Provide custom themes, skinning, or custom CSS.

Well a dark theme seems to require much more effort than this and be painless to support.
However I think after @epriestley works on high contrast theme, you can do the same as extension., if you want to code it.

Oct 17 2015, 7:22 PM · Design
tycho.tatitscheff added a comment to D14297: Switching to pygmentize -V.

@epriestley : something like this would be correct ?
Is there unit test I must write for this ?

Oct 17 2015, 4:12 PM
tycho.tatitscheff updated the diff for D14297: Switching to pygmentize -V.
  • Checking version
Oct 17 2015, 4:11 PM
tycho.tatitscheff added a comment to T9586: Modernize Harbormaster build step UI elements.

Oki.

Oct 17 2015, 4:10 PM · Restricted Project, Harbormaster
tycho.tatitscheff added a comment to T9592: "Create subtask" is not greyed out for logged-out users.

Oki this is much more clear so Worflow here is a javelin workflow.
Greping workflow in phabricator get me so much different workflow type that i was lost.

Oct 17 2015, 1:15 PM · Maniphest
tycho.tatitscheff added a revision to T9587: Detect old Pygments versions and encourage an upgrade: D14297: Switching to pygmentize -V.
Oct 17 2015, 1:07 PM · Setup
tycho.tatitscheff retitled D14297: Switching to pygmentize -V from to [WIP] Switching to pygmentize -V.
Oct 17 2015, 1:07 PM
tycho.tatitscheff retitled D14296: Fixing HM UI element from to Fixing HM UI element.
Oct 17 2015, 12:54 PM
tycho.tatitscheff added a revision to T9586: Modernize Harbormaster build step UI elements: D14296: Fixing HM UI element.
Oct 17 2015, 12:54 PM · Restricted Project, Harbormaster
tycho.tatitscheff added a comment to T9587: Detect old Pygments versions and encourage an upgrade.

Is it possible to make 4 messages (not installed - old v1 - medium v2 - recent v2). Or this is too much complexity ?
Anyway, I will start this and then you put this on hold till Pygments release the new version, if you want ! Is it ok ?

Oct 17 2015, 12:29 PM · Setup
tycho.tatitscheff updated subscribers of T9592: "Create subtask" is not greyed out for logged-out users.

I will purpose a diff too !

Oct 17 2015, 10:29 AM · Maniphest
tycho.tatitscheff edited the content of Starmap.
Oct 17 2015, 9:56 AM
tycho.tatitscheff edited the content of Starmap.
Oct 17 2015, 9:39 AM
tycho.tatitscheff edited the content of Starmap.
Oct 17 2015, 9:34 AM
tycho.tatitscheff added a comment to T8117: Choose the most straightforward possible name for a package management application.

I found pha-get amazing thought.

Oct 17 2015, 7:56 AM
tycho.tatitscheff reopened T9587: Detect old Pygments versions and encourage an upgrade as "Open".
Oct 17 2015, 7:48 AM · Setup
tycho.tatitscheff added a comment to T9586: Modernize Harbormaster build step UI elements.

So @chad are you oki for letting me contribute?

Oct 17 2015, 7:10 AM · Restricted Project, Harbormaster

Oct 16 2015

tycho.tatitscheff added a comment to T9587: Detect old Pygments versions and encourage an upgrade.

Woooh. That is fast, clear and precise. I will do it next week.

Oct 16 2015, 4:32 PM · Setup