HomePhabricator

Allow any {icon} to spin

Authored by epriestley.

Description

Allow any to spin

Summary: We are greedily hoarding this for ourselves, when we could enrich the world.

Test Plan: Used {icon cog spin}.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D14369

Details

Auditors
tycho.tatitscheff
Committed
epriestleyOct 30 2015, 4:02 PM
Pushed
industryOct 30 2015, 4:02 PM
Reviewer
chad
Differential Revision
D14369: Allow any {icon} to spin
Parents
rP2c3dbc48ee95: Move "Next Step" to a custom field in Differential
Branches
Unknown
Tags
Unknown
Build Status
Buildable 8501
Build 9799: Run Core Tests

Event Timeline

tycho.tatitscheff raised a concern with this commit.Oct 30 2015, 7:44 PM

It doesn't seems to works with color AND spin

{icon heart spin color=red}

{icon heart color=red spin}

But does work correctly without both

{icon heart spin}

{icon heart color=red}

sadpanda

tycho.tatitscheff accepted this commit.EditedOct 30 2015, 7:45 PM

Ugh ??

I trust my eyes but how !

Ah need a comma !