Page MenuHomePhabricator
Differential D14300

Fix fatal in Maniphest
ClosedPublic
Actions

Authored by vlada on Oct 18 2015, 7:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 9:48 PM
Unknown Object (File)
Mon, Dec 9, 6:13 AM
Unknown Object (File)
Sun, Dec 8, 8:11 PM
Unknown Object (File)
Wed, Nov 20, 7:21 PM
Unknown Object (File)
Nov 18 2024, 10:48 PM
Unknown Object (File)
Nov 15 2024, 8:57 AM
Unknown Object (File)
Nov 11 2024, 8:04 PM
Unknown Object (File)
Nov 11 2024, 9:44 AM
View All Files
Subscribers
avivey
Korvin
tycho.tatitscheff

Details

Reviewers
tycho.tatitscheff
epriestley
avivey
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9596: Call to undefined method PhabricatorActionListView::setDisabled()
Commits
Restricted Diffusion Commit
rP478249147006: Fix fatal in Maniphest
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

Fixes T9596.

Was unable to navigate to a task in Maniphest.

Test Plan

navigate to that task.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vlada updated this revision to Diff 34516.Oct 18 2015, 7:55 PM
vlada retitled this revision from to Fix fatal in Maniphest.
vlada updated this object.
vlada edited the test plan for this revision. (Show Details)
vlada added a reviewer: epriestley.
vlada added a task: T9596: Call to undefined method PhabricatorActionListView::setDisabled().
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 18 2015, 7:55 PM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added a subscriber: Korvin. · View Herald Transcript
vlada added a comment.Oct 18 2015, 7:56 PM

Looks like it was caused by D14299?

avivey accepted this revision.Oct 18 2015, 8:18 PM
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.

I've ran units on my system.

(Are you also running this on RPi? that shouldn't work.)

tycho.tatitscheff accepted this revision.Oct 18 2015, 9:04 PM
tycho.tatitscheff added a reviewer: tycho.tatitscheff.
tycho.tatitscheff added a subscriber: tycho.tatitscheff.

Yes my bad ! I was going to submit the same fix.
Y made a typo when amending changes to correct the indent on linting.

Closed by commit rP478249147006: Fix fatal in Maniphest (authored by chad, committed by chad). · Explain WhyOct 18 2015, 9:43 PM
This revision was automatically updated to reflect the committed changes.
vlada added a comment.Oct 18 2015, 10:12 PM

@avivey, yeah, I've got a Phabricator setup running on a Raspberry Pi2 for some personal projects. I've just done it today, it's got a very basic setup, and it's rather slow, but it works. So far, I'm happy.

$ arc lint on the actual Phabricator repository didn't work though, I was trying to compile xhpast and ran into a missing gcc flag.

epriestley edited edge metadata.Oct 19 2015, 1:02 AM

Thanks! Sorry about this.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
controller/
4 lines

Diff 34517

View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
Phabricator · Built by Phacility