Page MenuHomePhabricator

Fix fatal in Maniphest
ClosedPublic

Authored by vlada on Oct 18 2015, 7:55 PM.

Details

Summary

Fixes T9596.

Was unable to navigate to a task in Maniphest.

Test Plan

navigate to that task.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlada updated this revision to Diff 34516.Oct 18 2015, 7:55 PM
vlada retitled this revision from to Fix fatal in Maniphest.
vlada updated this object.
vlada edited the test plan for this revision. (Show Details)
vlada added a reviewer: epriestley.
vlada added a comment.Oct 18 2015, 7:56 PM

Looks like it was caused by D14299?

avivey accepted this revision.Oct 18 2015, 8:18 PM
avivey added a reviewer: avivey.
avivey added a subscriber: avivey.

I've ran units on my system.

(Are you also running this on RPi? that shouldn't work.)

Yes my bad ! I was going to submit the same fix.
Y made a typo when amending changes to correct the indent on linting.

This revision was automatically updated to reflect the committed changes.

@avivey, yeah, I've got a Phabricator setup running on a Raspberry Pi2 for some personal projects. I've just done it today, it's got a very basic setup, and it's rather slow, but it works. So far, I'm happy.

$ arc lint on the actual Phabricator repository didn't work though, I was trying to compile xhpast and ran into a missing gcc flag.

epriestley edited edge metadata.Oct 19 2015, 1:02 AM

Thanks! Sorry about this.