Page MenuHomePhabricator
Create Task
Maniphest T9675

behavior-fancy-datepicker may freeze chrome and firefox when `week start on` set to monday
Closed, ResolvedPublic
Actions

Description

No that this isn't a bug report against calendar (which is prototype I know) but against bad javelin component.
However the step to reproduce use calendar since it's is the most obvious part where this javelin component is used.

Step to reproduce

  • set Week Starts On to monday in user pref (who starts the weeks on sunday anyway)
  • create a new calendar event
  • try to fix end date going to something in november 2015:
    • to do this use arrows
  • then it freezes chrome windows

My understanding

Debugging it in chrome reveal me that when trying to edit the month and go to the next month :

I'm note sure how to fix this @epriestley, would you mind guide me ?

Revisions and Commits

rP Phabricator
D14409rP9366edf25589 Fix start in fancy datepicker calendar

Event Timeline

tycho.tatitscheff created this task.Oct 30 2015, 8:24 PM
tycho.tatitscheff updated the task description. (Show Details)
tycho.tatitscheff added a project: Javelin.
tycho.tatitscheff added subscribers: tycho.tatitscheff, epriestley.
tycho.tatitscheff added a comment.Oct 30 2015, 9:13 PM

I guess some absolute value somewhere maybe while(abs(start--)) instead

tycho.tatitscheff renamed this task from behavior-fancy-datepicker freeze the chrome and firefox when trying to acces the future to behavior-fancy-datepicker freeze the chrome and firefox when trying to acces the future and week start on set to monday.Oct 31 2015, 4:32 PM
tycho.tatitscheff updated the task description. (Show Details)
tycho.tatitscheff added a comment.Oct 31 2015, 4:38 PM

Edited, seems not to happen when week start on sunday !

tycho.tatitscheff renamed this task from behavior-fancy-datepicker freeze the chrome and firefox when trying to acces the future and week start on set to monday to behavior-fancy-datepicker may freeze chrome and firefox when `week start on` set to monday.Nov 1 2015, 9:09 AM
tycho.tatitscheff updated the task description. (Show Details)
tycho.tatitscheff added a comment.Nov 1 2015, 4:49 PM

@epriestley do you think it is worth trying to debug this ? those javelin components have alaways feel strange to me and for this one in peculiar, it really feels hard debugging it.

tycho.tatitscheff added a revision: D14409: Fix start in fancy datepicker calendar.Nov 5 2015, 3:05 PM
epriestley closed this task as Resolved by committing rP9366edf25589: Fix start in fancy datepicker calendar.Nov 5 2015, 3:07 PM
epriestley added a commit: rP9366edf25589: Fix start in fancy datepicker calendar.
Phabricator · Built by Phacility