Page MenuHomePhabricator

Desactivate subtask when logged out.

Authored by tycho.tatitscheff on Oct 18 2015, 9:35 AM.
Referenced Files
Unknown Object (File)
Sat, May 6, 8:38 PM
Unknown Object (File)
Apr 14 2023, 1:13 PM
Unknown Object (File)
Apr 8 2023, 9:49 PM
Unknown Object (File)
Apr 7 2023, 11:13 PM
Unknown Object (File)
Apr 7 2023, 11:23 AM
Unknown Object (File)
Apr 5 2023, 1:37 PM
Unknown Object (File)
Apr 4 2023, 12:04 AM
Unknown Object (File)
Apr 3 2023, 3:11 PM



Fixes T9592.

Test Plan

Log out ! Navigates to a task. See the add button grey-ed out !

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

tycho.tatitscheff retitled this revision from to Desactivate subtask when logged out..
tycho.tatitscheff updated this object.
tycho.tatitscheff edited the test plan for this revision. (Show Details)
tycho.tatitscheff added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 18 2015, 11:21 AM
Closed by commit rP0e8ed0c61684: Desactivate subtask when logged out. (authored by tycho <>, committed by epriestley). · Explain WhyOct 18 2015, 11:22 AM
This revision was automatically updated to reflect the committed changes.

@tycho.tatitscheff, you wrote this in your test plan:

Log out ! Navigates to a task. See the add button grey-ed out !

Did you actually do this?

That is, did you introduce the fatal after testing, or did you not actually test the change?

I did :

  • write the diff
  • commit it
  • patched my remote non-production phab, tested it
  • create the revision, get linting issue, canceling the rev, refactor it and indent it properly (this introduces the error), amend it to existing, send skiping unit (since my laptop mysql was not working since update and since i was on travel, it wasn't easy to reinstall it)
  • since i was on travel, I thought you won't send it as it is (I should have had the WIP on title) since unit was skipped
  • when i reconnected, cathed my error, audit it , contact you on irc, created a diff but vlada was faster

So yes I tested it before, but anyway it is all my bad. I should have put "WIP" in title, retest it after amending.
Sorry for that.

In hindsight, we'll only give out "Contributor" to net-positive improvements to Phabricator. No worries though, last I checked there are probably dozens of this non-disabled buttons around Phabricator. Easy pickins'.