I'm worried it may intimidate users who are worried they can not live up to the requisite level of professionalism.

We should use the cat example on the marketing site. http://phacility.com/phabricator/pholio/

Older versions of an image are available in the table below. For example, this shows iterations to a high quality professional picture of a cat:

Old images are kept in the Mock History under the Mock. You can click on and review old comments anytime.

It will update the old image, I want to keep the old image so we can track the changes on the design. maybe grouping of multiple image into one and not uploading a new one. I think this way its much easier to look at the changes we did on the design.

(When editing the Mock.)

You can just update the images (we'll keep the history) by dragging an updated image onto the old one.

In the Pholio application, the Pholio Paste object is defined in the PholioMock class. In the class definition, you can see PholioMock extends the PholioDAO class and implements a bunch of interfaces. Mentions can be implemented by adding PhabricatorMentionableInterface along with the others. To test:

This is probably a one-line implements PhabricatorMentionableInterface on PholioMock.

It looks like it tries to preload (I see requests in the network tab in devtools for all the images in the mock as soon as I load the page), but doesn't do anything to keep the preloaded data around.

It's intentional that these images aren't cacheable, but we should try to improve the browser behavior.

Possibly also relevant: I don't have security.alternate-file-domain set. Is that required to have cacheable images?

Also: the file appears to have 'Cacheable: no':

Potentially relevant: I see pholio preloading the images on pageload, but the server seems to be returning Cache-Control: no-cache, which might be what's causing Chrome to reload the image.

T6273

Im curious if there is any way to edit the inline comment/attachments...

Inlines are essentially "attachments" even though they are presented in the comment box. If you just attach inline comments, there is no actual post to edit, quote, view raw, or delete.

That post also has no primary content.

Even if it isn't the first transaction the arrow shows and you can't click it, I added a second "inline comment" and as you can see it has an unclickable arrow.

For the arrow, this is expected. Your first transaction has no primary comment, and the arrow does not let you take actions on inline comments (there may be several, so "Edit Comment", for example, isn't necessarily meaningful). This is a little confusing in the case of only one inline comment.

Just an FYI that Pholio edit is busted too so this is a bit bigger than it seems.

We don't plan to pursue this in the upstream, comments can get very long and be very difficult to read. Thanks for the suggestion.

We were never able to reproduce this and no one else has reported it in more than a year.

Pasteboard.co uses the separate-div-with-contentEditable technique as well:

@skibbipl Phabricator supports pasting images into any Remarkup textarea, including Conpherence.

I was planning to add similar request for conpherence, but it seems this task covers my request.

fwiw, http://pasteboard.co/ is reported to work on Firefox for Windows and Mac. I haven't tried myself, and I have no idea what is the sauce being used there.

Thank you for clarifying and sorry for the erroneous report. It was not immediately apparent to me that the header had this additional policy information. The behavior now makes sense; I had just been confused when setting the mockup policy and seeing a different one on the actual file object.

If you click the policy for an object (in the header), it will explain any special policy rules that apply to the object. Here are the rules for files:

This is confusion over the policy.

Expectation is:

I guess as a designer myself I don't understand the optimization here (quick create Pholio). I fundamentally work one of two ways. Serious 'pre-product' or explorative designs (which take 10, 20, 40 hours), which I expect revisions and long discussions on. This product is Pholio. The second is lightweight corrections or attachments to tasks. The 'hey go make this' or 'i just threw this together'. In those cases I drag and drop into comments/descriptions on a task or diff.

In T6831#89086, @chad wrote:

Adding a file either requires you click "edit" and drag in a file or scroll to the bottom and comment and drag in a file. I think both are equally easy, just different.

Are there some example tasks on the WMF install where assets are few/simple enough that making a mock is overkill, but numerous enough that finding the latest versions is time consuming/complex? If an asset (like an icon) is straightforward and doesn't need discussion, how often are there a ton of versions of it?

I should mention long-term I want to make the Pholio comment controls work on any image in lightbox, not just Pholio mocks.

Adding a file either requires you click "edit" and drag in a file or scroll to the bottom and comment and drag in a file. I think both are equally easy, just different.

Your reasoning makes sense. I think the actual problem behind this request is that adding a file to a comment is a lot easier than embedding a new mockup to the header or description of a task, counting the steps each path takes and the extra fields that a new mock offers.

I feel like there was a second discussion when we actually removed this, but can't locate it offhand.

In the Files case, we had this in the past (@chad's link has more discussion) and it wasn't very useful. The number of tasks with meaningful/important assets seems very small, at least on this install and based on feedback from other users.

Some previous discussion on Files specifically in T3742#39414.

I feel this is the same as the mention of Projects, without some level of explicit inclusion, the behaviour is confusing and causes additional work to correct when it occurs. Our expectation for attaching such items now is by using the action link on the task or by editing the description.

Closed by commit rPf24ae96bb6e0.

This repros IFF there are also some inline comments in the transaction history. Diff in a sec.