Page MenuHomePhabricator

Quicksand and Pholio - make mock edit work
ClosedPublic

Authored by btrahan on May 6 2015, 7:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 5:18 PM
Unknown Object (File)
Tue, Apr 30, 5:18 PM
Unknown Object (File)
Tue, Apr 30, 5:18 PM
Unknown Object (File)
Tue, Apr 30, 5:18 PM
Unknown Object (File)
Mon, Apr 29, 2:34 PM
Unknown Object (File)
Sun, Apr 14, 10:39 PM
Unknown Object (File)
Apr 1 2024, 6:01 PM
Unknown Object (File)
Mar 23 2024, 6:56 PM
Subscribers

Details

Summary

Fixes T8036. In addition to making the mock edit work, this tightens quicksand code such that the correct page id is returned even if start() has not been called yet. It also tightens mock view where some functions should respect statics.enabled a bit more.

Test Plan

clicked edit mock, mock crumb, edit mock, mock crum, edit mock, made edits and they worked! clicked edit mock, mock crumb, edit mock, mock crumb, edit mock, profile icon, hit browser back to edit mock, made edits and they worked!

also observed mock view page not occasionally wigging out from image_onload race not having statics.enabled respect during the above

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Quicksand and Pholio - make mock edit work.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
webroot/rsrc/externals/javelin/lib/Quicksand.js
75

i'll change this to a === null check

use === null check instead
redo celery

epriestley edited edge metadata.
This revision is now accepted and ready to land.May 7 2015, 1:31 AM
This revision was automatically updated to reflect the committed changes.