Page MenuHomePhabricator
Feed Advanced Search

Jul 11 2019

epriestley added a revision to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way: D20647: Fix "add more metadata" fatal in Pholio.
Jul 11 2019, 9:40 PM · Javelin
epriestley added a comment to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.

The renderHTMLFooter() method does a bunch of Javascript stuff and isn't actually related to the page footer, but PHUIRemarkupView and renderObjectRefForAnyMedia() were enough of a hint that think I have a reproduction case locally now -- let me figure out what I actually did and this will likely be fairly easy to fix.

Jul 11 2019, 7:53 PM · Javelin
20after4 added a comment to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.

Could this be related to the custom footer markup? The code in question hasn't changed in a long time but I suspect maybe it's related to changes in the remarkup rendering code that's adding metadata where it didn't previously?

Jul 11 2019, 7:00 PM · Javelin
20after4 added a comment to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.

I toggled developer mode on for a moment and managed to get a stack trace:

Jul 11 2019, 6:56 PM · Javelin

Jul 8 2019

epriestley updated subscribers of T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.

@20after4, any chance there's a stack trace for this in the webserver error logs? I can't immediately figure out how to reproduce this locally.

Jul 8 2019, 3:57 PM · Javelin

Jul 6 2019

aklapper created T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.
Jul 6 2019, 9:37 AM · Javelin

Feb 20 2019

epriestley closed T11824: Use Pinboard view in Maniphest Mocks tab as Wontfix.

This is probably a natural feature if we iterate here, but not worth keeping a task around for.

Feb 20 2019, 11:32 PM · Pholio, Maniphest

Dec 22 2018

epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19934: Restore a Mock key to Pholio Images.
Dec 22 2018, 10:17 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request

Dec 20 2018

epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19926: Implement Pholio file add/remove transactions without "applyInitialEffects".
Dec 20 2018, 9:53 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19924: Implement "replace" transactions in Pholio without "applyInitialEffects".
Dec 20 2018, 9:33 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19923: Reduce the amount of weird "static" and "cache" behavior in Pholio query classes.
Dec 20 2018, 8:18 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19922: Remove the onboard "mailKey" from Pholio Mocks.
Dec 20 2018, 7:56 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19921: Make the Pholio Mock "getImages" / "getAllImages" API more clear.
Dec 20 2018, 7:48 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley triaged T11351: Move Pholio to EditEngine and modern APIs as Wishlist priority.
Dec 20 2018, 7:48 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19920: Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface.
Dec 20 2018, 6:43 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19919: Remove obsolete, no-op implementations of "willRenderTimeline()".
Dec 20 2018, 6:24 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19918: Remove "willRenderTimeline()" from ApplicationTransactionInterface.
Dec 20 2018, 6:12 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request

Dec 19 2018

epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19914: Make Images in Pholio refer to mocks by PHID instead of ID.
Dec 19 2018, 7:21 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19913: Give Pholio Images an authorPHID and use ExtendedPolicies to implement policy behavior.
Dec 19 2018, 12:09 AM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request

Dec 18 2018

epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19912: Un-implement MarkupInterface from Mocks and Images in Pholio.
Dec 18 2018, 11:41 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley updated subscribers of T11351: Move Pholio to EditEngine and modern APIs.

@amckinley, for general context on where I'm headed here:

Dec 18 2018, 11:34 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19911: Give Pholio images a more modern initializer method.
Dec 18 2018, 11:28 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: D19910: Slightly modernize PholioImageQuery.
Dec 18 2018, 11:17 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request

Oct 5 2018

epriestley closed T12814: pholio transaction emails have too much html as Resolved by committing rP99034efa8b8d: Make Pholio mail render without a ton of over-escaped HTML.
Oct 5 2018, 8:37 PM · Pholio, Transactions, Bug Report
epriestley added a revision to T12814: pholio transaction emails have too much html: D19733: Make Pholio mail render without a ton of over-escaped HTML.
Oct 5 2018, 6:43 PM · Pholio, Transactions, Bug Report

Sep 15 2017

btrahan changed the status of T4382: Pholio inline comment "not submitted yet" message: add title to explain the message from Duplicate to Resolved by committing rP96d831491c2f: Legalpad - add a preview to document create / edit.
Sep 15 2017, 5:28 PM · Pholio

Jul 9 2017

chad removed the image for Pholio.
Jul 9 2017, 7:15 PM

Jun 9 2017

epriestley added a comment to T12814: pholio transaction emails have too much html.

Per @chad's link, PholioMockEditor->buildMailBody() does some improper stuff where it explicitly sets rendering targets and adds raw sections to the mail body.

Jun 9 2017, 2:05 PM · Pholio, Transactions, Bug Report
chad added a project to T12814: pholio transaction emails have too much html: Pholio.

T12776#225510

Jun 9 2017, 4:08 AM · Pholio, Transactions, Bug Report

Jun 2 2017

epriestley closed T12776: Pholio's "replace" transaction does not attach files properly after refactoring as Resolved.

This appears to have been resolved by D18042. I'm letting the mail stuff fall by the wayside for now.

Jun 2 2017, 11:17 AM · Bug Report, Pholio
epriestley closed T12786: New Revisions of Images in Pholio Mocks are not visible for other users.... as Invalid.

I can't reproduce this at HEAD, so presuming this was resolved by rP7b290b94a7.

Jun 2 2017, 11:16 AM · Pholio, Bug Report

Jun 1 2017

chad added a comment to T12786: New Revisions of Images in Pholio Mocks are not visible for other users.....

My guess is they updated early in the week, saw the broken image, and updated and still saw the broken image. Not that they updated and tested the reproduction steps again.

Jun 1 2017, 2:07 PM · Pholio, Bug Report
epriestley added a comment to T12786: New Revisions of Images in Pholio Mocks are not visible for other users.....

I believe this was fixed by 7b290b94a726f7c9eb3efd9e065499fde1b0ad00. Are you 100% sure that the image was updated after that change?

Jun 1 2017, 12:49 PM · Pholio, Bug Report
rphl added a project to T12786: New Revisions of Images in Pholio Mocks are not visible for other users....: Pholio.
Jun 1 2017, 12:45 PM · Pholio, Bug Report

May 30 2017

epriestley added a comment to T12776: Pholio's "replace" transaction does not attach files properly after refactoring.

Specifically, I got this (mail with HTML and text parts containing over-escaped HTML):

May 30 2017, 6:59 PM · Bug Report, Pholio
epriestley added a comment to T12776: Pholio's "replace" transaction does not attach files properly after refactoring.

On top of this, I got some email from Pholio with odd HTML behavior, but I can't immediately reproduce it and I don't have any guesses about what's causing it so I'll assume I'm just crazy until someone else hits it.

May 30 2017, 6:54 PM · Bug Report, Pholio
epriestley added a revision to T12776: Pholio's "replace" transaction does not attach files properly after refactoring: D18042: Correct file PHID extraction on image update in Pholio.
May 30 2017, 6:52 PM · Bug Report, Pholio
epriestley added a comment to T12776: Pholio's "replace" transaction does not attach files properly after refactoring.

(See also M1476.)

May 30 2017, 6:50 PM · Bug Report, Pholio
epriestley added a comment to T12776: Pholio's "replace" transaction does not attach files properly after refactoring.

I've got most of a diff for this.

May 30 2017, 6:47 PM · Bug Report, Pholio
epriestley created T12776: Pholio's "replace" transaction does not attach files properly after refactoring.
May 30 2017, 6:47 PM · Bug Report, Pholio

May 17 2017

amckinley created T12723: A failure to upload a file in the Pholio Mock editor doesn't dismiss the "Uploading..." UI.
May 17 2017, 11:20 PM · Pholio, Bug Report

Apr 24 2017

ivo added a comment to T5293: Respect orientation metadata in Pholio and/or allow images to be rotated.

We run into this as well, mainly when uploading photos of flipover sheets and whiteboards (to Maniphest or Phriction). Our workaround for now is to + click, so the image will render directly into the browser instead of using the lightbox.

Apr 24 2017, 2:09 PM · Files, Pholio

Apr 21 2017

epriestley merged task T6273: Inline comments do not support editing (Pholio, Differential, Diffusion) into T11401: Add ability to quote, edit, view raw, view history, and remove inline comments.
Apr 21 2017, 12:04 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio
epriestley added a comment to T6273: Inline comments do not support editing (Pholio, Differential, Diffusion).

I'm just going to merge this into T11401, at least for the moment. That may eventually split out into application-specific tasks when it gets underway.

Apr 21 2017, 12:04 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio

Mar 30 2017

epriestley moved T4056: Enhance Pholio/Files for additional File Types from Backlog to Far Future on the Files board.
Mar 30 2017, 7:34 PM · Restricted Project, Files, Pholio
epriestley moved T5293: Respect orientation metadata in Pholio and/or allow images to be rotated from Backlog to Far Future on the Files board.
Mar 30 2017, 7:33 PM · Files, Pholio

Feb 24 2017

celia added a comment to T4382: Pholio inline comment "not submitted yet" message: add title to explain the message.

Hello I have a question that:
if there are several users written in comments in Pholio Mocks part, how can I see other person's comments?

Feb 24 2017, 6:48 AM · Pholio
celia added a project to T4382: Pholio inline comment "not submitted yet" message: add title to explain the message: Pholio.
Feb 24 2017, 6:46 AM · Pholio

Jan 28 2017

chad closed T12166: EXCEPTION: (Error) [] operator not supported for strings as Resolved by committing rP7a947947a39b: Fix operator error in Pholio with PHP 7.1.
Jan 28 2017, 3:18 PM · Bug Report, Pholio
chad edited projects for T12166: EXCEPTION: (Error) [] operator not supported for strings, added: Bug Report; removed Bug Report (Needs Information).
Jan 28 2017, 4:49 AM · Bug Report, Pholio
chad added a revision to T12166: EXCEPTION: (Error) [] operator not supported for strings: D17260: Fix operator error in Pholio with PHP 7.1.
Jan 28 2017, 4:47 AM · Bug Report, Pholio
chad added a comment to T12166: EXCEPTION: (Error) [] operator not supported for strings.

perfect thanks!

Jan 28 2017, 4:43 AM · Bug Report, Pholio
Mnkras added a comment to T12166: EXCEPTION: (Error) [] operator not supported for strings.

That error makes sense,

Jan 28 2017, 4:42 AM · Bug Report, Pholio
acs-ferreira added a comment to T12166: EXCEPTION: (Error) [] operator not supported for strings.
  • Ubuntu 16.04
  • PHP 7.1.1
  • nginx 1.11.9
  • Galera Cluster MariaDB 10.1.21
Jan 28 2017, 4:42 AM · Bug Report, Pholio
chad edited projects for T12166: EXCEPTION: (Error) [] operator not supported for strings, added: Bug Report (Needs Information); removed Bug Report.
Jan 28 2017, 4:41 AM · Bug Report, Pholio
acs-ferreira added a comment to T12166: EXCEPTION: (Error) [] operator not supported for strings.

See also http://news.php.net/php.bugs/201680

Jan 28 2017, 4:39 AM · Bug Report, Pholio
chad added a comment to T12166: EXCEPTION: (Error) [] operator not supported for strings.

Can you provide system information, since you're saying this is a system (7.1) issue? I'm not able to currently reproduce this bug.

Jan 28 2017, 4:37 AM · Bug Report, Pholio
acs-ferreira updated the task description for T12166: EXCEPTION: (Error) [] operator not supported for strings.
Jan 28 2017, 4:18 AM · Bug Report, Pholio
acs-ferreira renamed T12166: EXCEPTION: (Error) [] operator not supported for strings from Pholio : EXCEPTION: (Error) [] operator not supported for strings to EXCEPTION: (Error) [] operator not supported for strings.
Jan 28 2017, 4:15 AM · Bug Report, Pholio
acs-ferreira added a project to T12166: EXCEPTION: (Error) [] operator not supported for strings: Pholio.
Jan 28 2017, 4:15 AM · Bug Report, Pholio

Jan 10 2017

epriestley moved T6273: Inline comments do not support editing (Pholio, Differential, Diffusion) from Backlog to Inlines on the Audit board.
Jan 10 2017, 5:20 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio
epriestley added a project to T6273: Inline comments do not support editing (Pholio, Differential, Diffusion): Audit.
Jan 10 2017, 5:17 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio

Dec 29 2016

epriestley moved T6273: Inline comments do not support editing (Pholio, Differential, Diffusion) from Backlog to Inline Infra on the Differential board.
Dec 29 2016, 4:30 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio

Dec 5 2016

epriestley added a comment to T5293: Respect orientation metadata in Pholio and/or allow images to be rotated.

From elsewhere:

Dec 5 2016, 10:02 PM · Files, Pholio

Dec 2 2016

chad added a revision to T3612: Lightbox v2: D16980: Add download link to embedded files.
Dec 2 2016, 8:59 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Dec 2 2016, 7:03 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Dec 2 2016, 7:02 PM · Lightbox, Restricted Project, Files, Pholio
chad added a revision to T3612: Lightbox v2: D16979: Hide badges in phui-comment-panel.
Dec 2 2016, 7:01 PM · Lightbox, Restricted Project, Files, Pholio
chad added a revision to T3612: Lightbox v2: D16978: Prevent double lightbox in lightbox comments.
Dec 2 2016, 6:53 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Dec 2 2016, 6:42 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Dec 2 2016, 6:42 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Dec 2 2016, 6:41 PM · Lightbox, Restricted Project, Files, Pholio
chad added a revision to T3612: Lightbox v2: D16977: Make clicking on file icon in lightbox download file.
Dec 2 2016, 6:02 PM · Lightbox, Restricted Project, Files, Pholio

Nov 29 2016

chad updated the task description for T3612: Lightbox v2.
Nov 29 2016, 8:44 PM · Lightbox, Restricted Project, Files, Pholio
chad added a revision to T3612: Lightbox v2: D16961: Make lightbox buttons more roundy.
Nov 29 2016, 7:01 PM · Lightbox, Restricted Project, Files, Pholio
chad added a revision to T3612: Lightbox v2: D16959: Close lightbox when clicking on image-frame.
Nov 29 2016, 5:21 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Nov 29 2016, 1:33 AM · Lightbox, Restricted Project, Files, Pholio
chad added a comment to T3612: Lightbox v2.

https://mozilla.github.io/pdf.js/

Nov 29 2016, 1:30 AM · Lightbox, Restricted Project, Files, Pholio
cspeckmim added a comment to T3612: Lightbox v2.

Ah I totally missed the F1234 being in the lightbox already. And I did figure that using 3rd party code to render PDF would be out of the question. I don't really know what the current state of PDFs in browsers is so I had my project manager hat on for that question~

Nov 29 2016, 1:27 AM · Lightbox, Restricted Project, Files, Pholio
chad added a comment to T3612: Lightbox v2.
  • I don't think that's a lightbox bug, just a general blog bug.
  • To be fixed.
  • If it's native? We won't be adding third party code for this.
  • We added F1234 to the header of the lightbox for resharing.
Nov 29 2016, 1:24 AM · Lightbox, Restricted Project, Files, Pholio
cspeckmim added a comment to T3612: Lightbox v2.

Woo came here from the blog. Just a few notes so far:

  1. The lightbox on the blog doesn't seem to show anything under the Comment pane even though I should be logged in (to admin.phacility.com). Or is the blog.phacility.com completely isolated/separate? These were errors I got in Firefox console, which I don't get when using lightbox on this instance.
    • Error: JX.$('phabricator-help-menu') call matched no nodes.
    • XHR POST https://blog.phacility.com/file/thread/PHID-FILE-3ittlvgojn2326tbg22z/ [HTTP/1.1 404 Not Found 338ms]
  2. I'm very used to "click anywhere that isn't the image to close the lightbox" behavior. My personal preference would be to maintain that when clicking on any empty space outside the image/file. I think this is due to where my mouse is located when I click the image (towards center of screen usually) and where I would go to click to close (in most cases just slightly down vs. top right corner). But then I use a trackball so...
  3. Is PDF preview considered? PDFs were specifically mentioned in the blog so I have to ask~
  4. (Maybe not totally related) Some way to easily reference the same file instance from different areas. Most users I see will continue to drag/drop the same file in different areas and not use the same file reference object {F1234} - which I'm assuming would mean two separate comment chains, etc. Maybe somewhere in the lightbox listing the tasks/diffs/etc. where the file is referenced would help understanding. Or a way to view/copy the file remarkup to be used elsewhere. Or maybe this is all T11543.
Nov 29 2016, 1:07 AM · Lightbox, Restricted Project, Files, Pholio

Nov 28 2016

chad added a revision to T3612: Lightbox v2: D16957: Use proper file icons in lightbox.
Nov 28 2016, 7:16 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Nov 28 2016, 7:13 PM · Lightbox, Restricted Project, Files, Pholio
epriestley added a comment to T3612: Lightbox v2.

(To answer your question more directly: yeah, no way to do pht() with variables in Javascript. We can build that without TOO much trouble, but I'd like to wait for a really good use case first.)

Nov 28 2016, 2:44 PM · Lightbox, Restricted Project, Files, Pholio
chad added a revision to T3612: Lightbox v2: D16951: Remove english from lightbox javascript.
Nov 28 2016, 1:59 AM · Lightbox, Restricted Project, Files, Pholio
epriestley added a comment to T3612: Lightbox v2.

I'd say just get rid of it, or render "X / Y" without pht()?

Nov 28 2016, 1:14 AM · Lightbox, Restricted Project, Files, Pholio

Nov 27 2016

chad added a comment to T3612: Lightbox v2.

Doesn't look possible to do "Image x of y" in current phtize from JS... Worth adding or just changing the language? I don't have any great ideas on updating the language. Unsure x of y is useful though.

Nov 27 2016, 11:09 PM · Lightbox, Restricted Project, Files, Pholio
chad added a revision to T3612: Lightbox v2: D16950: Prettier file embeds.
Nov 27 2016, 11:08 PM · Lightbox, Restricted Project, Files, Pholio

Nov 25 2016

chad updated the task description for T3612: Lightbox v2.
Nov 25 2016, 10:21 PM · Lightbox, Restricted Project, Files, Pholio

Nov 23 2016

chad updated the task description for T3612: Lightbox v2.
Nov 23 2016, 1:46 AM · Lightbox, Restricted Project, Files, Pholio

Nov 22 2016

chad added a revision to T3612: Lightbox v2: D16918: Restyle remarkup file links.
Nov 22 2016, 9:20 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Nov 22 2016, 7:30 PM · Lightbox, Restricted Project, Files, Pholio
chad added a revision to T3612: Lightbox v2: D16917: Allow commenting on non-viewable lightbox files.
Nov 22 2016, 7:29 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Nov 22 2016, 4:20 AM · Lightbox, Restricted Project, Files, Pholio
chad added a revision to T3612: Lightbox v2: D16907: Ajax commenting on lightbox images.
Nov 22 2016, 4:19 AM · Lightbox, Restricted Project, Files, Pholio

Nov 18 2016

chad updated the task description for T3612: Lightbox v2.
Nov 18 2016, 6:11 PM · Lightbox, Restricted Project, Files, Pholio
chad updated the task description for T3612: Lightbox v2.
Nov 18 2016, 6:10 PM · Lightbox, Restricted Project, Files, Pholio
chad renamed T3612: Lightbox v2 from Implement a standard 'image commenting' UI into Phabricator to Lightbox v2.
Nov 18 2016, 6:10 PM · Lightbox, Restricted Project, Files, Pholio
chad added a project to T3612: Lightbox v2: Lightbox.
Nov 18 2016, 6:08 PM · Lightbox, Restricted Project, Files, Pholio
chad added a revision to T3612: Lightbox v2: D16896: Show file comments on file lightboxes.
Nov 18 2016, 4:31 PM · Lightbox, Restricted Project, Files, Pholio