The renderHTMLFooter() method does a bunch of Javascript stuff and isn't actually related to the page footer, but PHUIRemarkupView and renderObjectRefForAnyMedia() were enough of a hint that think I have a reproduction case locally now -- let me figure out what I actually did and this will likely be fairly easy to fix.

Could this be related to the custom footer markup? The code in question hasn't changed in a long time but I suspect maybe it's related to changes in the remarkup rendering code that's adding metadata where it didn't previously?

I toggled developer mode on for a moment and managed to get a stack trace:

@20after4, any chance there's a stack trace for this in the webserver error logs? I can't immediately figure out how to reproduce this locally.

This is probably a natural feature if we iterate here, but not worth keeping a task around for.

@amckinley, for general context on where I'm headed here:

Per @chad's link, PholioMockEditor->buildMailBody() does some improper stuff where it explicitly sets rendering targets and adds raw sections to the mail body.

T12776#225510

This appears to have been resolved by D18042. I'm letting the mail stuff fall by the wayside for now.

I can't reproduce this at HEAD, so presuming this was resolved by rP7b290b94a7.

My guess is they updated early in the week, saw the broken image, and updated and still saw the broken image. Not that they updated and tested the reproduction steps again.

I believe this was fixed by 7b290b94a726f7c9eb3efd9e065499fde1b0ad00. Are you 100% sure that the image was updated after that change?

Specifically, I got this (mail with HTML and text parts containing over-escaped HTML):

On top of this, I got some email from Pholio with odd HTML behavior, but I can't immediately reproduce it and I don't have any guesses about what's causing it so I'll assume I'm just crazy until someone else hits it.

(See also M1476.)

I've got most of a diff for this.

We run into this as well, mainly when uploading photos of flipover sheets and whiteboards (to Maniphest or Phriction). Our workaround for now is to ⌘ + click, so the image will render directly into the browser instead of using the lightbox.

I'm just going to merge this into T11401, at least for the moment. That may eventually split out into application-specific tasks when it gets underway.

Hello I have a question that:
if there are several users written in comments in Pholio Mocks part, how can I see other person's comments?

perfect thanks!

That error makes sense,

• Ubuntu 16.04
• PHP 7.1.1
• nginx 1.11.9
• Galera Cluster MariaDB 10.1.21

See also http://news.php.net/php.bugs/201680

Can you provide system information, since you're saying this is a system (7.1) issue? I'm not able to currently reproduce this bug.

From elsewhere:

https://mozilla.github.io/pdf.js/

Ah I totally missed the F1234 being in the lightbox already. And I did figure that using 3rd party code to render PDF would be out of the question. I don't really know what the current state of PDFs in browsers is so I had my project manager hat on for that question~

• I don't think that's a lightbox bug, just a general blog bug.
• To be fixed.
• If it's native? We won't be adding third party code for this.
• We added F1234 to the header of the lightbox for resharing.

Woo came here from the blog. Just a few notes so far:

1. The lightbox on the blog doesn't seem to show anything under the Comment pane even though I should be logged in (to admin.phacility.com). Or is the blog.phacility.com completely isolated/separate? These were errors I got in Firefox console, which I don't get when using lightbox on this instance.
   • Error: JX.$('phabricator-help-menu') call matched no nodes.
   • XHR POST https://blog.phacility.com/file/thread/PHID-FILE-3ittlvgojn2326tbg22z/ [HTTP/1.1 404 Not Found 338ms]
2. I'm very used to "click anywhere that isn't the image to close the lightbox" behavior. My personal preference would be to maintain that when clicking on any empty space outside the image/file. I think this is due to where my mouse is located when I click the image (towards center of screen usually) and where I would go to click to close (in most cases just slightly down vs. top right corner). But then I use a trackball so...
3. Is PDF preview considered? PDFs were specifically mentioned in the blog so I have to ask~
4. (Maybe not totally related) Some way to easily reference the same file instance from different areas. Most users I see will continue to drag/drop the same file in different areas and not use the same file reference object {F1234} - which I'm assuming would mean two separate comment chains, etc. Maybe somewhere in the lightbox listing the tasks/diffs/etc. where the file is referenced would help understanding. Or a way to view/copy the file remarkup to be used elsewhere. Or maybe this is all T11543.

(To answer your question more directly: yeah, no way to do pht() with variables in Javascript. We can build that without TOO much trouble, but I'd like to wait for a really good use case first.)

I'd say just get rid of it, or render "X / Y" without pht()?

Doesn't look possible to do "Image x of y" in current phtize from JS... Worth adding or just changing the language? I don't have any great ideas on updating the language. Unsure x of y is useful though.