I deployed this and it seems to be working properly.

This has some rough edges that I'm not going to deal with for now:

I did some trial and error last week with Twitter via https://cards-dev.twitter.com/validator. That was for my personal blog, but some of it might apply here as well.

og:title should probably be the post title.

That use case doesn't strike me as compelling enough to justify a separate field or a behavioral change so I don't plan to adjust our behavior here.

In T12900#228746, @epriestley wrote:

Only you and users who have permission to edit <Blog Name> can see this draft until it is published. Use "Publish" to publish this post.

...would that resolve things in your case? Or does the rule we actually implement not work as well as "only the author" in your use case?

You must be able to view a post's blog to view the post, so the rule is effectively "view and edit".

Don't most places consider "Can Edit" to be weaker than "Can View"?

@epriestley, I tested out the scenario with the change applied.

Ah! That fixed it, thanks @epriestley. I'll let you know once I test out that configuration.

Remarkup is cached, so you'll need to run bin/cache purge --purge-remarkup (or make an edit, or create a new post) to purge the cache.

@epriestley, I wouldn't mind testing that scenario out this weekend (I'll have to change a couple of domain name settings to create the scenario, but that's easily undone).

Happy to accept a patch for this (deleting that one line of code) if someone wants to claim that they tested the scenario above and it worked correctly.

That is, the problem would be:

I guess we actually have to test this use case:

I can fix if it's one line, I just assumed it was something super hard with external urls or something.

I blame the fun police.

https://secure.phabricator.com/source/phabricator/browse/master/src/infrastructure/markup/PhabricatorMarkupEngine.php;4c7d464f8bf2627ef7455596fde2ae5667e67a57$356

Macros are disabled in Phame posts, via markup engine. This originated in D2202.

I did for now, will see what FontAwesome 5 brings, but the was never something I really liked for Phame anyways.

no no those are for the Meterology application

Theres like 20 thermometers for a health application.

also conflicts with Phabricator Health Records Application

Nobody loves making tasks and projects… what is this, a tool for PMs?

Or use heart for favorites?

Thanks, Chad. I've just used the Administrators group and adjusted the EditEngine permissions, which is sufficient for us; anyone authoritative enough to create blogs is authoritative and technically proficient enough to have admin privs, too.

Yeah, it makes sense to not auto-subscribe and I'm afraid I don't have better plans ready for cases where you don't want everyone creating blogs. You could at least make a group like "blog creators" and delegate.

My concern here is the specific request only solves a side-effect of the root problem, and not the root problem itself.

My concern here is the specific request only solves a side-effect of the root problem, and not the root problem itself. We do not expect admins to have to create blogs for people. I would like to understand better what we can do in that case.

Aside from that, I don't think it's too much of a stretch to say that as a general principle, permanent/irrevocable subscription to an object is tantamount to spam.

In T11687#195734, @chad wrote:

In my administrator/management role, I create a blog for someone else to write posts for

Why?

Specifically, a root problem would be how you got into this state to request this feature to begin with, not that you want the feature.

In my administrator/management role, I create a blog for someone else to write posts for

Sorry. I thought the root problem was obvious. I guess not.

this entire menu will likely go away

Please see Contributing Feature Requests and Describing Root Problems.

Oh man -- I didn't notice that the random test account I was logged in as in Chrome (named wwwuuu) was an administrator. I have a repro.

I poked a bit at this, but I think PhamePost is a special case, since it doesn't have a direct edit policy, it's edit policy is derived from PhameBlog and it's not clear to me how comment transactions get around edit policy in general reading through the code.

J772

Please follow the instructions in Contributing Bug Reports if you'd like to report a bug. Thanks!

FYI, there is a report about a regression from multiple users at WMFs-Phabricator: https://phabricator.wikimedia.org/T144338

Specifically if you feel this is a Phabricator issue, please provide steps we can follow on a clean/new install on http://phacility.com/. Test instances there are free to spin up any time.

Please see Contributing Bug Reports for how to file a proper bug report. See Support Resources for what resources are available for getting help configuring or using Phabricator.

I am an admin w/full permissions, but even so I've tried just doing this on my own personal blog that I created myself and can't even do that.

Specifically, if you don't have permissions to edit a blog, you should get a permissions dialog like below. Sounds like someone has been messing with the custom forms.

Looks like that'll work nicely!

Thanks for the report, and for the good reproduction instructions. D16313 should raise a better exception.

Indeed, fixed.
You guys rock!!

Specifically, this should be resolved by D16242 (July 6).

Can you update Phabricator and re-test? I expect this to already be resolved.

Resolved by D16246, I suppose.