Page MenuHomePhabricator
Differential D16493

Remove overbearing policy checks in Phame
ClosedPublic
Actions

Authored by epriestley on Sep 5 2016, 6:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 4:37 PM
Unknown Object (File)
Tue, Apr 9, 9:20 AM
Unknown Object (File)
Fri, Apr 5, 2:55 PM
Unknown Object (File)
Fri, Apr 5, 9:10 AM
Unknown Object (File)
Sat, Mar 30, 3:54 AM
Unknown Object (File)
Mar 23 2024, 10:36 AM
Unknown Object (File)
Mar 23 2024, 10:36 AM
Unknown Object (File)
Mar 23 2024, 10:36 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11584: Phame commenting policy checks are weird?
Commits
rP4b6da9735ba7: Remove overbearing policy checks in Phame
Summary

Fixes T11584. This controller does unnecessary CAN_EDIT policy checks.

These checks are enforced by EditEngine, and you can make certain types of edits (including comments) even without full-blown edit permission.

Test Plan
  • Commented as a user without edit permission.
  • Tried to edit as a user without edit permission, was rebuffed with a policy dialog.
  • Edited as a user with edit permission.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39692.Sep 5 2016, 6:52 PM
epriestley retitled this revision from to Remove redundant policy checks in Phame.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11584: Phame commenting policy checks are weird?.
epriestley retitled this revision from Remove redundant policy checks in Phame to Remove overbearing policy checks in Phame.Sep 5 2016, 6:54 PM
chad accepted this revision.Sep 5 2016, 6:59 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 5 2016, 6:59 PM
epriestley updated this revision to Diff 39693.Sep 5 2016, 7:08 PM
epriestley edited edge metadata.
  • Provide slightly cleaner feedback for trying to write a new post on a blog.
  • Slightly more efficient query strategy.
Closed by commit rP4b6da9735ba7: Remove overbearing policy checks in Phame (authored by epriestley, committed by epriestley). · Explain WhySep 5 2016, 7:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phame/
controller/
post/
39 lines

Diff 39694

View Options

src/applications/phame/controller/post/PhamePostEditController.php

Loading...
Phabricator · Built by Phacility