Paths

Table of Contentst

Make Phame blog policies non-nullable
ClosedPublic
Actions

Authored by epriestley on Apr 1 2022, 6:42 PM.

Tags

None

Referenced Files

	F19910129: D21748.diff
	Thu, Apr 2, 4:54 AM

	F19897081: D21748.id51846.diff
	Sun, Mar 29, 6:26 AM

	F19894734: D21748.id51846.diff
	Sat, Mar 28, 4:44 PM

	F19810985: D21748.id51855.diff
	Mar 3 2026, 10:19 PM

	F19796422: D21748.id51855.diff
	Feb 27 2026, 3:26 PM

	F19699381: D21748.id51855.diff
	Feb 10 2026, 7:48 PM

	F19550804: D21748.id51855.diff
	Jan 28 2026, 4:12 AM

	F19547498: D21748.id51846.diff
	Jan 26 2026, 8:14 AM

View All Files

Subscribers

Restricted Owners Package

Details

Reviewers: None
Maniphest Tasks: T6203: Adjust nullability of various questionable columns
T13661: Give Phame configurable interact policies
Commits: rP28b12fb3cdaf: Make Phame blog policies non-nullable

Summary

Ref T6203. Ref T13661. These policies are incorrectly nullable, although it's likely that no pathway exists in the application to write NULL into them. Fix the schema.

Test Plan

Ran bin/storage upgrade.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 1 2022, 6:42 PM

Owners added a subscriber: Restricted Owners Package.Apr 1 2022, 6:42 PM

epriestley requested review of this revision.Apr 1 2022, 6:42 PM

Harbormaster completed remote builds in B25631: Diff 51846.Apr 1 2022, 6:43 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 1 2022, 7:53 PM

Closed by commit rP28b12fb3cdaf: Make Phame blog policies non-nullable (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP28b12fb3cdaf: Make Phame blog policies non-nullable.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20220401.phameinteract.01.sql

5 lines

20220401.phameinteract.02.sql

5 lines

src/

applications/

phame/

storage/

PhameBlog.php

6 lines

Diff 51855

View Options

resources/sql/autopatches/20220401.phameinteract.01.sql

View Options

resources/sql/autopatches/20220401.phameinteract.02.sql

View Options

src/applications/phame/storage/PhameBlog.php

Make Phame blog policies non-nullableClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 51855

resources/sql/autopatches/20220401.phameinteract.01.sql

resources/sql/autopatches/20220401.phameinteract.02.sql

src/applications/phame/storage/PhameBlog.php

Make Phame blog policies non-nullable
ClosedPublic
Actions

Revision Contents
Changeset List