Page MenuHomePhabricator
Create Task
Maniphest T13661

Give Phame configurable interact policies
Closed, ResolvedPublic
Actions

Description

This is purely to make my life easier, but the "Phacility is winding down operations" blog post has attracted a number of lonely women and Khajiit merchants eager to offer wares if you have coin.

Exposing "Can Interact" as a configurable policy (so commenting can effectively be disabled) seems reasonable as a remedy? I think there can probably be a blog-level policy and a post-level Object policy which defaults to "Use Blog Policy".

"Can Interact" isn't currently exposed anywhere as a configurable policy, but I believe it isn't fundamentally difficult to do this.

Revisions and Commits

rP Phabricator
D21755rP4dae3e7e1fbf Improve some UI/language for Phame posts when viewer doesn't have CAN_INTERACT
D21754rPaae23f020476 Give Phame blog posts configurable interact policies, with a default policy of…
D21751rPc25595417f8a Give Phame blogs mutable interact policies
D21753rPf555fbcb50db Remove unused "MARKUP_FIELD_SUMMARY" for Phame posts
D21749rP6c2c80a3731c Remove ancient Remarkup constants from Phame and Maniphest
D21750rP5ce7f803f90e Fix double-bordered breadcrumbs in Phame blogs
D21748rP28b12fb3cdaf Make Phame blog policies non-nullable

Event Timeline

epriestley triaged this task as Low priority.Jul 21 2021, 9:25 PM
epriestley created this task.
epriestley updated the task description. (Show Details)
epriestley added a revision: D21748: Make Phame blog policies non-nullable.Apr 1 2022, 6:42 PM
epriestley added a revision: D21749: Remove ancient Remarkup constants from Phame and Maniphest.Apr 1 2022, 6:46 PM
epriestley added a revision: D21750: Fix double-bordered breadcrumbs in Phame blogs.Apr 1 2022, 6:48 PM
epriestley added a revision: D21751: Give Phame blogs mutable interact policies.Apr 1 2022, 7:05 PM
epriestley added a revision: D21753: Remove unused "MARKUP_FIELD_SUMMARY" for Phame posts.Apr 1 2022, 7:16 PM
epriestley added a revision: D21754: Give Phame blog posts configurable interact policies, with a default policy of "Same as Blog".Apr 1 2022, 7:41 PM
epriestley added a revision: D21755: Improve some UI/language for Phame posts when viewer doesn't have CAN_INTERACT.Apr 1 2022, 7:49 PM
epriestley added a comment.Apr 1 2022, 7:52 PM

This has some rough edges that I'm not going to deal with for now:

  • The implementation in "PhameInheritBlogPolicyRule" is not general (it can only evaluate the "Can Interact" capability), but it can't currently be implemented properly (without changes to how "PolicyRule" works) and can't currently be reached with any capability other than "Can Interact". This is a bit of a "gotcha" if posts ever have custom policies, but should always produce correct behavior today.
  • Some of the UI and language could be better, notably you get an "Override Lock?" sort of prompt when you try to edit a post you have permission to edit but can't comment on. This prompt should probably be omitted in Phame, but is an inherited behavior from Maniphest.
epriestley added a commit: rP28b12fb3cdaf: Make Phame blog policies non-nullable.Apr 1 2022, 7:53 PM
epriestley added a commit: rP6c2c80a3731c: Remove ancient Remarkup constants from Phame and Maniphest.
epriestley added a commit: rP5ce7f803f90e: Fix double-bordered breadcrumbs in Phame blogs.
epriestley added a commit: rPf555fbcb50db: Remove unused "MARKUP_FIELD_SUMMARY" for Phame posts.
epriestley added a commit: rPc25595417f8a: Give Phame blogs mutable interact policies.
epriestley added a commit: rPaae23f020476: Give Phame blog posts configurable interact policies, with a default policy of….
epriestley added a commit: rP4dae3e7e1fbf: Improve some UI/language for Phame posts when viewer doesn't have CAN_INTERACT.
epriestley closed this task as Resolved.Apr 19 2022, 9:07 PM
epriestley claimed this task.

I deployed this and it seems to be working properly.

Phabricator · Built by Phacility