I think https://secure.phabricator.com/book/phabricator/article/remarkup/ needs update to include this.

I've removed the requirement that prototypes be enabled and marked this as fixed in D19195. The behavior could probably be refined, but I think it should fail in an obvious way when it fails, now.

This should clearly be priority: Unbreak now!

This still needs another transaction type for installations/uninstallations; diff coming soon.

A related issue is that when you use {Fxxx} to embed an image as a thumbnail, we can fail with a default thumbnail if:

I think:

What's the status on this right now? Looks like a fun thing to try and get over the finish line.

@amckinley Let me know if you need more to go on than the description above or get stuck anywhere.

Actually I'll leave this open if someone wants to contribute a patch.

For the migration, let me just publish "run this command if you want to search existing files" in the change log for now, and then we can do the real migration if we see confusion about it. I bet 99% of the time you want to search for something you recently uploaded so the index will be functionally useful in a week even if you miss the guidance in the changelog.

To make the indexing work for new stuff, I think you can do this:

@epriestley I just landed D17702, without really tackling the problem of files being created in non-standard code paths. I searched the codebase for PhabricatorFile::initializeNewFile() and didn't find anything scary-looking; do you have any specific examples that might need updating?

Oh right. I mean Phacility doesn't cater to those people anyway since all repositories are private (and can't be public), so I don't think you have much to worry about there.

To clarify, I meant this:

Well, this is a GitHub-like isn't it? In the context of what was quoted, it was specifically GitHub itself that was mentioned.

I'd guess most people use the free Phacility plan because they need private repositories.

I don't think so because there are GitHub like solution that offer private repositories for free.

I'd personally be completely happy if all free users use GitHub forever and we only take their paying users

• PhabricatorSyntaxHighlightingConfigOptions defines this option.
• Change the type from wild to custom:SomeClassName to switch to a custom type validator.
• The new validator class should subclass PhabricatorConfigJSONOptionType.
• You can look at PhabricatorKeyringConfigOptionType for a (more complex) example of how to validate a value.
• Test by trying to change the value to something invalid, you should get an error.
• You can test a regexp is valid like this:

See also T12532 for related work.

We ultimately built an "ngram index" for this task, see T9979 for discussion.

• T11586 has context.
• D16541 added PHUIInvisibleCharacterView and has usage examples.
• Go hunt down as many error messages which include user input in a validation error as you can find/test and wrap them in PHUIInvisibleCharacterView. The task description lists some. I don't think there's any systematic way to find these, and we shouldn't expect to be exhaustive.
• Close this when satisfied / bored / everything else is too much of a pain to test.
• Primary goal here is just an onboarding goal of poking around some different applications, we haven't really seen users hit this stuff.

• When you click "Delete File", we currently delete the file in the web process. Since we've supported enormous files and pluggable storage backends for a while, this could take an arbitrarily long amount of time to complete.
  • Instead, we want to flag the file as "deleted", hide it in the web UI, and queue up a task in the daemons to actually get rid of the data.