Robustly fuse files together with `arc weld`
ClosedPublic
Actions

Authored by epriestley on Feb 13 2018, 11:12 PM.

Details

Reviewers: None
Maniphest Tasks: T8236: `arc weld` should do something
Commits: rARC8fe1d7701e5d: (stable) Promote 2018 Week 7
rARCbe1dd7e2ba23: Robustly fuse files together with `arc weld`

Summary

Fixes T8236. I played around with a lot of variations of this but in the end it felt like the simple version was best.

Test Plan

Ran arc weld a.txt b.txt, observed very robust fusion of materials.

Repository

rARC Arcanist

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

epriestley requested review of this revision.Feb 13 2018, 11:12 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2018, 11:15 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/__phutil_library_map__.php (2 lines)
A	M		src/workflow/ArcanistWeldWorkflow.php (133 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	45736	3491094		Feb 13 2018, 11:11 PM	★	★
Diff 2	45737	3491094	rARCbe1dd7e2ba230d77f894637fdcbc7d5a47dc7082	Feb 13 2018, 11:15 PM	★	★