Page MenuHomePhabricator

Make Applications extend LiskDAO
ClosedPublic

Authored by epriestley on Apr 19 2017, 10:58 PM.
Tags
None
Referenced Files
F15462572: D17738.id.diff
Tue, Apr 1, 4:04 PM
F15461103: D17738.id42667.diff
Tue, Apr 1, 5:16 AM
F15459229: D17738.id42668.diff
Mon, Mar 31, 11:11 AM
F15449775: D17738.id42668.diff
Fri, Mar 28, 12:12 PM
F15447654: D17738.id.diff
Fri, Mar 28, 12:50 AM
F15442362: D17738.diff
Wed, Mar 26, 10:57 PM
F15431907: D17738.diff
Mon, Mar 24, 3:20 PM
F15415687: D17738.diff
Thu, Mar 20, 7:27 AM
Subscribers
None

Details

Summary

Ref T11476. This is a bit hacky, but makes Application extend LiskDAO so we can apply transactions to it with an Editor class.

Also fixes schema stuff so builds should produce a clean bill of health again.

This might only get you slightly further, yell if you run into more trouble.

Test Plan
  • Ran bin/storage upgrade -f and got no warnings.
  • Browsed around, nothing exploded?

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I also got rid of TransactionComment since we don't have a table for it, it's optional, and we probably don't need to let users comment on applications (hopefully?).

amckinley added inline comments.
src/applications/base/PhabricatorApplication.php
36

Sung to the tune of "Doctor Zaius Doctor Zaius"

This revision is now accepted and ready to land.Apr 19 2017, 11:02 PM
This revision was automatically updated to reflect the committed changes.