Page MenuHomePhabricator

Make Applications extend LiskDAO
ClosedPublic

Authored by epriestley on Apr 19 2017, 10:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 3:41 PM
Unknown Object (File)
Feb 13 2024, 6:41 PM
Unknown Object (File)
Feb 13 2024, 6:14 PM
Unknown Object (File)
Jan 23 2024, 1:49 PM
Unknown Object (File)
Jan 6 2024, 10:23 AM
Unknown Object (File)
Dec 27 2023, 10:44 AM
Unknown Object (File)
Dec 27 2023, 10:43 AM
Unknown Object (File)
Dec 27 2023, 10:43 AM
Subscribers
None

Details

Summary

Ref T11476. This is a bit hacky, but makes Application extend LiskDAO so we can apply transactions to it with an Editor class.

Also fixes schema stuff so builds should produce a clean bill of health again.

This might only get you slightly further, yell if you run into more trouble.

Test Plan
  • Ran bin/storage upgrade -f and got no warnings.
  • Browsed around, nothing exploded?

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I also got rid of TransactionComment since we don't have a table for it, it's optional, and we probably don't need to let users comment on applications (hopefully?).

amckinley added inline comments.
src/applications/base/PhabricatorApplication.php
36

Sung to the tune of "Doctor Zaius Doctor Zaius"

This revision is now accepted and ready to land.Apr 19 2017, 11:02 PM
This revision was automatically updated to reflect the committed changes.