Page MenuHomePhabricator
Feed Advanced Search

Sep 8 2016

epriestley closed T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages as Resolved.

Presuming resolved until we hear otherwise.

Sep 8 2016, 2:49 PM · Setup
epriestley added a comment to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.

Someone in IRC hit this on stable and I haven't seen more reports on master, so I'm going to bring the changes over.

Sep 8 2016, 2:22 PM · Setup

Sep 7 2016

epriestley closed T11583: When initializing a new database, just apply adjustments without prompting as Resolved by committing rPb7e51877c316: Make storage adjustment a little nicer, especially the first time.
Sep 7 2016, 4:09 PM · NUX, Setup
epriestley added a revision to T11583: When initializing a new database, just apply adjustments without prompting: D16509: Make storage adjustment a little nicer, especially the first time.
Sep 7 2016, 2:54 PM · NUX, Setup

Sep 6 2016

epriestley added a comment to T11571: Consider benchmarking hardware during setup.

We can just query that as a setup check, although I don't recall too many issues with it recently.

Sep 6 2016, 11:28 PM · Setup
avivey added a comment to T11571: Consider benchmarking hardware during setup.

maybe also DB's max_connections?

Sep 6 2016, 11:24 PM · Setup
epriestley added a comment to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.

I believe this is fixed in HEAD of master now. Let me know if things look good on your end and I'll cherry-pick the fixes to stable?

Sep 6 2016, 9:21 PM · Setup
epriestley added a revision to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages: D16503: Add a friendlier "in flight" error page.
Sep 6 2016, 8:53 PM · Setup
epriestley added a revision to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages: D16502: Continue on bad database configuration from select scripts.
Sep 6 2016, 8:25 PM · Setup
epriestley added a revision to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages: D16501: Raise setup warnings immediately when failing to load configuration from the database.
Sep 6 2016, 7:59 PM · Setup
epriestley added a revision to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages: D16500: Split setup check phases into "preflight" and "post-config".
Sep 6 2016, 7:29 PM · Setup
epriestley added a revision to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages: D16499: Split setup checks into "preflight" and "normal" checks.
Sep 6 2016, 6:11 PM · Setup
epriestley added a comment to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.

Here's my general plan of attack here:

Sep 6 2016, 6:06 PM · Setup

Sep 5 2016

PicoCreator added a comment to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.

@epriestley : Alright then, Thanks.

Sep 5 2016, 4:53 PM · Setup
epriestley added a comment to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.

You can manually edit conf/local/local.json instead of using bin/config set.

Sep 5 2016, 4:52 PM · Setup
PicoCreator added a comment to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.

@epriestley : Ouch! - Alternatively since all of you are already on it. What git commit can i revert to quickly fix this? (Note it was a clean clone i am trying to re-setup)

Sep 5 2016, 4:49 PM · Setup
epriestley added a comment to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.

Sniped!

Sep 5 2016, 4:48 PM · Setup
chad merged T11594: phabricator ./bin/config - now requires a DB connection (Q_Q) into T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.
Sep 5 2016, 4:48 PM · Setup
epriestley merged T11594: phabricator ./bin/config - now requires a DB connection (Q_Q) into T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.
Sep 5 2016, 4:48 PM · Setup
epriestley added a comment to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.

This is somewhat involved to untangle because the old logic was actually wrong and had a small chance of executing a page incorrectly.

Sep 5 2016, 4:36 PM · Setup
epriestley added a comment to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.

Ah, okay, that's actually consistent with what I'm seeing -- I think I repro'd the web version. You do sometimes need to restart the web thing to get this flow to work fully (we run some special, more-helpful checks during setup, which is only run after restart), but I believe it doesn't matter in this case since the setup checks are a little buggy.

Sep 5 2016, 3:42 PM · Setup
chad added a comment to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.

maybe I need to restart?

Sep 5 2016, 3:40 PM · Setup
chad added a comment to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.

It does work from CLI, not from web.

Sep 5 2016, 3:40 PM · Setup
chad added a comment to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.

let me try again since I've gotten sleep. 8)

Sep 5 2016, 3:36 PM · Setup
epriestley updated subscribers of T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.

@chad, I'm having trouble reproducing the patch from P2007 not working. Here's what I did:

Sep 5 2016, 3:32 PM · Setup
epriestley renamed T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages from Phabricator configuration with invalid MySQL credentials isn't getting to the help pages to Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.
Sep 5 2016, 3:03 PM · Setup
epriestley created T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.
Sep 5 2016, 3:02 PM · Setup

Sep 3 2016

chad added a comment to T11583: When initializing a new database, just apply adjustments without prompting.

thx

Sep 3 2016, 8:05 PM · NUX, Setup
epriestley created T11583: When initializing a new database, just apply adjustments without prompting.
Sep 3 2016, 6:52 PM · NUX, Setup

Sep 1 2016

epriestley created T11571: Consider benchmarking hardware during setup.
Sep 1 2016, 2:24 PM · Setup

Aug 29 2016

epriestley added subtasks for T11553: Add various "make an HTTP call" setup checks, and run them in parallel: T2226: Include a setup test for gzip enabled on the server, T4921: Detect when webserver configuration does not forward HTTP authorization, T6866: Add setup check for missing QSA in rewrite rules, T6709: Update server requirements in docs, T11544: Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS, T4854: Detect mod_pagespeed and warn the user, or don't break when it is enabled, T5067: Can't browse or see history of any files with a '+' in the file path., T10597: Custom Project query results in . url which nginx blocks.
Aug 29 2016, 4:22 PM · Setup
epriestley added a parent task for T4921: Detect when webserver configuration does not forward HTTP authorization: T11553: Add various "make an HTTP call" setup checks, and run them in parallel.
Aug 29 2016, 4:22 PM · Setup
epriestley added a parent task for T2226: Include a setup test for gzip enabled on the server: T11553: Add various "make an HTTP call" setup checks, and run them in parallel.
Aug 29 2016, 4:22 PM · Setup
epriestley added a parent task for T6866: Add setup check for missing QSA in rewrite rules: T11553: Add various "make an HTTP call" setup checks, and run them in parallel.
Aug 29 2016, 4:22 PM · Setup
epriestley added a parent task for T4854: Detect mod_pagespeed and warn the user, or don't break when it is enabled: T11553: Add various "make an HTTP call" setup checks, and run them in parallel.
Aug 29 2016, 4:22 PM · Setup
epriestley created T11553: Add various "make an HTTP call" setup checks, and run them in parallel.
Aug 29 2016, 4:21 PM · Setup
epriestley added a comment to T11544: Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS.

Specifically, my plan here is:

Aug 29 2016, 4:14 PM · Documentation, Setup

Aug 26 2016

epriestley triaged T11544: Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS as Low priority.
Aug 26 2016, 11:51 PM · Documentation, Setup
epriestley closed T9235: Add a warning about "always_populate_raw_post_data" being misconfigured as Resolved by committing rP72a03dc03e7d: Add a setup warning for "always_populate_raw_post_data".
Aug 26 2016, 2:38 PM · Contributor Onboarding, Setup

Aug 25 2016

epriestley added a revision to T9235: Add a warning about "always_populate_raw_post_data" being misconfigured: D16454: Add a setup warning for "always_populate_raw_post_data".
Aug 25 2016, 10:49 PM · Contributor Onboarding, Setup
epriestley claimed T9235: Add a warning about "always_populate_raw_post_data" being misconfigured.

I was ultimately able to reproduce this, but it took some work and the instructions above definitely weren't sufficeient:

Aug 25 2016, 10:38 PM · Contributor Onboarding, Setup
epriestley added a comment to T9235: Add a warning about "always_populate_raw_post_data" being misconfigured.

Alright, let me see if I can get anywhere with this.

Aug 25 2016, 10:14 PM · Contributor Onboarding, Setup
jcox added a comment to T9235: Add a warning about "always_populate_raw_post_data" being misconfigured.

I've tried a whole bunch of different post requests (after setting those config values and restarting apache) but I haven't been able to get that garbage yet.

Aug 25 2016, 8:40 PM · Contributor Onboarding, Setup
jcox closed T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'] as Resolved by committing rPa88dc2afc2a9: Added a setup check for empty REMOTE_ADDR.
Aug 25 2016, 5:06 PM · Contributor Onboarding, Setup
jcox added a revision to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR']: D16450: Added a setup check for empty REMOTE_ADDR.
Aug 25 2016, 4:32 PM · Contributor Onboarding, Setup
epriestley added a comment to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'].

First, let's sort of limit the direct damage this misconfiguration causes by changing this line in PhabricatorUserLog->initializeNewLog():

Aug 25 2016, 2:43 PM · Contributor Onboarding, Setup
epriestley added a comment to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'].

Ah, nice! I'll write up some guidance on adding a setup check for this shortly.

Aug 25 2016, 2:22 PM · Contributor Onboarding, Setup
jcox added a comment to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'].

Alright I was finally able to reproduce it. Calling unset($_SERVER['REMOTE_ADDR']); in the preamble didn't actually end up causing it, which is a bit strange. The only way I could get this to occur was to explicitly set $_SERVER['REMOTE_ADDR'] = null; in the preamble.

Aug 25 2016, 1:47 PM · Contributor Onboarding, Setup

Aug 24 2016

epriestley merged task T7431: Redesign Welcome Screen for Admins into T11132: New Phabricator NUX.
Aug 24 2016, 11:47 PM · Setup
epriestley closed T5704: Print where we're reading configuration from on Phabricator script startup with --trace as Wontfix.

No clue what this was, haven't had issues recently. I think config may have become simpler in the last couple years.

Aug 24 2016, 7:14 PM · Setup

Aug 22 2016

epriestley moved T9235: Add a warning about "always_populate_raw_post_data" being misconfigured from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 8:59 PM · Contributor Onboarding, Setup
epriestley renamed T9235: Add a warning about "always_populate_raw_post_data" being misconfigured from schemes upgrades problem, and can't use `git clone` to Add a warning about "always_populate_raw_post_data" being misconfigured.
Aug 22 2016, 8:54 PM · Contributor Onboarding, Setup
sgielen added a comment to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'].

FWIW, in our case the bug was also triggered by logging in for the first time (for this account) using LDAP.

Aug 22 2016, 8:47 PM · Contributor Onboarding, Setup
epriestley reassigned T9235: Add a warning about "always_populate_raw_post_data" being misconfigured from epriestley to jcox.

Welcome to PHP! This will familiarize you with PHP! PHP is a special language!

Aug 22 2016, 8:47 PM · Contributor Onboarding, Setup
epriestley merged T8253: Upload file fails, probably my fault into T9235: Add a warning about "always_populate_raw_post_data" being misconfigured.
Aug 22 2016, 8:41 PM · Contributor Onboarding, Setup
epriestley moved T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'] from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 8:12 PM · Contributor Onboarding, Setup
epriestley assigned T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'] to jcox.

Phabricator can be configured with a "preamble" script, for making certain environmental adjustments to deal with loadbalancers. This is described in Configuring a Preamble Script.

Aug 22 2016, 8:11 PM · Contributor Onboarding, Setup
epriestley added a project to T8330: Detect/repair invalid "enum" config: Contributor Onboarding.
Aug 22 2016, 6:53 PM · Contributor Onboarding, Setup
epriestley added a project to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR']: Contributor Onboarding.
Aug 22 2016, 6:42 PM · Contributor Onboarding, Setup
epriestley added a project to T9235: Add a warning about "always_populate_raw_post_data" being misconfigured: Contributor Onboarding.
Aug 22 2016, 6:33 PM · Contributor Onboarding, Setup

Jul 25 2016

eadler merged T11370: RHEL Install script does not always install gcc if needed into T4200: Building OS packages and install scripts.
Jul 25 2016, 4:13 PM · Guides, Setup
chad merged T11370: RHEL Install script does not always install gcc if needed into T4200: Building OS packages and install scripts.
Jul 25 2016, 4:13 PM · Guides, Setup

Jul 22 2016

epriestley added a project to T4964: Windows installer for Arcanist: Windows.
Jul 22 2016, 5:34 PM · Windows, Wikimedia, Setup, Arcanist

Jul 21 2016

epriestley moved T4964: Windows installer for Arcanist from Backlog to Far Future on the Arcanist board.
Jul 21 2016, 12:11 PM · Windows, Wikimedia, Setup, Arcanist

Jul 7 2016

sgielen added a comment to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'].

I just had this problem as well. Turns out I had a typo in preamble.php. A more descriptive error would be nice, but with this task open at least the cause is easy to find :)

Jul 7 2016, 12:30 PM · Contributor Onboarding, Setup

Jun 19 2016

MatheusVieira added a comment to T4200: Building OS packages and install scripts.

@epriestley no i dont have any relationship with core Sandstorm, I'm a user and a fan of both apps. I'm just a student who wants to make life easier for the end user , and you create as much repercussion about it, I want to help phabricator and all other tools that I believe I send this text.

Jun 19 2016, 11:21 PM · Guides, Setup
epriestley added a comment to T4200: Building OS packages and install scripts.

I followed up on this in #sandstorm on Freenode but this isn't officially sanctioned as far as anyone there knew. They're not particularly happy about this either, but obviously there's little anyone can do about users going vigilante with evangelism.

Jun 19 2016, 10:42 PM · Guides, Setup
epriestley added a comment to T4200: Building OS packages and install scripts.

Oh, you've just been spamming tons and tons and tons of projects with the same message:

Jun 19 2016, 10:21 PM · Guides, Setup
epriestley added a comment to T4200: Building OS packages and install scripts.

I noticed you posted the exact same message that you posted here to Drupal, with the same spelling error of "Oasis":

Jun 19 2016, 10:15 PM · Guides, Setup
MatheusVieira added a comment to T4200: Building OS packages and install scripts.

@chad yes, and want to help who don't know how to deploy Phabricator to use Phabricator and Sandstorm is perfect to that.

Jun 19 2016, 10:11 PM · Guides, Setup
chad added a comment to T4200: Building OS packages and install scripts.

@MatheusVieira are you asking us to support it because you're a Phabricator user?

Jun 19 2016, 10:01 PM · Guides, Setup
MatheusVieira added a comment to T4200: Building OS packages and install scripts.

Link to the Sandstorm Vagrant SPK documentation - https://docs.sandstorm.io/en/latest/vagrant-spk/packaging-tutorial/

Jun 19 2016, 9:59 PM · Guides, Setup
chad merged T11175: Sandstorm Vagrant Package into T4200: Building OS packages and install scripts.
Jun 19 2016, 9:54 PM · Guides, Setup

Jun 8 2016

epriestley added a comment to T8282: What is the purpose of creating an admin account?.

Specifically, you saw this page, and decided that you were not in the right place?

Jun 8 2016, 1:40 PM · Setup
asherkin added a comment to T8282: What is the purpose of creating an admin account?.

Was there any indication that the form wasn't working / wouldn't have worked?

Jun 8 2016, 9:37 AM · Setup
mayuroks added a comment to T8282: What is the purpose of creating an admin account?.

Hi,
Thanks for responding. I was evaluating phabricator on my Ubuntu machine. I was certain the UI user registration wont work because email wont be sent out. So I went to terminal and used ./accountadmin to create an admin user.

Jun 8 2016, 7:27 AM · Setup

Jun 7 2016

asherkin added a comment to T8282: What is the purpose of creating an admin account?.

bin/auth recover is a general-purpose flow not specific to this case.

Jun 7 2016, 6:42 PM · Setup
chad added a comment to T8282: What is the purpose of creating an admin account?.

I've never needed to recover an account. Can you give us details about how you ended up in a place where you felt that was necessary?

Jun 7 2016, 6:41 PM · Setup
mayuroks added a comment to T8282: What is the purpose of creating an admin account?.

I faced the same issue too. As a user, after setting up a web UI why go back to terminal and type

./bin/auth recover <username>

and then come back to web UI to login? Once the setup is completed, a user would feel that the job is done and now he can login in peace.

Jun 7 2016, 6:31 PM · Setup
asherkin closed T10402: Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it as Resolved by committing rPf0eb6f4fe080: Add client-side check for protocol mismatch.
Jun 7 2016, 3:54 PM · Setup
asherkin added a revision to T10402: Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it: D16064: Add client-side check for protocol mismatch.
Jun 7 2016, 10:39 AM · Setup
valentinul added a comment to T10586: Call to undefined function mysql_real_escape_string().

@valentinul can you please let me know what exactly you modified in your php.ini?

Jun 7 2016, 7:49 AM · Setup, Bug Report

Jun 6 2016

asherkin claimed T10402: Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it.
Jun 6 2016, 9:26 PM · Setup
storrgie added a comment to T10586: Call to undefined function mysql_real_escape_string().

@valentinul can you please let me know what exactly you modified in your php.ini?

Jun 6 2016, 9:18 PM · Setup, Bug Report
epriestley added a comment to T10402: Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it.

Yeah, I think something similar to D15961 is reasonable here. It's going to a little bit one-off and weird, but this and the timezone checks are the only cases where we care about client settings, I think.

Jun 6 2016, 7:17 PM · Setup
asherkin added a comment to T10402: Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it.

@epriestley am I good to take a stab here at implementing the T3025-like behaviour?
If user is admin and clientProto != serverProto, display notification.
Approximately 5% familiar with Phabricator's JS side, but always interested in poking around more of the codebase - and I'm guessing most of this is gonna be touched in D15961.

Jun 6 2016, 7:05 PM · Setup

May 19 2016

chad added projects to T10931: Changing mysql.implementation setting doesn't work: Database, Setup.
May 19 2016, 5:08 PM · Setup, Database, Bug Report

May 4 2016

epriestley added a comment to T10402: Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it.

Some things we can do easily here:

May 4 2016, 4:19 PM · Setup
eadler merged T10919: Websocket notification not working anymore after upgrade from 2016 week 15 to 2016 week 18 (stable branch) into T10402: Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it.
May 4 2016, 4:03 PM · Setup

Apr 29 2016

chad updated the task description for T4947: SELinux / AppArmor ruin everything all the time.
Apr 29 2016, 5:29 PM · Setup

Apr 3 2016

paladox added a comment to T4964: Windows installer for Arcanist.

@epriestley and @mattflaschen I have created a windows installer here https://github.com/paladox/Arcanist-installer-for-windows

Apr 3 2016, 12:18 PM · Windows, Wikimedia, Setup, Arcanist

Apr 2 2016

paladox added a comment to T4964: Windows installer for Arcanist.

There are free installers that create the installation we want like

Apr 2 2016, 4:46 PM · Windows, Wikimedia, Setup, Arcanist
chad updated subscribers of T4964: Windows installer for Arcanist.
Apr 2 2016, 4:44 PM · Windows, Arcanist, Setup, Wikimedia

Mar 15 2016

valentinul added a comment to T10586: Call to undefined function mysql_real_escape_string().

OK, after installing all the necessary extensions and changing the php.ini as recommended by phabricator everything works nice.

Mar 15 2016, 12:19 PM · Setup, Bug Report
valentinul added a comment to T10586: Call to undefined function mysql_real_escape_string().

OK, I'm going to switch to php7 and see if it goes.

Mar 15 2016, 11:48 AM · Setup, Bug Report
epriestley added a comment to T2383: Run PHP environment checks from CLI.

T10586 is likely a second case (similar to T7248) of a user without mysql or mysqli.

Mar 15 2016, 11:47 AM · Setup
epriestley updated subscribers of T2383: Run PHP environment checks from CLI.
Mar 15 2016, 11:47 AM · Setup
epriestley merged task T10586: Call to undefined function mysql_real_escape_string() into T2383: Run PHP environment checks from CLI.
Mar 15 2016, 11:47 AM · Setup, Bug Report
epriestley added a comment to T10586: Call to undefined function mysql_real_escape_string().

T9640 is tracking PHP7 compatibility. We haven't extensively tested Phabricator on PHP7 yet, but I believe several users are running it without any issues. We're happy to fix issues you encounter with PHP7 if you report them.

Mar 15 2016, 11:46 AM · Setup, Bug Report
valentinul added a comment to T10586: Call to undefined function mysql_real_escape_string().

@epriestley that is from PHP 5.6.17

Mar 15 2016, 11:43 AM · Setup, Bug Report