Page MenuHomePhabricator

Split setup check phases into "preflight" and "post-config"
ClosedPublic

Authored by epriestley on Sep 6 2016, 7:29 PM.
Tags
None
Referenced Files
F13096666: D16500.diff
Thu, Apr 25, 6:13 PM
Unknown Object (File)
Wed, Apr 24, 10:27 PM
Unknown Object (File)
Mon, Apr 22, 1:51 PM
Unknown Object (File)
Tue, Apr 9, 3:59 PM
Unknown Object (File)
Mon, Apr 8, 5:47 PM
Unknown Object (File)
Sun, Mar 31, 9:03 PM
Unknown Object (File)
Fri, Mar 29, 6:51 PM
Unknown Object (File)
Mar 13 2024, 8:11 PM
Subscribers
None

Details

Summary

Ref T11589. This runs:

  • preflight checks (critical checks: PHP version stuff, extensions);
  • configuration;
  • normal checks.

The PHP checks are split into critical ("bad version") and noncritical ("sub-optimal config").

I tidied up the extension checks slightly, we realistically depend on cURL nowadays.

Test Plan
  • Faked a preflight failure.
  • Hit preflight check.
  • Got expected error screen.
  • Loaded normal pages.
  • Hit a normal setup check.
  • Used DarkConsole "Startup" tab to verify that preflight checks take <1ms to run (we run them on every page without caching, at least for now, but they only do trivial checks like PHP versions).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Split setup check phases into "preflight" and "post-config".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 6 2016, 8:18 PM
This revision was automatically updated to reflect the committed changes.