Page MenuHomePhabricator

Split setup check phases into "preflight" and "post-config"
ClosedPublic

Authored by epriestley on Sep 6 2016, 7:29 PM.
Tags
None
Referenced Files
F15458656: D16500.id39715.diff
Mon, Mar 31, 6:02 AM
F15432056: D16500.id39710.diff
Mon, Mar 24, 3:57 PM
F15420835: D16500.diff
Fri, Mar 21, 6:12 PM
F15407512: D16500.id39710.diff
Tue, Mar 18, 5:57 PM
F15388991: D16500.id39710.diff
Sat, Mar 15, 4:47 AM
Unknown Object (File)
Feb 24 2025, 8:09 AM
Unknown Object (File)
Feb 22 2025, 7:01 AM
Unknown Object (File)
Feb 18 2025, 11:42 AM
Subscribers
None

Details

Summary

Ref T11589. This runs:

  • preflight checks (critical checks: PHP version stuff, extensions);
  • configuration;
  • normal checks.

The PHP checks are split into critical ("bad version") and noncritical ("sub-optimal config").

I tidied up the extension checks slightly, we realistically depend on cURL nowadays.

Test Plan
  • Faked a preflight failure.
  • Hit preflight check.
  • Got expected error screen.
  • Loaded normal pages.
  • Hit a normal setup check.
  • Used DarkConsole "Startup" tab to verify that preflight checks take <1ms to run (we run them on every page without caching, at least for now, but they only do trivial checks like PHP versions).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Split setup check phases into "preflight" and "post-config".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 6 2016, 8:18 PM
This revision was automatically updated to reflect the committed changes.