Fixes T10402.
I tried about 50 variations on the wording and notification layout, this seemed by far the most reasonable.
Didn't implement a way to ignore the warning, which might be required - but figured this is serious and broken enough while being completely invisible 99% of the time that it's worth shouting about.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T10402: Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it
- Commits
- rPf0eb6f4fe080: Add client-side check for protocol mismatch
Messed around with $_SERVER['HTTPS'] on the server side and client_uri on the client side - saw reasonable results in all combinations.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Cool, this looks great to me. Thanks!
One possible though is that we might want to send the user somewhere local and more narrowly tailored to the specific problem (in case we change preamble later, or that document gets bigger / less focused), but we can do that later if this proves confusing or whatever. There also isn't any particularly convenient way to ship the user somewhere reasonable right now without building a whole controller just for the one page.