Page MenuHomePhabricator

Detect timezone discrepancies and prompt users to reconcile them
ClosedPublic

Authored by epriestley on May 21 2016, 7:18 PM.
Tags
None
Referenced Files
F15489310: D15961.id.diff
Fri, Apr 11, 7:48 AM
F15487650: D15961.diff
Thu, Apr 10, 3:53 PM
F15418626: D15961.id38427.diff
Fri, Mar 21, 12:30 AM
F15389020: D15961.diff
Sat, Mar 15, 4:49 AM
F15287049: D15961.id38427.diff
Mar 4 2025, 7:35 PM
Unknown Object (File)
Mar 2 2025, 10:48 AM
Unknown Object (File)
Mar 2 2025, 10:21 AM
Unknown Object (File)
Mar 2 2025, 10:21 AM
Subscribers
None

Details

Summary

Ref T3025. This adds a check for different client/server timezone offsets and gives users an option to fix them or ignore them.

Test Plan
  • Fiddled with timezone in Settings and System Preferences.
  • Got appropriate prompts and behavior after simulating various trips to and from exotic locales.

In particular, this slightly tricky case seems to work correctly:

  • Travel to NY.
  • Ignore discrepancy (you're only there for a couple hours for an important meeting, and returning to SF on a later flight).
  • Return to SF for a few days.
  • Travel back to NY.
  • You should be prompted again, since you left the timezone after you ignored the discrepancy.

Screen Shot 2016-05-21 at 3.08.53 PM.png (722×1 px, 90 KB)

Screen Shot 2016-05-21 at 3.09.08 PM.png (615×1 px, 125 KB)

Screen Shot 2016-05-21 at 3.09.23 PM.png (722×1 px, 89 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable