Page MenuHomePhabricator

Detect timezone discrepancies and prompt users to reconcile them
ClosedPublic

Authored by epriestley on May 21 2016, 7:18 PM.
Tags
None
Referenced Files
F19075338: D15961.id.diff
Dec 1 2025, 9:27 AM
F19070485: D15961.diff
Nov 30 2025, 5:12 PM
F18943884: D15961.diff
Nov 11 2025, 2:56 PM
F18852370: D15961.id.diff
Oct 31 2025, 8:11 AM
F18850493: D15961.diff
Oct 30 2025, 5:23 PM
F18825256: D15961.id.diff
Oct 23 2025, 8:37 PM
F18790077: D15961.id38427.diff
Oct 15 2025, 12:24 PM
F18781091: D15961.id38427.diff
Oct 12 2025, 9:25 PM
Subscribers
None

Details

Summary

Ref T3025. This adds a check for different client/server timezone offsets and gives users an option to fix them or ignore them.

Test Plan
  • Fiddled with timezone in Settings and System Preferences.
  • Got appropriate prompts and behavior after simulating various trips to and from exotic locales.

In particular, this slightly tricky case seems to work correctly:

  • Travel to NY.
  • Ignore discrepancy (you're only there for a couple hours for an important meeting, and returning to SF on a later flight).
  • Return to SF for a few days.
  • Travel back to NY.
  • You should be prompted again, since you left the timezone after you ignored the discrepancy.

Screen Shot 2016-05-21 at 3.08.53 PM.png (722×1 px, 90 KB)

Screen Shot 2016-05-21 at 3.09.08 PM.png (615×1 px, 125 KB)

Screen Shot 2016-05-21 at 3.09.23 PM.png (722×1 px, 89 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable