Page MenuHomePhabricator

Add a friendlier "in flight" error page
ClosedPublic

Authored by epriestley on Sep 6 2016, 8:53 PM.
Tags
None
Referenced Files
F19022916: D16503.diff
Sun, Nov 23, 10:29 PM
F18944979: D16503.id39713.diff
Tue, Nov 11, 5:25 PM
F18919713: D16503.id.diff
Nov 9 2025, 12:12 PM
F18904214: D16503.diff
Nov 8 2025, 8:13 AM
F18833011: D16503.diff
Oct 26 2025, 12:15 AM
F18807818: D16503.id39723.diff
Oct 19 2025, 3:29 AM
F18807817: D16503.id39713.diff
Oct 19 2025, 3:29 AM
F18807816: D16503.id.diff
Oct 19 2025, 3:29 AM
Subscribers
None

Details

Summary

Ref T11589. When we hit a fatal setup issue (essentially always a connection failure) after we've already survived them on at least one request, we can be pretty sure a server went down and that the problem is not a setup/configuration issue.

In this case, show a friendlier error page instead of the fairly detailed technical one.

Test Plan
  • Broke MySQL config.
  • Restarted Apache.
  • Got the "admin/setup" error page:

Screen Shot 2016-09-06 at 1.50.21 PM.png (1×1 px, 137 KB)

  • Fixed the MySQL config.
  • Loaded any page, to put us "in flight".
  • Broke MySQL config.
  • Loaded any page.
  • Got the friendly "in flight" error page:

Screen Shot 2016-09-06 at 1.48.05 PM.png (1×1 px, 68 KB)

If you want to design this better, easiest way to get to it is:

  • Set mysql.port to 9999 in conf/local/local.json.
  • Reload any page while already running (don't restart).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable