Page MenuHomePhabricator
Feed Advanced Search

Oct 25 2016

epriestley added a comment to T7607: Invoicing emails probably need some work.

I guess the Merchant version would be businessAddress or something since Merchants aren't normally billed.

Oct 25 2016, 4:39 PM · Phortune, Phacility
epriestley added a comment to T7607: Invoicing emails probably need some work.

I think we could reasonably do this:

Oct 25 2016, 4:38 PM · Phortune, Phacility
epriestley added a comment to T7607: Invoicing emails probably need some work.

An instance needs their own address (and some other information) on the invoice for tax purposes:

Oct 25 2016, 4:28 PM · Phortune, Phacility
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 25 2016, 4:08 PM · Restricted Project, Prioritized, Calendar
epriestley closed T11766: Write to the pull log from SSH, not just HTTP as Resolved.

It looks like the underlying issue (T11469) was resolved through configuration changes, so we don't need to go any further here. We are writing this log now, but it could use more work eventually.

Oct 25 2016, 4:05 PM · Diffusion, Phacility
epriestley closed T11766: Write to the pull log from SSH, not just HTTP, a subtask of T11469: Checking out from Phacility sometimes fails, as Resolved.
Oct 25 2016, 4:05 PM · Phacility, Bug Report
epriestley closed T11469: Checking out from Phacility sometimes fails as Resolved.

Another instance was reproducing this more frequently/reliably and reports that they're no longer seeing issues, and I haven't been able to reproduce it myself since the configuration changes. Presuming we're in the clear now, but let us know if you see further issues.

Oct 25 2016, 4:04 PM · Phacility, Bug Report
epriestley renamed T11784: Differential "stick to the comment area" and "jump to anchor" scroll behaviors interact destructively while loading content from direct links to differential comments are not scrolling to the comment to Differential "stick to the comment area" and "jump to anchor" scroll behaviors interact destructively while loading content.
Oct 25 2016, 3:50 PM · Inline Comments, Differential, Bug Report
epriestley added a comment to T11784: Differential "stick to the comment area" and "jump to anchor" scroll behaviors interact destructively while loading content.

I think this is actually a bug between several of the 300 different pieces of scroll magic we have on the page.

Oct 25 2016, 3:49 PM · Inline Comments, Differential, Bug Report
epriestley edited projects for T11785: Clicking on images for lightbox won't load with Persistent Chat enabled, added: Bug Report (Needs Information); removed Bug Report.

I can't reproduce this by following the steps you describe. Here's a screenshot of this working properly for me:

Oct 25 2016, 11:45 AM · Bug Report, Quicksand, Conpherence (v4)
epriestley added a comment to T11783: Diffusion Post-Push Webhooks.

In almost all cases, it's within a second or two of the push.

Oct 25 2016, 2:44 AM · Feature Request
epriestley merged task T11783: Diffusion Post-Push Webhooks into T11330: Allow Herald to "Queue Call to Webhook: ...".
Oct 25 2016, 2:33 AM · Feature Request
epriestley merged T11783: Diffusion Post-Push Webhooks into T11330: Allow Herald to "Queue Call to Webhook: ...".
Oct 25 2016, 2:33 AM · Feature Request
epriestley added a comment to T11783: Diffusion Post-Push Webhooks.

I'm going to merge this into T11330, but note that you can already do this via Harbormaster, as this install does (we build via Drydock, but you can run a "Make HTTP Request..." build plan instead).

Oct 25 2016, 2:33 AM · Feature Request

Oct 22 2016

epriestley added a project to T4776: Notify users when someone takes an action that takes them off an object's recipient list: Mail.
Oct 22 2016, 5:01 PM · Mail, Restricted Project, Transactions
epriestley edited the content of Changelog.
Oct 22 2016, 3:04 PM
epriestley created 2016 Week 43 (Late October).
Oct 22 2016, 3:03 PM

Oct 21 2016

epriestley closed T11758: "aliases" is valid configuration in Arcanist, but not recognized by "arc get-config" as Resolved by committing Restricted Diffusion Commit.
Oct 21 2016, 11:08 PM · Arcanist
epriestley added a revision to T11758: "aliases" is valid configuration in Arcanist, but not recognized by "arc get-config": Unknown Object (Differential Revision).
Oct 21 2016, 9:44 PM · Arcanist
chad awarded T11780: Consider quota systems a Pirate Logo token.
Oct 21 2016, 3:47 PM · Phacility, Abuse
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 21 2016, 3:10 PM · Design, Calendar
epriestley updated the task description for T11780: Consider quota systems.
Oct 21 2016, 2:44 PM · Phacility, Abuse
epriestley created T11780: Consider quota systems.
Oct 21 2016, 2:44 PM · Phacility, Abuse
epriestley added a comment to T11469: Checking out from Phacility sometimes fails.

D16744 should also improve SSH performance slightly, with a larger impact on larger instances.

Oct 21 2016, 2:27 PM · Phacility, Bug Report
epriestley added a revision to T11469: Checking out from Phacility sometimes fails: Unknown Object (Differential Revision).
Oct 21 2016, 2:27 PM · Phacility, Bug Report
epriestley added a comment to T11469: Checking out from Phacility sometimes fails.

This may have been the "MaxStartups" directive in sshd; if so, a partial fix is currently deployed (raising the limit on application load balancers) and a more comprehensive fix will go out tomorrow morning (also raising the limit on repository shards).

Oct 21 2016, 2:14 PM · Phacility, Bug Report
epriestley closed T11779: Header as Invalid.
Oct 21 2016, 11:38 AM · Dashboards (v2)

Oct 20 2016

epriestley closed T11771: Protect GC operations with a lock as Resolved by committing Restricted Diffusion Commit.
Oct 20 2016, 8:40 PM · Daemons
epriestley added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

Awesome, thanks for following up. Let us know if you run into anything else!

Oct 20 2016, 8:16 PM · Bug Report
epriestley added a comment to T11036: Put subproject columns on workboards.

I do not plan to ever let you reorder milestones.

Oct 20 2016, 8:15 PM · Workboards (v3), Projects (v3)
cguenther awarded T11357: Move Files to EditEngine and modern APIs a Love token.
Oct 20 2016, 6:46 PM · Restricted Project, Files
epriestley added a revision to T11771: Protect GC operations with a lock: Unknown Object (Differential Revision).
Oct 20 2016, 6:40 PM · Daemons
epriestley added a revision to T11766: Write to the pull log from SSH, not just HTTP: Unknown Object (Differential Revision).
Oct 20 2016, 6:32 PM · Diffusion, Phacility
epriestley renamed T11773: Improve behaviors for "overheated" policy queries from Feed does not perform well in the presence of exclusive spaces to Improve behaviors for "overheated" policy queries.
Oct 20 2016, 5:08 PM · Performance
epriestley closed T11533: Upgrading: Changes to Default Homepage as Resolved.

This has been live for about two months without any substantive issues arising.

Oct 20 2016, 5:07 PM · NUX, Dashboards, Installing & Upgrading
epriestley added a comment to T11775: Panel positioning improvements.

I don't plan to implement the rest of the feature request. Assuming drag and drop works correctly, I think this operation (reordering panels) is rare enough that using it is reasonable without introducing the additional complexity of duplicate controls.

Oct 20 2016, 5:06 PM · Dashboards, Feature Request
epriestley closed T11669: Dashboard drag and drop a test in patience as Invalid.

It should show a pretty clear preview of what it's going to do before you drop, so I'm not sure how it could be unpredictable? I wasn't able to identify any weird/surprising behavior when I tried to reproduce this.

Oct 20 2016, 5:02 PM · Restricted Project, Dashboards, Bug Report
epriestley closed T11775: Panel positioning improvements as Invalid.

even sometime seems to me not properly working

Oct 20 2016, 4:52 PM · Dashboards, Feature Request
epriestley updated subscribers of T11669: Dashboard drag and drop a test in patience.

I wasn't actually able to reproduce this -- were you, @chad?

Oct 20 2016, 4:50 PM · Restricted Project, Dashboards, Bug Report
epriestley added a revision to T11773: Improve behaviors for "overheated" policy queries: Unknown Object (Differential Revision).
Oct 20 2016, 4:11 PM · Performance
epriestley added a comment to T11773: Improve behaviors for "overheated" policy queries.

Pagination isn't quite as simple as I'd remembered. Specifically, we do not expose internal pagination cursors to viewers today because doing so permits an information discovery attack that goes like this:

Oct 20 2016, 3:51 PM · Performance
epriestley added a revision to T11773: Improve behaviors for "overheated" policy queries: Unknown Object (Differential Revision).
Oct 20 2016, 3:36 PM · Performance
epriestley added a comment to T11036: Put subproject columns on workboards.

Broadly, I think the two above comments are expressing a mixture of two ideas:

Oct 20 2016, 2:07 PM · Workboards (v3), Projects (v3)
epriestley added a comment to T11036: Put subproject columns on workboards.

The proposed behavior (no subproject columns) means that tasks could be in multiple different columns at different levels, since they'd be draggable normally on each workboard:

Oct 20 2016, 1:49 PM · Workboards (v3), Projects (v3)
epriestley added a comment to T11357: Move Files to EditEngine and modern APIs.

T11774 wants a "delete file data" transaction, which is reasonable.

Oct 20 2016, 1:31 PM · Restricted Project, Files
epriestley merged task T11774: Files are not deletable when uploaded by a bot user into T11357: Move Files to EditEngine and modern APIs.
Oct 20 2016, 1:31 PM · Conduit, Arcanist, Files, People, Bug Report
epriestley merged T11774: Files are not deletable when uploaded by a bot user into T11357: Move Files to EditEngine and modern APIs.
Oct 20 2016, 1:31 PM · Restricted Project, Files
epriestley added a comment to T11774: Files are not deletable when uploaded by a bot user.

This is working as intended, and not a bug. Administrators can not bypass policies. See the User Guide: Account Roles documentation:

Oct 20 2016, 1:31 PM · Conduit, Arcanist, Files, People, Bug Report

Oct 19 2016

epriestley added a comment to T11773: Improve behaviors for "overheated" policy queries.

I think this behavior is very good

Oct 19 2016, 10:37 PM · Performance
epriestley added a comment to T11773: Improve behaviors for "overheated" policy queries.

This is also a potential problem in the general case, although the general case of this is very rare.

Oct 19 2016, 10:30 PM · Performance
epriestley renamed T11773: Improve behaviors for "overheated" policy queries from Feed does not perform well in the presence of exclusive spaces? to Feed does not perform well in the presence of exclusive spaces.
Oct 19 2016, 10:11 PM · Performance
epriestley added a comment to T11773: Improve behaviors for "overheated" policy queries.

Broadly, most applications can execute Spaces queries cheaply by querying ... AND spacePHID IN (<list of spaces the viewer can see>) when Spaces are configured, which is efficient until some install decides to create 30,000 Spaces for some reason.

Oct 19 2016, 10:10 PM · Performance
epriestley added projects to T11773: Improve behaviors for "overheated" policy queries: Feed, Performance.
Oct 19 2016, 9:59 PM · Performance
epriestley added a comment to T11773: Improve behaviors for "overheated" policy queries.

The reporting user configured debug.time-limit to get a stack, which confirms this is a Feed issue:

Oct 19 2016, 9:59 PM · Performance
epriestley added a comment to T11773: Improve behaviors for "overheated" policy queries.

Here are slightly cleaned-up recent timeouts from the logs:

Oct 19 2016, 9:56 PM · Performance
epriestley updated the task description for T11773: Improve behaviors for "overheated" policy queries.
Oct 19 2016, 9:52 PM · Performance
epriestley created T11773: Improve behaviors for "overheated" policy queries.
Oct 19 2016, 9:37 PM · Performance
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 19 2016, 4:57 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 19 2016, 4:55 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 19 2016, 4:20 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 19 2016, 4:20 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 19 2016, 4:03 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 19 2016, 4:02 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 19 2016, 3:35 PM · Restricted Project, Prioritized, Calendar
epriestley closed T11735: Upgrading: Calendar Storage Migrations as Resolved.

I'm going to close this since things seem to have at least mostly worked and installs have had a couple of weeks to yell at us if we blew anything major up, but let us know if anyone runs into further issues.

Oct 19 2016, 3:25 PM · Calendar

Oct 18 2016

epriestley added a comment to T10215: Provide tools to combat and recover from abuse.

I can't remember if Phabricator already requires a confirmed e-mail address to do anything.

Oct 18 2016, 10:46 PM · Abuse
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 18 2016, 9:36 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 18 2016, 9:36 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 18 2016, 9:31 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 18 2016, 9:30 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 18 2016, 8:56 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 18 2016, 8:54 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 18 2016, 8:41 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 18 2016, 8:40 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 18 2016, 8:26 PM · Restricted Project, Prioritized, Calendar
epriestley awarded Image Macro "punt" a Hungry Hippo token.
Oct 18 2016, 8:10 PM
epriestley added a comment to T10215: Provide tools to combat and recover from abuse.

We can also let installs send us all their data, we'll decide if it's spam or not, then we remotely delete any data that we feel like deleting. But we'd have to charge like a gorillion dollars per message to make this sustainable today.

Oct 18 2016, 8:10 PM · Abuse
epriestley added a comment to T10215: Provide tools to combat and recover from abuse.

What sort of reliable and automatic solution are you hoping for? How could the system reliably, automatically detect that a user is a spammer or that a task assignment is unwanted?

Oct 18 2016, 7:07 PM · Abuse
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 18 2016, 6:00 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 18 2016, 5:11 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 18 2016, 5:07 PM · Restricted Project, Prioritized, Calendar
stevex awarded T3563: Consider fullscreen modes for Pholio (and other applications?) a Love token.
Oct 18 2016, 4:47 PM · Pholio
epriestley created T11771: Protect GC operations with a lock.
Oct 18 2016, 11:33 AM · Daemons
cguenther awarded T7789: Support Git Large File Storage a Love token.
Oct 18 2016, 9:07 AM · Customer Impact, Restricted Project, Files, Diffusion

Oct 17 2016

epriestley added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

After D16714, the problem tasks should complete cleanly.

Oct 17 2016, 11:05 PM · Bug Report
epriestley added a subtask for T10978: Modernize Audit: T11763: Make commit query useful enough to show "recent commits + build status on master" of a particular repository.
Oct 17 2016, 10:57 PM · Audit
epriestley added a parent task for T11763: Make commit query useful enough to show "recent commits + build status on master" of a particular repository: T10978: Modernize Audit.
Oct 17 2016, 10:57 PM · Haskell.org, Harbormaster, Feature Request
epriestley renamed T11763: Make commit query useful enough to show "recent commits + build status on master" of a particular repository from Filter Harbormaster builds by their provenance to Make commit query useful enough to show "recent commits + build status on master" of a particular repository.
Oct 17 2016, 10:57 PM · Haskell.org, Harbormaster, Feature Request
epriestley closed T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails as Resolved by committing Restricted Diffusion Commit.
Oct 17 2016, 10:56 PM · Bug Report
epriestley closed T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails, a subtask of T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion, as Resolved.
Oct 17 2016, 10:56 PM · Diffusion (v3), Differential, Mail
epriestley closed T11768: Show diff statistics (lines changed) as Invalid.

This feature request doesn't describe a root problem. See Describing Root Problems and Contributing Feature Requests for help filing a feature request which we'll consider.

Oct 17 2016, 10:50 PM · Feature Request
epriestley added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

D16714 should fix this by adding an implicit byte limit.

Oct 17 2016, 10:32 PM · Bug Report
epriestley added a comment to T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion.

Differential also currently does not substitute a diagnostic message when declining to inline a patch: it should. ("Patch is too big to inline because limit X is set to Y." or similar.)

Oct 17 2016, 10:31 PM · Diffusion (v3), Differential, Mail
epriestley added a revision to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails: Unknown Object (Differential Revision).
Oct 17 2016, 10:30 PM · Bug Report
epriestley added a subtask for T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion: T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.
Oct 17 2016, 10:17 PM · Diffusion (v3), Differential, Mail
epriestley added a parent task for T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails: T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion.
Oct 17 2016, 10:17 PM · Bug Report
epriestley added a comment to T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion.

An additional inconsistency is that the diffusion.byte-limit applies to attached patches, but the differential.byte-limit does not. There's some vague argument for this behavior (you "shouldn't" be reviewing patches which are so enormous that they can not be emailed) but consistent behavior is probably better.

Oct 17 2016, 10:13 PM · Diffusion (v3), Differential, Mail
epriestley renamed T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion from Unify patch byte/line limit behaviors to Unify email patch byte/line/time limit behaviors across Differential/Diffusion.
Oct 17 2016, 10:10 PM · Diffusion (v3), Differential, Mail
epriestley created T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion.
Oct 17 2016, 10:10 PM · Diffusion (v3), Differential, Mail
epriestley added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

Sorry, "tomorrow" definitely didn't happen. Looking at this now.

Oct 17 2016, 10:00 PM · Bug Report