Page MenuHomePhabricator
Feed Advanced Search

Sep 2 2016

epriestley added a comment to T11575: Make PhutilDocblockParser always return arrays when parsing "@doc-tags".

I'm going to retarget this to make the API more consistent.

Sep 2 2016, 12:19 PM · Bug Report
epriestley added a revision to T11575: Make PhutilDocblockParser always return arrays when parsing "@doc-tags": Unknown Object (Differential Revision).
Sep 2 2016, 11:53 AM · Bug Report
epriestley added a comment to T11575: Make PhutilDocblockParser always return arrays when parsing "@doc-tags".

We should probably change this API to always return array(), the "sometimes array, sometimes scalar" return value is pretty unintuitive. And any code which fixed this by adding (array) will just work.

Sep 2 2016, 11:51 AM · Bug Report
epriestley closed T11573: Phabricator goes down with minimal load due to asset delivery issue for some users as Resolved.

I'm going to close this for now since there's no more upstream action available given that the issue either no longer reproduces or disabling APCu appears to fix it and be a reasonable workaround.

Sep 2 2016, 11:38 AM · Bug Report
epriestley added a comment to T11575: Make PhutilDocblockParser always return arrays when parsing "@doc-tags".

Yeah, I think this didn't crop up sooner through a combination of the cache and there being relatively few files with multiple @phutil-external-symbol tags.

Sep 2 2016, 11:20 AM · Bug Report

Sep 1 2016

epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

We don't really use APCu for very much, so if you are able to isolate it as the issue (or are just suspicious, e.g. based on that launchpad bug looking pretty similar) it's probably OK to turn it off. I'd expect you to lose something like 5% performance with it off, not 50%+.

Sep 1 2016, 9:41 PM · Bug Report
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

If you turn APCu back on, does it freeze up again?

Sep 1 2016, 8:42 PM · Bug Report
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

I'm not immediately sure about the daemon confusion, although I suspect it's not likely to be a hint at the root issue. Caching for setup issues falls back to some pretty whacky shenanigans with APC/APCu disabled.

Sep 1 2016, 7:08 PM · Bug Report
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

That's probably a webhook URI configured in feed.http-hooks (which may no longer be configured).

Sep 1 2016, 7:05 PM · Bug Report
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

I don't see anything interesting in Multimeter, it just shows that the host doesn't see much traffic and that we probably need to update some package definitions.

Sep 1 2016, 6:40 PM · Bug Report
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

Are you running APC (Config → Cache Status shows APC as the active "Data Cache")?

Sep 1 2016, 6:29 PM · Bug Report
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

Also, can you show me what these pages look like?

Sep 1 2016, 6:23 PM · Bug Report
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

GET /res/phabricator/86668b8e/rsrc/js/phui/rdar.js HTTP/1.1

Sep 1 2016, 6:20 PM · Bug Report
epriestley updated the answer details for Q484: Does phabricator team do static code analysis on phabricator code base? (Answer 453).
Sep 1 2016, 6:03 PM
epriestley added Q484: Does phabricator team do static code analysis on phabricator code base? (Answer 453).
Sep 1 2016, 6:03 PM
epriestley added a comment to T11572: Herald Rule not inheriting Object policy from Project in a way I understand.

This is a bug with how relative/object policies and inherited/indirect policies interact.

Sep 1 2016, 4:39 PM · Bug Report
epriestley added a project to T11547: Paste query results do not display actual length of listed Pastes (but always "5 lines" if Paste is longer): Contributor Onboarding.
Sep 1 2016, 2:29 PM · Contributor Onboarding, Paste, Bug Report
epriestley renamed T11566: Provide more complete guidance on using regular expressions in Herald from Herald docs require better information around how to use contains, matches regexp, matches regexp pairs...etc to Provide more complete guidance on using regular expressions in Herald.
Sep 1 2016, 2:26 PM · Herald, Documentation
epriestley created T11571: Consider benchmarking hardware during setup.
Sep 1 2016, 2:24 PM · Setup
epriestley closed T11568: Daemons queue usage is low leading to slow imports as Resolved.

I'm going to close this for now since I don't plan to take any further action as the upstream; this appears to be an environmental issue (which we don't offer support for) rather than a scalability limitation (which we do).

Sep 1 2016, 2:21 PM · Diffusion, Bug Report
epriestley added a comment to T11570: `arc patch` download empty binary file from hosted svn repository.

I've just dumped this on the pile of arc patch-related bugs. Some of them are likely duplicates, possibly including this one, but I don't expect to dig through that pile until the next major iteration on arc, since at least some of them are likely not addressable without other changes. T11429 has a rough overview of upcoming plans.

Sep 1 2016, 2:12 PM · Arcanist, Bug Report
epriestley moved T11570: `arc patch` download empty binary file from hosted svn repository from Backlog to arc patch on the Arcanist board.
Sep 1 2016, 2:08 PM · Arcanist, Bug Report
epriestley added a project to T11570: `arc patch` download empty binary file from hosted svn repository: Arcanist.
Sep 1 2016, 2:08 PM · Arcanist, Bug Report
epriestley triaged T11567: Allow dashes in monospace font preferences as Low priority.
Sep 1 2016, 2:07 PM · Contributor Onboarding, User Preferences
epriestley moved T11567: Allow dashes in monospace font preferences from Backlog to Basic on the Contributor Onboarding board.
Sep 1 2016, 2:06 PM · Contributor Onboarding, User Preferences
epriestley assigned T11567: Allow dashes in monospace font preferences to jcox.
  • Try to come up with a way that - can do something dangerous when injected into a CSS rule.
    • See D7274#47131 for a template of how to attack this.
    • If you can come up with any attacks, don't implement this.
  • Adjust the regular expression in PhabricatorMonospacedFontSetting::filterMonospacedCSSRule() to include -.
  • Adjust the error text in PhabricatorMonospacedFontSetting->validateTransactionValue() to say "..., hyphens, ..." or similar.
Sep 1 2016, 2:05 PM · Contributor Onboarding, User Preferences
epriestley added Q483: Why is the "Need Triage" priority higher than all the others ? (Answer 449).
Sep 1 2016, 12:24 PM

Aug 31 2016

epriestley added a comment to T11568: Daemons queue usage is low leading to slow imports.

I'm not entirely sure, but it seems plausible. We compute "Queue Utilization" as basically:

Aug 31 2016, 10:43 PM · Diffusion, Bug Report
epriestley added a revision to T7924: Unprototype Calendar (v1): Unknown Object (Differential Revision).
Aug 31 2016, 10:13 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T11569: Nuance is fataling with calls to setIcon().

No, not updated yet.

Aug 31 2016, 9:59 PM · Nuance
epriestley added a comment to T7924: Unprototype Calendar (v1).

Well, "trivial" might be a little ambitious.

Aug 31 2016, 9:54 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T7924: Unprototype Calendar (v1).

Ah, thanks! That's a bug which we hadn't run into yet, but it's trivial to fix.

Aug 31 2016, 9:50 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T11568: Daemons queue usage is low leading to slow imports.
...
13. >>> [4] <query> INSERT INTO `daemon_log` ...
14. <<< [4] <query> 870,858 us
...
Aug 31 2016, 8:46 PM · Diffusion, Bug Report
epriestley added a comment to T11568: Daemons queue usage is low leading to slow imports.

Okay. Can you run this command?

Aug 31 2016, 8:00 PM · Diffusion, Bug Report
epriestley added a comment to T11568: Daemons queue usage is low leading to slow imports.

Oh, no, this is the right task. Your logs:

Aug 31 2016, 6:45 PM · Diffusion, Bug Report
epriestley added a comment to T11568: Daemons queue usage is low leading to slow imports.

Someone has configured a bad Nuance source, so let's start by fixing that.

Aug 31 2016, 5:09 PM · Diffusion, Bug Report
kislinsk awarded T10500: When diffing B against A in Differential, files touched in A but not B should be finessed better a Like token.
Aug 31 2016, 5:00 PM · Restricted Project, Differential
epriestley closed T11569: Nuance is fataling with calls to setIcon() as Resolved by committing Restricted Diffusion Commit.
Aug 31 2016, 5:00 PM · Nuance
epriestley added a revision to T11569: Nuance is fataling with calls to setIcon(): Unknown Object (Differential Revision).
Aug 31 2016, 4:51 PM · Nuance
epriestley added a project to T11569: Nuance is fataling with calls to setIcon(): Nuance.
Aug 31 2016, 4:08 PM · Nuance
epriestley created T11569: Nuance is fataling with calls to setIcon().
Aug 31 2016, 4:08 PM · Nuance
epriestley added Q419: Slow imports of commit and how to scale up (Answer 448).
Aug 31 2016, 2:55 PM
epriestley added a parent task for T11566: Provide more complete guidance on using regular expressions in Herald: T8644: Herald template / recipe book / examples / quick-create tool.
Aug 31 2016, 2:32 PM · Herald, Documentation
epriestley added a subtask for T8644: Herald template / recipe book / examples / quick-create tool: T11566: Provide more complete guidance on using regular expressions in Herald.
Aug 31 2016, 2:32 PM · Restricted Project, Herald
epriestley triaged T11566: Provide more complete guidance on using regular expressions in Herald as Low priority.
Aug 31 2016, 2:32 PM · Herald, Documentation
epriestley added a comment to T11566: Provide more complete guidance on using regular expressions in Herald.

The reason we suggest @ as a delimiter is that you don't have to escape forward slashes if you use a delimiter other than /, so you get a more readable regexp.

Aug 31 2016, 2:31 PM · Herald, Documentation
epriestley added a comment to T11567: Allow dashes in monospace font preferences.

I believe this is fine; I can't immediately come up with an attack using -.

Aug 31 2016, 12:35 PM · Contributor Onboarding, User Preferences
epriestley added a comment to T11566: Provide more complete guidance on using regular expressions in Herald.

Form (1) is expected to work, which is why we don't document a need for form (7): one is not expected to exist. If form (1) does not work, this is a bug with Herald itself, not with the Herald documentation.

Aug 31 2016, 12:25 PM · Herald, Documentation
franjesus awarded T7568: Support Desktop Notifications in Conpherence a Like token.
Aug 31 2016, 12:16 PM · Conpherence (v4)
johnny-bit awarded T11561: Write a "Contributor Onboarding" document a Cup of Joe token.
Aug 31 2016, 7:34 AM · Documentation, Contributor Onboarding
cspeckmim awarded T11561: Write a "Contributor Onboarding" document a Cup of Joe token.
Aug 31 2016, 1:23 AM · Documentation, Contributor Onboarding

Aug 30 2016

epriestley added a comment to T11565: Typo in Harbormaster User Guide.

Thanks for the report. This should be fixed in HEAD of master, and fixed in production some time in the next 24 hours when the docs regenerate.

Aug 30 2016, 9:22 PM · Documentation, Bug Report
epriestley closed T11565: Typo in Harbormaster User Guide as Resolved by committing Restricted Diffusion Commit.
Aug 30 2016, 9:09 PM · Documentation, Bug Report
epriestley added a revision to T11565: Typo in Harbormaster User Guide: Unknown Object (Differential Revision).
Aug 30 2016, 8:57 PM · Documentation, Bug Report
epriestley claimed T11565: Typo in Harbormaster User Guide.
Aug 30 2016, 8:55 PM · Documentation, Bug Report
epriestley added a comment to T11506: Build smarter CLI caching for instance data in the Phacility cluster.

Those changes add a fairly coarse disk-based cache here for use by the CLI. I expect it to shed ~95% of the load and make the admin tier stop glowing white-hot 24/7.

Aug 30 2016, 7:17 PM · Phacility
epriestley added a comment to T11563: Provide a way to get all diffs associated with tasks from the API.

Follow PhabricatorSearchEngineExtension or similar.

Aug 30 2016, 7:01 PM · Restricted Project, Conduit
epriestley added a comment to T11563: Provide a way to get all diffs associated with tasks from the API.

(The second step is because some types of attachments work on multiple object types, and you could even conceivably write an "edge" attachment here that just works for anything and returns all edges, although I'm not confident that doing so isn't a major security problem.)

Aug 30 2016, 6:57 PM · Restricted Project, Conduit
epriestley added a comment to T11563: Provide a way to get all diffs associated with tasks from the API.

I think you've already written these, but the budget walkthrough is:

Aug 30 2016, 6:56 PM · Restricted Project, Conduit
epriestley added a comment to T11563: Provide a way to get all diffs associated with tasks from the API.

For the record, I strongly endorse autopatching unreviewed code onto live, armed, autonomous combat vehicles.

Aug 30 2016, 6:25 PM · Restricted Project, Conduit
epriestley added a comment to T11563: Provide a way to get all diffs associated with tasks from the API.

Internal attachment is definitely the shortest path. Whatever we end up with is likely to look very similar to the naive version, and you can keep your attachment running after we offer an "edges" attachment, so there shouldn't be any real transition cost.

Aug 30 2016, 6:24 PM · Restricted Project, Conduit
epriestley added a comment to T11563: Provide a way to get all diffs associated with tasks from the API.

This is basically a special case of T5873.

Aug 30 2016, 6:20 PM · Restricted Project, Conduit
epriestley closed T11562: New as Spite.
Aug 30 2016, 5:22 PM · Bug Report
epriestley added a comment to T10679: When phurl.short-uri is configured, use it in the UI.

If you give a Phurl an "Alias", you can type ((thatalias)) in Remarkup to reference it. For example:

Aug 30 2016, 4:40 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley closed T11559: Add a list of individual repositories with update errors to "Repository Servers" page as Resolved.

I added a note about this to T7338 for the longer term.

Aug 30 2016, 4:25 PM · Clusters, Diffusion
epriestley updated the task description for T7338: Build more status tools for monitoring Phacility cluster health.
Aug 30 2016, 4:25 PM · Almanac, Phacility
epriestley closed T11556: Can't create Phortune Payment Provider as Resolved by committing Restricted Diffusion Commit.
Aug 30 2016, 4:18 PM · Phortune
epriestley added a revision to T11559: Add a list of individual repositories with update errors to "Repository Servers" page: Unknown Object (Differential Revision).
Aug 30 2016, 3:57 PM · Clusters, Diffusion
epriestley added a comment to T10679: When phurl.short-uri is configured, use it in the UI.

That should really have been in a day 1 "spend 10 minutes doing this stuff first" document, I started collecting this stuff in T11561.

Aug 30 2016, 3:01 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley created T11561: Write a "Contributor Onboarding" document.
Aug 30 2016, 3:00 PM · Documentation, Contributor Onboarding
epriestley added a comment to T10679: When phurl.short-uri is configured, use it in the UI.

Alternate/simpler test is "does /phurl/ work".

Aug 30 2016, 2:55 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley added a comment to T10679: When phurl.short-uri is configured, use it in the UI.

Also, are prototype applications enabled (phabricator.show-prototypes)? If not, Phurl won't actually be installed.

Aug 30 2016, 2:54 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley added a comment to T10679: When phurl.short-uri is configured, use it in the UI.

Ah, okay. I'm not immediately sure, then -- did you restart Apache / is /config/edit/phurl.short-uri/ picking up the change?

Aug 30 2016, 2:53 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley added a comment to T10679: When phurl.short-uri is configured, use it in the UI.

I suppose we could link to /config/module/site/, which has a list of all Sites, but it's probably not intuitively obvious from there what's going on. It's also possible in some future world to reach this screen without running Phabricator at all (T1806), although probably unlikely.

Aug 30 2016, 2:52 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley added a comment to T10679: When phurl.short-uri is configured, use it in the UI.

First screen is good.

Aug 30 2016, 2:50 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley closed T11558: Update-after-commit possibly got mangled in diff-to-file change? as Resolved.

I've updated both hosts and manually fixed D16464 to display the correct changes.

Aug 30 2016, 2:40 PM · Differential, Diffusion
epriestley added a comment to T11558: Update-after-commit possibly got mangled in diff-to-file change?.

Yeah, I just neglected to push secure002 when I pushed secure001. I'll fix this shortly.

Aug 30 2016, 2:29 PM · Differential, Diffusion
epriestley added a comment to T11558: Update-after-commit possibly got mangled in diff-to-file change?.

Oh, this looks like a smoking gun:

Aug 30 2016, 2:28 PM · Differential, Diffusion
epriestley added a comment to T11558: Update-after-commit possibly got mangled in diff-to-file change?.

There's no changeset in the database, so this isn't just a weird permissions issue -- legitimately, no changeset was extracted.

Aug 30 2016, 2:27 PM · Differential, Diffusion
epriestley added a comment to T11558: Update-after-commit possibly got mangled in diff-to-file change?.

bin/differential extract rPHU491ebc74d816dbe2fc8bbbbc992e8a14f8c613be also extracts the change correctly:

Aug 30 2016, 2:25 PM · Differential, Diffusion
epriestley created T11559: Add a list of individual repositories with update errors to "Repository Servers" page.
Aug 30 2016, 2:24 PM · Clusters, Diffusion
epriestley added a comment to T11558: Update-after-commit possibly got mangled in diff-to-file change?.

This might actually something more narrowly scoped since, e.g., D16468, D16469, and D16470 worked fine.

Aug 30 2016, 2:21 PM · Differential, Diffusion
epriestley added a revision to T11556: Can't create Phortune Payment Provider: Unknown Object (Differential Revision).
Aug 30 2016, 2:14 PM · Phortune
epriestley added a comment to T10679: When phurl.short-uri is configured, use it in the UI.

Ah, yeah. If you're using Apache with <VirtualHost /> directives, try something like this?

Aug 30 2016, 1:50 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley created T11558: Update-after-commit possibly got mangled in diff-to-file change?.
Aug 30 2016, 12:53 PM · Differential, Diffusion
epriestley added a comment to T11556: Can't create Phortune Payment Provider.

I think it's just adding implements PhabricatorApplicationTransactionInterface, then adding the methods for that.

Aug 30 2016, 3:44 AM · Phortune
epriestley added a comment to T11556: Can't create Phortune Payment Provider.

Also to fix.

Aug 30 2016, 3:41 AM · Phortune
epriestley claimed T11556: Can't create Phortune Payment Provider.

I think this is straightforward to fi.

Aug 30 2016, 3:41 AM · Phortune

Aug 29 2016

epriestley moved T11555: Paste highlighting caches don't take name into account, but should from Backlog to Basic on the Contributor Onboarding board.
Aug 29 2016, 9:41 PM · Paste, Contributor Onboarding
epriestley created T11555: Paste highlighting caches don't take name into account, but should.
Aug 29 2016, 9:41 PM · Paste, Contributor Onboarding
epriestley closed T11554: Access PhabricatorUser viewer from non initialized method. as Invalid.

Sorry, we don't offer help with third-party application development!

Aug 29 2016, 7:22 PM · Feature Request
epriestley added a comment to T4369: Phabricator HTTP repository hosting has fairly severe scalability limits.

Probably not. Because it's a scalability issue this does get some amount of internal priority, but we have a large amount of external prioritized work in queue ahead of it (see Prioritized).

Aug 29 2016, 6:06 PM · Diffusion (v3), Restricted Project
epriestley added a comment to T11551: Conduit API "project.create" return error with ERR-CONDUIT-CORE when only "name" passed as parameter.

Not yet, but soon. New code should use project.edit.

Aug 29 2016, 6:03 PM · Restricted Project, Conduit, Bug Report
epriestley added a comment to T11482: Build a changeset cache for Diffusion to improve move/copy detection behvaior.

T10423 was resolved indirectly (in connection with T11524) so we've sort of inched forward here.

Aug 29 2016, 5:57 PM · Diffusion (v3), Bug Report
epriestley added a comment to T11551: Conduit API "project.create" return error with ERR-CONDUIT-CORE when only "name" passed as parameter.

Try using project.edit instead.

Aug 29 2016, 5:52 PM · Restricted Project, Conduit, Bug Report
epriestley added a comment to T11402: Garbage collect and/or compress/archive harbormaster build unit messages.

I'd like to sort out T9365 / T10635 (better aggregation and/or query options for unit/coverage data) first, since that likely impacts how we GC this data. Ideally, we'd leave an aggregated stub behind (e.g., pass/failure count) rather than nuking the data completely.

Aug 29 2016, 4:45 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a parent task for T5822: Implement garbage collection / automatic archiving for Harbormaster logs: T11402: Garbage collect and/or compress/archive harbormaster build unit messages.
Aug 29 2016, 4:36 PM · Harbormaster, Restricted Project
epriestley added a subtask for T11402: Garbage collect and/or compress/archive harbormaster build unit messages: T5822: Implement garbage collection / automatic archiving for Harbormaster logs.
Aug 29 2016, 4:36 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a parent task for T9365: Harbormaster results are hard to aggregate : T11402: Garbage collect and/or compress/archive harbormaster build unit messages.
Aug 29 2016, 4:35 PM · Harbormaster, Restricted Project, Restricted Project
epriestley added subtasks for T11402: Garbage collect and/or compress/archive harbormaster build unit messages: T10635: Loading differential revision slow when lots of unit test messages exist, T9365: Harbormaster results are hard to aggregate .
Aug 29 2016, 4:35 PM · Restricted Project, Harbormaster, Feature Request